From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DB4CD1284 for ; Thu, 4 Apr 2024 22:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E49F6B0098; Thu, 4 Apr 2024 18:18:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 694B16B009C; Thu, 4 Apr 2024 18:18:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5354C6B009D; Thu, 4 Apr 2024 18:18:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 303E56B0098 for ; Thu, 4 Apr 2024 18:18:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E37361204F4 for ; Thu, 4 Apr 2024 22:18:00 +0000 (UTC) X-FDA: 81973263120.04.3BC10E9 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 09697A0006 for ; Thu, 4 Apr 2024 22:17:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eyJDJvff; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712269079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eIW+Z3FuH4Tlrbj9QrjroPzWQnEb4hQ4AxEw1tDZfk4=; b=DLgDhEZzHJVAMb3hOaHG4GOjOr+Y3as+bPntG7G47DQ5gGwxmBMfIOfOEC3FgXLf6lOiTA 6LGWcVrYIjARFYVv0kG75/Qm2CH0YUTHTXzWxd+QkenG/WGu8dBplLarAeDGxJdzbWgq6t MmrRhoRRwtBuqJZwO7tn/yKzq5fNyKA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eyJDJvff; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712269079; a=rsa-sha256; cv=none; b=IhE+XlJ8y5b6F3YVZKxGc3NsMq7UkNxGMARB9GHQH6V0fjSsUijFOi0nPFNcOi1SGetVPe AX3GmPpX+/YMxInZMrhJfHwLrEcS3TP/2oUmfC2RmF1HXXBZnnFo6KVkLNIPaS3Kw3NT5z +RimIXX8Ln+fOK/JmanrAGoDQCoKxw8= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4162a3e2d22so9477145e9.1 for ; Thu, 04 Apr 2024 15:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712269077; x=1712873877; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eIW+Z3FuH4Tlrbj9QrjroPzWQnEb4hQ4AxEw1tDZfk4=; b=eyJDJvffh2S00ZgqxPTmHUo8XhAtnNZyNEymhwta8EZ9MnwYyoC5YKTog78XU9O6c+ cCXSFxzlHBx4aw47vhJKPFA5hxZOoTuXbbn9B7B83PBCpYmvXM4mjFYhBMPTz+XuhZZP CezJel9csmPRVsSvmDI+Tm8p6wLe25KMQQAJ7DlYLGPh3ILa4265pmRea9cWqbn9WiEs vjEvkDHvupFGpOiJ/qIaF4x4U81eTiVvc0DVYChQyxHUoAZR5tKLMqxr7lrd/wKAWSuq sBx5HkkurJc+HGVQ9LwV1b21IC3vxtLCSCIiWZYJ2djA7vyTrD/8k2sxVeoYSXnOD34Q rwpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712269077; x=1712873877; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eIW+Z3FuH4Tlrbj9QrjroPzWQnEb4hQ4AxEw1tDZfk4=; b=l5kI0zNQBAYjqb1mCj2sZ7upypD2DiO8Io/HMEtwhusM6fNBAjeUhC79sTOTVTp7h3 boWeg5xylCvcZrJE4yvAhXgoA+OAEDusEbHECD+g22RDUNZcUiYZERXJPR1NNkZhtNxz uhbNAmoVEb8F2scPzGdSdBzH86/R+KAGQVesUhl60X4LQ3pTh3VdH7TYOnG5x8pQbmLN UhjYDBjVlUIwJDHvJVj7WvtFZr17CL7bMBcC4XAYdFLOcG+Mc5JPLovq90c/nc8OKEVs 9U9UbBD6KSj0aSC+IphIDRmjuM2izi5bA1dDyjuERECQAecA+bh3rrtZvdv1klDMH0Ui 2FQA== X-Forwarded-Encrypted: i=1; AJvYcCXZ3PXdNpIWKSS6fBrC0hcrs1pXpFA0kLZXKfBG0NLWcr5bq4SHAPLcnZWBa3SvXvIfPsw3cOA0O64UVtFIJmmgoBg= X-Gm-Message-State: AOJu0Yzx3FUJ0rrLkGMOoKFu1cs008F49aIcEBzvYjN2PZCsH6I6gBqK cOWTWP586ePU5UVENXdCcPAIcdPifByB5usRaJbVm5s4TnFBB0v7AMPlwLOUwYkN3TB/75GcUOs AVtiodv/KCkRwIXNbBC5IYxfUEeFmiS48bl2i X-Google-Smtp-Source: AGHT+IEoGycg7Q6yz1U10yVcrqSmmGhsvl59dTKCzdbY+AGkKJwTyJBRF58S2bqCqewHCyhhbzL+kREAY0nZt0Z/KC8= X-Received: by 2002:a5d:56cd:0:b0:343:a117:7d2 with SMTP id m13-20020a5d56cd000000b00343a11707d2mr434133wrw.71.1712269077043; Thu, 04 Apr 2024 15:17:57 -0700 (PDT) MIME-Version: 1.0 References: <20240404165404.3805498-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 4 Apr 2024 15:17:43 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm: change inlined allocation helpers to account at the call site To: Matthew Wilcox Cc: akpm@linux-foundation.org, joro@8bytes.org, will@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, arnd@arndb.de, herbert@gondor.apana.org.au, davem@davemloft.net, jikos@kernel.org, benjamin.tissoires@redhat.com, tytso@mit.edu, jack@suse.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, jakub@cloudflare.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, kent.overstreet@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 09697A0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ao9su47mncgxr4ycarmd1s3g9ff8i3ia X-HE-Tag: 1712269078-700235 X-HE-Meta: U2FsdGVkX19Siu/pA+5y++mYqOVX7A3mUGTe2SD3q+Gbze4CY+Zdk4LE2syo6H3qhtR1iskT3hKla0hu5kQzN3EcrJfAs3i0FJ9IXhuiHnP5BzkdYH79K/yUykCgH59fs2dXspPKcC1DCVw/lOkcl12I6wdPQeu8On27D3TZO+w9L+W2j0XH4Fvpo8q4lWmh7PZql6GVWi9I6Q7knLnrRlcWyUNqgQawGmHxWgfIVpj2DDEFi5671TtWRONq4ppkCjMajvLr/O4+/9w+TyG3morZ3wJQ4cIiJlcYYRSAO0W//XStoDZODsgVzdLX722pLhSWy1mc32VDxICz4JTv67H7EqKichSgHIXJ/pgigSMZ03FiJyWMmkBcXUbEaM9r2AfnQZhsfmpyMOZN1GlWO4uM95AltFDPTs9iSdyLqhrmMq5OfwzCO+OTjXQpfP+Gbu2WAohOB6U8Gm+stOLxDXdyw2qBJjpMwou605sjmZlEkb41eZJ8pfCdHIpFwcJLX1KmTm2aEoNNz7o7ul66DIxFGgx2Ns7b0SW95z8VelXOoopBJkWIi1a6OGpytpUBzsIq5iNALIOz2ejVNovvKNMcpFAnWhIllj1FJDyizlc4PX6eaEVrvZ1ZDcx2NMJ1zeUTl43kW+/Xnl64aG0KfARFYO7wAJVkAkrem4U0AnDc3JCuZWpwvwf+PJDKOosUUvUjKjTr1eLmwDG+CAj+pZObd50D5Xd/CseogiakDTCwrEmJgqfzyHY/NZe18YQmecuXxMv1Tz44kP/qxiZSezUrRR6KLQ6WpvyuRD3wAMqGqtmyXJK9/Z/U9Yc0z181Afex5usNSPgo7nuAqIsoFaTy5LoUjmR0engXlJh7xc0taqU6wtLhbMalb8J8Gpj3qgGIpJCh1wR6z/W9ElGTncvYB3xm2c5qqXIk0N9voZo36ioAFfExo2r4DnDbm+2JdOlHaRFrcsZBc5EBZZz e3VAMT1/ UGpk3vWD/IUskvL9XDnZpdrKOqkcfDewcZyiebWPJLckpxZ8hWGQ7PxAZpSR6+Y7lrzOeUiMmHcmB9pOInoExwQXnL2EbCbTtJ1PlSx0Zc8cOd23JJyjllIWMiyoNctmq3DiTK6W+nYRXJxBPrpCb/28eEmnLLG6Q0i8wUT4Sww8i8W8w68LVk4qIrX8c10wTCJH3Id2uNhku8/k6MDo+OyD37nLSN1gutUYrmIERtyH0TaprkObvkRlAgNkbKalKyBSKQl4VaD+2oSf5MK9SvicYWbbjIhc8Nfyk+HrZDLlhxSHjdV/OpMDD6GI0PP1IBFauviLz/aysnrYfO+qdSQ9ZquDKKk9aKJVBxsLVMtP3KsTksxonN/BA6+mRJs3LqSGOMrtp80Q1d4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 10:08=E2=80=AFAM Suren Baghdasaryan wrote: > > On Thu, Apr 4, 2024 at 10:04=E2=80=AFAM Matthew Wilcox wrote: > > > > On Thu, Apr 04, 2024 at 09:54:04AM -0700, Suren Baghdasaryan wrote: > > > +++ b/include/linux/dma-fence-chain.h > > > @@ -86,10 +86,7 @@ dma_fence_chain_contained(struct dma_fence *fence) > > > * > > > * Returns a new struct dma_fence_chain object or NULL on failure. > > > */ > > > -static inline struct dma_fence_chain *dma_fence_chain_alloc(void) > > > -{ > > > - return kmalloc(sizeof(struct dma_fence_chain), GFP_KERNEL); > > > -}; > > > +#define dma_fence_chain_alloc() kmalloc(sizeof(struct dma_fence= _chain), GFP_KERNEL) > > > > You've removed some typesafety here. Before, if I wrote: > > > > struct page *page =3D dma_fence_chain_alloc(); > > > > the compiler would warn me that I've done something stupid. Now it > > can't tell. Suggest perhaps: > > > > #define dma_fence_chain_alloc() = \ > > (struct dma_fence_chain *)kmalloc(sizeof(struct dma_fence_chain= ), \ > > GFP_KERNEL) > > > > but maybe there's a better way of doing that. There are a few other > > occurrences of the same problem in this monster patch. > > Got your point. Ironically, checkpatch generates warnings for these type casts: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html #425: FILE: include/linux/dma-fence-chain.h:90: + ((struct dma_fence_chain *)kmalloc(sizeof(struct dma_fence_chain), GFP_KERNEL)) I guess I can safely ignore them in this case (since we cast to the expected type)? > > > > > > +++ b/include/linux/hid_bpf.h > > > @@ -149,10 +149,7 @@ static inline int hid_bpf_connect_device(struct = hid_device *hdev) { return 0; } > > > static inline void hid_bpf_disconnect_device(struct hid_device *hdev= ) {} > > > static inline void hid_bpf_destroy_device(struct hid_device *hid) {} > > > static inline void hid_bpf_device_init(struct hid_device *hid) {} > > > -static inline u8 *call_hid_bpf_rdesc_fixup(struct hid_device *hdev, = u8 *rdesc, unsigned int *size) > > > -{ > > > - return kmemdup(rdesc, *size, GFP_KERNEL); > > > -} > > > +#define call_hid_bpf_rdesc_fixup(_hdev, _rdesc, _size) kmemdup(_rdes= c, *(_size), GFP_KERNEL) > > > > here > > > > > -static inline handle_t *jbd2_alloc_handle(gfp_t gfp_flags) > > > -{ > > > - return kmem_cache_zalloc(jbd2_handle_cache, gfp_flags); > > > -} > > > +#define jbd2_alloc_handle(_gfp_flags) kmem_cache_zalloc(jbd2_= handle_cache, _gfp_flags) > > > > here > > > > > +++ b/include/linux/skmsg.h > > > @@ -410,11 +410,8 @@ void sk_psock_stop_verdict(struct sock *sk, stru= ct sk_psock *psock); > > > int sk_psock_msg_verdict(struct sock *sk, struct sk_psock *psock, > > > struct sk_msg *msg); > > > > > > -static inline struct sk_psock_link *sk_psock_init_link(void) > > > -{ > > > - return kzalloc(sizeof(struct sk_psock_link), > > > - GFP_ATOMIC | __GFP_NOWARN); > > > -} > > > +#define sk_psock_init_link() \ > > > + kzalloc(sizeof(struct sk_psock_link), GFP_ATOMIC | __GF= P_NOWARN) > > > > here > > > > ... I kind of gave up at this point. You'll want to audit for yourself > > anyway ;-) > > Yes, I'll go over it and will make the required changes. Thanks for > looking into it! > Suren.