From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F23D2E009 for ; Wed, 23 Oct 2024 01:58:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51746B00A5; Tue, 22 Oct 2024 21:58:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E02106B00AF; Tue, 22 Oct 2024 21:58:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC9E36B00B0; Tue, 22 Oct 2024 21:58:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B01336B00A5 for ; Tue, 22 Oct 2024 21:58:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 134A3160677 for ; Wed, 23 Oct 2024 01:58:00 +0000 (UTC) X-FDA: 82703206656.12.A5CB5EB Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf27.hostedemail.com (Postfix) with ESMTP id B1B8E40003 for ; Wed, 23 Oct 2024 01:58:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=084gmQOY; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729648545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qul5hLmQAu+fWVlqGFGYgtVKdRyN4ZhOl3zbp5Ssux4=; b=5czfnpzQ9/bT7Xh2F4SGlUMKNU5b2FYOIfJyraSrZBv/Cn42PLNwVneoEAJQpcOmxU7nSn YYfqsQL5HTOAQz0y4ILdMJhqhqJXmBRgMGWBfPcHaC84LdS95nolhWUEBwUatRWviwURBe k1CHLtb0U1U+QSOV1qJEbANIHRilPII= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729648545; a=rsa-sha256; cv=none; b=b08JJOtYXxGlnHttGboCB/DSJBiTOpsuZDtqNyX/c8zceslTWo/zC15BJaQVjK1ulTdcdP jum8k8bTPDD6FWO3hqGvUBnycQmVZi5J+bfcjt4KtfeEvcojH7h6IdrBjU9OF6v2lt33xo vwKfC5hT/m3CNVVqxo1UHyxDkwUkBsk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=084gmQOY; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-460969c49f2so162721cf.0 for ; Tue, 22 Oct 2024 18:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729648696; x=1730253496; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qul5hLmQAu+fWVlqGFGYgtVKdRyN4ZhOl3zbp5Ssux4=; b=084gmQOYv7AYAeV5MyQIaFmpxrKxqQXOROdGw87E4K+o3+xtAykElSB9xw6/d7oUyE UJEEX0plFTo6JmejTkTMSWLD492QSmBhzfJKP91rzJaMHxBl3xEhYGYJEBTkbufbX7h4 9JevYE6HVYmyB2wUNLj+8gzMbZCa9yRp0UbPvYyTCLIJJ+xw1XVfueqzNkDfEr6Y6uOt ReSV8T0rHX0UN7TUTKoIzWAI2kkABpsUADDZNwh9B5owflQKxCf7wRxDytxfm0H3Qyqz InyM7RqYm9FHK6vmIXuzoXaBjpGvO7rIA6vBbK7hfaiXxGQpcPHoTEgFL/pktsI8jErB 21LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729648696; x=1730253496; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qul5hLmQAu+fWVlqGFGYgtVKdRyN4ZhOl3zbp5Ssux4=; b=O8SCr0vUnCRqauVzaXbac4FYKXy+ppQk05Uc2ZmwIO7KM7Yai4YPpWNdsDPqlFzRnQ KJEwEqHePSZKQJ0VPQhxDDKqMiWicZH2YNQYFKUCbOZGjN1F2k2oXaD2XMFtVzlOLm1L spCRSCMxO0LVeSJjTmLtVDRS2zMZs165sDxkdZiynul3OHOjOsULf1EUzGDUbhpSZYSS 1M97sDTx8l8vjmovXhBs9XYzbjptQNLiSyuAzokUZ1hHDhPt2+GUEu15n9EgxAzdfz2i SzARS6z/snSKBGa/FXHf7fOC4Qpk4yKnmLEWVsxU8e1FSCWfY0eddhNTQxXC2gbnx4hM 1B4g== X-Forwarded-Encrypted: i=1; AJvYcCXvtbgL8gRpTjojk3BnWXLEMMOVLqIsA4ZX5eRxFFyxNhqK1h8JXJdP7gtS9XcnljiDc0D/iFrFNQ==@kvack.org X-Gm-Message-State: AOJu0Yzq4tXS6wmR4A8y3xZrUJ3gdmO9ZnvnLqZUpNYOqEgA7BCZzgE2 i4StpixmElY3q7E+ncbEZLWyeRb/dViU44F/h4pURmJZ/sJ78KiWc7ldfVLj7Sfvf+4vssw3Ce+ aOhkpXJTHNE9ba7C24UnIJaIU6jXwqCmJgRaZ X-Google-Smtp-Source: AGHT+IEXNDm0BLPjKfpJzKU5ks7mDQGYPygYIIjU5CoGy8C32YDo/LicyZhWjZFCdyr9c69s0t6/gbsD4i/CuS9Mrf8= X-Received: by 2002:a05:622a:2986:b0:460:afbd:4101 with SMTP id d75a77b69052e-46113afa5c2mr1823401cf.4.1729648696304; Tue, 22 Oct 2024 18:58:16 -0700 (PDT) MIME-Version: 1.0 References: <32f70816-1678-d6ab-0db1-6412ff7a7333@linux.dev> In-Reply-To: <32f70816-1678-d6ab-0db1-6412ff7a7333@linux.dev> From: Suren Baghdasaryan Date: Tue, 22 Oct 2024 18:58:02 -0700 Message-ID: Subject: Re: [PATCH] slub/slub_kunit:fix a panic due to __kmalloc_cache_noprof incorretly use To: Hao Ge Cc: Vlastimil Babka , xiaopeitux@foxmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, xiaopei01@kylinos.cn, gehao@kylinso.cn, xiongxin@kylinos.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 36u8kaufnnrwn544y5chxk4f3you9dbq X-Rspamd-Queue-Id: B1B8E40003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729648680-773394 X-HE-Meta: U2FsdGVkX19pUpRRvPOjp7MNMD6z8Hp5jYRJUo9XwdUdXBQiVFHSi95w9+X5ydOqGwToTZyvP/utJ64HQkjG7+hNPfesGikt94ElU5xxKeEqU75016uqIXfh0u02Q7W3GLx5c+t5lMjCqJ0+WaeOUBazu/AYulUy54ubASHDytLPPAyG4A17pyetWrHqbqQ8huOQacHFdxZFNocz1nIiY31/HpK2kbYl4VzwmMiAhre+CHugzc9u1FC0j8aR6yEiJUCGWp7/Emuq5IO3uumbqE8apNK2UpAgST99x0uxDLujf8zntppSPlJtz+3+TSaYL7961QsSA3fU6hLKnaGVaH4vJnLIxBkKn8qmzL1lyX5HjDbBUH9GZnuBuLN8yz3abq1AwMBfxoh4xSv5KZcLlevyzoH6/641Q829TVvFO0+VEWouUhvi3hm41pXgOpm00fF5BOD4veyX/HlesRMVRWu/tg3Q9Ynvo6J0S0i+g//u4bVofx8SNmYALwp9bD5oApaZC+Ve3GSz+ZgzSOzAaUdkF2q70+Nb+OyLLRR/l1Jb3G3KAo5iefjqSwghvGrxI4o3eeWCF+F7HO2AiMziyv9ernPyUuW41/OF7wfnUdoBhCWnIlAr0gbgfbcbqgoHCPCWjjXYitWUJkwoqdFp1DmKaLMNMXpzHPyP5FPZdh4x148TyKpK+vWAUgweKTv3hJtCAi0qznCiisGw5sBzdzbXRx+JDYkeK78NBK27VzSAosd+aMQjYBRXgGSo9fvWs/RwVv5bYfSesu33ne6aEVLhECjp4JfsbIcUjSfQU1rF1O6T0cdkmPDtrHsRaoIAhWLuKzRXoFDnoPEpMqeI1TUNAQPNl+lsg3+qOo+9cIlvW5RyN/i0gUML4ng1Y8LF563PUYQFUk3v7EN5qq19mrvbGY3gRVcFmzK9548IMm1CctQTuMV8AAXn7zRN7yBSmz2ehMwuKRE2jxclhCk Dfx4FCEh k5VxrdpzL/Od88cZvKJs0tNhEEY5onlC++pAY6EagtxVN0OicySfdNqs8+uiHyEd0mUkmxQiE6qK07f+hlr+bzWLX9raiW1mZKdnqRbLWNbJ2Zq3lVV+6E+qerhbfqPcEn8tzzuomjrE9IcxZT3h93xG1898L/oVFPVEYhdJ2gsnv1aZrUdfTkg3wVNqRpjAz8nm6C/ypJoqf/lBzXvYkHXVWOm23QSzy5Z0JhzGAZuj5k7lu5qtNyEqByDMyQ08q7AyZocDeMSUP3xWFJ+cSHAxfWvxKX2TT/SvQ7vvll6vx9504+RrwbLkSVY2PnkoVFwK7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 22, 2024 at 6:47=E2=80=AFPM Hao Ge wrote: > > > On 10/22/24 23:27, Vlastimil Babka wrote: > > On 10/22/24 04:19, Hao Ge wrote: > >> On 10/22/24 01:42, Suren Baghdasaryan wrote: > >>> On Sun, Oct 20, 2024 at 11:59=E2=80=AFPM wro= te: > >>>> From: Pei Xiao > >>>> > >>>> 'modprobe slub_kunit',will have a panic.The root cause is that > >>>> __kmalloc_cache_noprof was directly ,which resulted in no alloc_tag > >>>> being allocated.This caused current->alloc_tag to be null,leading to > >>>> a null pointer dereference in alloc_tag_ref_set. > >>> I think the root cause of this crash is the bug that is fixed by > >>> https://lore.kernel.org/all/20241020070819.307944-1-hao.ge@linux.dev/= . > >>> Do you get this crash if you apply that fix? > >> Yes, this patch has resolved the panic issue. > >>>> Here is the log for the panic: > >>>> [ 74.779373][ T2158] Unable to handle kernel NULL pointer derefere= nce at virtual address 0000000000000020 > >>>> [ 74.780130][ T2158] Mem abort info: > >>>> [ 74.780406][ T2158] ESR =3D 0x0000000096000004 > >>>> [ 74.780756][ T2158] EC =3D 0x25: DABT (current EL), IL =3D 32 b= its > >>>> [ 74.781225][ T2158] SET =3D 0, FnV =3D 0 > >>>> [ 74.781529][ T2158] EA =3D 0, S1PTW =3D 0 > >>>> [ 74.781836][ T2158] FSC =3D 0x04: level 0 translation fault > >>>> [ 74.782288][ T2158] Data abort info: > >>>> [ 74.782577][ T2158] ISV =3D 0, ISS =3D 0x00000004, ISS2 =3D 0x0= 0000000 > >>>> [ 74.783068][ T2158] CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess = =3D 0 > >>>> [ 74.783533][ T2158] GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, X= s =3D 0 > >>>> [ 74.784010][ T2158] user pgtable: 4k pages, 48-bit VAs, pgdp=3D00= 00000105f34000 > >>>> [ 74.784586][ T2158] [0000000000000020] pgd=3D0000000000000000, p4= d=3D0000000000000000 > >>>> [ 74.785293][ T2158] Internal error: Oops: 0000000096000004 [#1] S= MP > >>>> [ 74.785805][ T2158] Modules linked in: slub_kunit kunit ip6t_rpfi= lter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_conntrack ebta= ble_nat ebtable_broute ip6table_nat ip6table_mangle 4 > >>>> [ 74.790661][ T2158] CPU: 0 UID: 0 PID: 2158 Comm: kunit_try_catch= Kdump: loaded Tainted: G W N 6.12.0-rc3+ #2 > >>>> [ 74.791535][ T2158] Tainted: [W]=3DWARN, [N]=3DTEST > >>>> [ 74.791889][ T2158] Hardware name: QEMU KVM Virtual Machine, BIOS= 0.0.0 02/06/2015 > >>>> [ 74.792479][ T2158] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -D= IT -SSBS BTYPE=3D--) > >>>> [ 74.793101][ T2158] pc : alloc_tagging_slab_alloc_hook+0x120/0x27= 0 > >>>> [ 74.793607][ T2158] lr : alloc_tagging_slab_alloc_hook+0x120/0x27= 0 > >>>> > >>>> [ 74.794095][ T2158] sp : ffff800084d33cd0 > >>>> [ 74.794418][ T2158] x29: ffff800084d33cd0 x28: 0000000000000000 x= 27: 0000000000000000 > >>>> [ 74.795095][ T2158] x26: 0000000000000000 x25: 0000000000000012 x= 24: ffff80007b30e314 > >>>> [ 74.795822][ T2158] x23: ffff000390ff6f10 x22: 0000000000000000 x= 21: 0000000000000088 > >>>> [ 74.796555][ T2158] x20: ffff000390285840 x19: fffffd7fc3ef7830 x= 18: ffffffffffffffff > >>>> [ 74.797283][ T2158] x17: ffff8000800e63b4 x16: ffff80007b33afc4 x= 15: ffff800081654c00 > >>>> [ 74.798011][ T2158] x14: 0000000000000000 x13: 205d383531325420 x= 12: 5b5d383734363537 > >>>> [ 74.798744][ T2158] x11: ffff800084d337e0 x10: 000000000000005d x= 9 : 00000000ffffffd0 > >>>> [ 74.799476][ T2158] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008219d188 x= 6 : c0000000ffff7fff > >>>> [ 74.800206][ T2158] x5 : ffff0003fdbc9208 x4 : ffff800081edd188 x= 3 : 0000000000000001 > >>>> [ 74.800932][ T2158] x2 : 0beaa6dee1ac5a00 x1 : 0beaa6dee1ac5a00 x= 0 : ffff80037c2cb000 > >>>> [ 74.801656][ T2158] Call trace: > >>>> [ 74.801954][ T2158] alloc_tagging_slab_alloc_hook+0x120/0x270 > >>>> [ 74.802494][ T2158] __kmalloc_cache_noprof+0x148/0x33c > >>>> [ 74.802976][ T2158] test_kmalloc_redzone_access+0x4c/0x104 [slub= _kunit] > >>>> [ 74.803607][ T2158] kunit_try_run_case+0x70/0x17c [kunit] > >>>> [ 74.804124][ T2158] kunit_generic_run_threadfn_adapter+0x2c/0x4c= [kunit] > >>>> [ 74.804768][ T2158] kthread+0x10c/0x118 > >>>> [ 74.805141][ T2158] ret_from_fork+0x10/0x20 > >>>> [ 74.805540][ T2158] Code: b9400a80 11000400 b9000a80 97ffd858 (f9= 4012d3) > >>>> [ 74.806176][ T2158] SMP: stopping secondary CPUs > >>>> [ 74.808130][ T2158] Starting crashdump kernel... > >>>> > >>> CC'ing Vlastimil. > >>> This patch essentially reverts Vlastimil's "mm, slab: don't wrap > >>> internal functions with alloc_hooks()" change. Please check why that > >>> change was needed before proceeding. > >>> If this change is indeed needed, please add: > >> Hi Suren and Vlastimil > >> > >> In fact, besides the panic, there is also a warning here due to direct= ly > >> invoking__kmalloc_cache_noprof > >> > >> Regarding this, do you have any suggestions? > >> > >> [58162.947016] WARNING: CPU: 2 PID: 6210 at > >> ./include/linux/alloc_tag.h:125 alloc_tagging_slab_alloc_hook+0x268/0x= 27c > >> [58162.957721] Call trace: > >> [58162.957919] alloc_tagging_slab_alloc_hook+0x268/0x27c > >> [58162.958286] __kmalloc_cache_noprof+0x14c/0x344 > >> [58162.958615] test_kmalloc_redzone_access+0x50/0x10c [slub_kunit] > >> [58162.959045] kunit_try_run_case+0x74/0x184 [kunit] > >> [58162.959401] kunit_generic_run_threadfn_adapter+0x2c/0x4c [kunit] > >> [58162.959841] kthread+0x10c/0x118 > >> [58162.960093] ret_from_fork+0x10/0x20 > >> [58162.960363] ---[ end trace 0000000000000000 ]--- > > I see. > > The kunit test is the only user of __kmalloc_cache_noprof outside of km= alloc() > > itself so it's not worth defining again a wrapper for everyone, how abo= ut just > > wrapping the two callsites? > > > > --- a/lib/slub_kunit.c > > +++ b/lib/slub_kunit.c > > @@ -141,7 +141,7 @@ static void test_kmalloc_redzone_access(struct kuni= t *test) > > { > > struct kmem_cache *s =3D test_kmem_cache_create("TestSlub_RZ_k= malloc", 32, > > SLAB_KMALLOC|SLAB_STORE_USER|SLAB_RED_= ZONE); > > - u8 *p =3D __kmalloc_cache_noprof(s, GFP_KERNEL, 18); > > + u8 *p =3D alloc_hooks(__kmalloc_cache_noprof(s, GFP_KERNEL, 18)= ); > > > > kasan_disable_current(); > > > > @@ -199,7 +199,7 @@ static void test_krealloc_redzone_zeroing(struct ku= nit *test) > > struct kmem_cache *s =3D test_kmem_cache_create("TestSlub_krea= lloc", 64, > > SLAB_KMALLOC|SLAB_STORE_USER|SLAB_RED_= ZONE); > > > > - p =3D __kmalloc_cache_noprof(s, GFP_KERNEL, 48); > > + p =3D alloc_hooks(__kmalloc_cache_noprof(s, GFP_KERNEL, 48)); > > memset(p, 0xff, 48); > > > > kasan_disable_current(); > > > Hi Vlastimil > > I agree with your point of view, thank you for you and Suren's help and > suggestion. That seems reasonable to me. Thanks! > > Best regards > > Hao >