From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA157E7719A for ; Sat, 11 Jan 2025 09:45:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 089DF6B007B; Sat, 11 Jan 2025 04:45:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A036B0082; Sat, 11 Jan 2025 04:45:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6AD06B0083; Sat, 11 Jan 2025 04:45:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C8B766B007B for ; Sat, 11 Jan 2025 04:45:56 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7358B120F56 for ; Sat, 11 Jan 2025 09:45:56 +0000 (UTC) X-FDA: 82994689512.05.74E7052 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf29.hostedemail.com (Postfix) with ESMTP id 8F070120007 for ; Sat, 11 Jan 2025 09:45:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MqRpUIH5; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736588754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oWH2l2Is7xlqMrYGBqUebxyAWxzhjEcfg1lrJhwyF+g=; b=8BI3AW+EJvtlr7QjMaSxIedu0zSrNXYyeb1+6AGW9B5yh4n/jesza+turwrwh7TvZtUEYc jbm8g2v+Wr3vlKicax3gKmVh4E69BPGXUZ1Q6yglRdI7GuXdO8ijj4cqkvs1gU9jRQZthj lenNy3X2Nc8CWBW+mWJWU4YlwNWfuAQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MqRpUIH5; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736588754; a=rsa-sha256; cv=none; b=mhVGDOooimq6tkECQs7ODJ7TkvviTN6Bvi2UTn50JQ1Ei5zinjxJqXZB/yby9omj2y4au7 3XMVtM26un+TsN26IW92Yutp2AC4lTb062xEAlqhGd5aWzs2uQ5htKtJfVzCln0GgEv22D 0rj4mTeLtLo4aCmSfN/btq2lRqVlMMw= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4678c9310afso24701cf.1 for ; Sat, 11 Jan 2025 01:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736588753; x=1737193553; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oWH2l2Is7xlqMrYGBqUebxyAWxzhjEcfg1lrJhwyF+g=; b=MqRpUIH5h6qWu4HhetRpeWW9WPfC+bNZb4MkOUiqTFlsZ643n7z21IP950bxmLrej/ /B40tNpvgQCnclwW7iAs9oQpD4+yMhtAOlgGZAAmlgKj6n/S9+kHd4VE1ewVdh7qa2Zf Cw9TGtLG31lgdgQUHIhtIJ+x95xYor8AsjBUFZRT9EGr85pvrKV6+wEV2MxTjwUhLTLp NMa9W0mGIXMXgG2Iakp55dG94KPWu4I2t5Nh01hfdDCy3HNcV+v5dDytHzQLEAmz0O7z zVQjD7X2+Jk4hryLS5ZyL+EcEMziDNXBWhjqXKlUZPaZRc6y9k6/1MALTLqjm39EdTt7 PdLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736588753; x=1737193553; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oWH2l2Is7xlqMrYGBqUebxyAWxzhjEcfg1lrJhwyF+g=; b=l7+oAMHRNEE0xYD++dgiptr2udrReK7k2cBQlVwMcdlaairWr0iL5Qbqwq9/Xpxjl6 PqeNJ233qZ/NhJKSvIH0whDHWjVbyqdQ0pFS4OsaYq+Ii6t/eVo69PaEiod+nIiQGHbS MTF90pHKPJrxCc85OJQMhKcr7SkzgF7m6oBZCQ1Je2/Y3nLx8jAvQYht08x+mh3WQHGK vuQQbEwimJv8teJWFou8HE3W7BURPRc8nc4qZqrkBY/Y1d7xMJ/oCCJKQEXmNyTR9uvA FiEhmY3pgOqxQjxbnMqOY5m9t+FPxogfO9sZsmpvPdMDNM4X1DigWWjQ+oTCdAdca80F d7og== X-Forwarded-Encrypted: i=1; AJvYcCUsHog0Al/sA73AwnJGWTTw/udOrSuPkwaC4WfpS58yfYDNHJEUKHbMiep37sjZseLH0B5euxiTPw==@kvack.org X-Gm-Message-State: AOJu0YwUbhCSrV+2NVFN6QyG5jPxYkTlK0Ic8cGJFfa8+RqgvV8UoCmF Tk5fiI6v3SI7V6AE4LlEmAJyRjRtiKda/wkv0Yhk2ldGhjffQpLqA6RekVGz7oh/4Wrq0H6ZhkR qIy/a/THxJ37PAid2QTOUtpj0Jy3L2KPDH3Kj X-Gm-Gg: ASbGncthbzeGcXIVf4xLdr7sNEq1VOygS+y4jnv5Cc7XnHkCHCaYWKRvraCfOfT8uXG GErc3DHClfV1TsCjjmfpy67JSuktbdrK7q59ulw== X-Google-Smtp-Source: AGHT+IGhIG2CngGEbgawYJjo0rZQOmtUym3oXRx6tZFSBOM4GfAYmvCUJp9dfUNCK3WK8BUs1iJeig+fCZsKFy6cjbM= X-Received: by 2002:ac8:118a:0:b0:46c:9f17:12dd with SMTP id d75a77b69052e-46c9f171447mr414841cf.19.1736588753300; Sat, 11 Jan 2025 01:45:53 -0800 (PST) MIME-Version: 1.0 References: <20250111042604.3230628-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sat, 11 Jan 2025 01:45:41 -0800 X-Gm-Features: AbW1kvbii1zCUiOl90M4f1ttosMhVd4eHlKP_X8K3onQwYNCQW4CfAqU6ROBXJo Message-ID: Subject: Re: [PATCH v9 00/17] reimplement per-vma lock as a refcount To: Matthew Wilcox Cc: akpm@linux-foundation.org, peterz@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: oewe65kx3exizqwu5p8bbinw9sdqhuwe X-Rspamd-Queue-Id: 8F070120007 X-Rspam-User: X-HE-Tag: 1736588754-304747 X-HE-Meta: U2FsdGVkX1+Hoo51bmnTq1XZaen+ThBSj+MGmYfErLxoHnv7BxPf2NaCxdg4TFMTb1vFv4Z/mewWX3Ph3q/E50aFUCi+CHXi1wrwc7z//3SbXjktwMIxlC5+5ZXozouBuRVGj346D/5z42WC9vTicbMDQtgI0HuhUDv/N7/8ftUEH1q/1HtiFNC2anwT+g2dmaqr+eMFFK6YMVIOlJh0U/UP2UOXac5dUz8JvSjXDuALLN0ftG4DJaw6/cYd0PiiMUnoywf4ye18bjHBB1r96Wc21GexuATDPzFfZ2zosA3TVyrfcR9U4Y8eM9aeI6T7v+VsjnA0t3EJU0JpFHJo253Iz491imxZRvyRir4OljTBn1GP25U0bmdMUhHVqtkQ+tVJjTYyRNgIbgmcW0aHpYvxQjPFDA0oH5hf7s5ZWMrTnej2Fo1HPvjmOS2DgkhLhPeGCBLDNNZIb0MOHuiUmEU8sR4v64zc6ANpKQzX2SSdDM9hb2RkK4Sz4YyE0zGDKZSV0iMrVxLdxB012qOVnJ4QhJUWKDSEeelXKte9WyQAqN4bpnPct5cuhSK/Uu8fzCvH8+9/ztCwNBoYTvsi0Y8p1SLHe56iO1+MuVcoHHRMx93Tg2iveouEQto0YzalJrKu7UuR+35rK0M8TULPSi0UXwEoodGbU78nUrqIX8H4fxMNM2LIFphtmQhwVqNPzE52Z0CPdwTfg9R8rolD1e5eyLWfhR8nZ4zBuh40EEnxj350L41KfreNup6Sw8gXpJsMqX2cnsv+iSVL4Ext8r7k7gqjlgnzb/UjpwbzZueJ7bEfYvY1w3fTs0dXiSe8L5t0S7FesVOphh4jJ2ddQDs6qVJ6YY4+lH6TaFtBHNWgUKQiGh79Sbb/mq0WpYgkIZS8l5zVEXaui7CTdhgKpHvK2B6OAz9zRtVvj6PFf8SB5iwSjZUR+hkm+SC6zZu/Rby/VhELM5w+Dnlulkp w+jzSzG7 3/2HajpjRx7OdMJgsAHPoBfmvuyq2NSHT8wcIETbajW1bvN/JI4l4/wNvH+m1XMwJW0Pf50w7zrCVXUsso+2xt7Meva3QmbYoIP9iRFa1SwPNBovmoOOxl4ZbjVya9IbR2fSLeXC+RqZqz9EFFV1UrrVOeJJCbG7lIJ+c7AQjGOCpwLsgpIxFWdIPnzfAaZbDGuDoRzLMmttRWY5XtuSZUU3UqSnOo6ArDbmv59HFrivjiptB+yBgP4jtjaJVt8l7xfa632ihxtwEsJzOJZzehuBD9Kf8C45hDaCiwyJtV4gHRSH4HCnFYkh540JOOIMIXlxJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.034566, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 8:52=E2=80=AFPM Matthew Wilcox wrote: > > On Fri, Jan 10, 2025 at 08:25:47PM -0800, Suren Baghdasaryan wrote: > > - Added static check for no-limit case in __refcount_add_not_zero_limit= ed, > > per David Laight > > Ugh, no, don't listen to David. I thought his suggestion to add a check which can be verified at compile time made sense. Could you please explain why that's a bad idea? I'm really curious.