From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDA3C54E94 for ; Thu, 26 Jan 2023 16:01:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6BE76B0073; Thu, 26 Jan 2023 11:01:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF4EC8E0003; Thu, 26 Jan 2023 11:01:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBD248E0002; Thu, 26 Jan 2023 11:01:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BA39C6B0073 for ; Thu, 26 Jan 2023 11:01:29 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 97E931C661D for ; Thu, 26 Jan 2023 16:01:28 +0000 (UTC) X-FDA: 80397415056.09.FC46352 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 7EE25140044 for ; Thu, 26 Jan 2023 16:01:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=h9de1i7T; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674748882; a=rsa-sha256; cv=none; b=eV8zwWtRws3BgKzZAbPYFg7nov+8lmt9nowbwKf5nHP4lI0c9rUbhEbKxUuPUKVZAUKbBw BBWoARdlGOjScQRbkqKsAFGxonCC1sbL/g3Tc0alvoaQLvb69rPlMnW0rqy27Qa4rcJ+UE 9rAU8ZiRCArN/hRHW75P5eZVlKnHAoI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=h9de1i7T; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674748882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7iT09H71Dme3Q3L2MGkwR4iQszyIGWWfBf0bjQrq8xA=; b=jjO05Tmkj7ub0eQssGl4kr/7k6uvHT2xKcTKocBLrSb8/E6hrZJX4VOJeT73S5eyckMgmw nxqPcE9JG95qQr7cDcPjXRf2/2GbnuFm5SKe0jAeVnhA5LZDZgeiwn7xNT5q0714+/qjrM +YFO5LukXkoFqFfUNY1lXSGs9ZCUhOI= Received: by mail-yb1-f173.google.com with SMTP id e15so2487113ybn.10 for ; Thu, 26 Jan 2023 08:01:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7iT09H71Dme3Q3L2MGkwR4iQszyIGWWfBf0bjQrq8xA=; b=h9de1i7T+L/7qnwBfp1S8fAzJvvQC2x2oi3vaG0TabJnrPiEBHWMEBUMQXNE++gvMw 0tvtDLc0gqU4SRrHQyLqiExsMlL/VWO5wXXXCyd4EfosvDm71I8QvFY9h9dh4v0odaek rqxRskgYYgAwXV/VpRufMlPSe3KjlzDDMsziRrkBRXl9kqFNnahRRoF7T3nsICDVigSD M9djwB9/VxsVfyDOcI98ZfLuT3Eimz5ul1kQFCbvVp6FsrPyT95Rr+ConemDfB7nun1a z0oNevShUsT5s5sUR+jodRgmCNuCA3ig4D6U+61xYKrnx3Cx6jPyfSahl9izAuY1q4Iw /Sug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7iT09H71Dme3Q3L2MGkwR4iQszyIGWWfBf0bjQrq8xA=; b=wJebNdttEnB5NYw0gTWEG851CqWMGTNAghjVUAMNvFo3ey28ZiopaHYD60/i4P/pBc rUpdrddggtvKsNe859sxR+FM/PgLdJbdRKlKZzrZNH+ub1VMxaktZYnUs0C/6Ot/dliS nsMkBxyDq59cDoajFkJkJv+syyrtL/VGP68QAn9r+xpAdWA53E7HPKpk6KBWtlYhbkDv LRLo9Yojm9Qr3t3toiey0ovK1gS/5zRoEHiy/9TOzmwHm3d3uDhDkoo1MhGnnSQc+KwG asqNPX4RGE1OiOIEqTQHL4AS7GLghbcYObAVyKoAPfATOJkLKxsV1hew3NBERZre6XBZ iFjg== X-Gm-Message-State: AO0yUKXie9F5D15hL09QLu1EHp7oR+3ne9b8vNIxneS/VKsH700E5jG7 wYVQyvwflA16+aNOI23/27Dpt2EzwwhnfLZVZ/uo+Q== X-Google-Smtp-Source: AK7set99qRZVqRtIv3KrfALWAP/G2LmVplScKaMgMWNFGGAbZHIOd3N3iLzS8k8hn4NEwWK4eNRhXhPnLf2Bk2V7g6Y= X-Received: by 2002:a25:5209:0:b0:80b:5988:2045 with SMTP id g9-20020a255209000000b0080b59882045mr1083640ybb.59.1674748881333; Thu, 26 Jan 2023 08:01:21 -0800 (PST) MIME-Version: 1.0 References: <20230125233554.153109-1-surenb@google.com> <20230125233554.153109-3-surenb@google.com> <20230126135815.7hjwrrv77y2en2ku@techsingularity.net> In-Reply-To: <20230126135815.7hjwrrv77y2en2ku@techsingularity.net> From: Suren Baghdasaryan Date: Thu, 26 Jan 2023 08:01:10 -0800 Message-ID: Subject: Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions To: Mel Gorman Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 7EE25140044 X-Rspamd-Server: rspam01 X-Stat-Signature: jxdmc43ax4upzxatu9m3bwbjouh61f1f X-HE-Tag: 1674748882-195223 X-HE-Meta: U2FsdGVkX1+aWauhZezKgxlLCMinBaSU+YPtg6sKkASHCdCy2X3PPs9EnQcJnBiBgIJyzUL1RK0Czjy8rx2zJW00DMe4T7NGd2WmSRBG84YFXpfwA3Z0NvFEGT3xQCYU3hn3sU/tG850VRzmq7GXJWrcesfRDKieazoXVCmcnhA7Ui/rQJfoVN9mvgwoIyZgkWAGavGnWN3YbWTXjbPmnDFnQxeYgmpR8A6/k30PlWlXDnM2FEoqvCDqyaWg2RiBw5lEx0faSfK7bgYYsrsQI7Lq9MFl6OiPLOMTawv6chZFCkSdC4lhJLV4j+hM0Zw7b2XNWMFhiJfaSb/V2Yk5v5PfQYUmlTp5j0uF1+oLr+QPCL1GHzuW4A+CAVddewi/35vSJBr77yhRFgjY82BpHqTWZIr76Ooc4IlZ9PSdm+ZepTbq7q4sm2SVM0BFfD2Koi4niwVVTzvtIcaM7khM1XedcdGUfxuDb1u8HOREHw4P0K8LJXzBgBwn784BsOIFfVLlQ9Z7UV+ewPYHuiUkensizMRJqoJU2iSRCQfyPjh+zOokYIRL/w2TnCSk5+wKDY58el/00Jc1uKbgcG170DGggBf+aVDdK2/wEqFkHTFkiF2ucNIjLOo+/HiTwAj3QbZalpeZ7SCMlgJENBzo8sGUWqfx7SXm+AV7Z+Tnv2Df0fOhdWGZ/9OmjelbyuX1j4ETWs3hbVb/y806xTLVqBDVgZWwmklrG1BR8whM1Q5fk6Cq2yGWvVnhPJA6vgPBuqPVNwRP8fLlvgYqe3iJKvTvxxullFHZ1k1rsBboaPOY29yo/mnn9azk4qnRRdR1zlgvR1RMWyvRDzkUGODNcxJQocoF8E2x2xHzJGSVjG2ErNul0udg45ObAFIso/6MUXGGrAum66X4AQurC9GQFomGKlsF6xVvxfNH56L8pdNlts5s+8E7kP46K9QzQzwOc7H7WAE1T1GJN/LtLQU KFJQiQ+g dXyqejQDHt6DHCcXBqW9lEg7x2At5e3+Dl07ylcJDfcF4oVhG5Ranlb2pCIvMjzHqaPT7+0mcDGv0dADOI5FZLMDmKN9kjD3tQJ/T6Ti7ro87AjvJLZlHIoAbPZUt0VTUsbMG45qYQnAkhWLzpdFz9f77vN7pAGexD4Ppb46aqlMhwb9fg4Uk0YiFBxVbW6ep7MYzFjaeaMf9tPu9kAWUnbD20j8SJyPKAK4hTVysw+gpby5oGgX3i0crMJtsgkZ2oKdMozRplxi+ZsXrst0rymaZpWa8KoBrz5J7/+9e7JICOM6ri6OcTBwgNX1MpDJWBzD7P7GYsbdQfGC9a+AkiHBCHcSYjRqkhyU52tQhVfmclvcpmTonYOxb5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 5:58 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 03:35:49PM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking exclusive mmap_lock to prevent vm_flags updates racing with such > > operations. Introduce modifier functions for vm_flags to be used whenever > > flags are updated. This way we can better check and control correct > > locking behavior during these updates. > > > > Signed-off-by: Suren Baghdasaryan > > With or without the suggested rename; > > Acked-by: Mel Gorman Thanks! I'll make the renames and repost the patchset. vm_flags_init(), vm_flags_reset(), etc. sounds like a good naming for this. > > -- > Mel Gorman > SUSE Labs