From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CE1C05027 for ; Thu, 26 Jan 2023 16:25:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB0E68E0001; Thu, 26 Jan 2023 11:25:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EC938E0005; Thu, 26 Jan 2023 11:25:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83E3E8E0001; Thu, 26 Jan 2023 11:25:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 741D08E0005 for ; Thu, 26 Jan 2023 11:25:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3B1FAA0DC0 for ; Thu, 26 Jan 2023 16:25:18 +0000 (UTC) X-FDA: 80397475116.12.B540E69 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf04.hostedemail.com (Postfix) with ESMTP id 6122C40016 for ; Thu, 26 Jan 2023 16:25:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BrNExWGH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674750316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rUFKXit/Slxp5jNkRtm2qJfbudUdkwg/5ym9L9/2xFg=; b=1gVuk8aYpMI/rzEUbRpWUVd+XkKwZMonb7jxiggeqcEvuYtHlf58gwjE+5eOYukzM53Hjj r+ci2RMaPkYCiyHjwMq0j9eNmODBgrFud4L4nZ0YkyYv9UxaYMyFWXw4zdBO/cL5V8lCmI FP8eJL1SudoUND9l6+ZMnj5pCJtEq2w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BrNExWGH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674750316; a=rsa-sha256; cv=none; b=f1jwbMhCaMmycY1wbKk//ucs8i27Ao+r36yES3SMDZoV4zu3CPW43yp83/HwunemBjFp/H K+GSC3ZI+P1XsxD8Z51tzSfnf3/t0bTTXEXw01VtEGDn/Nrat3l7BN/2T9Z9w4G0+va8VJ yRkezFKAI/j0M4iCICB9g41skZqsIbE= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-50aa54cc7c0so2438837b3.8 for ; Thu, 26 Jan 2023 08:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rUFKXit/Slxp5jNkRtm2qJfbudUdkwg/5ym9L9/2xFg=; b=BrNExWGHbV1NeR+vu2Js5zAqwDKTAmFhHgoWjYZ0a3qbH7rru8W3QViuclznskZkVo 6Q5eqrGX7jMOOdvE9K9lsVmJpHX9roidNQoqd4ah6qpZ3z5AR/LzfumpWsF7qxr+L/L7 2EeJAw9MATGkA5VBf2UwOc7KCg21F0CUspP8pGqPmL78PHbmYrJgHGcDXuiJf+tpyEq5 mYd3qiJmdB/mmqbT25mkgF6e/9yHOLIF4ZmJU2qiUjSg09+a1L9BOQF70sP/z/t1hEtG N3QguNCw23qX8RL/9XVLJb/vAzwIwx19tcG6Myly1SJ+d6fdbBsCbrW+Wp9iSE9SLjFe r7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rUFKXit/Slxp5jNkRtm2qJfbudUdkwg/5ym9L9/2xFg=; b=GMR3cAyJfbNKs0eAoCAV5sOmtVc7iFET7Le8KG5QFQWOhTE1KR0lWKXQ71MkdM+k/H kyNlRslUHvhCxHPQUCW6cDUmen0PP6Tlts18xzy2Tvqzw7UI74AuVcds7HNOxCsWg2Jq exBmy816AhjiHcLUS8PzSWRkZn1+smxEag+1H2w0KXpobZAI0LM3g4lz9Wku0//fGw3c D6kckxmo53ikRbFSfTaqtU7LMBwDH6949WsCNKdtkqZ7R2vGloWnEdnPqEGuZ0WBMpgi fvDyscUB0yLDqmwb2wAeyHL9HJYhQ42BTMzHryWgCOMbwW24z+2n6oLMC+81rgbDefhE Tc0Q== X-Gm-Message-State: AFqh2kqgqyWniAj4ecqCLmWu6g4ybcJApX4oQoW6ML/4KAs/dJGrbxQd nVFga9r02wq4e4b6iF2LShIrS2O5NBKYQoAHUBKm2w== X-Google-Smtp-Source: AMrXdXvRVLeaIi85wIrJBS5zRkOyr5/BQ66PCe0y1aLe9hmWIu7jqHBlhyy2SYPoXbE9x4WotKo1j1aRHLVU6Hd1LsI= X-Received: by 2002:a81:1b8b:0:b0:4ff:774b:7ffb with SMTP id b133-20020a811b8b000000b004ff774b7ffbmr3541685ywb.218.1674750315051; Thu, 26 Jan 2023 08:25:15 -0800 (PST) MIME-Version: 1.0 References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 26 Jan 2023 08:25:03 -0800 Message-ID: Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions To: Matthew Wilcox Cc: Mike Rapoport , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6122C40016 X-Stat-Signature: xyguydz9kh3gb5oismxzj4ciowaptwhz X-HE-Tag: 1674750316-723388 X-HE-Meta: U2FsdGVkX19QUkXOaoRsGbxyZFpijLAu/k0OVU+rNn0nPWqP5Vjqq2N77bAX4hXAvWPYLt34S19rv0xbfbSfapgKj6Y8KgSh94peSdwhg3p2yT8mRSq9il2/C5qFMFhF9Qk2SUSUqoHoZQk4sXWlDblR+vOZneZHCEzuigahYwGM/xsTv49qV0AEjwXfttEAdaU90e58sKEiJklZkDKdjV324fHSwfK+tDEYOU++nHi2roDFH8mAk2w367FVuDFOQ4nrNdPGZyWqffd1CE12afjILt7u533w8EtxnYmeeCRXgSztw7cEIEasVj62ctqAyVkrBpPCp9QrT5cEe9iy0ERT3df3DOUVbrxC7HvJexZ4Behjb9dmsxEQoKXRU1TWKbbpCLB0mOOQ058HJuY0qgV1PC5Qs7NQQDiR1+dWufr+53N67vbqSJYy87tkQVV8tdzxm/o73MA0DdoG5CsbtdPJQPOsV00nhjO/1y0sAcR+QDtJzR6DsY1Z4zHt9vjACtliHW7+KdLy4edUqSlPA5gwUUH+x88rRIDzuZ7QMUs34LCL2Q2SoKmr5+XP+bux1xnqw7nv/RMIkaSuP9+obSnsV+oZz7ZqRIMKoyCGDVtqrPrdYx3w4FPjqq7vkLqyr8Wj2Dq5+htrLB1qdHs7ZDf2Crhy7qL++Bi5R9g0tTjyf0YiCFfmP1Ywp7dXqgTun+so6ZtNSrIwXvEhvzI94qXpkNuYm23q65UQnIZ00H3m/ATEBw7vRG3sumknklj/KQ0lqDYthyCk8A5Dqc3lNKccN0zlrLgJqSDyVdmok00i4sic+TBD3KEtY1o4OdeRN7Gy9AFrxJLe8lQJ9YUIlc2UCZobqbjcbBV5G4QecccJw/Bi1taBLgh8kyXTAymMBqKtQwnAXK0y2tsj8sn6wkresFJhlDA1evKWv/Q0Yq6PGbq8OdZYFAbSRTU3NQFdbkt3zcB7J0OlHrPbSWa MfXe0DeE zR8L+kbv3QBbpiqRNciO6Q6aFXq7wQ9l+yUOQM7khUnTcMW7vJS7xZl7g4vedubUqWU9RAyfqUhOVU0NbkdCBJcdmYVxUIXfw+db309NMGEK193f3VUarMzSjS2gDBsR3ErxTTV+o7B+n5wlQZwJ3u/SW8TxnE/KBvkjVSPYlAXm6Pe0pqTtvZZf/sN/zFaqt/wEuxKwFfcgEM0g/Sg1+tIHBTCFy+muUpCfm1M+BSrUyjbJbia9WU/IqVuEX14HlqcsNPW122taObqQgMjndzdo4l/kZrTQ5C/1pggeoEnw4XElopmyW55/i+I+opUFN7Z0ysZelMK89NGfyiH4gl0yJJZR1oLjS2VmejSK/3LirgaTQGU3s7Hr1fGyCtD763ytcPYdT35jhFKVVglqXQwjjX8LBQZVlZZhY0I04cfdrLNyHDlaGuIDFm4pIvZBfX8sb6SUV+Nv6BRdfqVbNBSGYqNvcgZpcGAdS2iZngqnHWvwnSz07P0jz/r7eYaGf6kW2xvx10BQH8vbhnvQCANOHZakrS3RJAGKcyTe/JN2807eaKxbuzzb/mtbA7QkgH4DZU/rptFdZ3p9ezy/u3mucegQ18KFclZrwfKbOIkH44AlPF64TM6AWMABWFE57a+ZTdyHkvuMhdDPlAFaO7YFP0h2A0tCc3divgKR33dNVNezbzqeLVYDEg0Ze7GX+vWk2F0enkyZYkJTowUzI3aB5PYgQaruu8BZ23euYQKMk7uk6NXxNA+zoygEKPsErMk+NwvhQQcBifJ/o/lkf8EKONlRXdYeY88EA7oe/Vn0eDX/q/XNcK7z1yt0jMLLn6d23DyzXcbOkx8/518K8Mu89bpuElymEjXrSx0734kGsmWzH1DbqaQVjiQA+Mdb/pp4pCP/bMPssA3BflRRjltKwtsVzCcwAT+tkB5JyaqlAvfDIJ0YfpqQpgANzSiqNPG4QykjTp/ig7iZRI931zghNd8VR 4I1uLMBg j6Hg9G7/64Kp8j7s2Jl8ilQUqR61t1/gFgTlgXQ0+Gbd9dNhQOotNyw7LyyKeIo+Gp8tWYebdgoyVYWYNC8AsvrXqFcWfaAghG/h05sU8C4U+FYAUffclONjOd7SPRwFzQ+l/3Ob044dTJFOn+8wzJBPkJSMDABFAQd+rmpESB0E/iofMT8/0AawT5C4/r9Amd4mW6MUSOMrCn/9vkkCRBKE7/nAugsbaX1ai6JzcypbEEPj96FTU8+na1DGKCZYxpJA90n1qosSHV1WiBAntJmfnjXwRS5VsKYz8aZaVJ4r8YrFgigCzkwlpbojeJ4M4adX5ZKkOGxHfIAdpW+MquKvAWrvuHR2y3RqipZ2p4WaLdN1QcPYRqdWagXCz9PejaNdxIE6JPJvAn849ZyeFg20Rif5L3wuxBFVjoItOvdYe2tzYYq/Q/P9LTLr8/Vguy5gKkljmzke5152zQw8+PftK133BvTJ0ndJ0UX4EKmhv4dxPJgdX71nr/wDz+FEJHy48np0f/lRCSgxNPy3W4Onmuqt/9DvV6NVwJ6Zv2LkEi+MbUhpNvDYGF6lblIq87JNgMOPl4j2pY39BtQGRMrvXV82qlZ4FrA6BfF6EAuF5KzedY7/xTezUS3VZ+cmtgpeWzbalTpNwHhK46iJSfuFJn7AVuUHTS55BBT5jll3VLmbUP9BDZE4idBt8zhyhkgBTYdTKbGH0Jepfl9TenY6yE6iQ44hF8VFfxtqd5DAI+wj60IHFf0AmmbN2NBM6uIvGLkKO6fv250lSlUS2Wr80Ia8cW5234ZvBmLRP3Ziq2KqhVrF2we9M7swGvP7nnF0y4I7exafR1FrHGQfyuLn/iVUFt2JEszNtHTbkVnd8ZQPAlOPUROIJHmMdz+GZZLulW8WCxOe0Xs7H8UxnF/YozFKLexcd7LLpAW50u8zbegDSUJ5Zg64abfKCiDUJ83vc5oXfYL7T+gyguF5RMLxokBbX ulYidDrL 7OJxATca8rP0k+VIko+98hQx4yzAGBvD/iIKhlOzMu0zd6MJTISP2nm946Uy3Ui40Yq4UoJVMWZgYv8+11heyXJyPlt/DX81A0qTMWtZ+LhClpU26HOsEIxvgB9N3VvIQmxA9gW9dzcPVlfkwwamL+94odVVD4k6/+r6/b9pZqNuD7B99mbXVR1DhXbMlMWUGpX3QtVFP4e8rrI6K021IWvwvUuH6j0pBu/QA40t1IFRHTedYCfou8hVxguGuxAq95IySCM9GPF4POY4AvhJ9QQQT6W33lTmTz9BPfF5e1WAl5tidl7gr7WSF4Q6zYZr/Xb5NZC1LLD3k/MYb3YvicG+NSAiYjIDaWu06Y2SoZR0aIYb3DjEK4CgKz9mzYwv9t/NXbGsCGmdKdIe5Zw9Bda5O8wu/Ua0PMMZPAYNnzB54eNMVqjvq5T30qEkAM3Q8USuTSIgDwRfaiufFK+11EPN/2apmy6oqr0fI9GPU1qAMV6naVnuhwO/M+IRKtFCrBVuFPpNELs7KGANbj5/CRJw9AVWymwZmfk6u3CC2B1crTHMTyMgIzwg4aScjb3JCAlqRmS9ZLWnRsPVDi18zIh6/Aw+Eewv4x9H2mqlX+99uVknKdi9pnRVuLXmmhuww8+WZ+M8Xn4rFgGtOQ/R1qJjiNM66s3EBcjd3JV2ZIuBn12KOMsP+S8m6vSfKHYM254NJu9ulxpIMGKj8SCa+gvNphS0xiGz+wOOVcPWVIJt6XpXcyV1PpKY5Nl7xP9WociDMM58YLrcNgb1FGh7Fb4tsJR9Mq4czRjLoLmS054Zkp3HA5EaDF33FwL2mlHSXim7+2yo82Um24qA/pRDgc7B4ZkhRhgUbLeOxv+EGRh4iJTDhVoljrq9TXXLUm7wO0hqdcTcRldXAX1xq1PDR4PFHI0PVs+nNr6EGhuHRSiJSqRTRJFj7FPeKjidO7nnagWAcOsT4ll0nkw2n8k9dDyIKAbaU skC3bCCc y88qMdw83tSs/DEwk7boUsqUYsjBk7BYxL5kMjnXgcgP4p4x20OuVcLDrOgGJZebXwd+jGNQ5dFIImg/ibXm+DH27kfFQr1ztdq1/YabrI+JcJ7FWiiLjouPOW2qfNNfWhPcXeccz5QhHffRrYS2qNuIecQ+p7ik4xMwE35FacwZ/b9ySp8paLa/UZjTqLz6pKDwtdkTNeKbiU5NCE4ErQv0Jpl46BRf5DHp7qrdxplUAVA1wYTa1lxztWXjju1q0N27udv5vEsZHg6OwV6xz6iXeIOMLxk+k1hoxqieoOCd808CAGOy4W7TfvcAwG5yi3oQf9UA9pirFoO2tTdCH55IjdWlzm57Erf+AVXwlc997SOpxWUNszZC+qnfOv/qUavLiTknxAUKgMv/Y1PxrODM3pfp0C2B50oeaSDCdEZBJ+lvYXOX1pEBjoQ6gFSnjak/92CkAWXBJZWExPl4fgq6877Nny1GsUAhkes4Ko0Q81qVqDMAHRWmrZcQWXbU7M7t8xAVTH8MsuNGp3WyWnGqiSX8GN3YLJmctOoZZkmLfeeUpN4+8hr81pYQWO73V+Y7iWtoqScSWoNZu1k7fW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox wrote: > > On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > > > +static inline void init_vm_flags(struct vm_area_struct *vma, > > > > + unsigned long flags) > > > > > > I'd suggest to make it vm_flags_init() etc. > > > > Thinking more about it, it will be even clearer to name these vma_flags_xyz() > > Perhaps vma_VERB_flags()? > > vma_init_flags() > vma_reset_flags() > vma_set_flags() > vma_clear_flags() > vma_mod_flags() Due to excessive email bouncing I posted the v3 of this patchset using the original per-VMA patchset's distribution list. That might have dropped Mike from the list. Sorry about that Mike, I'll add you to my usual list of suspects :) The v3 is here: https://lore.kernel.org/all/20230125233554.153109-1-surenb@google.com/ and Andrew did suggest the same renames, so I'll be posting v4 with those changes later today. Thanks for the feedback! >