From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E48C4829E for ; Thu, 15 Feb 2024 16:48:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1655B8D0006; Thu, 15 Feb 2024 11:48:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 115B88D0001; Thu, 15 Feb 2024 11:48:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9568D0006; Thu, 15 Feb 2024 11:48:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E16068D0001 for ; Thu, 15 Feb 2024 11:48:15 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9817EA0F2E for ; Thu, 15 Feb 2024 16:48:15 +0000 (UTC) X-FDA: 81794620950.27.F3D0C27 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf12.hostedemail.com (Postfix) with ESMTP id C37CD40023 for ; Thu, 15 Feb 2024 16:48:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MKJNT60j; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708015693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1tI+hCE30y1jp9jG4DD8d4tpJXQ3JxVVysbuWcCVNic=; b=Qszpc6hiev5VJn32tfy2YfZOVBgRPGE9UDSt+oO+aONrgMLYB3TyoyNr8vMVWflqVpf/2A v+4aqWCYjcUVSdIqM1+CcPwzZcEDUj/zCWQ8N33pdyfqTtGRcbJzJazQg35l9FDlwKerLb J9WYBAreQFa5FTK7dP6db1pSs+zmH2U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MKJNT60j; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708015693; a=rsa-sha256; cv=none; b=xkJezhLSOGL4iUOLqPVXmQHLh9bxvRL5qQsuvJk+9TTR3qeeX7H7i38xfrvgSxZV/i89Ur RjFQaqS109JxUOwB7YKec1/6CL7l43rinmal3+n/XAu3i7e9ElYAteIPTp6ISRNvHVDYv9 KTKNkjIFEIez8zTb0diIPMrv8rLnd+c= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-603fd31f5c2so18578457b3.0 for ; Thu, 15 Feb 2024 08:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708015693; x=1708620493; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1tI+hCE30y1jp9jG4DD8d4tpJXQ3JxVVysbuWcCVNic=; b=MKJNT60jyMZgCSCIQi5X31MGVW/YyFa7z3HHzJw6DEDsZq7wqqeR2cebdIUIgPm6LR /c8IrNnlH46wHhVThenGjZzi5wS1y8xh7WO52DgZPJO3GxcB55i3EzDSqINNjWU/nYZk Ejalw+eBD7kRvDqAphEycw7i+AW6OpJxT1Mi0geiMn6roFhAwdlJtgqd6D5+O+sN7Ndx i968HWeVyXt1ZD1eR6lbYpo45w3JnKF/jWOaKX3tE3cvRcgE9tOUrVPohyy8OZUUf7Dz XIbhfBDT+/0ZQGRCQTvvkhsuomvAsPSNqe4QgcNFZ4jQUTL8coF1dV9l1FpY4iz0jDnq mWwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708015693; x=1708620493; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1tI+hCE30y1jp9jG4DD8d4tpJXQ3JxVVysbuWcCVNic=; b=YsYMO6yqXNodtoA+2dyB7lmjC1hGe7/JfnfAAaf0fz80K0d2pN6zAc2W4qzwJBGmXF XAIUjZwrOYCHSy5aXl9nbiJbAcmVGzugtrlmtAPytdsDOi0mLceMleNjimYS4yGAvfqs hUdNL9B+jX1DTZ2f9INGTDNFBq0ETPVmjOHwwhn15HGUqxgFBxk2/tEt8fobzADMndqe Q41bHncoIntKtjyEzykvBFZFsyv1k5bxzrMH2jxQLHZPCD8StgbkShWMTrSGW0XRvkBP ymhproU2UTPSFfvtOWCxFtYEI+8+ZMI7x7sXDDz8MCtcTiWOnE41/8t13vHXzNukQg0h 13Sg== X-Forwarded-Encrypted: i=1; AJvYcCUwgBnM97+AwEeBwtYOpBBLkVLft3wYY23Ifw3N7Lua2UUOyKvfZdj2ojmwkf4rJA2qNguD7R70PdDcQoJYhv4wDos= X-Gm-Message-State: AOJu0YyejX51+nT+YODZ3QXIJz5v+7eyJY/LxKHzjOutK6H/j0VtO8dG RbiOjHDTcwBOdbLVSWzUbqn5SKCY2d8/oixgIjF8YjoN9M97qe9WF3zQBQNAIYlyJ9hzVtYmUMv zqbVuUXv/YFmB2B65y5TlVgzCk/+WOrwh34Jy X-Google-Smtp-Source: AGHT+IEpKo2L6oplIyxSXpvbYHFzpW3S2D2HSJYFHw3+xQqVKIR17Ywy1D0gSKm8xVOUSCj/xezJ/KNnf15e7J0VTMo= X-Received: by 2002:a0d:e284:0:b0:607:77bd:711 with SMTP id l126-20020a0de284000000b0060777bd0711mr1808635ywe.11.1708015692595; Thu, 15 Feb 2024 08:48:12 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 15 Feb 2024 08:47:59 -0800 Message-ID: Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() To: Michal Hocko Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C37CD40023 X-Rspam-User: X-Stat-Signature: 6aj3t6a7iq5tdako8r79d6myfapihhib X-Rspamd-Server: rspam01 X-HE-Tag: 1708015693-997490 X-HE-Meta: U2FsdGVkX1/r8CtJlFalcFR8meNHkwLlmzAJou/eaMY9cqGxUi7EM/ysbggcZ+9wWI5d1TS/rysFGK0D04mPvObNW7JHmMZrZKzB6vCS++w8+zIWvCvtqnx0ptuSFB/8VzVp8CcA6GPcoqZBAUVRT8rVimymzjedfUL5ZOx32bDJTJIBelHsG4g2Dh81wx7hnf3fWfIi4iLnrxv+m6eaL9Lsrl5ItBHn5Q/Adb5HrNGtjUKufgx9JeTkDkjk6XOCZWmbsBPDssQCzINgybdx/AB+z/GHX9AP+EYYQyaVGT4fiqn36+NiPjObsW+epnd5Fu0EuhQAVEpZHtj69PkLpgibGUCBGsR/Cx0jybrt7tie/p+HfxYD+MaxmnUGzUCgeQQYS0UjXmaxM+2RW//K4NpCnirEUff49pwtE63D1vi7sCg3M+8d5yrlkYeCL5fUO71BZbWPQ4BKxmFAgVmuhNSE+E2S7w8Mmy3b9nOfsGTGS9HqdVkmUl8zwjfiDuBCBR/YfsRjjIzaCNnGTV2G+/EX2j3ZZ0kPrf3oSnjiNCDMpkKKPZouoL4xNX6JHkJB8fSiwazKpe/wKSKgFCWBbF6tob0nMU0DUNO7l3q0EnSTFnRwNAW8Dnw4OnvD+aAisr1SfoZz/Neu+sEIo7VC4MMIP4/2oLOvJvDvq7rsWDTBnpiXw5ocPNJ8CV1uWQrGywZ837cSDZnGlLZqKtKE8ZWFGFZFGrvqoWjcKHKgPDUlZJJin3YHqVbTyrenkqr1pMj+JyLVsjrnmLTMLzRnpgrsisI8qTx5qlW1oVEZAWrc4qlimnN7RaJtbw94qyKn2WFjMykKbUsDrQEI5RuO3Kf51R2BgilGhB6t6kkVsGpTcOOciO+oJ96oq/J0RmK8YAoR0C+IvoINpjZQVB9MPWmzhw4khmY5jHfUHNo0Bck6NAm3Qf/qgHrm52rCJL/SMS+tRXhIxkDNsKXCpjv sz/g/oJl AVrh0rsMWK1VnG/AsdgkiMaYaY1snHxz/KAWQfKyHGrWqOSfBGg5BLC1D4heHyuEn46OQse/b6PiZtiqSucVKAR/fnMHTyZiEK1VTgzh3M4dST4qbFp7xfV3rllRqnXWuB3QTW1JgJVaip9GkyqLlpdQyEvu6sU9Dlo34a73TLRgwMbK/41afSOhcLb8QeCHY7fPGmg3wEjrtSIgEjC4ywf1InKw/9CEWWhZ5Qy/HLAeH+CvJzLxg6r+rjWjca6KXxPPeWSgZzLfaJvfkV70i6XEfPFN7d5p67FAzFe/b1hkaa12iz6TOLCaSkffiXmY42UDqK2nss34qfEKA2PnX/ZvQ+/db9cfNF14zfcyj6P6Q7vVFuXAodA9hVLQwmoMMVUEURvzx3sUW5IT3SE96TwyG+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 8:45=E2=80=AFAM Michal Hocko wrot= e: > > On Thu 15-02-24 06:58:42, Suren Baghdasaryan wrote: > > On Thu, Feb 15, 2024 at 1:22=E2=80=AFAM Michal Hocko = wrote: > > > > > > On Mon 12-02-24 13:39:17, Suren Baghdasaryan wrote: > > > [...] > > > > @@ -423,4 +424,18 @@ void __show_mem(unsigned int filter, nodemask_= t *nodemask, int max_zone_idx) > > > > #ifdef CONFIG_MEMORY_FAILURE > > > > printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poison= ed_pages)); > > > > #endif > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > > + { > > > > + struct seq_buf s; > > > > + char *buf =3D kmalloc(4096, GFP_ATOMIC); > > > > + > > > > + if (buf) { > > > > + printk("Memory allocations:\n"); > > > > + seq_buf_init(&s, buf, 4096); > > > > + alloc_tags_show_mem_report(&s); > > > > + printk("%s", buf); > > > > + kfree(buf); > > > > + } > > > > + } > > > > +#endif > > > > > > I am pretty sure I have already objected to this. Memory allocations = in > > > the oom path are simply no go unless there is absolutely no other way > > > around that. In this case the buffer could be preallocated. > > > > Good point. We will change this to a smaller buffer allocated on the > > stack and will print records one-by-one. Thanks! > > __show_mem could be called with a very deep call chains. A single > pre-allocated buffer should just do ok. Ack. Will do. > > -- > Michal Hocko > SUSE Labs