* [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub
@ 2024-10-22 20:56 Sourav Panda
2024-10-22 21:03 ` Pasha Tatashin
0 siblings, 1 reply; 3+ messages in thread
From: Sourav Panda @ 2024-10-22 20:56 UTC (permalink / raw)
To: akpm, surenb, yuzhao, linux-mm, linux-kernel, pasha.tatashin, weixugc
Cc: Sourav Panda
alloc_tag_sub() takes bytes as opposed to number of pages as argument.
Currently pgalloc_tag_copy() passes the number of pages. This fix passes
the current unit, which is the number of bytes allocated.
Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()")
Signed-off-by: Sourav Panda <souravpanda@google.com>
---
include/linux/mm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index ecf63d2b0582..2890001c8b97 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old)
/* Clear the old ref to the original allocation tag. */
clear_page_tag_ref(&old->page);
/* Decrement the counters of the tag on get_new_folio. */
- alloc_tag_sub(ref, folio_nr_pages(new));
+ alloc_tag_sub(ref, folio_size(new));
__alloc_tag_ref_set(ref, tag);
--
2.47.0.105.g07ac214952-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub
2024-10-22 20:56 [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub Sourav Panda
@ 2024-10-22 21:03 ` Pasha Tatashin
2024-10-22 23:04 ` Suren Baghdasaryan
0 siblings, 1 reply; 3+ messages in thread
From: Pasha Tatashin @ 2024-10-22 21:03 UTC (permalink / raw)
To: Sourav Panda; +Cc: akpm, surenb, yuzhao, linux-mm, linux-kernel, weixugc
On Tue, Oct 22, 2024 at 4:56 PM Sourav Panda <souravpanda@google.com> wrote:
>
> alloc_tag_sub() takes bytes as opposed to number of pages as argument.
>
> Currently pgalloc_tag_copy() passes the number of pages. This fix passes
> the current unit, which is the number of bytes allocated.
>
> Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()")
> Signed-off-by: Sourav Panda <souravpanda@google.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks,
Pasha
> ---
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index ecf63d2b0582..2890001c8b97 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old)
> /* Clear the old ref to the original allocation tag. */
> clear_page_tag_ref(&old->page);
> /* Decrement the counters of the tag on get_new_folio. */
> - alloc_tag_sub(ref, folio_nr_pages(new));
> + alloc_tag_sub(ref, folio_size(new));
>
> __alloc_tag_ref_set(ref, tag);
>
> --
> 2.47.0.105.g07ac214952-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub
2024-10-22 21:03 ` Pasha Tatashin
@ 2024-10-22 23:04 ` Suren Baghdasaryan
0 siblings, 0 replies; 3+ messages in thread
From: Suren Baghdasaryan @ 2024-10-22 23:04 UTC (permalink / raw)
To: Pasha Tatashin
Cc: Sourav Panda, akpm, yuzhao, linux-mm, linux-kernel, weixugc
On Tue, Oct 22, 2024 at 2:03 PM Pasha Tatashin
<pasha.tatashin@soleen.com> wrote:
>
> On Tue, Oct 22, 2024 at 4:56 PM Sourav Panda <souravpanda@google.com> wrote:
> >
> > alloc_tag_sub() takes bytes as opposed to number of pages as argument.
> >
> > Currently pgalloc_tag_copy() passes the number of pages. This fix passes
> > the current unit, which is the number of bytes allocated.
> >
> > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()")
> > Signed-off-by: Sourav Panda <souravpanda@google.com>
>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Oops... Thanks for the fix!
Acked-by: Suren Baghdasaryan <surenb@google.com>
>
> Thanks,
> Pasha
>
> > ---
> > include/linux/mm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index ecf63d2b0582..2890001c8b97 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old)
> > /* Clear the old ref to the original allocation tag. */
> > clear_page_tag_ref(&old->page);
> > /* Decrement the counters of the tag on get_new_folio. */
> > - alloc_tag_sub(ref, folio_nr_pages(new));
> > + alloc_tag_sub(ref, folio_size(new));
> >
> > __alloc_tag_ref_set(ref, tag);
> >
> > --
> > 2.47.0.105.g07ac214952-goog
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-22 20:56 [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub Sourav Panda
2024-10-22 21:03 ` Pasha Tatashin
2024-10-22 23:04 ` Suren Baghdasaryan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox