From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84100CDD0FF for ; Tue, 22 Oct 2024 23:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B526B00B9; Tue, 22 Oct 2024 19:04:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBBD86B00BA; Tue, 22 Oct 2024 19:04:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5B796B00BB; Tue, 22 Oct 2024 19:04:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B666E6B00B9 for ; Tue, 22 Oct 2024 19:04:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04979A9D71 for ; Tue, 22 Oct 2024 23:04:14 +0000 (UTC) X-FDA: 82702769646.02.57DEF21 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf25.hostedemail.com (Postfix) with ESMTP id B0F03A000A for ; Tue, 22 Oct 2024 23:04:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jUfnDuWa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729638119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0bVSD09bB3faYt4CVbD26hdRycfzJMqJ+dyf4YHR0wQ=; b=jJnBEbwIYbgKVHrpXbi7HIzyop7maG566/MrWFagRa0RfsZwYdjZRS+6lugtetamc8ox9M DNdiw/AVioQYl/5Zul5kNBnp89lqx/idm1+YLFvQRg2IOVIju1dgLwXGuXQllu1+vENdb2 EsCC8mL+fjgfMmlejph+aPVOTeAv9zU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729638119; a=rsa-sha256; cv=none; b=WRdKRIQ9oOVrUB/22c4D4C/hkJBCSL1YNDUSAcgNB7+wK5ZGy2CTh4rTeF0f+6yGekwLWc 0WnHlKSuJeLozoe03dCIw6ywNXadp6WTJyJTqdOfkMcuFcpVksSzUaMqSx3TCxycK3IbwP GuDH+3OUBFGrfyjka2d2q0m6DYUb27Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jUfnDuWa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-460b295b9eeso54211cf.1 for ; Tue, 22 Oct 2024 16:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729638285; x=1730243085; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0bVSD09bB3faYt4CVbD26hdRycfzJMqJ+dyf4YHR0wQ=; b=jUfnDuWa9o0GrhtxIWC0FCfX6vTkNcgI/7q3+fZbdRqZrKtsGCMXOK2uBgypCK9p4H 5oTGt085w2pN4ze2wrkj1d1gcoF2uyxZ46Dr/UKTnMZLQ6nHh/7BiQrrTDFfSxjkhVEg Q6xpGd80P37FjV4tHZzNXVdwtMEm77u62Z+NLvBgV02/J7fhNILAdvQ5YCuec0epLVzW 446im6/PiOneT9vDvfYrxS2vI5zvo7hEGzY8/30nM7O1FlzQ73yqQOXB/uOMmsXHClmj d5LZEzLbyzC3Chp+toFans61QbEsoB2Db/xaPhPJKTVCKMK7VwTP1RGFNsJZfOrWKDTI dZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729638285; x=1730243085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0bVSD09bB3faYt4CVbD26hdRycfzJMqJ+dyf4YHR0wQ=; b=hvMZ7bmdLVDvWALh+2A8H2ANv5OXaat1447dt2G/QkR/BfHZgczM+iePGD7+5Gl52Q jfhScaSyj6bbKaeHPTySXYrYizpC4rXydrJUyMLAJTEvLMu9U6jEne/nHX2mWWgUKpJz mzPvqKTVCKzlvDqJgcUaabuawT3ZPa6oG4WKTtAbt5kT3utAn2Yu2GztbEv/3IcTSxvI M4ML3zc9uLUahGa4UkyqGGdcWvXFkAdKxULxfX9V4MPJhk1XvHahJwvBVCKqub3TFpvF bMuPmwrmgnV4Jt5moJCGyIwMlLeO5ztq4C2gnivOuti7gZeNcX4PB3SG3WcCWTPzSnRR eyKA== X-Forwarded-Encrypted: i=1; AJvYcCVP0qPcDZdUokHt05uv9jTLMgsfozkk5Q8oiV8RlrW3Of6lHFPbzKn26dDr6O3VqoGmmqpOb+pnXQ==@kvack.org X-Gm-Message-State: AOJu0Yzy555jXfs9KdXiNSk9bp+4KeXJyz9+EFmLUmtWJSgkBE0LyStb 8627L7dOEC2HRaqj7XuTurVUc4tuDjIaNP/WuiGyamYY63CUEFr8TXFFJTlBqIbMxLU+/pY2nF2 NewhRWrKnVvUgGdYFu7bw7jpePzi0VcAO5Rnz X-Google-Smtp-Source: AGHT+IGKkOi4J8lTlYZdHUzI9kAHBuz9nhLGV8Ib23f+FNH2f8NHlazCJ4EMPsRH8Q2vBoyyCBiccjnJLfL428i4Gaw= X-Received: by 2002:ac8:7d08:0:b0:453:5b5a:e77c with SMTP id d75a77b69052e-46113b19040mr1860901cf.10.1729638285185; Tue, 22 Oct 2024 16:04:45 -0700 (PDT) MIME-Version: 1.0 References: <20241022205622.133697-1-souravpanda@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 22 Oct 2024 16:04:31 -0700 Message-ID: Subject: Re: [PATCH] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub To: Pasha Tatashin Cc: Sourav Panda , akpm@linux-foundation.org, yuzhao@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, weixugc@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B0F03A000A X-Stat-Signature: 7app8xsq9rrujit1we5dn4gjra4mau6z X-Rspam-User: X-HE-Tag: 1729638274-938020 X-HE-Meta: U2FsdGVkX1+6sNLJJ9sDflLJDVittfgNeOKzSnPf1qOkYl1fQDj9yLhZtFzHkKeQpUKCT7xXcMqlhgc/6yVPXyYDK+Vw2Q2XqmnY1wSii98tT953GYi4oql08WfcH4n7/XYnymPjGmRp6ENFOlmxxFmAgFXFXxS2Us172IuIJYKTx3JaIB6hWj9s0tbPRb06M61njUJh2wt4PU9Pi7myoD28KIrd+TrqqFIvuiP8edglFZJNpRhp5a8aLk1rx277rCg7AIelKbJp1hZJvyNt0T/RfZSwC9VGxyyKepYWpInws61hAbdx5/o2Vc83pV0befFPJ9Z4iWnuQ34cqKp5IgA7nCD5yFvQGDpv4B2U22iM/gEBoC1aXK6y88WkuUiHa5SKzBXP5gVf5lasnSAzKVsUP3AvSuOub6gREL9QrNS9WRtGSGmTQqmClEq737fnKwbB+HED2gkggD7Av6UfdKkGmJxocYXihCwO/HWVJ0AcNJkMYlz7hteWrTNTqSNb2U9duVt3x4enx8Ld3nPpd/fF/XKGvxw6uLGRGu5/qqqBX+3vzt/CqbRWhNDgY1gXvKhR1xCDkvsn6Zzsf4UD3+2/O4TomOjkeQ/6OLwLDcTbebQodIXfYGEcagWo2ue9AX19TkASNs29Mjwbcpsad1Hum+25SuFsZqpCXUePxUiH1k+S4JwzC+L5Fl1PekxYK+zXSHVlp633zN8xsYU5xSc45SpU3ULkaf1OArxta6ygzv4EQ6kf+2T09e2+palJwhOtjK1Gf6Y1nnHq6l4UmRXNSMg9dvgX+M3pWlYLr8K16bYHrUxbFXNlOctrUqurE80XJhXECl/YiY8GsDSWVyi3VM+qF6J+Grqw61+YyBd41W560+TDbR4suqg4BORb2HBocE2fHpMkSBAfbBjCFGK+w2kgqvJ5FuSfMyzwsnLEWctCVTARndn1iN9hm80lk5XfPyZM3oAazF+sCRj 3x7dIAHV 0eIC2+j+/94ZXY1eO/HKpowSYyqjKUsM3KsDWYjss4l1XIVN82ojNcIVGBjO5+JW1zJEybAkOu7lNU/B3Y0hR/aEO+ZMfNEhffEAmhAWJsoxYlD+FhRAoBGWsAmksP81029AjWxuF3xJwF/1SmMBJDhpYaKb1xXiN4LGbN30oGjBR42rxlYEjHi4JbXRqNSLszK2I0Ww0JrWCi1mNmqdUGmqvI/VCl1BJYm/J605y/ySyUetD4yWFQD4cNtm3IIeRAJN4w3fYiLvSJt/3fYplOuDBA3KGdYmqtUHZuG4f20/Tbz/oTTHt1vw6sAJiC0h/UBUP X-Bogosity: Ham, tests=bogofilter, spamicity=0.311794, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 22, 2024 at 2:03=E2=80=AFPM Pasha Tatashin wrote: > > On Tue, Oct 22, 2024 at 4:56=E2=80=AFPM Sourav Panda wrote: > > > > alloc_tag_sub() takes bytes as opposed to number of pages as argument. > > > > Currently pgalloc_tag_copy() passes the number of pages. This fix passe= s > > the current unit, which is the number of bytes allocated. > > > > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > > Signed-off-by: Sourav Panda > > Reviewed-by: Pasha Tatashin Oops... Thanks for the fix! Acked-by: Suren Baghdasaryan > > Thanks, > Pasha > > > --- > > include/linux/mm.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index ecf63d2b0582..2890001c8b97 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio = *new, struct folio *old) > > /* Clear the old ref to the original allocation tag. */ > > clear_page_tag_ref(&old->page); > > /* Decrement the counters of the tag on get_new_folio. */ > > - alloc_tag_sub(ref, folio_nr_pages(new)); > > + alloc_tag_sub(ref, folio_size(new)); > > > > __alloc_tag_ref_set(ref, tag); > > > > -- > > 2.47.0.105.g07ac214952-goog > >