From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A05D42B9C for ; Tue, 12 Nov 2024 15:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93EC16B00CA; Tue, 12 Nov 2024 10:38:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EDB76B00CC; Tue, 12 Nov 2024 10:38:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78DB36B00CE; Tue, 12 Nov 2024 10:38:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 59D606B00CA for ; Tue, 12 Nov 2024 10:38:24 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A751C02C7 for ; Tue, 12 Nov 2024 15:38:24 +0000 (UTC) X-FDA: 82777849308.29.082B35D Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 97F17C000D for ; Tue, 12 Nov 2024 15:37:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DCkQRQpL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731425726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/JqgBTdvRwSGK8eOVAs/6HIFEqq9Bti4PaqUniteh9I=; b=zv2TZOL+Wnb7g9ugI0mcfU3z1rXfd9Co2f3TmcaT11AxM0lv4vZWKWMlJ9K75OYwmTjLqb m1txGKTEoFAZRveur4Ut3wg9gxQyLGqFBiY3+m/v23ZjkJJYjFeVAFaOhWxXjkwd8pItYb NkxXy6ZVZ7fjYnxgNY0PxhjM7PgTcf4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DCkQRQpL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731425726; a=rsa-sha256; cv=none; b=m4LzJ5NjYFuYabTUKSulnGnWOMpAH0rkxHtTgCFGZWVmPcqaftg8cb2gfW/0WnDvEnRGG9 xpgr53hR0UQAaiei/73LorSCUcW2SuuGj5lWBJfo7qUzB4roh8/zBxjAbV44mPpCvH8JDX sDJ2lOc55BwEjHcQHGA1k6clzKeuaPY= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-460969c49f2so309861cf.0 for ; Tue, 12 Nov 2024 07:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731425901; x=1732030701; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/JqgBTdvRwSGK8eOVAs/6HIFEqq9Bti4PaqUniteh9I=; b=DCkQRQpLiZqPNlO4ndF1APYGEw8KZkRCvS9SS4OYNqomBOUWmY/ms/rMbrmM8Oq00M 16hpDD9JcW6EUH2UO469UMmHqxt+SjZsAMG3xNAlD5wgRE8tsTqE+soOo1ukhEaq16A3 wXhsxO1KUQooYPXYzPweN0wEz+OE2xS9swiOclbUfNg87IoS5uRhhzNTn+xFO5W4T0qX mr6JyJff8A/Z2pjmmQN9SldctQFcHW33GsPUI6n96uMBdVRh8D4oUHwHynAZzxAtxygV T4UFDaVkx77R16zZ5pzBH5n0wdqN3KGBCJbSDk9GKsh1HpAc3jaDU6YFIwLJAalyTtJz ww9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731425901; x=1732030701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/JqgBTdvRwSGK8eOVAs/6HIFEqq9Bti4PaqUniteh9I=; b=nYesKerHLCc5Z60cyzHVTXc0LM7/0EMYMJWbUiBYqNFpozrgpfi/2lCgauNafFNmyW Fg8g0qlV96eMBQad9WKjiRXJW0Zc/xjxbGWKzaUuLxU7ebMamwiwhrzIKJ1tmd7AdLVR 5TjgcTr/FxNc27e9EDBfl0nIfB6IkqDjM/LHLqwP2iRe/wEIFz5CwCBbVc3Z7A/zqeM7 xpFd5fso5GO1ftuEK7XtaqwnoVwI7QuSSfysiWpXF1Bhre3nau8l6oix1r2t8p3E6ddD gEZmuAMTYnWaxwpvi0w0MWarxUT5dds6a1eIDY1G/rcV8giZ+WBmiJOwoKQBIpaTyjrp GKiw== X-Forwarded-Encrypted: i=1; AJvYcCWix6DJmnWETEybSsbqSMuYP/Cbrhlsfhta4QY/kmbDZLB1peaFEfGEm/lg8HPkG0Y51jmwBRDCew==@kvack.org X-Gm-Message-State: AOJu0Yx76qC8XPr/uAhma/up/chJ0aUhQJxJc5Fq54VXUJ6x+BaunU3+ 2xcvm6W+gu7W6QXzNS+t6wR3Tr/CnIKZGkRuXYB59/1YbdUVciimu7Rmk5jORu9LBGjASqpgOUe UUD3di2/DPdlSYGyOVsCoszAZqid+xKjeKWXm X-Gm-Gg: ASbGncstEVUCt56Daxg1wnXbS22SWaR2rVC7K7f7czmiWkU1r0B7RVfgPlUz42hzulp J1o71Qs4tizhiqwOsDQ/ehqccV0jhWusLuQhISenGP1amSs5d8FyHJLoJMISg3A== X-Google-Smtp-Source: AGHT+IHUzTnNuTgHD++1wwv0TlqxOZDUnSUEsiVLrKzmwtbuaHLsHnNii9tgVcNny3YBSiqEcNw+ojp2iDX2vnVLjr4= X-Received: by 2002:a05:622a:4b0f:b0:460:b4e3:49e with SMTP id d75a77b69052e-4634288b366mr2486921cf.9.1731425900989; Tue, 12 Nov 2024 07:38:20 -0800 (PST) MIME-Version: 1.0 References: <20241111205506.3404479-1-surenb@google.com> <561f69f7-147f-4f34-ac2b-aa1c8c3dae7b@lucifer.local> In-Reply-To: <561f69f7-147f-4f34-ac2b-aa1c8c3dae7b@lucifer.local> From: Suren Baghdasaryan Date: Tue, 12 Nov 2024 07:38:09 -0800 Message-ID: Subject: Re: [PATCH 0/4] move per-vma lock into vm_area_struct To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 97F17C000D X-Stat-Signature: sgat96hys1as9a3tiih3asxpt9uk6t6g X-Rspam-User: X-HE-Tag: 1731425859-851243 X-HE-Meta: U2FsdGVkX1+Y+FCx8b3lVAcXACttB/yIbX+XdLmiNTRdiEZ7b/KXeXNUeik7aUvuE+xRDl/cehfihGCdSjVDHZKM2Gwj0TAc8/ZQ+F8bUDAc6aILZgInSvJ/laPEfkP6MpLH1S7FlivOFsS1QLxNrY69KJVHG4EHqEg8AUfi9RaH9gk/Cg2sHFlA1s9FWciQ1ZAWVltdQS0vmaZuXjNAz44GDDxTQEcPeV3uikgbCjjKvcmSayYBiwmk6WPDD/LcVPGAUxp8MGllzlZQTHzQ/rbh8du2yOiLtSOfUhNkwaLGN0DmnFnNMAU0u9jN44dbpQ7nomk3RCcyA3db6aW41UAsssAUiA02hDMQFUVY8mVknGIq7+cfObN07fqaSRQzK2FzcBO2ys7l1WT74F34fDIib0d2+vxsDhcOiKFMAEisXAJpazI515POGbVrwmqIKhHIfiX6+NZQYfRGkGmreBax6/cKlCZF/3+EYXvPWFCb9A6EueUsq0I8OdSZ5vzlkutDV3NtKgvH7swSGiWYmF04yH8mPiCvp+tGdKp6wEAwcyygRf6LLkQXOKT6/mQwvdt1QkzUrz7BDQIhOhit3qoXnLBbw6T2hVv+Xf3xlWWJV5cw3OpW9fUOvkdXI5Ue2mixr9uDPmYwA0tXI5W4Rz0M5qs/b6FUthLGQn9WZW06tduBqQaZt5Q31wwHURB8kLZyEWxB8ydpVdBmG8ld26xSDGpUbQ2O3b/4czJ/a4JMAThKpIx130NgW2J186VUl0JvnzebyNRiInqqiIr5IED80mB5aKxZE+MSBRYupBQOp+xTZ6Z9FCRdC9qU/dHudcd3yX9cLL6k5zINjKFORsrFpbIL9e3jD/JQ1io3Z8+LFisH4c0oHgsu9yUpr7P2j2mZaTpzL1w/3sOI8kLh/4iBErOpQYxXf0zHe1B/kz8dg4EiFf1ANzH5zxsf0doD6mmybRUTP8TgWicX31z jC0LkB/n Mmlh4nXXaU4qXjDaI0ozdUmIoDq9GhT+eC3Bf3ogJ2ayyAo1bBXoThVZUC6JYlrvLgtVWWvHYCMzICgGie8pEJLADb952B35xIoY3pOV9IhJeuUtRVaoJR+Z3XQ8adlD7t7OCo43F9VnJ8hNdp/ygAhr0luW3Lcor/PuG6f2roYL5j1RdfycNh6F3h86WEmSSXH0UleCAckp4EG7iI0R4ClAjOV6quaW+A2jqRkE0s0tFXf/iqDQgw7G3ZpR4xfBY+ABJr6J85l/DuWY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 12, 2024 at 1:39=E2=80=AFAM Lorenzo Stoakes wrote: > > On Mon, Nov 11, 2024 at 12:55:02PM -0800, Suren Baghdasaryan wrote: > > Back when per-vma locks were introduces, vm_lock was moved out of > > vm_area_struct in [1] because of the performance regression caused by > > false cacheline sharing. Recent investigation [2] revealed that the > > regressions is limited to a rather old Broadwell microarchitecture and > > even there it can be mitigated by disabling adjacent cacheline > > prefetching, see [3]. > > Sorry to nag + add workload, but could you also add changes to the > Documentation/mm/process_addrs.rst file to reflect this as part of the > series? It'd be really cool to have the change as part of your series, so > when it lands we update the documentation with it. > > This change fundamentally changes internals that are documented there so = it > makes sense to :) Yep, I already prepared the documentation patch to be included in v2. Sorry for missing it the first time around and thanks for the reminder. > > Thanks!