From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB08CFC501 for ; Tue, 15 Oct 2024 01:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38E2A6B00AB; Mon, 14 Oct 2024 21:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33D916B00AC; Mon, 14 Oct 2024 21:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 205E56B00AD; Mon, 14 Oct 2024 21:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F19A56B00AB for ; Mon, 14 Oct 2024 21:49:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 682A280703 for ; Tue, 15 Oct 2024 01:48:54 +0000 (UTC) X-FDA: 82674153198.14.3D72044 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf13.hostedemail.com (Postfix) with ESMTP id 9DAD120003 for ; Tue, 15 Oct 2024 01:48:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2sapbYn4; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728956750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cTpr4H8C4FWrqjFNlXZjN+OALNaMX37MopaCmWm2Q8M=; b=Rk6DwjWaxgyDPrT9X1iglOABUMkEehIC2ysjchNw2LWI89ac/w4hLoW5GCxgwOZiG3WLKc 2c/oo1i+0UrHwxHhAwqjuYLN2BzQonHj3X6dtG+9BIwUxOTAsu2W07d+qQ/R3469IiMkFH JQNbd4Q5c3wKfQ5haNM/ieqmW4zl974= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2sapbYn4; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728956750; a=rsa-sha256; cv=none; b=ggfY4EU2vWQqNcH6VGqmd6pABpGR1A7l3k3yjhgnyKomjXGjeaEV94pzSrSqC/aUnaBmvh eDGRuXa+uxIfc8/PkJjOFZhUDG5Qi+vBngj1xfMZx7/3HzNERwr+f9ncr4tusP9+WWqtAV vcdKWRixu83KQi6ZJxXlbpT1j8yNARE= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3a3b28ac9a1so942395ab.1 for ; Mon, 14 Oct 2024 18:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728956938; x=1729561738; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cTpr4H8C4FWrqjFNlXZjN+OALNaMX37MopaCmWm2Q8M=; b=2sapbYn4cm/Gq59ntXyPSBqTkS8bIC13Nfp3SC9dL1kDJto9ZWhLrT+5AEWoXbUlOg nDvkry4+YCP+CfN06Ze9zrAkC4FaNfQtHR3iyGJtv8s3NwaauFp2HdEqj+fLZkoWv0Kj 6lPBYuD8R1I7suCtxbgN5OX1XFFOT3NoO9ZAeaCjBLn41qhBFWa3WMV9fezwrRAIQvWC OAIH6sjlwHy7EMGN4fE1u5ErGVWPK4IaO+5Zm1NTATJz3QNSx8j+CuM/ET1m3ZsyWPxe y6q4OYOKvX1v2sqUZfhG0IWeUeuf3WXC8ncl5fOlvWq+0olrILH9dJJWaPIypfH1TpIn gD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728956938; x=1729561738; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cTpr4H8C4FWrqjFNlXZjN+OALNaMX37MopaCmWm2Q8M=; b=omblqgl5G/UdJbTyRmXVVMM9ehe8ksGn4EPR2GWX8bL9r0VfdCd1IcmxpOJjGbb4WK zwrnfl9Z0lvp/1E0h9hTL1CcI8Lhi/syLPtVndTiU585s/bkyTWdvwnE0GfyWk8NBVkI SH5CjAL3qKdRk0Ft5hdw9ea6hfe5JOtkwf4XrFhfzJIDiwz5pCzVWZ780hBpz3ubYCqv QZdSNdsQ4emdKhdqOqtPXFRmHPIccXm9uZ/VYmFdlrI08K4Uh5rXYiRfU7h9z3cUOuwW xOaNGf0WEMpnotimsvjMgGnWuWh1xVDgvqZgXo4SR3s7j7qUxKxSc7gok42pb+D3wDf+ TqYw== X-Forwarded-Encrypted: i=1; AJvYcCV6BWsMgllj6R7e2xnCtVO5KIr3lpP9NYdSg/SAp5JjI3mJXiukLa4PSDXvNs8TsMDlT7v6FwIK0w==@kvack.org X-Gm-Message-State: AOJu0YyO+G73D7hRo5Xa325/MZEGkqlt6AC9gh5M8XE56U6XDl/Hwzg/ T5Fe7GjWo8KCVkkOnCo2VQI67f+nd9i9HZGMUbnyZmRFN9u7xg0usoEP9mMvT110jWHMFw3SunG euyzJrWDQ2Gj4idE0ZoUcHl4oy60bU9wLNaI7 X-Google-Smtp-Source: AGHT+IGesUbiPOAGaxIbzzDgO9fqyDFQzVpz+70lg/ZZegnkGH6H5WSOBtADDa6r+PO3K17MJxP/ANuwhYpFXw18SQc= X-Received: by 2002:a05:6e02:1446:b0:39e:68d8:2891 with SMTP id e9e14a558f8ab-3a3bd2cb5e5mr13845395ab.6.1728956938353; Mon, 14 Oct 2024 18:48:58 -0700 (PDT) MIME-Version: 1.0 References: <20241014203646.1952505-1-surenb@google.com> <20241014163231.9ef058c82de8a6073b3edfdc@linux-foundation.org> In-Reply-To: <20241014163231.9ef058c82de8a6073b3edfdc@linux-foundation.org> From: Suren Baghdasaryan Date: Mon, 14 Oct 2024 18:48:45 -0700 Message-ID: Subject: Re: [PATCH v3 0/5] page allocation tag compression To: Andrew Morton Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9DAD120003 X-Stat-Signature: ymqef74whzq9cka7ybfofnth8xx8quwt X-Rspam-User: X-HE-Tag: 1728956932-810487 X-HE-Meta: U2FsdGVkX1+9htAKtzXCPD4DYxNgD2Gq0ZF7+l9NufxI3xceL+IhXmACqexdCFRxelNP87I9kzNSxx7Tv9KfSpbBiXtjPvfMGOumPGsI2GWU9FHoukPNbXO3ntwdl55+R6R2Idz5iuANExml1oBRWOWhrV/IPNi+8nOmKGOd6DbukDu3SPu7P0zeDsuiznB+7gpfacXRtp7QixNwmgklS2bE6mVepgBDdBJDkbSDdP4vzbJQpRocFH5UH5QkoAHWGk2LSx2ccFefbeN6FC7kVF4OKypNkeSaDzlZohLSpahB7uSWnX9VnDTh0Z2DskRGF4EzGBmX6+qgpeIjlt9A/t1+kOuKG83+RuIVxcHkEJhywQu0pmmZtGQtjYPQBZbWDIjLSW9xuOt6EthHZlTf/ylyAm4O+PelSMLM6PZ5KtERtoWDQiwoeCRgkjsaVparWwqJdVeFXi6SNiQnax3AWG3wajRLQC7fnzDkSCLm9H38IcwvGkI2G+VgeCDw+DuvIB074XPBjOmlVuryovtZi9pZRdBC9Kth2yOZ9WvEJHXFkHq9jQBYnUwkgwvanf/A8r4qeI6l4if27MiwtjxbBuJBKbleGMPb9FwG8wWWTIKC0kIaehAiN5RWvjNeg7U27f/CZgPB7LAM3Z95btuvFDN/C0AypxaTOUTLK8qEHlQcnfhbij8+6Qs9Y3e3kLXUfieywiQ380a/iVBzr8RSNktgY068H0mjoj2BsBHw6So1DSQf2K2ruoK+BQPdcmpmxlQzJ70pIwxLQYUJ/ZEJmk2mGQO62tCBVXl1EIG0M5iH/qdhw8CFxnT9/F+XJXi81gtiUGq81/7QC4Tl1PXkL/+BrfeG46IXMVr9/QeMmlamuQX5TkqaDr9bUjssI5MO3S48PRML3AfhktPJgJesGTHFQbkQgHk8+7jy2jDNv1pOjvdsUly0j/5lAdeUFAs4UPmm9h6o3WigBo942Fe HNTtUwxl Wjg+vCTYyB2Fb3x3bAcvffnImHUeBbfZuJ90A2lc6964ToxzMIwd+mhP2joyn/MwrHYxBjjMuliweM9bzYQnU0A4YUohIMbXuNnCQzzQjd9AmBpnpwljXX11Nxre/q85PPpK1VY6IUwR+LSlmtNKI8lyg5ouh6oRkSdgPX2jvXvVUl19nByhz9pxQQMAsjVXGbt3TXdXX10YGCcsYpBFXLlxqcaFrU6poriJRvDCjrKcms75KoAH/Y8JgTnoIlJZGHjtI1NqqL2Z7x+cWkzcbu7kBsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 4:32=E2=80=AFPM Andrew Morton wrote: > > On Mon, 14 Oct 2024 13:36:41 -0700 Suren Baghdasaryan = wrote: > > > Patch #2 copies module tags into virtually contiguous memory which > > serves two purposes: > > - Lets us deal with the situation when module is unloaded while there > > are still live allocations from that module. Since we are using a copy > > version of the tags we can safely unload the module. Space and gaps in > > this contiguous memory are managed using a maple tree. > > Does this make "lib: alloc_tag_module_unload must wait for pending > kfree_rcu calls" unneeded? With this change we can unload a module even when tags from that module are still in use. However "lib: alloc_tag_module_unload must wait for pending kfree_rcu calls" would still be useful because it will allow us to release the memory occupied by module's tags and let other modules use that memory. > If so, that patch was cc:stable (justifyably), so what to do about that? Now that I posted this patchset I'll work on backporting "lib: alloc_tag_module_unload must wait for pending kfree_rcu calls" and its prerequisites to 6.10 and 6.11. I'll try to get backports out tomorrow. I don't think we need to backport this patchset to pre-6.12 kernels since this is an improvement and not a bug fix. But if it's needed I can backport it as well. Thanks, Suren.