From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E63C3DA42 for ; Wed, 10 Jul 2024 17:29:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FD586B0095; Wed, 10 Jul 2024 13:29:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ADFA6B0098; Wed, 10 Jul 2024 13:29:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 875CC6B009C; Wed, 10 Jul 2024 13:29:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6786B6B0095 for ; Wed, 10 Jul 2024 13:29:21 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1EA2C140142 for ; Wed, 10 Jul 2024 17:29:21 +0000 (UTC) X-FDA: 82324529322.17.EBBF4B0 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 59BAC10000D for ; Wed, 10 Jul 2024 17:29:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sm9Wyj7c; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720632526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3iXewCGk4UXaW4hocBhxSKfcWdGSVP/acob1v9TkqC8=; b=O4eKKZCyNckuk1hgjO2g3FHm7cOt8nMsytUm1zlOqHsf+kXk7eEGmIUTtnig9V8SKyRwiT GneGUVl0wyoh1my7EzM6CQxbSnZH8j/gQ6oMijQWwPOQaqSQOt7gIb3WD8dUv4CR3pDvx0 Z5nUUD00Y+netUE4LJkrojAKe2F2C5I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720632526; a=rsa-sha256; cv=none; b=ctX8g6Do+kHqI8fOCe83NRFCWMjs6XUxKNOYp++zn7l4AyFtafG2LqLkTgQTP6LVOyg142 W3koYUG/LXfx6atqcV/UcUj13c3F9NHv7pgE3zah7YbWZf71AeDJay4Wj+o9oI8q+3Wi1U sX6YxQWHNgqYUxItZJ0lqOo41hti/P0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sm9Wyj7c; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-654ce021660so46210787b3.1 for ; Wed, 10 Jul 2024 10:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720632557; x=1721237357; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3iXewCGk4UXaW4hocBhxSKfcWdGSVP/acob1v9TkqC8=; b=sm9Wyj7cojf+0KORgjPfh+N5Z0Z+wCjKtldAX3Y1O3ZKoFWMOFRDkKDhJemr6Myw0z anbS8AAg5WZtkljpD+BGWWXKjQ3n7hOH3l3FkU5onbHTNrW3EOqb6bTPFOahRmH+3hP/ tIXimb5FZImaCENt2CbAZqDgcOxmscP539mtkxoDmhWa+QZtXnWlj2ih11GKunqyIiv7 bvuDJJR2WhpBM3p4rdV3r9o4poVeCYG0Xj1gG6kFhXTSg+5N+00YR7Bc/Bxq8+Bj8/ZX ii4zxj9/pA3pUMZp7T+SoR28Vy6J36Vu/Hnd53Shsm63o2j8RArldlbVPDK8lxbScM5G Z9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720632557; x=1721237357; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3iXewCGk4UXaW4hocBhxSKfcWdGSVP/acob1v9TkqC8=; b=Qi3bQZQFpuNFfJ8EGm9grA9rTmLMLqZUFiGbx9TvS1fUeiNG5AWCd6N2vyw11om0+i VbJQwgaepl9isiZOHaYMR8vPOwldsqrNKkqnXxgSd+1dVKx7e34J0jms5+RRw8Vqz34/ nOz7LuPxoUKIwGOjYMx2pWgnpPZZHWoD6rv/mi8+zkr7gAAIUJQSSHjm89WWz4OVA5kc wYWX22v6wqbzSSY3Ydq69dbtxcwNOUfPvnU6kq7UfImqkvwMEOai8Ny5Z2Mc3Aa8oLWi ixojyrBiYeRTCoOj8FQLJFdgrIrg9r6Wu0tyIqyAjr//3iVzG2WRhNdSO671U/ZtLPov fALQ== X-Forwarded-Encrypted: i=1; AJvYcCXE37a2R3JL4gs2xYEuhJ3w9OACuAlaYhYlM8aXTtU+7MMYI7cdLPs06Hs7Us6yvJSLC/BOk2hDMrc11amRtQCoAXU= X-Gm-Message-State: AOJu0YxPV7CzFQ0Cn1fKqwP/1RK2xoxuwJ0KXt2fdDx298sDjFHg7cqw 4zMayOMsDwSsczlLwIzfnTuu6o5beB1lxWrCDPYPcVdhwh+nhO+yHpyZqVpaSpReptpo/Jc+IdS 1X6vna/MSbh+slUg5Fat5CrT7ozJN0W/Rg3Zo X-Google-Smtp-Source: AGHT+IEIDiCBHmmpw23IGTQWJ41MQYqaIhSIDn6iqpEnXhLW5tT7MkOR627Dov6cGq5tnj+GsCRbDY7uModenssyYUw= X-Received: by 2002:a05:690c:630b:b0:64a:3d6c:476d with SMTP id 00721157ae682-658ef24af88mr78735977b3.25.1720632557191; Wed, 10 Jul 2024 10:29:17 -0700 (PDT) MIME-Version: 1.0 References: <20240704182718.2653918-1-Liam.Howlett@oracle.com> <20240704182718.2653918-7-Liam.Howlett@oracle.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 10 Jul 2024 10:29:04 -0700 Message-ID: Subject: Re: [PATCH v3 06/16] mm/mmap: Change munmap to use vma_munmap_struct() for accounting and surrounding vmas To: "Liam R. Howlett" , Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 59BAC10000D X-Stat-Signature: tb36dgu1d5k9ybar3pk5em8r7gbhmoke X-HE-Tag: 1720632558-837514 X-HE-Meta: U2FsdGVkX1/8FTesfPbXuyZrHFRu40E/zChiNcDSD6Xke1+VUiBgKbs+gX0YbXzJXnjnNUBfUAg67iClkPBMCisSRIOOLbXc2tbpCTO0mVa7XQ3dacxaUd9vLAbJmkca/QOqZm9EwZGKuXAip0xzemi2feAYXtGwdbVmGBw8aEQDe9v/TKfpr2AkriXX87ZkKpyjr5UshLQDyJ77eOjJUKzNlndDCGT4FrHr3xVKaJREy8JMOwS8QAmTHZbORGuy5G+x39fzIFiz+4xB6HYeAW4FZFRhHrhq8lywQcnrT1G3Y4a1gV2bg9lCPJNgWiAzmt9vGAYJ6ST4nY1tnh+h91k+PFU0pZXfnmoMIrYYn++0iBCoXWorD5IdUfEwupXlBHMaMg07mBBHdHwjuuiB14Lu8luoYM6sSSJ1jbciexOYOEWAMuQy5zEoGLGzzNmZQllBT5emYK3vA+L/k6LdFiaIPrydYxS/bTYgYAnCfW3a7zJsGGtVhL61AbZ6jXE5mGs8QvgjGmXMFlftgQ9nznet0KQBUmxsUmOXb7iKhp8qzu32LjkW3h3f8EDFRUyH4khwVAggiLw2rz44/79T83rEx+QLVTl4QOU1BeJIxqRlKmxNA+HKO6gH7SYVAnoSG21/WAG++J99vTVVR7Dsa0kExNzHSmMIITh9RBan6Iy24MDdsm9hak6wddhN8GWW6YnBPFxVA1SW4AM7Hpl8Y6Z/6UPE6XEksRFJienQqOcv0YFctsNUJx+ElgSwvuvZw7Syg2B6oYdfu5vdyamUH40RvwNISmFUDYid5g/kzet5MkkHhBo7+soHATLPN6cnYBJw5D/QpnjMaEfbQyuub0pDrV0kYqD9PvkkWM6r1NFybuxYRZEDXY/kXn28Gpud7j4vkAL9tF0U7Xq/jKQM8ONvUeoHiDyGafh6/SWZ9FO36qvJ4xFI9rQ2hBBJ3AzOJMN8PI6X8jE1Jf9rR2Q EKqvyn4T e/MWi8IcmE7abeAQL7BTvmC/GbGa9RQ6wIyox6YQKL4R2xpDWVwtPylmEkMpru2REI0lSXhkLkYjRzy1qAb+KylDfwsQ/PXFAcs0xOS6Jf7nUnwVO/KSKtqjjZmi6XwVg7eR4gErb1/C+NpUiTBjPX8fLYeX++Ja+T5IDeYKhbi8wLBIkKReCTI2nz9E2Hk3Up5WJtDJBZ5aM1yrxl5BQWORicv7RFjjWMNQ+R9zQfiYbH1mLUQ93f2F7W0E0n6f6kMvc7QFSVKzetds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 10, 2024 at 9:07=E2=80=AFAM Suren Baghdasaryan wrote: > > On Fri, Jul 5, 2024 at 12:59=E2=80=AFPM Liam R. Howlett wrote: > > > > * Lorenzo Stoakes [240705 15:27]: > > > On Thu, Jul 04, 2024 at 02:27:08PM GMT, Liam R. Howlett wrote: > > > > Clean up the code by changing the munmap operation to use a structu= re > > > > for the accounting and munmap variables. > > > > > > > > Since remove_mt() is only called in one location and the contents w= ill > > > > be reduce to almost nothing. The remains of the function can be ad= ded nit: s/reduce/reduced > > > > to vms_complete_munmap_vmas(). > > > > > > > > Signed-off-by: Liam R. Howlett > > > > --- > > > > mm/internal.h | 6 ++++ > > > > mm/mmap.c | 81 ++++++++++++++++++++++++++---------------------= ---- > > > > 2 files changed, 47 insertions(+), 40 deletions(-) > > > > > > > > diff --git a/mm/internal.h b/mm/internal.h > > > > index f1e6dea2efcf..8cbbbe7d40f3 100644 > > > > --- a/mm/internal.h > > > > +++ b/mm/internal.h > > > > @@ -1488,12 +1488,18 @@ struct vma_munmap_struct { > > > > struct vma_iterator *vmi; > > > > struct mm_struct *mm; > > > > struct vm_area_struct *vma; /* The first vma to munmap */ > > > > + struct vm_area_struct *next; /* vma after the munmap area */ > > > > + struct vm_area_struct *prev; /* vma before the munmap area *= / > > > > > > I mean this is about as pedantic as it gets, and, admittedly an annoy= ing > > > comment to make, but the ordering... can't we at least put prev befor= e > > > next? ;) > > > > I can do that, no problem. > > ... > > > > > > > > This is a big improvement overall, very fiddly code. > > > > > > Reviewed-by: Lorenzo Stoakes > > Reviewed-by: Suren Baghdasaryan > > > > > Thanks!