From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609E7C3ABBC for ; Fri, 9 May 2025 16:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5C106B00A9; Fri, 9 May 2025 12:12:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE1DC6B00AB; Fri, 9 May 2025 12:12:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81AA6B00AC; Fri, 9 May 2025 12:12:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 869336B00A9 for ; Fri, 9 May 2025 12:12:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDD6C578A6 for ; Fri, 9 May 2025 16:12:13 +0000 (UTC) X-FDA: 83423861346.02.DB092DE Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf07.hostedemail.com (Postfix) with ESMTP id 1AA0540010 for ; Fri, 9 May 2025 16:12:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tegNM6Jh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746807132; a=rsa-sha256; cv=none; b=l5cqxB/XwVwghA7Gxo5IotbY4nuj3thYNtxCZKrAVl658I0Kmqfj4IW3zTXnUIfs7vh/Bk 1IdeHAV5WsBRaE9fVhwR3cG+8w1jti6G1huyoh6oe5YUHfiiTdQlAHebLKhSotY7gRPttA nrLgLrf4PbbqMyZ+q/S0aJ7BBDGcsdU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746807132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJ0e2Dp+V4tD/ke6DdCR2L2h6MLLeZoz4bYh7A08nR8=; b=PfdgLHus+dEhCfRprrabJpVzxshJHDSd4wK4S7XqDF7GkWBweCFujmwPs6fSayr0+iEGVo BnLmfvnaQJkSdVLz2faryqvhwM+iLiLMR79QwRHZarWu8cMaEnF9LaMcks1AqVFTTxFK/C vwW/qEYgbXxNSB3D0UyhSyPmklVEKUQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tegNM6Jh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-47e9fea29easo358881cf.1 for ; Fri, 09 May 2025 09:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746807131; x=1747411931; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HJ0e2Dp+V4tD/ke6DdCR2L2h6MLLeZoz4bYh7A08nR8=; b=tegNM6JhBaDjBvuPybMVvRs0H7KWE20j/EreaXXwS7ZMgEPYD0epBqfiNNPSjXZDLt rv5cNLbXkxaXqFFAAJY2wzh3jr4Kfe872nkgKEQlDPhpmjCe9K9VPQIN2TBezqqPPh2b oL0//2ej02dPDET47xupQAPDpMGi93+5fi7W2UUF0Sxzvkmg4+e6Se3lLUsoM3RWfBJ2 JTz/UHG8w5DqobIrwrSi/Ldljd9azomFpdSoWvmRG0ajPYBvN+1XavKuhcYfqrmUkXVj YtKeVAtdDuxZ80DRf/YlRyDhby+7Y69DmAeC0mGKUG/CX0KG8Rn/2pAEFZ9W4eTHM/HL omiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746807131; x=1747411931; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HJ0e2Dp+V4tD/ke6DdCR2L2h6MLLeZoz4bYh7A08nR8=; b=TST90O3i7YhbgNbvuT75HG7K6IFprMg1ojFbdsJghopF+eTBx42X+nCEVD+pRHaQVx geP82jrCfZCJXdmCPUEzha9PskTglT5UyWT6W+vraUU8mfJQqKmBD8d7ffG2mslExOi0 HKKdxGH/mxIHUARISbC/pkAXLGHkl/kBglq+G+OAtMYmp0mwU2XSiZIILUQmD/RlkDXD 4vhL81eLtBsHoujAVDPg5pc5bWk5aMSvGUt/X7tJKj2LgKxNfsahJy0HbJTZeqIJh48F w3GAyHH27kmWsT0V8fpd6rtaEwzT3JGFxbaMo/HSF3cOFsR0QCdM0bvD1MkKtHwC4Mx9 Lw9w== X-Gm-Message-State: AOJu0YzSYwmv3omA6E0HzZrJNHaLqsmj4kZpPxMvunk0dK4w75cLxVAh 7/MzDLIr/JxJW34pg5aa49QfmsvCfxRXtbCbbBvA9O7cdhe1UbUixnjphLkDh15/LJI9hZywxjA or45K/qhLXscHWc0XenpNbYvMAUA0rworqjXz X-Gm-Gg: ASbGnctuv27qwkjx0XW+5mBXd7ov1FqxGy0UNiaLe2BlsrQgxG7vukkz+pUMimTBTAx qazjlnr7WQD7K/UvVG0OqNoSpmYQNZOpL2ZVWP1Jm6+hWu981GM6UX+iW0qKsppsTp81MsMh1bw 7/hgGETZYN0ojI6edDnnit X-Google-Smtp-Source: AGHT+IGj+nO6HWXoAl1fk8tSci2T0jd9LIYOGUek55sj+b1gNbZ8zZtW068pzz6/EJUAx9HCzTkK0ZYsXWMjMgO/Ndw= X-Received: by 2002:a05:622a:1ba1:b0:47d:c9f0:da47 with SMTP id d75a77b69052e-49453cc0928mr3860061cf.19.1746807130770; Fri, 09 May 2025 09:12:10 -0700 (PDT) MIME-Version: 1.0 References: <20250508234742.93114-1-cachen@purestorage.com> In-Reply-To: <20250508234742.93114-1-cachen@purestorage.com> From: Suren Baghdasaryan Date: Fri, 9 May 2025 09:11:59 -0700 X-Gm-Features: AX0GCFuo9GCs6aEIJ2jRW7Bye-SIRwApUh9jLSbPBxcguJYGEAzIZkzPGlMcVSo Message-ID: Subject: Re: [PATCH v2] alloc_tag: check mem_profiling_support in alloc_tag_init To: Casey Chen Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1AA0540010 X-Stat-Signature: ztee7wafors36khjxuz6k9ydij49q4de X-Rspam-User: X-HE-Tag: 1746807131-460695 X-HE-Meta: U2FsdGVkX1+9ZKwCfBwbo3yLt2/WuyBiwRL3WhnXBcgfbWKmBys3gc04Y6QXOdsKNOrJaMnYC6sKLAsDal6UY5kkyRj9E4eK3gSceIjDAuVzTo0ZETwcade2OyIX8g9xQvsoaTPmHp5//iyxs0QDeua5V/hG9bNVHbO96QYDW56Ab3UKZp42o/uI+yhcTy9jPIKGPXBz55eBn+XwhC2Q+97NmCg+LaJou9/G0eXzFLSmwF6oDBoB2Mo10i1b4s7GoOq5042qNUIPQy/U2RkVghqiY9nfkTSrtRTmAN8+cHWmhSbnh5IoyN+xpkdDSowdI+4t3S5afI+UryQ9XRNJqdvIBI4/Z30yOZz/SML4cJ3/tCGRr9zflBjjb7F7CQ/jhi8CGv0i99C74BH9XzB6G/SQCApURMp3BLbta01NGGV/Pv9U2XhgsjSgw31I5zQ/T+Gn3TecxLn62bxlkKrUjCtGSHkZrhWUyFJKpDN05j1cUio4zNvhXXnc2yT4l6VGXpiQT6xhxiIbB8ZiY7n9c/9/bPof7Ws9GgHBLjJyd1gwdXn9YzsMRqlIk+PtWztm9jLvf6DKVXAhklgBHLDTBrTa/JJqxiD31rhcKsxwWKkVtTujDPVY/wf9RaxO0A/wQm3wko9HK2OFrrlwRQBgq2y3ADZo9pq1Gr2zHMY4SdY7jsttVyWXSmtrWHKKkfTJk+rsymmQFzeP8Nu9AMTkB3x8X2lNLsN8fnYdUA2ZuxubGYj9/7vQBu62CVSZHe1iY6iSFSerLdwY2EssByDBCAkrOxOz9bN5MJWmR9Bqg70vGE423m7RDP0KtpHcPK5YK3FlGtBC54IkV1671Zbc3Phf441F6xk+arQVlEW1frvbD8lJlxCVbsKuP+uNYPb7hO+bRLTFY11f3In7px+N5dw7rEEDXcDT+Q+eSWsMsMbouEtmnA3uMVBhe09MRs9rv0rnmkAwF97nthygkq+ LYkD2E5c F5Buhlll9Z2YSfSnEM3dIUeP8RatR9F5ZS78f5DgIKQOLJcqHzSQTkFur39TrZAuYoCD5pY5RI43rsQT/Co7G5jKuOuCQkqZKjNuAHDgH3XgRTJFDzLfbwtYbBFZXW2NVDzVNzfZ4XizsUXCyz0Boo2JGxN5smZQHhxGtw/xKFj45RIcIpPAag2SX7yV6KpkTWcRy4irn96YeKeHbqPGSvfmdmWtz8wxS1Azs2UIXUndKQ8ObfCP+0gYjHnnSp0go1nBfs0ZDETy6gefoCbqXNNuVwIMtoLXx9zWoUOCUK9wuJmyHhbK7ObNQbqxd2ufegidBbdoJWGUSzuI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 8, 2025 at 4:47=E2=80=AFPM Casey Chen = wrote: > > Allocate module tags and register codetag type only when > mem_profiling_support is true. If it is set as false, > for example by sysctl.vm.mem_profiling=3Dnever, skip them. > > Signed-off-by: Casey Chen > Reviewed-by: Yuanyuan Zhong Thanks! Looks good to me but let me take a closer look over the weekend to make sure we do not break anything by skipping this allocation. > --- > lib/alloc_tag.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 25ecc1334b67..fbf128072c7e 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -762,14 +762,16 @@ static int __init alloc_tag_init(void) > }; > int res; > > - res =3D alloc_mod_tags_mem(); > - if (res) > - return res; > - > - alloc_tag_cttype =3D codetag_register_type(&desc); > - if (IS_ERR(alloc_tag_cttype)) { > - free_mod_tags_mem(); > - return PTR_ERR(alloc_tag_cttype); > + if (mem_profiling_support) { > + res =3D alloc_mod_tags_mem(); > + if (res) > + return res; > + > + alloc_tag_cttype =3D codetag_register_type(&desc); > + if (IS_ERR(alloc_tag_cttype)) { > + free_mod_tags_mem(); > + return PTR_ERR(alloc_tag_cttype); > + } > } > > sysctl_init(); > -- > 2.49.0 >