Re: [PATCH v2] alloc_tag: check mem_profiling_support in alloc_tag_init

[Suren Baghdasaryan <surenb@google.com>]

On Thu, May 8, 2025 at 4:47 PM Casey Chen <cachen@purestorage.com> wrote:
>
> Allocate module tags and register codetag type only when
> mem_profiling_support is true. If it is set as false,
> for example by sysctl.vm.mem_profiling=never, skip them.
>
> Signed-off-by: Casey Chen <cachen@purestorage.com>
> Reviewed-by: Yuanyuan Zhong <yzhong@purestorage.com>

Thanks! Looks good to me but let me take a closer look over the
weekend to make sure we do not break anything by skipping this
allocation.

> ---
>  lib/alloc_tag.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> index 25ecc1334b67..fbf128072c7e 100644
> --- a/lib/alloc_tag.c
> +++ b/lib/alloc_tag.c
> @@ -762,14 +762,16 @@ static int __init alloc_tag_init(void)
>         };
>         int res;
>
> -       res = alloc_mod_tags_mem();
> -       if (res)
> -               return res;
> -
> -       alloc_tag_cttype = codetag_register_type(&desc);
> -       if (IS_ERR(alloc_tag_cttype)) {
> -               free_mod_tags_mem();
> -               return PTR_ERR(alloc_tag_cttype);
> +       if (mem_profiling_support) {
> +               res = alloc_mod_tags_mem();
> +               if (res)
> +                       return res;
> +
> +               alloc_tag_cttype = codetag_register_type(&desc);
> +               if (IS_ERR(alloc_tag_cttype)) {
> +                       free_mod_tags_mem();
> +                       return PTR_ERR(alloc_tag_cttype);
> +               }
>         }
>
>         sysctl_init();
> --
> 2.49.0
>