From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5C8C38142 for ; Tue, 31 Jan 2023 21:08:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3D56B0071; Tue, 31 Jan 2023 16:08:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 564526B0072; Tue, 31 Jan 2023 16:08:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4058B6B0074; Tue, 31 Jan 2023 16:08:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 335A16B0071 for ; Tue, 31 Jan 2023 16:08:34 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 11461AB05F for ; Tue, 31 Jan 2023 21:08:34 +0000 (UTC) X-FDA: 80416332948.15.5E7523C Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf20.hostedemail.com (Postfix) with ESMTP id 30CEB1C0022 for ; Tue, 31 Jan 2023 21:08:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="U/HrMYPE"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675199312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bDq7d/n4hRdxw/uuHY1zsy7WUcXmIawJLMPKVEj5Oqk=; b=4HRjCLd+ybUmSDGv1++ZtwAHvtbHBc5jhiSCeWEmCv81wF202Qz1ZRWRziIF0G8ok/euS0 1REVuPBb9jXjupvN5vwBLgXFwd1HcqJCR9h1ihkeT1PN/ZpfdIyO7J8J0UGKsFQaNps0wh 7fzie+4BmZ69TzJTglQJYRSMQH1g9pU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="U/HrMYPE"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675199312; a=rsa-sha256; cv=none; b=EsKjvVk276SHcXk6CYNkgssai6awItylWmCgg37YxIgyo1HRuyOahnUjSFfzXh3NOjGFTo 1/Le2RbSiXVYIWeo7EnWrRks7p8W4h8Xp2Z4cMpARcl/XtESjgqCFCip0T5Uy2Mht5XndJ Z7ue+HCnXGMOz9gDDmnACknm1CTcHMw= Received: by mail-yb1-f177.google.com with SMTP id h5so19800164ybj.8 for ; Tue, 31 Jan 2023 13:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bDq7d/n4hRdxw/uuHY1zsy7WUcXmIawJLMPKVEj5Oqk=; b=U/HrMYPECFRkq9PkPWwApR3OeNslyly/bOGovMVkhgn5x/4H3rBa+5Q1e8lajkmDFg hdXiowPRj5EJYmQVq9v0e3GI9JRDz5DDKyxwYMJnQQUDMLSyXobCMDk8u5db/owOJJ5L GAAyUx478W7Dj8GmbfulidXOwwUIp82QUFfTe8W4/EE7jRoOVHESeFqMZbWCROEzxlFp XbZxSml7D6XvIfI3uiwDZBOWarlwFsYgBHo7/hJ9rwt2ieOpQlFlDGL8xtXyb8xPzMAL BNBZNshG24V4cs4Sz8MVzFEx3BFPEwCUj7E3bhs6Ek5WwtzRyXCLhX5E2tjmXkI8dGzU Dzbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bDq7d/n4hRdxw/uuHY1zsy7WUcXmIawJLMPKVEj5Oqk=; b=NL9XpEnZkaSYORH3NdVpyyXM6Qsm7E8v7Tf7oOOzoc2M39q/XuYT7c8afT2f1ugT3O 8+F9U6Ess8rb7jpDQMHfrSC/5GCB5SjTBATsQ6kp/gujOYc3TaKSJOxp+bRrMV6tSc8r yqZmCp4hjxtZFfkyOl3izO+Iu36jFT4jAyfGNj0l+70dtY1mugjldOsepfhXwSyx80n3 jaole9zJQcxMpAhQiSrkV5dX9pnhyFXRXStbGHeJboA4xeQcfM/6800lueAUFkna6bvx OX16Yp4rE432H8ukFoD0I4/EvQIvQKeW6NEWBjOHEPgsqXYtpEkE1xMr6NDRIUJvxN25 NYkw== X-Gm-Message-State: AO0yUKVhRp8i3LHdrcbCjkoUlBT/oJEvUQou1C0qoU1ig1n7WdjKMzNZ ytZgKjGiMpdAaCm9+c9gSLUa9ppqP2AzSUgqMskeVw== X-Google-Smtp-Source: AK7set8TN+vhTCk6n+wEoQB3UO9IaaO8ylUfxNJA77IxdpDEU7vhpknIio3f4DVrz3qNcZAJLnR7+kYgR98f6snoq4A= X-Received: by 2002:a25:a088:0:b0:80b:6fd3:84d3 with SMTP id y8-20020a25a088000000b0080b6fd384d3mr46494ybh.316.1675199311005; Tue, 31 Jan 2023 13:08:31 -0800 (PST) MIME-Version: 1.0 References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> In-Reply-To: <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> From: Suren Baghdasaryan Date: Tue, 31 Jan 2023 13:08:19 -0800 Message-ID: Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls To: Andrew Morton Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 30CEB1C0022 X-Stat-Signature: n8jq16t177z3py8auc53ebytwfr6i1p4 X-HE-Tag: 1675199311-327249 X-HE-Meta: U2FsdGVkX1/DiXUpsPFY0Le2RikY4Lo0zq3Q6EK4fdq/Eh8VIrxSQYudQVvNZz1WJbZrUGMDrwBmJoAHJJ7Zq2J/DNHp6KZcY5NZHXILLFRYLhm6lSKOzU1dVjwDODtagZBJoiGy1TS0dk1hSeS3hEjJpKxHDWQ2lQvR5wtn4JLyQPK+GRBfmFSRzGg0i/Y5SUEhp16F3RPtvM8bBWrX/AotrsqbE62Wh0IqOpTATv9TyR4iBTopdmGzP9+fQbDFo5khkHc2/cgdXJTiE91eo6bKR19OwXkTp3vZFagVIMy8hOAyhtfhg/4T3NLV+PGTpgmaHd+tTsl7H8Z2rPqzMp+q1Y6ISS4kqLH4fTIG00+PHYheVM0lZwqNmujkFVdLanJJlLG7kO4kKyZqmU2V5h0Jd+tllwPaRaZlktMY7V+NncoCMgslGMm087vEG0jRTWNZfm6sGIRPeirXaUjuLTI/5es31lBVbzMpanCmxAGRYOZh/g+IgXycRem13VeiJfjw67eebzZNhvBcvtuSCd8xNyND4F9cP35g2st8zZ/5IhSes2Ev99Cfm7FNRt65iBxzhHaa3GVCzstWT88N8YXBwfZZCUwFPLO1FL2Cv5FAP4pnp7RkWEaWRlXvOF4DvQdzOLR4/vK+NPk351irmvZvoREbwPiKJmZDOKMsXnZwOR6ipI+YuBlWswS9r7kvSUVOtkNEDfRz9YG7wPlLMczM61HoUMc89aur1TXvjMQW0aCsTHw3TbTsUPisM8OtFj83MuUe1WrONIzcCbRI07OUQrw0r8qYJm/D4IlJw75XR6vdyZKsPyQM5WTsLewPWJJVMv/MjT6I92KsxhqPB/tJCTMmD9xo/ziJgMvKJGEmBCPQi7Ie805JT1e/+wXJg9J1ReM++f9caBHECeEXs6oOYf/RWteATeWkNoN3Xk54l1pI1dUwDgva/CTVzufGC93u3eLARdsq03dx8gc dBQt8zYT dUGPHxH+eInty5UTOlgw74QZrdpZdGACZLDFXEyoLdsLEXe2OjbI8+HlW7Zd3/kfgeKe7GfB/Vftz+dffUq2WT/Ivu64xM5i9U+h7eUHQdjugGjZZ06Vgsp1N8zNCF0oajH7LLrhA4Cy/phJ1V0WlwiDW3l5AqOGtS9Paq10l/lLAJv4AV/BWioK+1kZ6hS1oOs56ecexmbbF6Jn7scyjWecIkzvXlNWw3faWi6vZcIdNlBsbtdI1JCLTqdJF5iVCbLKlrfvubNqlnnWJ1+fXgqdV2LCFFEKinWNbp4CSc0hohgk2RO5Rp2aFOHb9GhGkHC7MwEtYEcqY1f7sxCGS+tzkcDHIQGIUvoK6lt26dD+OQTX0o7FFrvNsTdrubZsXXLtI/XUAE0m4gi0umLxcqo/viFjhXXd9Eh3aCPvHFBNGUw4raXI840CKboZz47S+anvWRTzMjNvBnxUjEUyfewktIqCT6F8FBx128wUHSnCVpy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton wrote: > > On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan wrote: > > > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > > } > > > > > > I think it should be: > > > s/VM_MAYSHARE/VM_MAYWRITE/ > > > > I added the fixup. Much better than resending a seven patch series for a > single line change. Unless you have substantial other changes pending. Thanks! That sounds reasonable. I'll also need to introduce vm_flags_reset_once() to use in replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send a separate short patch for that? > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >