From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42045C021B2 for ; Thu, 20 Feb 2025 23:48:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925B16B00C5; Thu, 20 Feb 2025 18:48:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D50B6B00C6; Thu, 20 Feb 2025 18:48:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77625280001; Thu, 20 Feb 2025 18:48:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D8606B00C5 for ; Thu, 20 Feb 2025 18:48:04 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CD1D9123049 for ; Thu, 20 Feb 2025 23:48:03 +0000 (UTC) X-FDA: 83141963646.12.6907DB3 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf27.hostedemail.com (Postfix) with ESMTP id E947C40008 for ; Thu, 20 Feb 2025 23:48:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bNHlcWPq; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740095282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJ52xrYw0e2LR3Y/QHWFxevJeskk1MyNuCPxtVHZCh4=; b=rMOeatv7gLqHOlofLwPiuXvsAS0GWyaftKs+eneaOg2LjrhOc62/U55Kmn+8Ff8YCjIF1E fyPcmzWK/QLSw/Qxa4dAxZv72A7yLW9KbGiZQ5V5VYlvtmXdJA9syl1oo8A+rF/gMDcEdB 3/UinVaoSeqJ9i3mCgmXs29OH3YgenE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bNHlcWPq; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740095282; a=rsa-sha256; cv=none; b=sTmOmb7X1euVbplh0HpABwjLA3iS8aGV3YvVTUq1P+O/jITIXacg5A9n1MtR0CInosJTnc RuTxj6F5qFBnroIZfgwH6GDMdnwBWa83sT9YGFDGvmmjFD+4kAdVilz4ePotdYnGXO7unH CUDHMVMQ1cMN0jAXDWBibLPI2+947DY= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-471fbfe8b89so149191cf.0 for ; Thu, 20 Feb 2025 15:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740095281; x=1740700081; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EJ52xrYw0e2LR3Y/QHWFxevJeskk1MyNuCPxtVHZCh4=; b=bNHlcWPqClHe9UzpcNkVHqG0m8gJpt8RuUE/hDLwzfCRwApF6lnHk9hpGb619UEFK/ HAEDaOqdwWF2t5YLLuzqv78sJOY0vvAfKMW0/nl8Aa7hzTvmfyCt0EPZzJJH2muVtkbq ZEh1DjUp72l4CdvElB4XkHLa7ogyTJqvWYfanUtKlIQJm60BUjGUYwt6+vWnCOYzK5FG J0Su6YGJ8qNp1UMiwVthcTtlIsgm4VjgRMuGtpaY2jGuqFL+0cfaZmpXcpwJvbtGs4lv uT1ayvE5tuTABluqsfwvHVyvir6vVw4JkHzbkTYtsAwwPd/RgY098mEKpGG28k98vcpG ntGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740095281; x=1740700081; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EJ52xrYw0e2LR3Y/QHWFxevJeskk1MyNuCPxtVHZCh4=; b=BhFY2dngxeNYrsJ2t3pcrJiWRWtICNbTX5//w2qRNWN7923hXjNnYOPUUXev97hcU+ idLvpr/U6Hvf/f1j/Qh03a0AxPAwTMBuviE21akPMhK7Y4QEvDEecOB9tVWjJoyeJUVI LGWQ3rl7wHOqY4zPG2irs/FELHDSL4qlzeJHxjrHXjoCBHJydjHeZqOKJQFlbQkXe7U9 9bbCjhzlTe9MqhWsaCNZxpGvtg1R93eaCcEvCkWasLBYfM1xocUrvJ46BootEzz3Hrfs 3g5l4EG73jUIvxjnhDFmCFNw0KjNxZoDPaUR1hXwmJupOYAHpBQtfBcRSv8xPR+badBd DO9w== X-Forwarded-Encrypted: i=1; AJvYcCWpF7SZbLNwvZ6+zNRkcTjP0R8io5IStkBrDwny3oucIu8dcXP+rEH7tcjV1+iBeMXVXCMCSq1pPw==@kvack.org X-Gm-Message-State: AOJu0Yy33aUXOoHaS962OHw09LXURNaqyTREv9I2qDAGIvARuy50QSz0 wA4/DYnIWG7ZWytZkPYY3TsEE+zmf8c1qxJKL42cHig+Oi17sgH9BgyS8h3zaDxwudGKv8MtdXV q2GyqOMMBfD5HWhaBZkYXlB571LxbhphSwOWi X-Gm-Gg: ASbGncsuerMQJNQadTUNmw5ZCQ9t15qc5SZuoA3faRhBVQC+e1AUv1viWZI55e03jgH hDmhV0Q381/GJeY1gqnQiF9JP22wRUrJFL8inShizv9wVZL0orrkU1HcMlJ7ASlWKklc0NTwP X-Google-Smtp-Source: AGHT+IFmaSpRnsGM8+AZlAkhk06W4xzijmbpvaJ2/bkXBeKOOwp6bLz1k6/q4DrPQgjQhBXNVyucstHrMrc9SLe2rJY= X-Received: by 2002:a05:622a:5c6:b0:463:95e2:71f8 with SMTP id d75a77b69052e-472250eb34fmr460861cf.15.1740095280733; Thu, 20 Feb 2025 15:48:00 -0800 (PST) MIME-Version: 1.0 References: <20250219112519.92853-1-21cnbao@gmail.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 20 Feb 2025 15:47:49 -0800 X-Gm-Features: AWEUYZnLgJ9XkVKVqKz-VeVmRJp0uuiWIqQqgb2zjtH-XaVBBUqmnjdUOgpxS-k Message-ID: Subject: Re: [PATCH RFC] mm: Fix kernel BUG when userfaultfd_move encounters swapcache To: Peter Xu Cc: Barry Song <21cnbao@gmail.com>, Lokesh Gidra , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, zhengtangquan@oppo.com, Barry Song , Andrea Arcangeli , Al Viro , Axel Rasmussen , Brian Geffon , Christian Brauner , David Hildenbrand , Hugh Dickins , Jann Horn , Kalesh Singh , "Liam R . Howlett" , Matthew Wilcox , Michal Hocko , Mike Rapoport , Nicolas Geoffray , Ryan Roberts , Shuah Khan , ZhangPeng , Yu Zhao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E947C40008 X-Stat-Signature: kex8pxrtcwp9hz5gbtibyags13kro1ec X-HE-Tag: 1740095281-871264 X-HE-Meta: U2FsdGVkX1+kujWp+wDmb52kXd+Fp3gX7lSLE8ajQl1RsWVoBZbQXQSf7l1JfXutN+eXu7rTebUdOqZMinGK1ftkFwCep3wVAuNKtNT+/GmFwHeEPVx95jIMhrW6HBhwCb6tRdLzYVsVfPlTjMm6Q3zTn2fo73ddcTJJkncgN7lntuuo1ZL1ikLW2whGy8Z+dGMchi08S27vyPAAZ6e7G8VR/A0txY2gbLwgOvPmul/fUgjifmnvYEz+SojCnjJaWEiGmg3BHxzBEGiAxwB64Rc6vZ6eiOPHDs5WeqV1FMvhaxlGTS5+jxnlb07/ratuG5ivI+68+ijyfvF9nntMPQ4IvSNP/qvEHnafbi3303n3iJ89okKFG8uJJmHtmylFP8VFG8HfUXQIrKHrLX7jRCZ1Q7bUF6V0oPiXDb+/dGT0/Uk5rfJKvFzjHFk9TLQyyFeFW7bwAZCCgGBD4DyS+rB9/e5WkkUJeT4iUVFuhAeNU4rtZiPe/WWYBpmzFN02rf1jEDRhGh3AJm2UVIVr5efkj1J2XwHGpLL/bVFhYIuat8a4hp+HT8bTk/1Wtn/ddeVRQ31bYjMzAFQuzGGCpaBqaMbA1GnzRxcxhs/ERRfM96hS06efA9AfF2BR4gpU6zvLUtpj1Abk/A95CNvs/cvXASy1DXWRF5L44AnCfJLV/oWXzXQONlAxrLNLhaoB3RNrlZjDWAVcAbvp3VaIWS6roBs8yPFJhhJ0L9eG/e3z9s4YRqp0o91fMtMBWv5hmK4GQUH9M+bUpCyUS59XqOyw3iBxeRfFJQEgvIhExdQJyiytyADV8w3fRZhJDpsORMeSfyC4Te2t3/AAEEOOUdzhi+Fvpnwx8Is66+tYL2+vEIA49QZve3io+MNp0hfaUDyIGU3t0Ls754qoPgmm1UBEhKZbeP+1eoXafIi2UM3ZU/8YQ6/OVHOm1a0+B4UKOKMPf7FUZY7QfCnfugr zf9ryd/+ 0mqMiSGiKY+3fDpHSIIYV1I2v4DWI9fXaOZ1myIRYfSnP7i8xtbuGFgLvCGRypBABTSjnIXKfRaba6ZM0w5H+ka9hVOCFWJPz5voD+e7+74f4CO/ZuWgzjA63FAp0+pcepugYQ1H9Mupns3qHTibpKr6+bGNWiRNiN6LBIho1ODPFnosaICpWYClOdTRJuSnZ/SixUnM+cRllovzX4MsKh05zPJ2BxShBkM0YidP/NOnGJ8BK46dgF7dgEISKP/alpqMuzG3QxZJ+3iAs1J3GMvViGuGOeMakTdJpwDmq0y4A02VUN33cl4+uLbQ7ikUeEJ5jfwprrOgM8z8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 2:59=E2=80=AFPM Peter Xu wrote: > > On Thu, Feb 20, 2025 at 12:04:40PM +1300, Barry Song wrote: > > On Thu, Feb 20, 2025 at 11:15=E2=80=AFAM Peter Xu w= rote: > > > > > > On Thu, Feb 20, 2025 at 09:37:50AM +1300, Barry Song wrote: > > > > On Thu, Feb 20, 2025 at 7:27=E2=80=AFAM Suren Baghdasaryan wrote: > > > > > > > > > > On Wed, Feb 19, 2025 at 3:25=E2=80=AFAM Barry Song <21cnbao@gmail= .com> wrote: > > > > > > > > > > > > From: Barry Song > > > > > > > > > > > > userfaultfd_move() checks whether the PTE entry is present or a > > > > > > swap entry. > > > > > > > > > > > > - If the PTE entry is present, move_present_pte() handles folio > > > > > > migration by setting: > > > > > > > > > > > > src_folio->index =3D linear_page_index(dst_vma, dst_addr); > > > > > > > > > > > > - If the PTE entry is a swap entry, move_swap_pte() simply copi= es > > > > > > the PTE to the new dst_addr. > > > > > > > > > > > > This approach is incorrect because even if the PTE is a swap > > > > > > entry, it can still reference a folio that remains in the swap > > > > > > cache. > > > > > > > > > > > > If do_swap_page() is triggered, it may locate the folio in the > > > > > > swap cache. However, during add_rmap operations, a kernel panic > > > > > > can occur due to: > > > > > > page_pgoff(folio, page) !=3D linear_page_index(vma, address) > > > > > > > > > > Thanks for the report and reproducer! > > > > > > > > > > > > > > > > > $./a.out > /dev/null > > > > > > [ 13.336953] page: refcount:6 mapcount:1 mapping:00000000f43d= b19c index:0xffffaf150 pfn:0x4667c > > > > > > [ 13.337520] head: order:2 mapcount:1 entire_mapcount:0 nr_pa= ges_mapped:1 pincount:0 > > > > > > [ 13.337716] memcg:ffff00000405f000 > > > > > > [ 13.337849] anon flags: 0x3fffc0000020459(locked|uptodate|di= rty|owner_priv_1|head|swapbacked|node=3D0|zone=3D0|lastcpupid=3D0xffff) > > > > > > [ 13.338630] raw: 03fffc0000020459 ffff80008507b538 ffff80008= 507b538 ffff000006260361 > > > > > > [ 13.338831] raw: 0000000ffffaf150 0000000000004000 000000060= 0000000 ffff00000405f000 > > > > > > [ 13.339031] head: 03fffc0000020459 ffff80008507b538 ffff8000= 8507b538 ffff000006260361 > > > > > > [ 13.339204] head: 0000000ffffaf150 0000000000004000 00000006= 00000000 ffff00000405f000 > > > > > > [ 13.339375] head: 03fffc0000000202 fffffdffc0199f01 ffffffff= 00000000 0000000000000001 > > > > > > [ 13.339546] head: 0000000000000004 0000000000000000 00000000= ffffffff 0000000000000000 > > > > > > [ 13.339736] page dumped because: VM_BUG_ON_PAGE(page_pgoff(f= olio, page) !=3D linear_page_index(vma, address)) > > > > > > [ 13.340190] ------------[ cut here ]------------ > > > > > > [ 13.340316] kernel BUG at mm/rmap.c:1380! > > > > > > [ 13.340683] Internal error: Oops - BUG: 00000000f2000800 [#1= ] PREEMPT SMP > > > > > > [ 13.340969] Modules linked in: > > > > > > [ 13.341257] CPU: 1 UID: 0 PID: 107 Comm: a.out Not tainted 6= .14.0-rc3-gcf42737e247a-dirty #299 > > > > > > [ 13.341470] Hardware name: linux,dummy-virt (DT) > > > > > > [ 13.341671] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT = -SSBS BTYPE=3D--) > > > > > > [ 13.341815] pc : __page_check_anon_rmap+0xa0/0xb0 > > > > > > [ 13.341920] lr : __page_check_anon_rmap+0xa0/0xb0 > > > > > > [ 13.342018] sp : ffff80008752bb20 > > > > > > [ 13.342093] x29: ffff80008752bb20 x28: fffffdffc0199f00 x27:= 0000000000000001 > > > > > > [ 13.342404] x26: 0000000000000000 x25: 0000000000000001 x24:= 0000000000000001 > > > > > > [ 13.342575] x23: 0000ffffaf0d0000 x22: 0000ffffaf0d0000 x21:= fffffdffc0199f00 > > > > > > [ 13.342731] x20: fffffdffc0199f00 x19: ffff000006210700 x18:= 00000000ffffffff > > > > > > [ 13.342881] x17: 6c203d2120296567 x16: 6170202c6f696c6f x15:= 662866666f67705f > > > > > > [ 13.343033] x14: 6567617028454741 x13: 2929737365726464 x12:= ffff800083728ab0 > > > > > > [ 13.343183] x11: ffff800082996bf8 x10: 0000000000000fd7 x9 := ffff80008011bc40 > > > > > > [ 13.343351] x8 : 0000000000017fe8 x7 : 00000000fffff000 x6 := ffff8000829eebf8 > > > > > > [ 13.343498] x5 : c0000000fffff000 x4 : 0000000000000000 x3 := 0000000000000000 > > > > > > [ 13.343645] x2 : 0000000000000000 x1 : ffff0000062db980 x0 := 000000000000005f > > > > > > [ 13.343876] Call trace: > > > > > > [ 13.344045] __page_check_anon_rmap+0xa0/0xb0 (P) > > > > > > [ 13.344234] folio_add_anon_rmap_ptes+0x22c/0x320 > > > > > > [ 13.344333] do_swap_page+0x1060/0x1400 > > > > > > [ 13.344417] __handle_mm_fault+0x61c/0xbc8 > > > > > > [ 13.344504] handle_mm_fault+0xd8/0x2e8 > > > > > > [ 13.344586] do_page_fault+0x20c/0x770 > > > > > > [ 13.344673] do_translation_fault+0xb4/0xf0 > > > > > > [ 13.344759] do_mem_abort+0x48/0xa0 > > > > > > [ 13.344842] el0_da+0x58/0x130 > > > > > > [ 13.344914] el0t_64_sync_handler+0xc4/0x138 > > > > > > [ 13.345002] el0t_64_sync+0x1ac/0x1b0 > > > > > > [ 13.345208] Code: aa1503e0 f000f801 910f6021 97ff5779 (d4210= 000) > > > > > > [ 13.345504] ---[ end trace 0000000000000000 ]--- > > > > > > [ 13.345715] note: a.out[107] exited with irqs disabled > > > > > > [ 13.345954] note: a.out[107] exited with preempt_count 2 > > > > > > > > > > > > Fully fixing it would be quite complex, requiring similar handl= ing > > > > > > of folios as done in move_present_pte. > > > > > > > > > > How complex would that be? Is it a matter of adding > > > > > folio_maybe_dma_pinned() checks, doing folio_move_anon_rmap() and > > > > > folio->index =3D linear_page_index like in move_present_pte() or > > > > > something more? > > > > > > > > My main concern is still with large folios that require a split_fol= io() > > > > during move_pages(), as the entire folio shares the same index and > > > > anon_vma. However, userfaultfd_move() moves pages individually, > > > > making a split necessary. > > > > > > > > However, in split_huge_page_to_list_to_order(), there is a: > > > > > > > > if (folio_test_writeback(folio)) > > > > return -EBUSY; > > > > > > > > This is likely true for swapcache, right? However, even for move_pr= esent_pte(), > > > > it simply returns -EBUSY: > > > > > > > > move_pages_pte() > > > > { > > > > /* at this point we have src_folio locked */ > > > > if (folio_test_large(src_folio)) { > > > > /* split_folio() can block */ > > > > pte_unmap(&orig_src_pte); > > > > pte_unmap(&orig_dst_pte); > > > > src_pte =3D dst_pte =3D NULL; > > > > err =3D split_folio(src_folio); > > > > if (err) > > > > goto out; > > > > > > > > /* have to reacquire the folio after it got= split */ > > > > folio_unlock(src_folio); > > > > folio_put(src_folio); > > > > src_folio =3D NULL; > > > > goto retry; > > > > } > > > > } > > > > > > > > Do we need a folio_wait_writeback() before calling split_folio()? > > > > > > Maybe no need in the first version to fix the immediate bug? > > > > > > It's also not always the case to hit writeback here. IIUC, writeback = only > > > happens for a short window when the folio was just added into swapcac= he. > > > MOVE can happen much later after that anytime before a swapin. My > > > understanding is that's also what Matthew wanted to point out. It ma= y be > > > better justified of that in a separate change with some performance > > > measurements. > > > > The bug we=E2=80=99re discussing occurs precisely within the short wind= ow you > > mentioned. > > > > 1. add_to_swap: The folio is added to swapcache. > > 2. try_to_unmap: PTEs are converted to swap entries. > > 3. pageout > > 4. Swapcache is cleared. > > Hmm, I see. I was expecting step 4 to be "writeback is cleared".. or at > least that should be step 3.5, as IIUC "writeback" needs to be cleared > before "swapcache" bit being cleared. > > > > > The issue happens between steps 2 and 4, where the PTE is not present, = but > > the folio is still in swapcache - the current code does move_swap_pte()= but does > > not fixup folio->index within swapcache. > > One thing I'm still not clear here is why it's a race condition, rather > than more severe than that. I mean, folio->index is definitely wrong, th= en > as long as the page still in swapcache, we should be able to move the swp > entry over to dest addr of UFFDIO_MOVE, read on dest addr, then it'll see > the page in swapcache with the wrong folio->index already and trigger. > > I wrote a quick test like that, it actually won't trigger.. > > I had a closer look in the code, I think it's because do_swap_page() has > the logic to detect folio->index matching first, and allocate a new folio > if it doesn't match in ksm_might_need_to_copy(). IIUC that was for > ksm.. but it looks like it's functioning too here. > > ksm_might_need_to_copy: > if (folio_test_ksm(folio)) { > if (folio_stable_node(folio) && > !(ksm_run & KSM_RUN_UNMERGE)) > return folio; /* no need to copy it */ > } else if (!anon_vma) { > return folio; /* no need to copy it */ > } else if (folio->index =3D=3D linear_page_index(vma, addr) && <-= --------- [1] > anon_vma->root =3D=3D vma->anon_vma->root) { > return folio; /* still no need to copy it */ > } > ... > > new_folio =3D vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, addr)= ; <---- [2] > ... > > So I believe what I hit is at [1] it sees index doesn't match, then it > decided to allocate a new folio. In this case, it won't hit your BUG > because it'll be "folio !=3D swapcache" later, so it'll setup the > folio->index for the new one, rather than the sanity check. > > Do you know how your case got triggered, being able to bypass the above [= 1] > which should check folio->index already? To understand the change I tried applying the proposed patch to both mm-unstable and Linus' ToT and got conflicts for both trees. Barry, which baseline are you using? > > > > > My point is that if we want a proper fix for mTHP, we'd better handle w= riteback. > > Otherwise, this isn=E2=80=99t much different from directly returning -E= BUSY as proposed > > in this RFC. > > > > For small folios, there=E2=80=99s no split_folio issue, making it relat= ively > > simpler. Lokesh > > mentioned plans to madvise NOHUGEPAGE in ART, so fixing small folios is= likely > > the first priority. > > Agreed. > > -- > Peter Xu >