From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCF6C52D7C for ; Mon, 12 Aug 2024 19:14:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EEE66B00A2; Mon, 12 Aug 2024 15:14:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79E4A6B00C2; Mon, 12 Aug 2024 15:14:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 618636B00C3; Mon, 12 Aug 2024 15:14:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 405C06B00A2 for ; Mon, 12 Aug 2024 15:14:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A4916140381 for ; Mon, 12 Aug 2024 19:14:11 +0000 (UTC) X-FDA: 82444543902.01.C515BC3 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf17.hostedemail.com (Postfix) with ESMTP id D58BE40003 for ; Mon, 12 Aug 2024 19:14:09 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HgVvMJW+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723489993; a=rsa-sha256; cv=none; b=GCIBongXwV6n3EQjIf6xyKtoGiKdhCVprPf8AdtC/G5WiBQ0dj2uwAQuvD3YNEvcX2BEXf wqhNbvnhXPTUd3DnOBZ/fjjdwZhamcr61eYbbTuJVZnEJ3DD2BVvVmhDBe65sdIQynz59A 3rgRAA65qxcxBQ/3kwaibiRkq8dqThM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HgVvMJW+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723489993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XtaSChf9uo0ybT1NoNPBaEDjGJ0lTbrthdw0OmWDFR0=; b=QZHIJB1XUmKaF+gDfZbykOjTW1wmJZko6P0SmMB46/wQpb3cuog4xUGldcZpI8LTZzuOgB Wx6qtGk+wX2g9xU+dUFIgWJc31MIXFXNjRUE36CqmLiG8+wEC2vwouTAARf98tWlrdTdcb vROV1ynm7m5OFrrRX64l5Xth3lZ78xY= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e08a538bf7bso4305726276.1 for ; Mon, 12 Aug 2024 12:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723490049; x=1724094849; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XtaSChf9uo0ybT1NoNPBaEDjGJ0lTbrthdw0OmWDFR0=; b=HgVvMJW+2H6GLPVDBTkBQIWNysroGb6i1VPRJFT3byZEsmdZtagW1gXcKslysdcNg1 ScSrYjfTq/52VSZ/pB4t1QxCjMzhXTlKn+Y72ISOyhrQ4411GSVxSXBGIpvonsgfVT+d ISziMNxUf9UsxORwyZOz3w/s4OL3O71+MEQhcf5vmFQxMDni5NhDe+NDbB1PeNUXwHqu Jh5wkRkYODuGYOSkqRgXq/DVaLrDu5ksRUwNcR/Sm1kI+PHMyyBoYuSjSa4M5c52znnZ rD6x+ka/h13tbFapTNQBs2soj6YJDeXhi3PysIbY2M8l7npzUw0FhaAkfADZYlg2ORX/ r/Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723490049; x=1724094849; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XtaSChf9uo0ybT1NoNPBaEDjGJ0lTbrthdw0OmWDFR0=; b=hoUFfSCQhG185DarRThJj6be/Ndwmy/AV+mTQYnjTjrV4c0G0uFUn8B0BQMXqJi1ID yvV6dXC3PP50N4WSgLbhyDmYLLym7nZF/rWl/egdTL7jy7CZGPPQPh87LNsb/s2VZx2Z KzIDz3oQllPlaIR6eBRejTgS3DqihShtqiXg/KsktaD7d9d9HYUKoLmJn9rdZEzRFS/8 bU5gwRuFse10J+4/igjMvYZ2iw41asAn40iuQo9efXQ5WvW0rJJtkGoMLTtELEM9+M4c s9+6Q5MTTDMZBlrqkqofD4CJcbIHzeg5pRsCCTuyd/iowVG+UTaCszgKctdHWz5c1stx gLhQ== X-Forwarded-Encrypted: i=1; AJvYcCX65d+M0ddwHxBWKtAXmBCzvle4P7sAJg94r37hH68TIEeZvl2HkA5frMIQBfWKeL0YY4XhzJHB+GHgF5HekiFMbH4= X-Gm-Message-State: AOJu0YxiIEN0S6PUUf0D0dTK1BAJ+hhNexfNhxVfJeKD3tVXxYMwhgE+ c+nrjk1BCXP7ILhQqDUbiIzHJEwTe1eeL3G829LoIf4kgChdlZCyHiZRUZ+yVv/oVvu/yN5cA0M sj5hYp+13YR1NbjNeCF6rGS63GUsmoaRagPV6 X-Google-Smtp-Source: AGHT+IGGG5DMp+SVuP3f7HKlwVDWfFOHacaNaoNGeEutQ8erHBsQ7xws5Tes0AaQfBOG7bi0vHdccinZ9LgSUBIUaQU= X-Received: by 2002:a05:6902:2e13:b0:e02:d8f1:5fe with SMTP id 3f1490d57ef6-e1140ec05admr504243276.25.1723490048547; Mon, 12 Aug 2024 12:14:08 -0700 (PDT) MIME-Version: 1.0 References: <20240812184455.86580-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 12 Aug 2024 12:13:57 -0700 Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: mark pages reserved during CMA activation as not tagged To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D58BE40003 X-Stat-Signature: jfewfanz16rguor54o33d95mr1g1aoq1 X-Rspam-User: X-HE-Tag: 1723490049-445499 X-HE-Meta: U2FsdGVkX19XF/dsjCdta+tkok+CNpP8CD/3qSvW2PjPDJJXlsLhtgE8kKaqsVvPz6hAw484PdMgOenlngeZwwc/cN55qXdAMR5TwxJHztSQQJOXOxo2iuJbsZKQRlWxrMPhnHa+0OV1PmARI75cpm4GurbROlw3+lbcHhtkRsoG0LQfKNWPetb8OQ3DQNvI5fFEP+Tc7wqvJviLPzdpVEGwLrME8lk72+cLocdKmg8DA7k56Os/U3uazn6mkzTPt6Izdzh2otI5rLmdhX0QVPWa49ch01u69HUAO3zLpWMbkCEagAxJQvKJwl8dKqNFwJJ9NOFQti7+Bd9TUbZurZNg4eSJgUbMCSfKQ7aKbiBBs+YZfyExqYvb4Sf2z80HP4imctzIy+DDbVixADB0lMzEWb2U6Ua9jjyAdAK9/IgQHmXHAhiIxoOm93/UQa1QfRXWNczqSGKnKHzk6OYMB0FRsoaZTb0NK01mQqd/r/1mf5OV1gsxqD5Kzbld3XJihY6+R3fghMXa9coa6T/FsnHaxaTMD6P7s04ZZYwmnxZLyvmBhWAIgLHOZw3cEjRC1DrDzB7SDidB/iJYMPNGYThU/WaXHpzOcGCjDcEi7jxXD0SASgRvGkxwVw35/5rAoKc5tPa4YwpF7JAdvMM66QI9FACRq2MEuSjmj8erkDd8k8JJ1wg5YOA3yMDfQ39j69YmiO+vKn87bN/WENHG4bkg6dF5nEojzuRKbya192Nu2/1CIlbJAML0eus+oCJBtV8BhJd/eZLVw9Op57Ie1XFykjzeo2TElaeiUmf3yLQJsiTWY0zz9D0wj7t8XKuEm37kQqTGHFzZDsj4XHtEG/vJcD1pKaAae2SJESzcL83E4djS73V3AUWcy+C6Xlhh1cxHi99Pj4HgL3C8cGbA79qCZtFalJVfRTmWmEcPIS3KuqRZ9r/TrPVFwMXBQJr3eb9ymWfv/O7SeY0tOYD ngA9Izk+ SFhkX8O9sFxu6vIWpwvR2ZvfajfhJVG1wSBmevUBeuzO1i674nm0MgFeuN2vnwy9+HSBzOnx1SYIESmXekvttgocoAgPnpc7ptOxNhdFr3EHQS/gRKEyPQsD3q5Rh52Lk6gT/4KODUFKw8NOVD0NeLolGfkQsoqywW9gYxFOcnrtYjw3yGTZY691FEts8+FS2H1fDBlsWfmaVG+eGld68TeQq+jLrEJvbopdA+9Yb8yCp6rHZlWdUTZsKQaEbQWdsSeqYBaLXYslQtFEFR1lEfSIKDdN44E/EgcBtxXiDrasMl10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000994, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 12:11=E2=80=AFPM Suren Baghdasaryan wrote: > > On Mon, Aug 12, 2024 at 11:44=E2=80=AFAM Suren Baghdasaryan wrote: > > > > During CMA activation, pages in CMA area are prepared and then freed > > without being allocated. This triggers warnings when memory allocation > > debug config (CONFIG_MEM_ALLOC_PROFILING_DEBUG) is enabled. Fix this > > by marking these pages not tagged before freeing them. > > This should also have: > > Fixes: d224eb0287fb "codetag: debug: mark codetags for reserved pages as = empty" And Cc: stable@vger.kernel.org # v6.10 Let me post v2 with these corrections... > > > > > Signed-off-by: Suren Baghdasaryan > > --- > > mm/mm_init.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 75c3bd42799b..ec9324653ad9 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -2245,6 +2245,16 @@ void __init init_cma_reserved_pageblock(struct p= age *page) > > > > set_pageblock_migratetype(page, MIGRATE_CMA); > > set_page_refcounted(page); > > + > > + /* pages were reserved and not allocated */ > > + if (mem_alloc_profiling_enabled()) { > > + union codetag_ref *ref =3D get_page_tag_ref(page); > > + > > + if (ref) { > > + set_codetag_empty(ref); > > + put_page_tag_ref(ref); > > + } > > + } > > __free_pages(page, pageblock_order); > > > > adjust_managed_page_count(page, pageblock_nr_pages); > > > > base-commit: d74da846046aeec9333e802f5918bd3261fb5509 > > -- > > 2.46.0.76.ge559c4bf1a-goog > >