From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA7AEB64D9 for ; Tue, 27 Jun 2023 22:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 546A58D0002; Tue, 27 Jun 2023 18:51:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F71F8D0001; Tue, 27 Jun 2023 18:51:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BFB98D0002; Tue, 27 Jun 2023 18:51:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C32C8D0001 for ; Tue, 27 Jun 2023 18:51:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EB33A1C8426 for ; Tue, 27 Jun 2023 22:51:13 +0000 (UTC) X-FDA: 80950025226.28.D23B93A Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 2C71540004 for ; Tue, 27 Jun 2023 22:51:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZTYm0x40; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.210.51 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687906272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+LszDuwd0JI0HIewJamGQBtOvL8Phlguklg1GXeUghc=; b=JY+3XM93by73Z5oc2ABf9uxx6nBmfjg+CgSdRclNWbs8snDEUN71W3zV27hKFj5rlQX32I WkEE9EQmB3dg4tjitJY8uPpK9m08kOl7jbdgZ3JU+WqGCc6Y5CdYopK0XBifsGsW39f4gy qCfSli6EEAiG82lSIPZoZxd+1uHAOrE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZTYm0x40; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.210.51 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687906272; a=rsa-sha256; cv=none; b=GftWjMt/RHl+UnWCCydqNXJDqNlTDznivhGjpW2fq97mXdbaner+fKL1oeTwo594+yH+Eg 4SR/pOaQMN3LvfgoqGsRgYPF3rzNzqp09QHC5e7QMdKmBj80EWGOjnorh8Z1yKsToMkz4A VIl/mupdPn/CYic1EH+5KSsCx2Moa/c= Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6b5d57d7db9so3994851a34.3 for ; Tue, 27 Jun 2023 15:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687906271; x=1690498271; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+LszDuwd0JI0HIewJamGQBtOvL8Phlguklg1GXeUghc=; b=ZTYm0x40ZLSTozo8OdUEDg6aP6VHAjEOKt9m8a0VBIjPKMsjmlIY1APoWlVbnY1h6J aZtv0BhxbvxJSxqbPds7nuadWCdi0PBCYA2iNGFfdOk1IqhFmHrIyRE9gQQMfdYS+HTk fErHPcxhdvdFNBQppWAgoB5zXa9h5PojIHov5akQnttxyiOJZlLX4RjAcHbirkkgc6eK UILitNX/PP7zfXjJi52fUfPegeCZDgv2Bm/sk5ldUCK6E3zbYZ5rwi+BRNMfftMbsELO r7CDVFXlUMe8FL7GLtVwmOxlS6WRyo9Hq8chC13ZxJ8LpqRgneIefylWnMov7kFaI21l kxEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687906271; x=1690498271; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+LszDuwd0JI0HIewJamGQBtOvL8Phlguklg1GXeUghc=; b=X1nxdKP/UIia+X8LsXadbJesOcpcIsIlABEnUEMeu4Gtubz7Z7BpozAg+qn1pGcigf 2oQWmG1lwqyCiduA97BLr9hyztUFBuBpGAOXPEawWhS0hkmpYgGQmhTHuXoSQZP8YOJ3 zXKxIgwz/sr43V8RojjmYb9OmBRzjoyw1990PN40wzYGsUodxqusPzlV+dJ4IysICQES qI3PFu77RdoNpP05HY3stDLhmFHcO/w7AHLIKc9ePFpFAXS4HO30mkJWqI27T8p+Y2Mg Wl+8CwLkSp/bU7gYlTm1hDbI7/4Op3IxlaVUNA2Oda2hGt0IxpRMlG3OEed/kUIvACa+ GNog== X-Gm-Message-State: AC+VfDwDIOZL6vZXLrRAPR/rYZMfAsefcVe4tO5pN9tyaNI1Tbh4pWD/ farTpjUNSW8gm8Hl4pQvhYmr69AqrX9dfqamNqjAQg== X-Google-Smtp-Source: ACHHUZ47JJm2vI3qvxCQ6n+rlicIXi+ipR+Jw7Pls8XgO10xo3/Bb5T8+xNik6O7lNv/FyTOGt88gkiuaHQT3QevGS0= X-Received: by 2002:a05:6830:1e96:b0:6b7:4aa6:77b0 with SMTP id n22-20020a0568301e9600b006b74aa677b0mr7005846otr.17.1687906271134; Tue, 27 Jun 2023 15:51:11 -0700 (PDT) MIME-Version: 1.0 References: <1685531374-6091-1-git-send-email-quic_charante@quicinc.com> <20230531221955.GD102494@cmpxchg.org> <230e45e8-8cd8-3668-bbfa-a95212b4cb99@quicinc.com> <20230605180013.GD221380@cmpxchg.org> <4543c4e5-43f1-bae2-245e-951437e4bd07@quicinc.com> <70743150-dc85-1a1a-87ec-e3dd9f72c5d0@quicinc.com> In-Reply-To: <70743150-dc85-1a1a-87ec-e3dd9f72c5d0@quicinc.com> From: Suren Baghdasaryan Date: Tue, 27 Jun 2023 15:50:59 -0700 Message-ID: Subject: Re: [PATCH] mm: madvise: fix uneven accounting of psi To: Charan Teja Kalla Cc: Johannes Weiner , akpm@linux-foundation.org, minchan@kernel.org, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2C71540004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8nu8o7u19xw6yie5x497mckt6brsofsp X-HE-Tag: 1687906271-692875 X-HE-Meta: U2FsdGVkX18+v94BqZV+CXH7vf4OAconwxPKZZpDIDFWt8NwF8MNClR/7TqefhC4LTA4MM4ZKfYPKPlLnqGCFuj1X6q/jPzZpYsBNJ2c73jQlIltzElelhTtEDlgSk59bEaR23vbmxnCmY04DnXRjb9xehHZyEF/DjJSpfPXtZIISqsSFEO4p1jBKo0hd2ECoFp0O0j238eKkpqcYHBhm5/vHc/Iqvq7tY8gZpGT7uvTiXjrNO5XGNoMtuvibi0zGA1Fgi0ZVkViX1aZG4JWxHLkw3E0cHUFdq0XDF2Kdprv+LIZvrYDOtaAOwCcIiEV0j0MmB1TiYPTk0rjzsQ5VSQCvjB/mJH9EdwJKZ/YjY5cgoyWHrCAYJCiQlbSUTn3BNhhbJItCQ5616Cs4D0MQfarUr8NpUgC9IzEEubtrySYE0hjZOQz438JgK8QHthPWfbxrFvOlxMlEoagqeS1o/AEw+yOqBJejRz76M1mZdPsNq+GbO/XovvV4173Gl56/v2CsSAKFJpmQ74n8MBxuw+tsIb5vMyN3HOHZ297zlyegmQMy06Iw1ocXE4mUWiNcn647oGmt7HLPVy1JzA6nhlgH3v/cR9EIfRb1CbugdnbxJJFx95eLll1tAccB1vz5QPpi7CW33sUk7yp5J3bROn/FVE0kbrcFjZV87B7sC1TuemocQvTo6SKYXApkljE03XydxiEvKi2S84r/7smNSkf7sCb9aO8mX76oCZf8gWMY4KmNMH6YZ45oULGBPigfC+YNtFZUqDwbdXyrBqPBmmKXscVnQCXZ4HVbT+SvWKRAVHzogCnnqrjeLi4Ffow7HpBDBpU8pngZLblwc2k6F2alRJP6AqBvfA/o4NYTzv7/aWeUm7giyf02U7aFlYZ/6ssviIchVAxFt0oGjrIvX3pWAKeNrBqXDxXTKzn7J9P+d5x/YRb0Bi9vShxhX5aTj21tcdSPw+JBupiqZ3 hsKFxmdO em2FueDu98IjJclSpi0t93cDdNidZsPcy+DVhxRPrLQ0gZBgmV2eP9cdMqy4JxJVyULyrCv6g+ube77Ssyu2uagSwkhnljwkQktmme23GfgjWH/jUgeVtJlc+RimxOrMy8i2rY9Xvw4HXz4fBstQN1Gl5bW8Or8q2Aie5zFaZnrFfOdKv2FPYW8K7SQcCjWzXE+6uCIx2qLO/quX281J/wyn2+LCB2Bd24sdQR7MfdY+vk96SP8AKYi6EqUccZ2HXqOPn2RioDBkg6LmGqqaC3xSUQBas4ZIhaTZH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 7:31=E2=80=AFAM Charan Teja Kalla wrote: > > Hi Suren, > > On 6/10/2023 4:43 AM, Suren Baghdasaryan wrote: > >>> I can see use for that from userspace to detect incorrect madvise() > >>> and adjust its aggressiveness. I think the API might get a bit comple= x > >>> because of the need to associate refaults with specific madvise()/VMA= s > >>> to understand which hint was incorrect and adjust the behavior. > >>> Instead what is the opinion about giving an MADV_PAGEOUT_INACTIVE > >> interface which does operate on a page only If it is on the inactive > >> list and !PageWorkingset ? > > IOW you want a less aggressive mechanism which can be used by the > > userspace to tell the kernel "I think these pages won't be used but > > I'm not 100% sure, so drop them only if they are inactive"? > > I don't know how much that will help when the madvise() ends up being > > wrong but maybe you can quickly experiment and tell us if the > > difference is substantial? > > We did some extensive testing on Android and this ask is not helping us > much. I am really not sure if there is some other usecase that can > benefit from this. So, for now I just stick to your suggestion of making > the pages on the Active list as the Workingset at the time of pageout. > > Thanks for checking that. Your plan SGTM. > > Thanks. >