From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3162EB64DA for ; Wed, 5 Jul 2023 18:15:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56F0F8D0002; Wed, 5 Jul 2023 14:15:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F8498D0001; Wed, 5 Jul 2023 14:15:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398828D0002; Wed, 5 Jul 2023 14:15:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 244548D0001 for ; Wed, 5 Jul 2023 14:15:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1BB1C05DC for ; Wed, 5 Jul 2023 18:15:05 +0000 (UTC) X-FDA: 80978359770.23.81C3280 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf10.hostedemail.com (Postfix) with ESMTP id CE369C0010 for ; Wed, 5 Jul 2023 18:15:03 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4TFMCjMv; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688580903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mN+8m1ObowZ74/MLZ++4zNOVgKxyk4abeoHHzPL0ezY=; b=SrExxvNhU0P+wW0u2If3JXHYfsHOuoMbIbJP8Cp8tFN9yGLJfOkh+yrkHp+T0soLoYfj4s 0aO7MPQelH4SrYl30xohHEEk1AuXnnl2BbTNGzuePuzxVm3ghGkzQm3e0ypzTax4Q0Pq5s sSBiiKYEIOTbb9HC17Q1m087Iwcvf6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688580903; a=rsa-sha256; cv=none; b=ufhnsPG+T29W8eUCCnz5ENW7+zwNsgUvDbhKtlDhFarawFd5lIYLo8v0j8VcVq1AsP5vvY qbxjy920V5qW3YMR+AhuKKuiejfOB5McUYtIr/9E3zy4BSDT+WDeyBzfcAVfXreOlFLKni g1PMnMe2WocZKHXE1ldgeR09KUd4kBA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4TFMCjMv; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-c15a5ed884dso7973047276.2 for ; Wed, 05 Jul 2023 11:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688580902; x=1691172902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mN+8m1ObowZ74/MLZ++4zNOVgKxyk4abeoHHzPL0ezY=; b=4TFMCjMv9iG+yqvy1BZCXvPVHaAAiUMgSlESlQ24abzZb75mpvo4noUD94rWEbxSwN 2Dlz8AWTMjrSG4gawG4Uh6ULXX+zF17/kLnPeMF1MCgbYmbB6+zq2cO418wb9Xi7Ffjt vvBykSdfuu+sRbQU5SCWpWrlzrjNPXjxI5avEpX3nxHQGa6Wmh4i0wG2pi4KEdqW1qNS tta+EW2l09KXS+jEIZFzV3NaW7CAg7cSqRBw768qp7KoyC+dUhLwH3L8IHjR9Q4vU0Wh PoK+i/B5EHpcdwlqwH5hK4aAvpfmUemy0RRP54JpB8jaV/4bwUnwBUXTw42Axmxfy0ed Gdiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688580902; x=1691172902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mN+8m1ObowZ74/MLZ++4zNOVgKxyk4abeoHHzPL0ezY=; b=F2N7Ufm6NZE3DmuGq/Nl2QrfAW1UWGwdk5MXa60VU7aEDiciWEQupkfLlOTJI+1x+g MZIZixf8M1c7RNwuyDH8VhrEJhyvBLRunQ2YwxDZ3URBV4CQ3hSbWcAO6x42mbgv/Q2K PQrofkEJQyWOD6aOEX6MzS1LOXFPYkidQo91F76qloXLWdd+fLvPXsoDC7cMe1VMuixL A+N0LcsWpBpIWgn/ibsRoPl9cS6np5xsRUbDzgX7QfwBNUl4PvHZ1qph/HTdlDgN3kKQ d0IHF7KFqHx14WWpqwW9MvZIAuYeQ/3Wsjb+Y6KHf8+TYnP64dpavx63NlYc9bMNwa63 KRbQ== X-Gm-Message-State: ABy/qLZKEWD6JB09ehJtMpLoqT/rdkAPoG3y1nNguTatCBTluulzOeVs y5wzT9d1CNevDCyqeEa5uvaPylF9gawITft82fjw+g== X-Google-Smtp-Source: APBJJlEmDjvoEme69I8YCn0M78cljJMU1hQs/lP0iWGg79WAt9uupvyQmLpjOx+Bgg5NHy46qtYnpkRlzLRzoRRjbnU= X-Received: by 2002:a25:cfd3:0:b0:c4e:48eb:b8d4 with SMTP id f202-20020a25cfd3000000b00c4e48ebb8d4mr10899950ybg.27.1688580902461; Wed, 05 Jul 2023 11:15:02 -0700 (PDT) MIME-Version: 1.0 References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 11:14:51 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: David Hildenbrand Cc: akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CE369C0010 X-Rspam-User: X-Stat-Signature: rshq55g4jbug4t35afymmtc17phhiawe X-Rspamd-Server: rspam03 X-HE-Tag: 1688580903-20098 X-HE-Meta: U2FsdGVkX1+NFJVvSrabaCkNvRMAjfo02QQjsWT2PwXKLSAnou/+rHvU/EaQnY7K0UkASZQR0fVReKv9Q9tbMTViHsfmogVXPjUdlDUet7vV/HLtA6Ya1PiVIUHa+syEzwaIzTO9909IllmBCQ7SoIco1BgsU4dimtPkt8Qd2LGz1/cYUI2LpJX70OVA+JXeRbOyVQjdKDnKN4ixso7g4XI7EqxHRw24G/WRHMTT4HWwvwVI+MT5XucPwIaOkWGabpz12GGa9LotywP+35Dv20OwNe/DAnoX/rVWJNxYtaRMHXXMICCctgd5DjUe0K3j8dyyj4taJypr2PfXt0do63MQVTSeONxFs4UxRB64Ell1Xm/3Oln8qroBJX6tVUupO167LzDvB7McXhzEKXKp8bhdFrOrQO+Zsv+wJtlWQ/Lg9kV+T3ZCPaG/e5NTmwRdIM8MYEt9KLP27zpB/I0uWJKT5KufTbNzpybHfzFreTex9UC+KZIZPPvFGopdInYtxFBqZP3yE3BKhiYKJ7FF9AVvpvkSAPU3FJVSYmSyix0+8Lw7Uf59bVZwg4E2SAs5gTneKne803I3Y/cWFY/y0doShRuKxFTX5Dq2UP7Rjhvtd6BIxkGp99Hvg5zSrCo6ugMZBQuuqXhdnxoONzGTt4fBMndtljgqsxqpJ9G51NOwwdzrEBEP4fsodkENYxYQYf4CxfyhWAM3z0pSOIu1DHR1LbMLQ85wQEMP/R07cOo/5JLRYQxm83NhL0UB4JcqmMYPW2n9sg+YcCab0ws2mjHAcIxrthwhNlgE7/H55YWrac0mUFCaVx5tBHUVYDYTcPitILFzenhSwuJohj0WppzMoDQHfpnekeeFQuKkrk3Hgs94Gne/F1QEz9hvq/FKTranMSnfJP885VrM7QJRWvCYcDw9enBliaWb/5PU3q57i/Ujz2t7gQq03QD54JAin5Sqct/K31pjt38wp9c vYbW4in+ tyKN9Sp2kMjwu9LzLlkToyUvDa9D3b6xqJbtPykU3qbigPWtd/bv+mU16LvsyCyamKYc5gzWTBoiJqt1BdDEmH7AbvUE3Uzx0yPUUTJdtjjve00gQyCmFhmM5TtyEQT83WUU5RRv6cowSsja/Yl4T8i5serRfqvhwmjCWGK6iOfEUC7DBxQQOHaKCT/m0kVj0WVKQb7BP8wTjFjKfA5jAu3Edcitg+RwUS710YNcD56M5N6bvT6/Xl6+ytnIE3q3maqJTzMTDIzn+IY7gEcz1NT8VbqIUWi5cb0S0Vf1E9TpMHE+cnVUbPHBb45iAvvX5r52cXDZofkcHzuVbFdrAb5XVZw00BC4oIld66v29Iduq2T/8ZRHwpeiVZfvNV6dx8Cw3sII9NzKyw5t9qfuW9I0lo25FwzMMn4CNvhqEp/Z7jkCAB7g2kSb4XJ5rsXYayvMU8KFmZVyIvsX0CyxTgLL3Y8eDOQqCPAvXzdmreUBh9rkPT2xsdIkXrUXGcdSUF0Gt3ItVyvXH2++V2Y35E6SB2uWwDhn/PbTZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 11:09=E2=80=AFAM Suren Baghdasaryan wrote: > > On Wed, Jul 5, 2023 at 10:24=E2=80=AFAM David Hildenbrand wrote: > > > > On 05.07.23 19:22, Suren Baghdasaryan wrote: > > > On Wed, Jul 5, 2023 at 10:16=E2=80=AFAM David Hildenbrand wrote: > > >> > > >> On 05.07.23 19:12, Suren Baghdasaryan wrote: > > >>> A memory corruption was reported in [1] with bisection pointing to = the > > >>> patch [2] enabling per-VMA locks for x86. > > >>> Disable per-VMA locks config to prevent this issue while the proble= m is > > >>> being investigated. This is expected to be a temporary measure. > > >>> > > >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > >>> [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@go= ogle.com > > >>> > > >>> Reported-by: Jiri Slaby > > >>> Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3c= df51b@kernel.org/ > > >>> Reported-by: Jacob Young > > >>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > >>> Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handlin= g first") > > >>> Cc: stable@vger.kernel.org > > >>> Signed-off-by: Suren Baghdasaryan > > >>> --- > > >>> mm/Kconfig | 3 ++- > > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > > >>> > > >>> diff --git a/mm/Kconfig b/mm/Kconfig > > >>> index 09130434e30d..0abc6c71dd89 100644 > > >>> --- a/mm/Kconfig > > >>> +++ b/mm/Kconfig > > >>> @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > > >>> def_bool n > > >>> > > >>> config PER_VMA_LOCK > > >>> - def_bool y > > >>> + bool "Enable per-vma locking during page fault handling." > > >>> depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > > >>> + depends on BROKEN > > >>> help > > >>> Allow per-vma locking during page fault handling. > > >>> > > >> Do we have any testing results (that don't reveal other issues :) ) = for > > >> patch #1? Not sure if we really want to mark it broken if patch #1 f= ixes > > >> the issue. > > > > > > I tested the fix using the only reproducer provided in the reports > > > plus kernel compilation and my fork stress test. All looked good and > > > stable but I don't know if other reports had the same issue or > > > something different. > > > > Can you point me at the other reports, so I can quickly scan them? > > by Jacob Young: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > by Jiri Slaby: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3= cdf51b@kernel.org/ >From strace in https://lore.kernel.org/all/f7ad7a42-13c8-a486-d0b7-01d5acf0= 1e13@kernel.org/ looks like clone3() was involved, so this seems quite likely to be the same issue I think. > by Holger Hoffst=C3=A4tte: > https://lore.kernel.org/all/b198d649-f4bf-b971-31d0-e8433ec2a34c@applied-= asynchrony.com/ > only saying that Firefox started crashing after upgrading to 6.4.1 > > > > > -- > > Cheers, > > > > David / dhildenb > >