From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE87E77188 for ; Wed, 8 Jan 2025 15:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EE306B0083; Wed, 8 Jan 2025 10:51:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59E1B6B0089; Wed, 8 Jan 2025 10:51:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440376B008A; Wed, 8 Jan 2025 10:51:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24DF96B0083 for ; Wed, 8 Jan 2025 10:51:46 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BC9811608BE for ; Wed, 8 Jan 2025 15:51:45 +0000 (UTC) X-FDA: 82984724970.05.8A50CDD Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 3021818005E for ; Wed, 8 Jan 2025 15:51:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VgoYiWRR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736351493; a=rsa-sha256; cv=none; b=0dMNOD8PJVKucgGi4RKRarSVEsRLLU0OLLoadh0g4hVWO2zAzsIN3mUD8IwuQXrnBoYVYg F9BVuA7+7dtjM+Qz2SB0BZQdECHtcSDr2Zqhkt+iHBymR/RBTm6trTAWaiFJso49D8YH0y xcxN/0L3sky4XTE5kkREMAT7I3oGaaQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VgoYiWRR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736351493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67I/eii2fGSHYgJGbfX3cBs1DaiGogWYfZocV6dT03s=; b=7YfB+ZbFfir/4Ld8K67NFR0DN+LhvkeZeS90dl1pWp3cdThvt1A38vRjVQmZuv4jYnD3Vg 8KHTsiWmcb3jCMwOW9jdkpp5hT4XUyu/YBADOUYoHIVWsk14GHd3ht1i1rb+FhbgD6zhLN 2hcEo2txtfWyGRx6lks0wkp5hMfsSrQ= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467896541e1so272311cf.0 for ; Wed, 08 Jan 2025 07:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736351492; x=1736956292; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=67I/eii2fGSHYgJGbfX3cBs1DaiGogWYfZocV6dT03s=; b=VgoYiWRREzvdYTn529FD6DyjC1lkd/wGGvcYnYfvAbxrVDL/+1y5PpKCfTjv6ARSP9 TkNUI0Zzp9At1MKMwTtxMvR3hn2Wo9zjuy0meG8AE/XIFDdt0nLhZocT8O/R10G9rekP boCNjw9yc0wJclfHuHEjnf68kWMlD0hZnYVp9OfFAHaetbJnVqJ2YYDFvQoa/RylW9XZ lvMHKGUSH5xWScURZnxU4LI7RbXXiEkI6avau12jjdcqezz+B+i9hz5vurQx6O2q7fhH nNYVXOBpic5dKv3cjQScBTc1wIjhmfG8CuTK7admbJJhVb8AJUv0RRK8rQPMvUXGxpVZ IU6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736351492; x=1736956292; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=67I/eii2fGSHYgJGbfX3cBs1DaiGogWYfZocV6dT03s=; b=bIkRCIoMFekSeiuRX4pvEmlVMoNz2daBKSOcE1hb6/E29CKtCGfKbTKHozP5RfojJv routQ7zsgANzrpjsFMNGfomLxlNLxXpKvG5rKtFYJyd9nEGqg1HAGArxzNPs+AxF8iqc gACMxNA8APJeSFEWGTx9SOjoSZZq+RnxNJ27iC87OVsJgmITQnmD/cM4ZBrrXuZnL13u 3iqLBGsz/1y9HWL+goUu3AMJsNsaaxIcXbueMAKw8EZwqmvdH8CqRHIkw2x4py1B1Abs 4GNX2AHuNH03asdc07AQ4XitMaIRz4lvFzuSlrQ1PhLYEM5dwxUKGWjfbgGbKaBtkvkZ uJBQ== X-Forwarded-Encrypted: i=1; AJvYcCXUY4MFpm9U3d9JkYBVc5Jc79iLUvNlkM/GvRpOcl/fJ3zSmRWOpASXX0m/3dQ7zpLK1S4jJGTXSA==@kvack.org X-Gm-Message-State: AOJu0YzD8Pj4se/JEM+2JXtcuNqYER0H5X479wk7MRGBdhvgALzIs7C+ +iHFzzaCzJ2B5SPLMmE1uRWya5xciFbE9el0EkE/vo7EuwMYYY8e28vexke8NxTfBVVklkDhw21 3VqNPlyRP65ZyB6sjOcD2BiqohwIgCYJEdMKq X-Gm-Gg: ASbGncvV9T6gMJVfDakY+6KxD7cmIXXOVjGnsC2P+NSrPQoO6bstywa/UKVWnNb/aFx TzEqeYl49LsGnOD3HOPfteguNpRhtyTeEhhH+sGVS1M/YlUh/JFcyxJhloluqzlB+e8iy X-Google-Smtp-Source: AGHT+IGAjJ69c3xdt/cOeIDTYcJcuvF5lN4zzXqs2+83I6HeZnTzndRU6K9Q+Ky+4IOkHYETzRAEvkJAbjt6S8+JRdw= X-Received: by 2002:a05:622a:5ca:b0:467:7ef7:88a3 with SMTP id d75a77b69052e-46c70c493a3mr4075591cf.16.1736351491758; Wed, 08 Jan 2025 07:51:31 -0800 (PST) MIME-Version: 1.0 References: <20241226200335.1250078-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 8 Jan 2025 07:51:20 -0800 X-Gm-Features: AbW1kvYmq_53L3WCXY_lvkkNZXx9paTFerEl0V7tznZm7zknATJbTiu7mcbsBKw Message-ID: Subject: Re: [PATCH 1/1] fixup for mm/debug: print vm_refcnt state when dumping the vma To: "Liam R. Howlett" , Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xpuhhbufmcy79j3k46qxggujmtnkpfch X-Rspam-User: X-Rspamd-Queue-Id: 3021818005E X-Rspamd-Server: rspam08 X-HE-Tag: 1736351492-333456 X-HE-Meta: U2FsdGVkX18A7L1E7HCZH+1U1sn3ErLpYoFqtdjVuK4mfAnseUugl5k2b+CeVG5OOd00mDiFi3MUaaCKROiHo9qDJdgVvq853nrYETavGDCP+u7pO+7K1KTxvzeVrOfe7apQZyBQtUkk4k/l1WzIFyTMHKDFVAFkoJ9fBRlRAykZnouho/rHdhbYl8QttitxeB2m8cA8SN8ffo4FQFpDHHmY/RK+JmHiQ1jfM8EytD1/4n+e8sUR6JYrPIjxvmFCmEh2ONHSp7Cs0mA83JX5eNDsYJ0RJzyNXi6xAeSI2TXcHWB1OwDR8mgCCznS3dAJV02SQtQnyQFSxunQTClXa5lYq9QRCd4hvmmJsRsv05sly7RfRpyOxdGI0wx+g4C1GpXLKVETW4B8999qKKu+GvqgxDsDNE35QLk5Cr6DqWlJIyBcYBgBevMXjSn8urPLJ4bXGAwqPY0EyqRbTUK+Iov+7ct0fjTvlFb1hfANZgN0w1XeiPz2ZuuET2/IZ4zRHlZT2rXgWhvsFW+69PVjF3g8MUzziAMxaKj+UrazIsca7JXWZzD4uMvXNGGT6zcZARLfDc8WOSqAfxrMFj1OsNzhSI5zWqbDIrL+U8r0Xjf6ySfLemYrWM3rjpnTOOoSN2spHLQxBwPFK/OkulRH0x5QCmO2JGNxwQbSV7JTPDb7oqY46cshEIrUcFptSOdIWzwJn29VHLoXFyq1aWxJRWd+a1jeXdY56lPdj1vY4kQeGEBo8vETRsCuNv4f/aRi/Ke6jOuOvwFL4zDt0LbUzhsyUlnp+Eq/suyxAAKAFNiVkO8bdbou9P327Gsr7S+NU3zYVCIEgv9HEFgInM35sqMYaZUrVxpSeuuRgWBjtMkjxFSCRLkDjA4WpVya6HA3nfvGOMvkrXqJwup2vATnNQUweze2g1VLTuFlf/kHRIiuNeeMBScYECGHIYP6Fj8NGZmK6w344MmmxVE2woZ BXC+OUff DNcdGXZHnN9rCFbfZxPcCew+a78AckHLKuGZVhHfQHdhwA8PBRdQyCp/f6ZR7d0Ge8BMm+2PfwPJBzoWSflSD8eA6N1q0Tc495Hy/3zwy0CPZHwHZC2rTwPGkYwA5dVQmvfBVravUSb/rv8YwzfIWM7VgD/zP61I7TmIy9zPYD1h6UU3ZnSVxVUcFfFoqqE75iYFfUwChN40lzmI0o3UVMPHXX6S15nmXSzS2ZQqvdgwoFN7fHo7B+Z51myfvDrgOH374qqDHpztzap1GJY1YBPqgxxTAEC2JEgDRlNVMbnXNCXbquuNBXaSEaO7NizWMaRLGN0y8ZouhTmVG9hrqnm2JAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 10:57=E2=80=AFAM Suren Baghdasaryan wrote: > > On Tue, Jan 7, 2025 at 10:50=E2=80=AFAM Liam R. Howlett wrote: > > > > * Suren Baghdasaryan [241226 15:03]: > > > vma->vm_refcnt does not exist when CONFIG_PER_VMA_LOCK=3Dn, therefore > > > when CONFIG_PER_VMA_LOCK=3Dn and CONFIG_DEBUG_VM=3Dy we need to avoid= its > > > usage in dump_vma(). > > > > It might be worth having a function that decodes the information in the > > vma lock and outputs a string that spells out what is going on, > > You mean something like "attached, 2 reader(s), 0 writer(s)" instead > of "refcnt 0x3" ? > > > and > > another that just outputs "not supported" or something. > > Do you mean we should report "not supported" when CONFIG_PER_VMA_LOCK=3Dn= ? Hi Liam, I have v8 ready for posting except for this patch which I'm not clear how you wanted to change. I thought printing the raw vm_refcnt for debugging would be consistent with how we output other fields, like vm_flags for example (without interpreting each bit). Could you please clarify, preferably with a sample output, how you would like to see vm_refcnt printed? I can also keep this patch out of the series for now if we are not sure yet how it should be displayed. It's not critical and can be added later. Thanks, Suren. > > > > > This has the benefit of spelling out the state and only having one plac= e > > to update in future dump_vma() changes. > > > > > > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-kbuild-all/202412270328.HiJX1mRt-l= kp@intel.com/ > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > Fixes https://lore.kernel.org/all/20241226170710.1159679-14-surenb@go= ogle.com/ > > > posted over mm-unstable. > > > > > > mm/debug.c | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/mm/debug.c b/mm/debug.c > > > index 68b3ba3cf603..9c4cbc3733b0 100644 > > > --- a/mm/debug.c > > > +++ b/mm/debug.c > > > @@ -178,6 +178,7 @@ EXPORT_SYMBOL(dump_page); > > > > > > void dump_vma(const struct vm_area_struct *vma) > > > { > > > +#ifdef CONFIG_PER_VMA_LOCK > > > pr_emerg("vma %px start %px end %px mm %px\n" > > > "prot %lx anon_vma %px vm_ops %px\n" > > > "pgoff %lx file %px private_data %px\n" > > > @@ -187,6 +188,17 @@ void dump_vma(const struct vm_area_struct *vma) > > > vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > > vma->vm_file, vma->vm_private_data, > > > vma->vm_flags, &vma->vm_flags, refcount_read(&vma->vm_r= efcnt)); > > > +#else > > > + pr_emerg("vma %px start %px end %px mm %px\n" > > > + "prot %lx anon_vma %px vm_ops %px\n" > > > + "pgoff %lx file %px private_data %px\n" > > > + "flags: %#lx(%pGv)\n", > > > + vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->v= m_mm, > > > + (unsigned long)pgprot_val(vma->vm_page_prot), > > > + vma->anon_vma, vma->vm_ops, vma->vm_pgoff, > > > + vma->vm_file, vma->vm_private_data, > > > + vma->vm_flags, &vma->vm_flags); > > > +#endif > > > } > > > EXPORT_SYMBOL(dump_vma); > > > > > > -- > > > 2.47.1.613.gc27f4b7a9f-goog > > >