From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ED5C4345F for ; Thu, 25 Apr 2024 21:35:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55AE46B009E; Thu, 25 Apr 2024 17:35:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3DE6B009F; Thu, 25 Apr 2024 17:35:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35D0E6B00A0; Thu, 25 Apr 2024 17:35:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 164376B009E for ; Thu, 25 Apr 2024 17:35:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C30091A12EF for ; Thu, 25 Apr 2024 21:35:17 +0000 (UTC) X-FDA: 82049360274.27.506CDF3 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf14.hostedemail.com (Postfix) with ESMTP id ECF53100002 for ; Thu, 25 Apr 2024 21:35:15 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=M1IbNPx6; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714080916; a=rsa-sha256; cv=none; b=CawQubZaOl7fwhoOLnywWNAlv7B7ZEd7zIZoQEszbqyyvAFrjbzn1ErG7Hmum8lDrd4MDk ie6OXbq0IJLFSDdkBYSlU9wzQ0jhWn25pIdEzayJvoDNcSFAaO8rka2m17taoAl+eauUpa ssRmXz1z6EdJyIw1mWPIh3K8dRGrWRQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=M1IbNPx6; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714080916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dNAVjZRL3SNvhEv7UtPjNVw2qSZLNXEHiDVYNBop7Cg=; b=30GqTGv08Q6IB2nvwPcpKjGYhEpt6+EeBQjxg68g+6oxw9pE5fw0YsAxCoVtNr5KZQxpBK y397jjlcMfgdDAxiX3K+dfU6uDIaC2cWNKTPcvsexnoCgOpQt7ha3JeFvQ2AUSH/4iC8oN SJpvxwE9znoM5aQOkQ7NXybIg0kJjS8= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-de55e876597so1797871276.1 for ; Thu, 25 Apr 2024 14:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714080915; x=1714685715; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dNAVjZRL3SNvhEv7UtPjNVw2qSZLNXEHiDVYNBop7Cg=; b=M1IbNPx6m1bXqxcIqSq7WdkPHtjtt+X+TROE4T7mtx7jzf9xQ/ZfIImlRta9StgE62 p8e/qURDiwvQmeZ+i+XwX0V79hwU0/82mCcWrpN3Re6bks6Dgp0oWsVfBTpM2BLAy+dY IXDFyAJvFkiKWMOqB6E4esGV+ociDFo1chUE/wlAEP8nXEpnjq8j4uwI+WAvQHGphkUr aZTDfhrfuJ2KvSr3zC1wY6ysOgWBDu62dZzBD6/GJnQje7PQjfkeXZ8w8qWocZ9r6RvI N1C2KydYGCCXAev1n4KDJ+i9H8yQA4W8CGg7eIPJ7f77N6qOcv0m+1OOVba2H287z7Q9 7H6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714080915; x=1714685715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNAVjZRL3SNvhEv7UtPjNVw2qSZLNXEHiDVYNBop7Cg=; b=f16F2YFpGt+m4rk7XlbD4pdm+EYn6qqOq5V5Y+FvA/PLCsFcJT4JXw6J/h5ciKpfKH 7rM6KCEUd4CAdWAHPOQ5/5ayGsMGKH8bB5n/99JrLGq7xJSfOPbtHUwjMEcbRzenKaOP nyq5NZniEcmdsIaAc8aVPyFK/CVg+LuWY2LKun4KlPsK9f8Q8QkTBfcj+d1Lh/K1EGQA bVVHDK7jS3hG9H+p2yGttexJmCjO0WRi/VGRqZn98ywIocfQLz6U6IwbywWKfc+jwNdv 4RxIAquyAxF+si66Boz/mCQlzBTcGdG77KtjwyAq9Rwhpsa/PMfQXKRaxmf3LMJ3ibOE K3cA== X-Forwarded-Encrypted: i=1; AJvYcCVcr8IImHjlvlpwAtnb1lczzixKvWOxJcA9bcZwuSVv8mOzuQbWemlQIorGWl3xBbR22a8YmBju1+xAfsarlqPhrFo= X-Gm-Message-State: AOJu0YxjPSbFZItE1t6UIN7T+w2fNaEC+w9zVuzNqfmv31PRrdIv4MUU Ju/CxNHAvIKHGlGeQ2UCP1xodyBZ++aoxWMHvBInN93sItw1jzba/a9upvYN4JiyGyjVk6H2sHu 08fEBVSReY/un3LIBx5yHn8GJFLdN4+SkJAHP X-Google-Smtp-Source: AGHT+IGQ7MeXm0dvILJ0AXWrIM9WmgMhHcldUahIe6fZQn6xXrjGpkS7ue/fUW0Lq66Lii1hOI5w9eO9wnXdvzFvETU= X-Received: by 2002:a25:c5cb:0:b0:de5:56ca:759b with SMTP id v194-20020a25c5cb000000b00de556ca759bmr991751ybe.2.1714080914454; Thu, 25 Apr 2024 14:35:14 -0700 (PDT) MIME-Version: 1.0 References: <20240321163705.3067592-1-surenb@google.com> <202404241852.DC4067B7@keescook> <3eyvxqihylh4st6baagn6o6scw3qhcb6lapgli4wsic2fvbyzu@h66mqxcikmcp> <202404251254.FE91E2FD8@keescook> In-Reply-To: <202404251254.FE91E2FD8@keescook> From: Suren Baghdasaryan Date: Thu, 25 Apr 2024 14:35:03 -0700 Message-ID: Subject: Re: [PATCH v6 00/37] Memory allocation profiling To: Kees Cook Cc: Kent Overstreet , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ECF53100002 X-Stat-Signature: 6ed7t79sb8xmgq7o695zg688abgezh47 X-Rspam-User: X-HE-Tag: 1714080915-444888 X-HE-Meta: U2FsdGVkX19WfeV7+5tGUL426oeMd+ZiZFpzjGJhDlWLDk5C2QFBxR2H3OLG9CZ5lhOedCwNar3jFrra6Du9QlL32mckYipJTHqRaoIxLvOcCgPqnya+scDIqxqPzyHoZ4xF5OsMTYDCfjSb1JYeUm3RhF5x0QWEfWH+dp4Bm3OthT5TC/nBRkwquWmRzG1zYVaGSXkfIkmHcQPKDXo93CkoZqEmq9odiKIR2OKhDH+M6YoPBneidVaf0VI366/pl2oYMAcNcGZwUxX9wd3jr+907n9CW3Igv0tPvdN+RhhxwkH4CJM+GORdOnyDH8spccz+YnBc6cceTeuTFnjIaFiKt6iS2Dtoj+xEQfiZbS7GsX/LcUAgjohPwLr2lem6vkwVz9Zcp0KdyoLF0CdcudLAr1VwJWhyiWfeGQJDRV4lrV/+dUslzFvYA/AECXMyh6E5gjnFSiKrQ+wE+8GVFLnPM4GXJ6pEAewHH+SrPnmfXI67olOrsUVqNlwG+XYfJ1DtYlA0Ph8XSHlvZIa2nSWiuHU2pAhNZbdTip9F+C8fU+6r6CbwHZIJv0uzIkPh6AsoPPIumxhCCurzzZc5BIEF/VvVPuCR1GtK81qORzhOzGs9p82uXIA78NYPMLKRLpQwlBRLCG3hTV5k/u8IKPlA13jN3PoNZ+o86fqEp7ng9jUWbie/jWU/oQJSbog8k+BgW+T4IGW8U0pdb2zX+3s5Mi693b2BRAOiQQVytO3r0ttAqK22LvsCCzlJ7NsSQbKqoXhsHFTWfaMxnX72DVScPWvcqtG1vjv0ORv4FTNkdRZC4yZNk3wlg0Mh9XIDNEaFxbepcPkWz8lrgfi2nchM3c3LNRcykKMwP2R7yS8JpPin9SxBx3cYYrTtDqA/V7UPuSgyyERIOjUC5YYYJzx6taiSZZrLb80aMd6aOUpdHZeaGzK1vppQC2J72SYc4AunpxHq3udjSZqae8q mioTE2gN hXG5uBnOoehFbTrydXO4KzHyEzkbjERk1c6L1Zw/pFdXsmY2Yxv5feESGWj6JfbtsRgc9j32cf6B2crbZGUW8AJbSvpcHF0t0m/jIkO6rK5mRtxfUcPxhwWGlE3C7eSW3Zx8Y7zcOVm58gJN314MyQPgeRsbMKC9JusWNpm9iAxZVj4mnV7l+nRYNfSrmYj68tByBVjej4k0+yZ3AKyqNn3b9oQD0Kf3OeCMLv+6lxuzg7NFkxtTsCox1caDm5x2MPjq1wFDU27hUey84HTScu/A9sWtSy8fC6mE2rZ74VdtwaNb9LhsjOZTpWVv8cjcluxNJmYbM/N6+Q0A0On12Vf1KOFyBHmn+xYMK2Bxu8VA9e2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 1:01=E2=80=AFPM Kees Cook w= rote: > > On Thu, Apr 25, 2024 at 08:39:37AM -0700, Suren Baghdasaryan wrote: > > On Wed, Apr 24, 2024 at 8:26=E2=80=AFPM Kent Overstreet > > wrote: > > > > > > On Wed, Apr 24, 2024 at 06:59:01PM -0700, Kees Cook wrote: > > > > On Thu, Mar 21, 2024 at 09:36:22AM -0700, Suren Baghdasaryan wrote: > > > > > Low overhead [1] per-callsite memory allocation profiling. Not ju= st for > > > > > debug kernels, overhead low enough to be deployed in production. > > > > > > > > Okay, I think I'm holding it wrong. With next-20240424 if I set: > > > > > > > > CONFIG_CODE_TAGGING=3Dy > > > > CONFIG_MEM_ALLOC_PROFILING=3Dy > > > > CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=3Dy > > > > > > > > My test system totally freaks out: > > > > > > > > ... > > > > SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs=3D4, Nodes=3D= 1 > > > > Oops: general protection fault, probably for non-canonical address = 0xc388d881e4808550: 0000 [#1] PREEMPT SMP NOPTI > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 6.9.0-rc5-next-20240424 #1 > > > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 0= 2/06/2015 > > > > RIP: 0010:__kmalloc_node_noprof+0xcd/0x560 > > > > > > > > Which is: > > > > > > > > __kmalloc_node_noprof+0xcd/0x560: > > > > __slab_alloc_node at mm/slub.c:3780 (discriminator 2) > > > > (inlined by) slab_alloc_node at mm/slub.c:3982 (discriminator 2) > > > > (inlined by) __do_kmalloc_node at mm/slub.c:4114 (discriminator 2) > > > > (inlined by) __kmalloc_node_noprof at mm/slub.c:4122 (discriminator= 2) > > > > > > > > Which is: > > > > > > > > tid =3D READ_ONCE(c->tid); > > > > > > > > I haven't gotten any further than that; I'm EOD. Anyone seen anythi= ng > > > > like this with this series? > > > > > > I certainly haven't. That looks like some real corruption, we're in s= lub > > > internal data structures and derefing a garbage address. Check kasan = and > > > all that? > > > > Hi Kees, > > I tested next-20240424 yesterday with defconfig and > > CONFIG_MEM_ALLOC_PROFILING enabled but didn't see any issue like that. > > Could you share your config file please? > > Well *that* took a while to .config bisect. I probably should have found > it sooner, but CONFIG_DEBUG_KMEMLEAK=3Dy is what broke me. Without that, > everything is lovely! :) > > I can reproduce it now with: > > $ make defconfig kvm_guest.config > $ ./scripts/config -e CONFIG_MEM_ALLOC_PROFILING -e CONFIG_DEBUG_KMEMLEAK Thanks! I'll use this to reproduce the issue and will see if we can handle that recursion in a better way. > > -Kees > > -- > Kees Cook