From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC57C4829E for ; Thu, 15 Feb 2024 14:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7C3F8D002B; Thu, 15 Feb 2024 09:58:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA118D0013; Thu, 15 Feb 2024 09:58:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4C508D002B; Thu, 15 Feb 2024 09:58:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9EC2C8D0013 for ; Thu, 15 Feb 2024 09:58:58 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 77435A2986 for ; Thu, 15 Feb 2024 14:58:58 +0000 (UTC) X-FDA: 81794345556.02.78E841A Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 8485C4000F for ; Thu, 15 Feb 2024 14:58:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="woRbq/tJ"; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708009136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tw/wN6EwhF1l4GL2nZ/ht1qejqJOWh5ecVMENBzDBDY=; b=MP9KH3oADmYcSRgiY+zvNBFuhdgonCP93hKeBHSVdFjdf1gkXwbgF0QZ7JKoA+p0rXv8pN FxQtt71p+elfc+oGJlT5B6IYCYu40PuHOCl0tjjzQiD42BVaNAd7cL/7bud/E6JiIapImB 0+ETrMZgu3rka82w9DOh71kn+bLwLJY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="woRbq/tJ"; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708009136; a=rsa-sha256; cv=none; b=CuGIErRNzbD1JaTKvBhmTyyVCn+7bS66ZqN0p8AjYyAEyRSmLZMmgK+9qRV9QnUgj0C9P7 uFYMptN5FnNKjp7bacqfXLo9PngQhFAFDMQJB8hyNAYInMgPIvk4KQCrYwa21Ys0JovEcv VIPjAnAfZf8P9kdkCIl/69nsegxx/mQ= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dcbef31a9dbso664663276.1 for ; Thu, 15 Feb 2024 06:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708009135; x=1708613935; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tw/wN6EwhF1l4GL2nZ/ht1qejqJOWh5ecVMENBzDBDY=; b=woRbq/tJ6GA+D73VG9a5vSNMBW3U8octWfujGksF+m+iYPUpP2FmGU5EbMQRkj7UJf qbB4nk0fRWvCFh2E7kcsPSBeENPwA0c3NgO6+DaUiXw8h+r5m5yStNohyGR+4aRfTqi5 Uya23fTmaxVysedH2oGzQ3saVwjlPWCOmuD/ztMlIF0OuWhyvYfcAxMJ3hFedrVqmwGX JrFifXrPRjGrtvK5t40KEEmcBmYZQPxwTakLQ7Nb9qjL9R3yM/Pk3GZYVRJRQQoy6oKJ RWSK29cNO9Dapc4zwfJDQI7MIAtdTlm4me5sqJ4iRnsEk/jUSjJbzghF5KKNjC7jMFIL aKag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708009135; x=1708613935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tw/wN6EwhF1l4GL2nZ/ht1qejqJOWh5ecVMENBzDBDY=; b=VTOfs8X2zBpNKj8QKVL7rnMGFcm5/rDEGuwePKaeh1kGRunfDoYGtRoOZS8OXW/nmh ++FUUnRQooqBof77NXuwb2HhHHddim22rRA+bYMZiXw66xQNEQonacoRoi6KIbUXpI7n Ys6GmiSlXVmmuAMvGGbwJnkc67PbFBrm/LuPx3hH1sGaZ++9RuC9gtjwlFAVe2ZD0zpr rxnz6Qs4mcEFItzMv/msW5GI7Mg92lMUO+XP2WJFNJDbVyHX6UoKr1q8DrOa6OnzTLHL T4EDDCmqR6BUgthcZ1aDlzfCo4k2Pon/y0msRDcT+g78kEC/JDyxAIiuRPXq8xz52b4A cVgg== X-Forwarded-Encrypted: i=1; AJvYcCWAtmEOMUZUwp8jcSevuvrbOJRwxqe8Ekwoyf00tw2Xkyn0x/hTRxbuKpU4xJz9Rf0y7L8qUXwpmL9cqTNOLk/AOcM= X-Gm-Message-State: AOJu0YyRl0bz0mpryD0GuP0V4OzcbIKxyYkJ1j6k+3UuQfXeVtqFQE6l 7gMRRmRGs4ifZAPkPkVw8VQd0rh/MY7hGgsUN+l7UESlJ0mtkhr+nc86lHrkAs1Z/W4Wh/SaYN3 P6EjKJ+cK7Lku17KiopUqtu82ziqLOf1AiGCZ X-Google-Smtp-Source: AGHT+IHbdGXWcfbi3sM7zNcX3xbLXT1pZZDBplduLx68NqKeXRGL2TAUM4SLA4O1Gc053VxRA9U/P0Ad1H3i0YzTDwI= X-Received: by 2002:a25:8750:0:b0:dbe:9509:141c with SMTP id e16-20020a258750000000b00dbe9509141cmr1821330ybn.30.1708009135319; Thu, 15 Feb 2024 06:58:55 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 15 Feb 2024 06:58:42 -0800 Message-ID: Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() To: Michal Hocko Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8485C4000F X-Rspam-User: X-Stat-Signature: yoheq68srdaj5p84wwuf6aqtgjum36xn X-Rspamd-Server: rspam01 X-HE-Tag: 1708009136-580249 X-HE-Meta: U2FsdGVkX191X4fzWOVaHpVAtO4ylB5DYI1mfNQPXD/TfrrGY5ORfQJee+92ttn6QZ9cDdmOoYxe3+5POxj4F8sdfjDUpbXitfK+0BbsoI9PxDf7IaqzwbcIoQQ1Ic3qBiNZxlMH7f1i1mC+cjQ/aOaq92j3W7S973MnMgJH9Opi+ELNcAzo74A1M/4E2HskShEIromQE7YAPJUDLzcj5sCH1JCo4etZn5G1pC8794rv6H9Khjgw64JLMF5iSub0prD6Xhxuri3j0S5U0fyX1UqVBbjUiK2eElB2yVcNiIgncKD5EaoKKX5xKALPHlpCypKTVTGmQWQF7jsjSwqE40NzCjld5ILcQiVpDT8FfSp5ctH67Lf4fMNXVZnxkiK0Icc4TgclronZoMG7nDU06vPDUJNWYlhsvZse65CCfa9KM5lvZJwAs1lOhYhABiINxd25PERZ90aOOIqK4y0Ix/iWeNwSrNWxNADhJxByfsUwQwnwxZv6iKNrvyhKdoRgH4LA6k4DHiuLoXqWgyV8eCZadlpl2T4re7pZCcZ80hdqilnmDO16b8sBojFvxFhNJDGsxJXYVVfaJ/s6zqJy93m7Ux3Pq1ry63qdvwFBFRciWch5w1e/7EbAyBfWSafThkqj6InJwI2aiAkxq7rau3T9oPaIAHimgCPvuxkf330nbGJDH98lKalNQ3+NX1BJWFsVvACxklLfmD86+r3ldsRIF7VfPJ3/8jsrngDgx9Zs7G2mkHlYKsQ7xhznbJfWU9OQB537LYbi2/b9IS8ubg3wN625lFKpuD+/5k7Llp3qaGvIzRB4OoMqlkTtPE3QT7empQyVSRId3dxqJshiKNcs6DV438bKXxSdq41Ux9br1eKK+kFtJ5VAYsOFGTb6+Fh+zGqhWQ3dq6B49ylNrBhpd3IK7Dx4jNbN48aQ4ZUpK3CKlrf6n8s6N6DWs0+G0TLqGS/Zsqekx5TaLvm whdCibYG hSdm74ZXtm2/h8mEQmPOdV57w/DpNVvKadSQJLzBJo/AGef62k6Km0ttZF/sPqYAEllIQJD0FzuhigSAp5Y7ywjACv+f8uUBD7mE/ghWXR03DXfvIR3BuLMlU/RGYWFzwlYe+nVBCBlLlGDdrl4bL96yPRsc5/NfVnEmYDQB5dqQ/foZm1aHlrn2scOFV0t1Cp6GJYr0GNUjh1KX3dXVqx/A71YuggMpcJGYme+hKPkm13N/NwPXImwgisSnLDq2sBFhDE45bP77uZAlAztqzpIBwG5FI9cnoBCfTHhunntXXQhUlg2xeyI3MtQCXBTFiqaYm4ESYf0zv81mL3F4ELxKQPiK9joRnGnNsPtUZ04okpKfgiuJtSel7tGpP4U5+gcnKQ6dt2dlClaSZwcp23a0o2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 1:22=E2=80=AFAM Michal Hocko wrot= e: > > On Mon 12-02-24 13:39:17, Suren Baghdasaryan wrote: > [...] > > @@ -423,4 +424,18 @@ void __show_mem(unsigned int filter, nodemask_t *n= odemask, int max_zone_idx) > > #ifdef CONFIG_MEMORY_FAILURE > > printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_p= ages)); > > #endif > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + { > > + struct seq_buf s; > > + char *buf =3D kmalloc(4096, GFP_ATOMIC); > > + > > + if (buf) { > > + printk("Memory allocations:\n"); > > + seq_buf_init(&s, buf, 4096); > > + alloc_tags_show_mem_report(&s); > > + printk("%s", buf); > > + kfree(buf); > > + } > > + } > > +#endif > > I am pretty sure I have already objected to this. Memory allocations in > the oom path are simply no go unless there is absolutely no other way > around that. In this case the buffer could be preallocated. Good point. We will change this to a smaller buffer allocated on the stack and will print records one-by-one. Thanks! > > -- > Michal Hocko > SUSE Labs