From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47312C5321D for ; Mon, 26 Aug 2024 19:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA7BE6B0085; Mon, 26 Aug 2024 15:07:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A57E16B0088; Mon, 26 Aug 2024 15:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91F0C6B0089; Mon, 26 Aug 2024 15:07:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7437E6B0085 for ; Mon, 26 Aug 2024 15:07:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 379511C5339 for ; Mon, 26 Aug 2024 19:07:44 +0000 (UTC) X-FDA: 82495330848.16.7DB92C6 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 69A30140018 for ; Mon, 26 Aug 2024 19:07:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UmKJhOhG; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724699243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7rPuT+GJsYPFao+5rq3DRvTvjZuIBMa12VKy3PtmhCY=; b=L9T4xGp0frZNrQ7CFYk3U0QJHHL/+sREh6cVxt/5+zLoZJHy4wZxOYw+D119yWOyeeaUZw LAA7M8cGcN5kJQz6YfEgZQoNQZieDxU/cPfbCYX9C56wO8ms8loQxRBVR32DZNkc7aUTke iS1MDA6EiW2cJtoEy8/N3ujz9uy1bsI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UmKJhOhG; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724699243; a=rsa-sha256; cv=none; b=gQBT8wzCYzRMBgYedmgG8HI6wnTyek660nnJsKPy3DvhDvBY4lZuzjckBkf8Mua3hIN0HG NkfRh5IibC3H2BhdCnDO34l6U/n/oN4wXCy28lzRxjFQNiJrKima0FW+C76c9Beb68ZYdv PmL/JWINJvCyM99s6e6kTySArBJ8c34= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4518d9fa2f4so62031cf.0 for ; Mon, 26 Aug 2024 12:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724699261; x=1725304061; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7rPuT+GJsYPFao+5rq3DRvTvjZuIBMa12VKy3PtmhCY=; b=UmKJhOhG4D3iTsafA98zS8+lb/2IPEyhCIAN6Z8YlQgO3KduL1QVBUOsa14Y7VvLuO SwOoGF2gkn4eIoaf3whFlg/UFwMEwBeMEJahQv017CXCyR/xVI/Fd8lH68qKmGMywfXU CJQQU3SbpfX6zcAy5Tc7KpChJ+aLCm65sIWJjyusbSQzC/WUi0hpo7dIVA23arvb4Pg8 LECILBparDBEWahUqPx0qPqmGJ3N6KaK52pq5qF91T0BUohxQnkzwnGhL5Jw9kIWatjg 155Ul08O+NwIv65FtfHVu0Ce5CNp1/ZMrHGqYtBq3P3ZMNPK5Nxp4vRejRAPL2CR4iD4 tZww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724699261; x=1725304061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7rPuT+GJsYPFao+5rq3DRvTvjZuIBMa12VKy3PtmhCY=; b=iQOk0ebHNbbr6TwlMSvhGxFcYbIWJLeUN9LCks06WD7x0D5x03g704Z2H4DK2cYnsq Bzeb837pTI8qysuOwD0yu6x5kILvIYhZAkKERaKSqt/rnotmddXckAi1m3Etpv/z+yyb AZfDY9w7oISuFPcdcqE6EMmZLJahay6laTXefduwrlFyyuOpuvl+/8csfSVunhhQvd0p QtYTDei7+nMGKuCLN5xs7CuXODXL5ScIZ9mcuokF9U8m2Dt9gblixyLMKWT9nQb5wkeZ Y0ZESN6bERL6kxQ6YLbA05y0bQ8CiMhhS9ocJrzkYQq3riUdsF8uSsnczYkgMTTiJX08 yqGA== X-Forwarded-Encrypted: i=1; AJvYcCUjqlXrGVN7IHjvadGrmxmANb50/IvMBs3mnZRB8JgwmI3E7141BC2Wr9YZD/L9/0bigprJxq8eBQ==@kvack.org X-Gm-Message-State: AOJu0YyT74SL1gT6nCXZ5mLZykOO1cvJE8Ty/BTqQKr/VKk95zP0qn3K uwC2iGaHMs2CQnvWpyAKNCk0cxAPtZjloBYCLeC1CrjZ8n7tW27TajIb1y2Cj1o+e3yltXwIueO XqWnFxDX+LqzRAS3T11J0CJ/Y9WiUYZ/+zYqh X-Google-Smtp-Source: AGHT+IFw0j5SlfzJrOxUT+ehixWHMOE6ne2a3tGOBDku0BVzObIQKN02nnM2qnlMirn/Y4UEd44sY83CtZa0FIYA7k4= X-Received: by 2002:a05:622a:30f:b0:447:e0e1:2a7b with SMTP id d75a77b69052e-45661e33c0dmr320571cf.23.1724699260988; Mon, 26 Aug 2024 12:07:40 -0700 (PDT) MIME-Version: 1.0 References: <20240825163649.33294-1-hao.ge@linux.dev> <8e052e52-4c8e-279c-bcd4-3c4cd1325bdf@huawei.com> In-Reply-To: <8e052e52-4c8e-279c-bcd4-3c4cd1325bdf@huawei.com> From: Suren Baghdasaryan Date: Mon, 26 Aug 2024 12:07:27 -0700 Message-ID: Subject: Re: [PATCH v2] codetag: debug: mark codetags for poisoned page as empty To: Miaohe Lin Cc: Hao Ge , akpm@linux-foundation.org, david@redhat.com, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nao.horiguchi@gmail.com, pasha.tatashin@soleen.com, Hao Ge , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: u7ms4sax8gzqq88kjcd65g6n8k5t64ap X-Rspamd-Queue-Id: 69A30140018 X-Rspamd-Server: rspam11 X-HE-Tag: 1724699262-383496 X-HE-Meta: U2FsdGVkX19GnP2jpKvUrryjTZ+x47nCu7lFwGS+yZckgQe4eq9tJO+B33sR3046l7TQmToQrx2o49sEEUhI+FyUJe4uTCYigDDuUNLzy20Kn5BMsNaW8d16Ad7H2Q2S5c/eib72FhnBFjfyX+ae7ulTVQzfvs5j75VfjkxIv4f9FhDn8rBQZ6RLM82GkO3TkPdolqoeaPVf89wo+d86akgN70IJyiK3GEMbJP61DnDcQhCLzpjyK9iEgj9T0x4xNX7me1vOOf4m1fGCOLTFNhCSDgIu16xge+l4nI1+/zml9hx74seEkJpfPN/LRb87Mh7uyz2E7RSvd5Ld3IBb/iMsCMSQRcMIh8EAvSFlZuELv5xv8imu/YLPuWODCXhYk6/K7pFcwphciGnq/uv1li+Yp689iyq6xUhNaWbKRqjNaybLMp9i/IY/upA6dH9wYdDPrkWVUpYgjix9q+hIKVX3+6CRVq1QWPMVZBoh7HP5u9FVUkBcfdhCxtND0/EY9cn8N5SgmFmIJjGYk7Og+g2kv5yAMQSxP8cJaRWeZXamiVJxkeQU/DJ6NSaHXXskzowXDwc3QHHG9VxJ/MuRU9VZdmHZhsAJuQsNR9M32W7DQcS/XxoFSy1e9Eh3cMUiqTJ82mEwDsZE5oe6aJeS7rJ/rRW2Ug4BKVQgsw19Tz/rvHw5S/He4jLCyjstywu9Ixo3pmz097MCzrA3qP4LI5de64JAYu2gplbBQpBTyH/ASJtYCmXaI70z6DvD8JBPgNONQBC3v401aNQNeUnuTYbc8/CgqKgcblNceVBV3ai3HJ5LWHkNQCub2GYc/NZOGBhYR0dF0nqUGry5x1HgcWtFZ2EMiIou3g0fYj0KLKYHiQxU7+bFPbXW1uEb9/JL8QqvhH+qmSVdZXovI7R8RdMEp8qG6YA6B90nAbl2sak5s0vpJgQCDkRBnAMJ0QrkhsFcBIcXXnPtdQAkkpe T+g9cqI1 ROjB1YxoQTwHfnYoem/u9C3kPecmnqu9miaDrBRHqK8IQ0Kxa1LQLuSTQYC1WsQpgY/Mm+cdH5aeuGsEUadizvKNe60G/muFoYFjGSLK+10D4Jz/qtD86IyPAlALq42t9pfqBOcVG1dusY40mRMQjTAle8vlnPyns/+/T59kuJrS5RgiDGe0BNH693sXlMVvphKtvSg2V0RlGM0MDKzJ/N5rJhxJOxDvwQYtflii6qLnvq8IZk2qwEe+bQo7Qh8jgTIIxSkZ9ydEzZwscT75IGMg/DN+RnWG1inSOJLTSoBwuIoaKlxw7YscaErdg7XgjuiFEgFTktDgiGh6EV2i1t6w5Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000107, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 25, 2024 at 11:32=E2=80=AFPM Miaohe Lin = wrote: > > On 2024/8/26 0:36, Hao Ge wrote: > > From: Hao Ge > > > > When PG_hwpoison pages are freed,they are treated differently in > > free_pages_prepare() and instead of being released they are isolated. > > > > Page allocation tag counters are decremented at this point since the > > page is considered not in use. Later on when such pages are released > > by unpoison_memory(), the allocation tag counters will be decremented > > again and the following warning gets reported: > > > > [ 113.930443][ T3282] ------------[ cut here ]------------ > > [ 113.931105][ T3282] alloc_tag was not set > > [ 113.931576][ T3282] WARNING: CPU: 2 PID: 3282 at ./include/linux/all= oc_tag.h:130 pgalloc_tag_sub.part.66+0x154/0x164 > > [ 113.932866][ T3282] Modules linked in: hwpoison_inject fuse ip6t_rpf= ilter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_conntrack ebt= able_nat ebtable_broute ip6table_nat ip6table_man4 > > [ 113.941638][ T3282] CPU: 2 UID: 0 PID: 3282 Comm: madvise11 Kdump: l= oaded Tainted: G W 6.11.0-rc4-dirty #18 > > [ 113.943003][ T3282] Tainted: [W]=3DWARN > > [ 113.943453][ T3282] Hardware name: QEMU KVM Virtual Machine, BIOS un= known 2/2/2022 > > [ 113.944378][ T3282] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT = -SSBS BTYPE=3D--) > > [ 113.945319][ T3282] pc : pgalloc_tag_sub.part.66+0x154/0x164 > > [ 113.946016][ T3282] lr : pgalloc_tag_sub.part.66+0x154/0x164 > > [ 113.946706][ T3282] sp : ffff800087093a10 > > [ 113.947197][ T3282] x29: ffff800087093a10 x28: ffff0000d7a9d400 x27:= ffff80008249f0a0 > > [ 113.948165][ T3282] x26: 0000000000000000 x25: ffff80008249f2b0 x24:= 0000000000000000 > > [ 113.949134][ T3282] x23: 0000000000000001 x22: 0000000000000001 x21:= 0000000000000000 > > [ 113.950597][ T3282] x20: ffff0000c08fcad8 x19: ffff80008251e000 x18:= ffffffffffffffff > > [ 113.952207][ T3282] x17: 0000000000000000 x16: 0000000000000000 x15:= ffff800081746210 > > [ 113.953161][ T3282] x14: 0000000000000000 x13: 205d323832335420 x12:= 5b5d353031313339 > > [ 113.954120][ T3282] x11: ffff800087093500 x10: 000000000000005d x9 := 00000000ffffffd0 > > [ 113.955078][ T3282] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008236ba90 x6 := c0000000ffff7fff > > [ 113.956036][ T3282] x5 : ffff000b34bf4dc8 x4 : ffff8000820aba90 x3 := 0000000000000001 > > [ 113.956994][ T3282] x2 : ffff800ab320f000 x1 : 841d1e35ac932e00 x0 := 0000000000000000 > > [ 113.957962][ T3282] Call trace: > > [ 113.958350][ T3282] pgalloc_tag_sub.part.66+0x154/0x164 > > [ 113.959000][ T3282] pgalloc_tag_sub+0x14/0x1c > > [ 113.959539][ T3282] free_unref_page+0xf4/0x4b8 > > [ 113.960096][ T3282] __folio_put+0xd4/0x120 > > [ 113.960614][ T3282] folio_put+0x24/0x50 > > [ 113.961103][ T3282] unpoison_memory+0x4f0/0x5b0 > > [ 113.961678][ T3282] hwpoison_unpoison+0x30/0x48 [hwpoison_inject] > > [ 113.962436][ T3282] simple_attr_write_xsigned.isra.34+0xec/0x1cc > > [ 113.963183][ T3282] simple_attr_write+0x38/0x48 > > [ 113.963750][ T3282] debugfs_attr_write+0x54/0x80 > > [ 113.964330][ T3282] full_proxy_write+0x68/0x98 > > [ 113.964880][ T3282] vfs_write+0xdc/0x4d0 > > [ 113.965372][ T3282] ksys_write+0x78/0x100 > > [ 113.965875][ T3282] __arm64_sys_write+0x24/0x30 > > [ 113.966440][ T3282] invoke_syscall+0x7c/0x104 > > [ 113.966984][ T3282] el0_svc_common.constprop.1+0x88/0x104 > > [ 113.967652][ T3282] do_el0_svc+0x2c/0x38 > > [ 113.968893][ T3282] el0_svc+0x3c/0x1b8 > > [ 113.969379][ T3282] el0t_64_sync_handler+0x98/0xbc > > [ 113.969980][ T3282] el0t_64_sync+0x19c/0x1a0 > > [ 113.970511][ T3282] ---[ end trace 0000000000000000 ]--- > > > > To fix this, clear the page tag reference after the page got isolated > > and accounted for. > > > > Fixes: d224eb0287fb ("codetag: debug: mark codetags for reserved pages = as empty") > > Cc: stable@vger.kernel.org # v6.10 > > Signed-off-by: Hao Ge > > Reviewed-by: Miaohe Lin Acked-by: Suren Baghdasaryan > > Thanks. > .