From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B808CCD1284 for ; Thu, 4 Apr 2024 17:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22CD96B0089; Thu, 4 Apr 2024 13:09:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD386B008A; Thu, 4 Apr 2024 13:09:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07D416B008C; Thu, 4 Apr 2024 13:09:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC3546B0089 for ; Thu, 4 Apr 2024 13:08:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ADA1120606 for ; Thu, 4 Apr 2024 17:08:59 +0000 (UTC) X-FDA: 81972484398.09.F13A95E Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 99417A0003 for ; Thu, 4 Apr 2024 17:08:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BxTWBCtF; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712250537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KuDs1drwJi9Z+z9OuWkhK3ckPKS9r4/p1uVUkFqevFk=; b=uvaM88As3aPltXwuAcYmaKEK7+eqdKivXyOsDRcSnkm3l9xDMPAnKfOrazs+HF8I9TLuGd SXr/pWRk13icWQudnxcvvoBRcONdskcYBZ27LLD/nWIWelrrQ0DrkQSXTaf5Gc6dybhGR+ WtlLdVpOE5uonznA1ko64gZFktI4hGo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712250537; a=rsa-sha256; cv=none; b=Uo8fN7GmMRbG7S0UGhgxz1kntViVh/Fzcwq/6/7M15fOohIpIa5TGVLOs1i/kK5r6SUBlA dkCPMByoy3R5Ko+hhsEmNpD60Y+a50wzWx1+N+MN8ZGcAlC0yf4XVbC+q/xWjo6VWTRIF/ zvvvYs/WCsDVCk0kLe26eXCp6LDG5bs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BxTWBCtF; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-dc236729a2bso1238400276.0 for ; Thu, 04 Apr 2024 10:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712250536; x=1712855336; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KuDs1drwJi9Z+z9OuWkhK3ckPKS9r4/p1uVUkFqevFk=; b=BxTWBCtF+ZLpdmdufSXqAQNbPNIEK3t2L3zDnLkXlQR7mA4mCkM1l7sha945j3LqcI qI5AHKJSDu1idrCErr+dreoQ/Lc10xm4Q0uS2zWqwFXtytXlOOCw9LL9N1+Ez9cCbN+m pcQufBOq7v03k8R7t9o6BMn44ru/xaoOgFyifhgLtFRaCQtlaOYSwuDVfXbqEYiVfyJw FAdyQ4YDXdYHHwErHpIaVKmgYbXPzaO6a+OL7hhTAIc2lWwEOBQUxH3ndw1sjae7w6Pg U6QzdPx/58zc/M+PLmakQj3DUzdx+5Kya+aC5oIF+q1/woCzrSJHl0e4ZUNNwGQP/IwO UAsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712250536; x=1712855336; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KuDs1drwJi9Z+z9OuWkhK3ckPKS9r4/p1uVUkFqevFk=; b=H3KMncl85VpWNLZH1DsOZgLlWFia1c9UeqIOmz924Bj3Nr1tKKK2aSMim5v4RizqWB xH6+pvrJaeoW2s73buZdszau4a07wqQarZmlFrjESNhpoOs/P9oFziN52WSqlJyTCa1B OKMk1cTimYFYmPS93gmVJJ/+Pfx8Do92Bt77p7IdNBJ9UutMmJH16cFpwRAQmr2SgK01 OzDEL76RNJsLfjH8U+8SK2WZXZa2XF7KmN7f9mX3ZwuwiIM9O4jLQIbjJiSSYw9/4QuV 94k1aTz8OETVgxSX8RPDOtuDUiDaNnpI4jGpMNeMPcmNHVho6UPQzPfQR+X97LRXKc56 BC9Q== X-Forwarded-Encrypted: i=1; AJvYcCVFhlgN3niQKgMNk1XbBuMGT5eTX/zHd8VCm1AZtQSI/QPEtK9eQTOpQDZREjPsBeTu8/r+Nlq2dCwmpX4/aGiz6bE= X-Gm-Message-State: AOJu0YxxBuT5fdi07KQpaSDhu6U1YQ7C/ikTJ9NDWc86aAU0BOFc7LmX qZkZwQDZk4SQBn3VB8mTdVvCqATtNbdss0rBCj6m/frCq6UB7aFSvtKMI0jXGsT3xPGONDbOXGT P+asdanO3YbLSAiBoKxZBkWjNejD7gKppqHgi X-Google-Smtp-Source: AGHT+IFt2ASldzAexjX0sPM2NMrH0Lqtd66mUXGVX9ZgF2XSVZKC+BEFwLxb4crFlAjVgX0qYdICDkkyaJeo+de/1Hw= X-Received: by 2002:a25:ac19:0:b0:dcb:b072:82d5 with SMTP id w25-20020a25ac19000000b00dcbb07282d5mr3065164ybi.64.1712250536330; Thu, 04 Apr 2024 10:08:56 -0700 (PDT) MIME-Version: 1.0 References: <20240404165404.3805498-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 4 Apr 2024 10:08:45 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm: change inlined allocation helpers to account at the call site To: Matthew Wilcox Cc: akpm@linux-foundation.org, joro@8bytes.org, will@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, arnd@arndb.de, herbert@gondor.apana.org.au, davem@davemloft.net, jikos@kernel.org, benjamin.tissoires@redhat.com, tytso@mit.edu, jack@suse.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, jakub@cloudflare.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, kent.overstreet@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 99417A0003 X-Rspam-User: X-Stat-Signature: onymddxrpc5jtqkod449w7r7hp61t74t X-Rspamd-Server: rspam03 X-HE-Tag: 1712250537-123017 X-HE-Meta: U2FsdGVkX1/MrWsZ8b/KBNrKqYxRPHZEdsACw5YCnVT4Asybug/2R8Zihp96+uxHHb5cW0bImJ+pT2iPUVozLeGmJXtDhT8L551B+tLu8KV+b00rBjDB408JgMyyweuUJOpY4+7QSkXfy3rjLLkRtx3NCziM0rl63VykNPLJ5raY9qgVdgyaf4Jz6Y93Xo2nZKS/56bAUMXAEd1G2AeoKHCFxRLJFGjt4qKFAXRJAACBS29HT0V0N8jAb1Mef9xKEJjhcU7wQlV1qgxbqJtw8Y+JcTkssfLs2czmZOIH6dPBfQA25B5bf0w5B87Idt6cfqe9A3N0ouCYzeM2ZeFRUlNISbnBf7cEOrB533UvYMz4DLH4JPAam1Q6+hxsRCJOoQ+RUKe9WFWWwsODrM57YZa64KR0Wyp2wS0NcbNdC3VFi3RIf7hl8Ot+aglWqjgIbIl+DGRVQn6wpEoQZH6NCjCKZEdLjs68A+t09jVZ2fuLh6Cq+M6iQmr9FLEqjVppiAQjnFX5KEzuLIaW4FLWzeWBfmmfav13r+ktG8tzdrG8OaxSUDb6Wo1cPYYADuWw5gj+HDor1l1sDEOjmXjyOJpeYM9vRAy13qNf6+IFz5AajTzG7EIH6xKXNlfQmO8Z6bfPFz8fJTqsoq8X3JSXXsfJ5W5+Tr3gMh1dPiUBZDaEK93t410NhkDuuvo4F/Fi1osnPzMVXwaBLPgNmQeN/CrvNexN56aiq9M7MaEbLr7zIsjxlxtGQ+cjE34h+APqPYMrDoYgl6UUHE1mky6Enarrl50abRpAC1NlzxJ/3yDT8p1qQXu4udKHjRo8eGaWJ06lepLL3iuCHsevs1N71DREdO4xRwHg304tj5gmrm5M+1HuifKjEGVkz6YhPRUYK+J53I4NFiGUHfoXP6MqOh28gZ/NkygQ2sDlM3gR7f/3F22uKcHWFKMUShlhcg2VYbLQIGFfGDeES9Ib1yu uZm65nf/ sXz5P+tokgPGLL7QPL+X8sdZpYc2LUgtGKy/uLARZZHmyiyCOp+Pp2I8WcWzDHeAVGzz5LD/AONPgVlhK3mLecRtfjjKfP30Kmwg5lBgNoTmT/b8lbmitmoNJVxG+lyi00cdmk5z7RIYH7YE7JsFWrwuINqmSbXbUflopSpNls/kVeruePvqFfrOrXanJk9uQUdVjEUBmPqiQo4BfL4HlbIDOvxSguhdoeXVYMDKyt4J/XFw0L5VF36UrFPtLTRebpvaZHx/cOseWli818ZmADDv582Jzd3BYWfqu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 10:04=E2=80=AFAM Matthew Wilcox wrote: > > On Thu, Apr 04, 2024 at 09:54:04AM -0700, Suren Baghdasaryan wrote: > > +++ b/include/linux/dma-fence-chain.h > > @@ -86,10 +86,7 @@ dma_fence_chain_contained(struct dma_fence *fence) > > * > > * Returns a new struct dma_fence_chain object or NULL on failure. > > */ > > -static inline struct dma_fence_chain *dma_fence_chain_alloc(void) > > -{ > > - return kmalloc(sizeof(struct dma_fence_chain), GFP_KERNEL); > > -}; > > +#define dma_fence_chain_alloc() kmalloc(sizeof(struct dma_fence_c= hain), GFP_KERNEL) > > You've removed some typesafety here. Before, if I wrote: > > struct page *page =3D dma_fence_chain_alloc(); > > the compiler would warn me that I've done something stupid. Now it > can't tell. Suggest perhaps: > > #define dma_fence_chain_alloc() = \ > (struct dma_fence_chain *)kmalloc(sizeof(struct dma_fence_chain),= \ > GFP_KERNEL) > > but maybe there's a better way of doing that. There are a few other > occurrences of the same problem in this monster patch. Got your point. > > > +++ b/include/linux/hid_bpf.h > > @@ -149,10 +149,7 @@ static inline int hid_bpf_connect_device(struct hi= d_device *hdev) { return 0; } > > static inline void hid_bpf_disconnect_device(struct hid_device *hdev) = {} > > static inline void hid_bpf_destroy_device(struct hid_device *hid) {} > > static inline void hid_bpf_device_init(struct hid_device *hid) {} > > -static inline u8 *call_hid_bpf_rdesc_fixup(struct hid_device *hdev, u8= *rdesc, unsigned int *size) > > -{ > > - return kmemdup(rdesc, *size, GFP_KERNEL); > > -} > > +#define call_hid_bpf_rdesc_fixup(_hdev, _rdesc, _size) kmemdup(_rdesc,= *(_size), GFP_KERNEL) > > here > > > -static inline handle_t *jbd2_alloc_handle(gfp_t gfp_flags) > > -{ > > - return kmem_cache_zalloc(jbd2_handle_cache, gfp_flags); > > -} > > +#define jbd2_alloc_handle(_gfp_flags) kmem_cache_zalloc(jbd2_ha= ndle_cache, _gfp_flags) > > here > > > +++ b/include/linux/skmsg.h > > @@ -410,11 +410,8 @@ void sk_psock_stop_verdict(struct sock *sk, struct= sk_psock *psock); > > int sk_psock_msg_verdict(struct sock *sk, struct sk_psock *psock, > > struct sk_msg *msg); > > > > -static inline struct sk_psock_link *sk_psock_init_link(void) > > -{ > > - return kzalloc(sizeof(struct sk_psock_link), > > - GFP_ATOMIC | __GFP_NOWARN); > > -} > > +#define sk_psock_init_link() \ > > + kzalloc(sizeof(struct sk_psock_link), GFP_ATOMIC | __GFP_= NOWARN) > > here > > ... I kind of gave up at this point. You'll want to audit for yourself > anyway ;-) Yes, I'll go over it and will make the required changes. Thanks for looking into it! Suren.