From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32E8C433E0 for ; Wed, 20 Jan 2021 16:58:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70586233ED for ; Wed, 20 Jan 2021 16:58:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70586233ED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CB1E6B0005; Wed, 20 Jan 2021 11:58:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97A8D6B0006; Wed, 20 Jan 2021 11:58:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86B426B0007; Wed, 20 Jan 2021 11:58:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 6EABB6B0005 for ; Wed, 20 Jan 2021 11:58:02 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2F58E181AEF3E for ; Wed, 20 Jan 2021 16:58:02 +0000 (UTC) X-FDA: 77726760804.14.ant36_5a03af72755c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id C43561822989D for ; Wed, 20 Jan 2021 16:58:01 +0000 (UTC) X-HE-Tag: ant36_5a03af72755c X-Filterd-Recvd-Size: 7258 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 Jan 2021 16:58:01 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id m187so3452446wme.2 for ; Wed, 20 Jan 2021 08:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rpcAZMiidkdn8kgbweSucunSZNfQr7y4sBDVK9pNMyU=; b=aSKdOyEfUZ7+nbgQG4Oz34S0QFBBEpe0NkmOUgkIRQmr7puRYU8XMppmMlQK5DGLFM 0GuKLRPRBMQvkzaw9QCBPnYJ8+Doyqjuf4weUAIPh7K2nTvy5Y9ipXkegUZc0/jbwYMN Z/+ys6EhiyqdFl1caKGMEH7NMXeQT4GVAjgw0ggJJUigQcSJWPWhBUTwagRzTm3SFNUF Vh7dMIiU/ZWLwWHovBCP7+kQOgS1da5mvzAOu1AlNAUshTtLvBSqJVGxkhVPe4yo++Nw +gq/kzv307e98VThRr81N9MAIin6nMYoBnx1wOuKtT9u50vzlv3s0hf29boUw909vpQv 283Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rpcAZMiidkdn8kgbweSucunSZNfQr7y4sBDVK9pNMyU=; b=LLU76mepvNbXqH3NSa1jr+05zElkb94WDJQMYJ4+IjhKDP0aE3+sokaWB5fBMcy2E3 PMNlC66V82ikPhIHWq1iqC12zq8W1Oqo46AHAVPpeEgxSG9dGYCEC8e5h2zvmJCcULyk xWyYKcqRJGQgH5Gk3leNq10qiU+YNd+XK7Uayqt5AEKJPGswuuUH/Fcd/Q3iqve6P3En UA6+4SFuofx1Rsia8fY2c5OXqGfmme7kEd2wF82kxke9BJclEdO2dQOGRrxP3Lhmj9Bu s1VyQZPB0QZ9MrgwNt46ztZD85uy4S5cvfp7IzdPXT463tAftBqJV9yQdPHaAOLe3O9k jlSw== X-Gm-Message-State: AOAM532po1gjzSKIc2K3uvNwpUzeG5p5PxfsdQVfUjoeZ8/hg8M58coP FC1MMxPEu6+4CxFkUZx80UnXqfumQNpzDRkZnxB3+A== X-Google-Smtp-Source: ABdhPJzk/tqIUvkT/+lRnqF2/87jws3xp9TGgijlSnku7fw8B2GOkgwDvPruEYich6TykilQINnAL5XxzzoViuhPoV4= X-Received: by 2002:a1c:98c6:: with SMTP id a189mr5184234wme.88.1611161879809; Wed, 20 Jan 2021 08:57:59 -0800 (PST) MIME-Version: 1.0 References: <20210111170622.2613577-1-surenb@google.com> <20210112074629.GG22493@dhcp22.suse.cz> <20210112174507.GA23780@redhat.com> <20210113142202.GC22493@dhcp22.suse.cz> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 20 Jan 2021 08:57:48 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise To: Jann Horn Cc: Michal Hocko , Oleg Nesterov , Andrew Morton , Kees Cook , Jeffrey Vander Stoep , Minchan Kim , Shakeel Butt , David Rientjes , =?UTF-8?Q?Edgar_Arriaga_Garc=C3=ADa?= , Tim Murray , linux-mm , SElinux list , Linux API , LKML , kernel-team , linux-security-module Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 20, 2021 at 5:18 AM Jann Horn wrote: > > On Wed, Jan 13, 2021 at 3:22 PM Michal Hocko wrote: > > On Tue 12-01-21 09:51:24, Suren Baghdasaryan wrote: > > > On Tue, Jan 12, 2021 at 9:45 AM Oleg Nesterov wrote: > > > > > > > > On 01/12, Michal Hocko wrote: > > > > > > > > > > On Mon 11-01-21 09:06:22, Suren Baghdasaryan wrote: > > > > > > > > > > > What we want is the ability for one process to influence another process > > > > > > in order to optimize performance across the entire system while leaving > > > > > > the security boundary intact. > > > > > > Replace PTRACE_MODE_ATTACH with a combination of PTRACE_MODE_READ > > > > > > and CAP_SYS_NICE. PTRACE_MODE_READ to prevent leaking ASLR metadata > > > > > > and CAP_SYS_NICE for influencing process performance. > > > > > > > > > > I have to say that ptrace modes are rather obscure to me. So I cannot > > > > > really judge whether MODE_READ is sufficient. My understanding has > > > > > always been that this is requred to RO access to the address space. But > > > > > this operation clearly has a visible side effect. Do we have any actual > > > > > documentation for the existing modes? > > > > > > > > > > I would be really curious to hear from Jann and Oleg (now Cced). > > > > > > > > Can't comment, sorry. I never understood these security checks and never tried. > > > > IIUC only selinux/etc can treat ATTACH/READ differently and I have no idea what > > > > is the difference. > > Yama in particular only does its checks on ATTACH and ignores READ, > that's the difference you're probably most likely to encounter on a > normal desktop system, since some distros turn Yama on by default. > Basically the idea there is that running "gdb -p $pid" or "strace -p > $pid" as a normal user will usually fail, but reading /proc/$pid/maps > still works; so you can see things like detailed memory usage > information and such, but you're not supposed to be able to directly > peek into a running SSH client and inject data into the existing SSH > connection, or steal the cryptographic keys for the current > connection, or something like that. > > > > I haven't seen a written explanation on ptrace modes but when I > > > consulted Jann his explanation was: > > > > > > PTRACE_MODE_READ means you can inspect metadata about processes with > > > the specified domain, across UID boundaries. > > > PTRACE_MODE_ATTACH means you can fully impersonate processes with the > > > specified domain, across UID boundaries. > > > > Maybe this would be a good start to document expectations. Some more > > practical examples where the difference is visible would be great as > > well. > > Before documenting the behavior, it would be a good idea to figure out > what to do with perf_event_open(). That one's weird in that it only > requires PTRACE_MODE_READ, but actually allows you to sample stuff > like userspace stack and register contents (if perf_event_paranoid is > 1 or 2). Maybe for SELinux things (and maybe also for Yama), there > should be a level in between that allows fully inspecting the process > (for purposes like profiling) but without the ability to corrupt its > memory or registers or things like that. Or maybe perf_event_open() > should just use the ATTACH mode. Thanks for additional clarifications, Jann! Just to clarify, the documentation I'm preparing is a man page for process_madvise(2) which will list the required capabilities but won't dive into all the security details. I believe the above suggestions are for documenting different PTRACE modes and will not be included in that man page. Maybe a separate document could do that but I'm definitely not qualified to write it.