From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A4CC369A2 for ; Thu, 10 Apr 2025 01:44:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DA126B029F; Wed, 9 Apr 2025 21:44:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9609A6B02A0; Wed, 9 Apr 2025 21:44:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DA396B02A1; Wed, 9 Apr 2025 21:44:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5C3A56B029F for ; Wed, 9 Apr 2025 21:44:13 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F3248121887 for ; Thu, 10 Apr 2025 01:44:13 +0000 (UTC) X-FDA: 83316438786.10.9379982 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 0BE1E100009 for ; Thu, 10 Apr 2025 01:44:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PX12Pfw6; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744249452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+yKC2x25bVW0SoAN6HnoHyxVhw374RFdKzdjCwoUfu8=; b=iPLDShYKAdC6caB+X6UfJsNrizbaGPJQ0NDyEiNT5lCcxYy5OIzZKACQRawtJl+wiQxuPR nSz83k/X0hLbA4fy91nRbbH56Yo0xDJKpLtVzlOh3nDyyxeM2iU0ruyK4jWaAu8cZmUG3+ TjT7s7e/l38jiA3X0JdfCf49xQI45wE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PX12Pfw6; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744249452; a=rsa-sha256; cv=none; b=uO519/rjV1j0UcYuEdhZ6feKpUq7Xk3/Dd2VYDhA9hkgHKASVZJMVcWcn1e3tgU9QTVeOD P3LFmsrCtdiL4VzhQXQjtOEfgvzWH9bwdB58M43eeNBWA3jKQRx7et5Smv1HoJp6Mo0rzc +eQZsQhxIVeJ/uQFq1WCGg8/SB4xcPg= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-47666573242so218361cf.0 for ; Wed, 09 Apr 2025 18:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744249451; x=1744854251; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+yKC2x25bVW0SoAN6HnoHyxVhw374RFdKzdjCwoUfu8=; b=PX12Pfw6u0yFWIbmCeEBaFzTFhwXY7vjyUCh3+F28mC4Ypv4dPe2FuCEeZcT3zcZRV xUprd7SpjiKhKynEyW2TCn4QhIEBd05LRNvR1lzH14/FSnc5lDh0PV/sXffd3o779J86 q92onhshsx8EeULl+fq4dnEVsLi+uvlSK3ijMqhvEKSQTFKve9VFiIj0ca8JSgStHiDp 1pGUPg6MXVHo3JR+j9Uj+dMkNOQPD2yvyMevg20byZpb2TvQTyMEXsLbJ1K1wggNOdQe 0d7ebqUjYqbC9hyFmJKuMpyUQa/69IYJgfnAxwLtZ7cQDx9DK6TjJ0TbhJcHwR1wIF+6 v9oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744249451; x=1744854251; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+yKC2x25bVW0SoAN6HnoHyxVhw374RFdKzdjCwoUfu8=; b=AQOEcbzxSCFZGA5Ec6rpkM82kYHknvZIyinO7vFBfQuys3TUIhBCef6IYjHfiKgRKW WpZfRN7dHOP3aXmqKXgV3OANcsMFftjdKGecR23LZJYZ3Y8wkDDeISYly/HqoYEgmPx8 JMsHrh6hjBwqmbcda+yv8rYCcHHsCAsCfnoP/F8GbUELyzkihyg+Ef6xHQw7w239BjJE ulFARfMS4Zqclfv8YFItlJ/1Uhf0OGqM40PyAv0h7vITU35M++q+xR1rP/1bSlLUZ2uo J8SKeyENJFFHjR8RSPdxFApKjF6liPMEoatpW98SAv/fEhLcnTybjAYWN/QATAMI5CZb JjLA== X-Forwarded-Encrypted: i=1; AJvYcCUx0qHws6ULNOYX44ioT/LgiEDfw+rbOBhzcs6LkztP+Co/wEd1lD2q99HyMBamPne1DNsku8LiQg==@kvack.org X-Gm-Message-State: AOJu0Yy8ov93GI5NES5TR+QmljD5OrnfP4eEt8xvasiQrZbAzKFjuKZI YTStNEktTh+cZbaEZuWskEs7M+u1rRJh/thX7YMFwbeEch+XiI7gT34MYRuXnRgMPlJbXC3J+9P PyKDAyW0lopaPt3p/2eDfE7wizjH5muhgYw5Z X-Gm-Gg: ASbGncu+3TmpD795qRQUVqQJkET99CiB9G2nW1E4Fk/1neWIhlLRIm84A8mlPvk5Djn 3lm9SPdN3qmRGgeNM63ag/mY7Qr+6gxn4mvHzHaCP/nxQvFySdL6GKAxPfNadzrT4Fb12W7dlKS /Zt+QMd5sTYTynOcB/QP2do/LxcUGh+2DkZGMyHETzEDnQbradiw== X-Google-Smtp-Source: AGHT+IESrymKJuTkp/I03vRZgFZ72FzhYfy+dsTbnH8e7Pmq5AGwBWMIRvEhzS8/iQ7gQ5+WMVfMQKM5+rQgNnDGf7w= X-Received: by 2002:a05:622a:1806:b0:471:e97c:512 with SMTP id d75a77b69052e-4796e30f1acmr546951cf.29.1744249450907; Wed, 09 Apr 2025 18:44:10 -0700 (PDT) MIME-Version: 1.0 References: <20250409225111.3770347-1-tjmercier@google.com> <20250409171238.494fd49979b4607bff9791b7@linux-foundation.org> In-Reply-To: <20250409171238.494fd49979b4607bff9791b7@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 10 Apr 2025 01:44:00 +0000 X-Gm-Features: ATxdqUHOCmT7OO26_qCJK3Nd5nKrvPZ2FhtaYhxc9Q1LkvSVmmzv0z_SFSzzVeU Message-ID: Subject: Re: [PATCH v2] alloc_tag: handle incomplete bulk allocations in vm_module_tags_populate To: Andrew Morton Cc: "T.J. Mercier" , kent.overstreet@linux.dev, janghyuck.kim@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0BE1E100009 X-Stat-Signature: agq7wtdt8ey8qogjhzbp44ufdpiyrbe1 X-HE-Tag: 1744249451-669497 X-HE-Meta: U2FsdGVkX19oObvXMbTXV8ohFlOmskH+TgdXAs5fl0eXXl+RmYWeHmMlR5FxwNSUbsbqo4qLUeOJ/sYZMNjpUwwiccto3TFbqUDhPjbPq4wSJXyJjYPawtqZpMjnFsuUfbjSY16d/Rnx4dOyZnifXq9mx1bJ4UNxB1KQcChhwsPaQoaCXV3GGZfVcWD83AENYzkGrzcsfMGpZ4nenXJxPIsgkFGr2XeRDf/csJy0yWliZyxPGbU3wN+YEx/n0ywAcpaa/Fu42rXVDH2GfzIrRo3aF9hKG89QxYwveIDnPGvx4jsM31RZ+JjP/pwk4zse9WV1auSKLUv2YEYKLPqiNdUVAJu/FL5YBhPsLlMBKIm/8cYYEwXmLqQyQ1SHLMkASeMtGwTczRb0OmyHtjMFFDWSPYLqlGZFDjQBDma12BZJMEBH2Yftu1MJc/8LIwXz97E+ygkVwJXEJYNfUQkpenumytdHc0U/xardbGzBvR8zN0A2Ux2CiEXbFoznny65jB4hcmTETG3iPo9NnrIepdavzVR+nbrFxsuh1jISp5zMnj0DNxTaZFdS7d7aJAIAzLkf9HVrtOVil2usUlpejTLrJY0TGDpb5TLbOJOil4BPS9U5X7qbFP31Pp9Kzdsn2+nK5kK6R+52bzfKc2FUc3EM0K5Gup4EHqWYT8uo8CTGSHcrgX5vhvPAcVLe1mqMMSo8FKv4Izjjj3+PwGajHCQe2M7QgudAyQAbL6Qe46zCI4uprowZaFBpEJ3njrB1lcUvE1IPPh6XH1Beij8yFdaA8qKO7BGHXdn/iM7HCQV7BCaMkv9hksf6+ERg88Nh9pAVxNkkuNgRo/w0HbQ+wFwqJn14PhA4YmtzoZDqGSrN/LAppPw0r8ir2QJELqUpiS2Se7EB5QZpa9SQUgiRFm/E5J6b9mIZ+IVPKDnvy51F9lLIRmzXHojg8lfbpTYXJnaSvNyZq6zJebghBnK JqdtVrgN NVrr6iD0z12dEKE+JkZwwaXZWmIkOOm+9Y0AmAwvvaNIWW4x+onTdmcYHWr9I8GPgchogHw1898kGc7hayRIWZNvBYTMujkvGH9yq3bNc53UIVVAxl1NmU4cnUhjyVTtoGt6kK2MaduFNGRlum7dzczVw0VQUQYe/sTHB6OJDv0YnPddP9UEJIPhnPLpfBmNnouOLS0lvlAWmeBN3NjhOV74uRr3IE2xlusARJlnldftMIJCfLKCKzCaggoXssYvWyXYteXTwfS2pRGMO6Fpb0PxZcQLgZvtWFGasMKn1HM2OhFFzOPg68977MyrvnoHWIvFg X-Bogosity: Ham, tests=bogofilter, spamicity=0.010613, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 12:12=E2=80=AFAM Andrew Morton wrote: > > On Wed, 9 Apr 2025 22:51:11 +0000 "T.J. Mercier" = wrote: > > > alloc_pages_bulk_node may partially succeed and allocate fewer than the > > requested nr_pages. There are several conditions under which this can > > occur, but we have encountered the case where CONFIG_PAGE_OWNER is > > enabled causing all bulk allocations to always fallback to single page > > allocations due to commit 187ad460b841 ("mm/page_alloc: avoid page > > allocator recursion with pagesets.lock held"). > > > > Currently vm_module_tags_populate immediately fails when > > alloc_pages_bulk_node returns fewer than the requested number of pages. > > When this happens memory allocation profiling gets disabled, for exampl= e > > > > [ 14.297583] [9: modprobe: 465] Failed to allocate memory for = allocation tags in the module scsc_wlan. Memory allocation profiling is dis= abled! > > [ 14.299339] [9: modprobe: 465] modprobe: Failed to insmod '/v= endor/lib/modules/scsc_wlan.ko' with args '': Out of memory > > > > This patch causes vm_module_tags_populate to retry bulk allocations for > > the remaining memory instead of failing immediately which will avoid th= e > > disablement of memory allocation profiling. > > > > Thanks. I'm assuming we want cc:stable on this? > > btw, it looks like the "Clean up and error out" code in > vm_module_tags_populate() could use release_pages(). True. I'll add that into my TODO list. Thanks! >