From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B73C67861 for ; Sat, 6 Apr 2024 21:42:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BF246B0085; Sat, 6 Apr 2024 17:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0477E6B0087; Sat, 6 Apr 2024 17:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD926B0088; Sat, 6 Apr 2024 17:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BBC946B0085 for ; Sat, 6 Apr 2024 17:42:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 357371203CB for ; Sat, 6 Apr 2024 21:42:56 +0000 (UTC) X-FDA: 81980432352.22.1A6EF95 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 736301C0008 for ; Sat, 6 Apr 2024 21:42:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="MsijmPK/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712439774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m1G9gUrNc9dGzPe7AYM33DPZfjgc9cVYEl/DEKm89Aw=; b=njyfguMYTzfFz/gg9l1EFyZVSMi1822zv8mBL9UjEENRPO737cPvacLE993+86RdNkA/GJ mktvge31AmLaeWNFDN7AvLeZvTsG1kAEhsVAlJJVWU0m7MTZl4OFyOCqXClkMby2ZUJ6YY X7sjoKEhIhXfsEZhNdhTarZZn5ltWZ0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="MsijmPK/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712439774; a=rsa-sha256; cv=none; b=vVPo9MSMPCUbDn/+VWwJYVEhLwQXpEHD7cM8oMkXEgzVEJs7Bl7lIO3RKQZGIqvKzpOjxx Bt5blEhFNr5aN0/8LyVPhdYtqG6B6v/nn4vcL9bdP39qcj6kMwvNHrmHlpEXUObe6O6yyY BKNbK4Fft6Zix7roWhQZavjbGuAR1Xk= Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3c5d5de746cso1125133b6e.0 for ; Sat, 06 Apr 2024 14:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712439773; x=1713044573; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m1G9gUrNc9dGzPe7AYM33DPZfjgc9cVYEl/DEKm89Aw=; b=MsijmPK/+zeOIf6K3cWJ+NYXxay7A9rQlqlKqUz9Lq1ccqvMco7m8errtY9S/ezqg1 XKXkXS+jwnn/l4DetoPQN4F6kUhAU7m2F+zYPyCqQKg4JygE6gFZH8E31rJz+pGVZtrO FKUy2Pb+vQpZUSHjWDIt0yvgx3H3UYmq7RBqZxwXoOhiLNiwYC/Dwh7PYcl83aTWs/Id nniuWFW5SGT4XgNIo0b6PJTL+GRzypEqew1w3ZWeGLFSd92Er6X4veaxoGspE85V9QPq 5k0WoMT17cEvT4I5NSckZhjT7HpaMs7H+dCoV2kdwyq4SKzb8i5HtOzVz2T1ZnL5MWCn bh6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712439773; x=1713044573; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m1G9gUrNc9dGzPe7AYM33DPZfjgc9cVYEl/DEKm89Aw=; b=a37rkyiCj8C4v4VpTCCk4GTdMik1Q48/IRjbTdRy+iLFrtsYYrUnirQjz7Xamx80BJ 2mGWBAyYu8OnUDE6Eud9/E268BPk0+LqGa/C7YwaHD+9Nw9qfqyYPRa308qZGPzHLE3n 25JBKBxz0GJuQwsZnMfzCKTe2HsK6f+BsUTQGx9Zc8tT4HwiPtL3iiRabR71zWVQhL95 V6TppKGYDd1z9g85ekxRhtDiZdCIDJju224fxkhnGWP6tR1K+S70GO11cryQKa7P3Bd0 WOnIVBY0FAl3t7g7OuJT79yuVGrPNMDuPtdXFYDCfdG6tGhiuw4yaazfjF85kssRbd0D /J5g== X-Forwarded-Encrypted: i=1; AJvYcCVZYJWJzGUKFXB2UpnFJfAEengQqrhPpFw+XKD099zq26eKY89yx1JSpc+9X4mqP84N36y1PthiT9lTbVRPtZjKXdw= X-Gm-Message-State: AOJu0YzhHMtsq4SzRXwpFsXC8tlXsQ+9fvjSzfVli616EX/SXJjUar30 kq6dh4sMBmVkDM5VWzCmaoIGaa9esVj6j4xlfXOaNiyw+eL30BYO4ZPQvj0QG2TNS8cJ2CJQAKp 5OY3UDmsgCJ1JsxZIzl+jcEVd8BS5XBheFE/C X-Google-Smtp-Source: AGHT+IEy/KQG2Rqx5HErdblj8QUCCqwueXsecSytEtIs4U2W0lIYmqOxwok485xQsC2WwPFvE/PMCfWXWAWd2KQRtS8= X-Received: by 2002:a05:6808:3084:b0:3c3:dcfc:f694 with SMTP id bl4-20020a056808308400b003c3dcfcf694mr5989197oib.47.1712439773006; Sat, 06 Apr 2024 14:42:53 -0700 (PDT) MIME-Version: 1.0 References: <20240321163705.3067592-1-surenb@google.com> <41328d5a-3e41-4936-bcb7-c0a85e6ce332@gmail.com> <3d496797-4173-43de-b597-af3668fd0eca@gmail.com> In-Reply-To: <3d496797-4173-43de-b597-af3668fd0eca@gmail.com> From: Suren Baghdasaryan Date: Sat, 6 Apr 2024 14:42:40 -0700 Message-ID: Subject: Re: [PATCH v6 00/37] Memory allocation profiling To: Klara Modin Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 736301C0008 X-Stat-Signature: 8artaqu7hcnasrt8w9derdddtjfhjhrf X-Rspam-User: X-HE-Tag: 1712439774-773923 X-HE-Meta: U2FsdGVkX1+WC2O/NB82IUulW/RZp322rGQnBIjX/l/e+5vbVSOM/vAJimQDo1f/ySyZvKSsn4hDSTH2BmAxTeG2sprxTGmwLW28NSgDZbe5uLnlXmiy5Jui+sUU+iIjFSOhDkvqQlHc9NAnvT/dM+jmtBN3kKmGbStxEzqMsm6daLAXPneANBch5SS1waYHH0l5pNLnxTxOMUlE0BqBP0a3j4lpiwa9QDT/gb45+id0w1DCnK5y6dxZA4R3pj9Y9H/SbCMxyZeLo9+hRdgNHuU6jhmx1oV/Jzr1LGz6zjZx8BYmYgrqPFKc3GlkW+fjT0lD4I3xiLhhA8eNTNyI9BE0reZNoaVLDWw/oh3YRQOe/nM5YAXtvXxph+2fqtXSwxO552uBTLmJxZw6+PeKSqWHH/lAvd+/UDZTB/LBio1EzVEY8+oOfwUJ8aJKEdAAu98Gh9/WHaVlndbo74N0S65UcAvcPog9uCcCHCTNgzBljodCA+fmyJUNi5+P5FBq8FInL209IibSqSj83Z6vcKV4liAXYvOdk77DIztibpp4M0u27WYL8ijGtJo+2wf18ab/8uYcoIAxGGlw0FyRbRvhlCCO/8HXnmjcwodIc+tDLGCrKibJy5P861JSU75WswAW9QCPn9/rJQls3SoJjevOdiqKYNKck8G09huEdP5Sr4rFSjGrNdZ4pabfrmi+jufZqV/g1KK6kv9fllc1P9Trf2zSrzKRgqCiliSD5BZ1cn8R81G6xiPGHk2tHONgTUSqO8YCTjrc+Er86LqW2D0U6XO4TAMyHdJpWWLRLjsGXudQCK1ap5JX+qF7AMAAt9fLA28TTdTHZxUn9poVJP7vfU1/JMarpV9Zfn7KZKgiIEwjRIVvT9tEKWtiEfd8xaGqykp4j58Ku5Bp/6MyJy/LSuL54H/2vWTr1CuTr8YcGjoakvqcOkquHqx4b6/u+oNUHLKimApJr6oxaVg PccSpSOc dfMfO3fnrwimJ9pi5ryvgNWsV00ercr82SfX/yk6TDpf5FJKC/PCwehM+XTuTLMfWhRnWTvyyusVHXvG3O+yNKxghdEUGSyOZMPE6t+IPrVHD8xwP7NdtpYOKFESWJf5oh6iO9lsNDJXUKUQB44AO8/99oGBw80lkhD6EwFLNQGudVOFTEw6G/AYGzRcE69hPsnLAlvsuOfIKCin3ISobt6CqFJoadz6DUtB2FFvjLQvUCFRx4L33dTjQzFh85NeIhuJeXw490xJq7wTKbBF3HN/22zqtlVtgsHlAkbyhlyHsppr+SNHn6RW6YkqvT8jbddDIzgDngN6irQxCT0SgNnOwEryMKroGgxXbynfn6nVLTwq5HmGwgZ6E37W8HmQ/xGLHic4xTq4hmkzav4LnHfY0YA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 5, 2024 at 8:38=E2=80=AFAM Klara Modin = wrote: > > > > On 2024-04-05 17:20, Suren Baghdasaryan wrote: > > On Fri, Apr 5, 2024 at 7:30=E2=80=AFAM Klara Modin wrote: > >> > >> On 2024-04-05 16:14, Suren Baghdasaryan wrote: > >>> On Fri, Apr 5, 2024 at 6:37=E2=80=AFAM Klara Modin wrote: > >>>> If I enable this, I consistently get percpu allocation failures. I c= an > >>>> occasionally reproduce it in qemu. I've attached the logs and my con= fig, > >>>> please let me know if there's anything else that could be relevant. > >>> > >>> Thanks for the report! > >>> In debug_alloc_profiling.log I see: > >>> > >>> [ 7.445127] percpu: limit reached, disable warning > >>> > >>> That's probably the reason. I'll take a closer look at the cause of > >>> that and how we can fix it. > >> > >> Thanks! > > > > In the build that produced debug_alloc_profiling.log I think we are > > consuming all the per-cpu memory reserved for the modules. Could you > > please try this change and see if that fixes the issue: > > > > include/linux/percpu.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/percpu.h b/include/linux/percpu.h > > index a790afba9386..03053de557cf 100644 > > --- a/include/linux/percpu.h > > +++ b/include/linux/percpu.h > > @@ -17,7 +17,7 @@ > > /* enough to cover all DEFINE_PER_CPUs in modules */ > > #ifdef CONFIG_MODULES > > #ifdef CONFIG_MEM_ALLOC_PROFILING > > -#define PERCPU_MODULE_RESERVE (8 << 12) > > +#define PERCPU_MODULE_RESERVE (8 << 13) > > #else > > #define PERCPU_MODULE_RESERVE (8 << 10) > > #endif > > > > Yeah, that patch fixes the issue for me. > > Thanks, > Tested-by: Klara Modin Official fix is posted at https://lore.kernel.org/all/20240406214044.1114406-1-surenb@google.com/ Thanks, Suren.