From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845D6E7717F for ; Tue, 10 Dec 2024 16:29:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D7566B0252; Tue, 10 Dec 2024 11:29:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 060E26B0253; Tue, 10 Dec 2024 11:29:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1C3C6B0254; Tue, 10 Dec 2024 11:29:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C02756B0252 for ; Tue, 10 Dec 2024 11:29:02 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5F8F412099B for ; Tue, 10 Dec 2024 16:29:02 +0000 (UTC) X-FDA: 82879583094.12.F73074F Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf06.hostedemail.com (Postfix) with ESMTP id 10330180007 for ; Tue, 10 Dec 2024 16:28:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pMtor4ZB; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733848125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bf5h9unDEvxY9TWD5u6hoRQPAOn47cfu9U+YnF+nEzs=; b=TPB7FhmZZo+UyDpWAKidAwN3gphSMx0gKCeJqipvIE50pJ3Q+cg+fQ7XpzyQBaWbWehWuB 64NbHIb39tOMvIvMm3dzXfuSsNbFN/4zPFP/nEihipXgCJwbbaCEv32TMljKvBeMRTtH0c KmayfCmiOpsxG+PUyk7y+qJOjcSjRpU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733848125; a=rsa-sha256; cv=none; b=eIJH2Wuoykx9BWc8+sk/conVPHjWW5gXdxgDSUX261RUPI+XQqL3O6cOUL9PyGvxtJczDN s+eNqSQ3Pk5UDdPG0tapS6Zu5DsEeDR65LmRBkfFq3lb8PgCw8JtXJNH7Z2fAemxEFEd+h 0kIzvzBcxsSjGmEpbvp6noaxr02+maU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pMtor4ZB; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4674a47b7e4so277211cf.1 for ; Tue, 10 Dec 2024 08:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733848139; x=1734452939; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bf5h9unDEvxY9TWD5u6hoRQPAOn47cfu9U+YnF+nEzs=; b=pMtor4ZBgh0wBZDiuUTpPXkI6KvrHUU1P7pJwOVhAiSCMy/vTb+wpIfKwFycZXKZBg BO4bI4wWTOeekRiqmcBQWAFgTFKev8scAOWbiErkBwFrlZs7rEDQ1D8rkexfJY9XvJ12 zMEJGIgDpw/PIuDCVk6XvHEuHdTX7QSgF087IF9u2fdYrpyBR9n2x6wgwQ9Js6nyUfUp EE7sQEuPNkB52Bl2e/LHGllVhrvhAolqD7NsADj18dKnxUPR1HWOr3DCazbhM6Sk7q8Z PUGxkyKvyscWzttnM5QWbEDRPPH9bSqpB+CSduBIx/yUyZXkLX5R9IXa3/SKtADt0rK2 gWaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733848139; x=1734452939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bf5h9unDEvxY9TWD5u6hoRQPAOn47cfu9U+YnF+nEzs=; b=RH6rqEvX7hNv/YziNd6SYlj5Xsuwzw1O+obxNH1wwDzTvTHWBfYi2wMK3x87aoISmw Y7n9ouN8X2ELwKDq94+h7ecsmeWZan1h5xalVkszfKzBeX0K1ZNxnia1LJ8gN3xELir3 AzXZlab9RasNtP4yfG+EfnCgdrodlZhpzkTNS85Ny7HRO/ufPNdZjKDDLql+ZHcteak2 FiU35ERcfiIlbBpCPVVD71rsLJbHrrLNqA50GRsuMqrvVHGNTLOGVtIANnIMCBeyb5LW it8Gv1BcrvCMHh5I6S3QSzJm+KaAGUauw3qwzu4otBz+U9i4u5e3wzchHUbLUPFgXu0m fp5A== X-Forwarded-Encrypted: i=1; AJvYcCX0VVQulkHQNFrPzRQ/9EmY+rti/mBCD1Qa4ytq9XnBxjPW77wboRSdiutHbFSMQe8g9Z6qUy+GzQ==@kvack.org X-Gm-Message-State: AOJu0YwykrbZOoCdCaxN0BaKlCN43o4RmVf2Xwib2ZI0XWAdi+LbAr1l b0MeQhnwocCEIMVe6M/cOktqQku2qXdugUf3hR39j4zQaXabN5uMLDPW4XCI7FHjmY3XkFSAiWN E2oI7E83Zf2tIphNmzw4h24y3a9uWL5l80QiS X-Gm-Gg: ASbGncsEjIzQkqdO1bjmU/VomOYlxwUbFxJAxkoWJ1PvWT8W1lZnezVCTi19aCCLs9l KI6vgQrpTllySfWNS73WMdYof55BaY0O1irI94kLYg4RRqPW6wtBRlYgDnGhQ1Eu1Rg== X-Google-Smtp-Source: AGHT+IG18A1lS1fdcxb1YBnBEyBoavuVqg9A2/HQxThNRPuA8ZJGfzBBwB6pD1Bx1UZCGAdfo+5l5/Vg84fvlmkLzCc= X-Received: by 2002:a05:622a:5510:b0:467:82de:d949 with SMTP id d75a77b69052e-46782dedc53mr2054901cf.12.1733848139314; Tue, 10 Dec 2024 08:28:59 -0800 (PST) MIME-Version: 1.0 References: <20241206225204.4008261-1-surenb@google.com> <20241206225204.4008261-4-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 10 Dec 2024 08:28:48 -0800 Message-ID: Subject: Re: [PATCH v5 3/6] mm: mark vma as detached until it's added into vma tree To: Vlastimil Babka Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 10330180007 X-Stat-Signature: 9ichi5syyrssut3cwpw1drcd9pummky1 X-Rspam-User: X-HE-Tag: 1733848124-866743 X-HE-Meta: U2FsdGVkX1/gr9uq2ZomZj1JClADmIhOyXH9p9WPhxobwom0WR3PpDjJv22okPlBYZ922c6UZGQ/3Cn04Ge1Hp8VVHx3nnSLXiliAryZxongAr217szd30AX5l/Z3onM9PCe0lm0TCv11oPIFwexy1LeoIMAwR06m3VxfZExEnogEFAZ/idsdnd4XOzrblhgcus90cj2ioo5EDCbOQvdf/XnmidX0gDXr5xWm5ucDpOYSZBaI8mpSJ6G+S9bjUXn3MT5yDnQWu/LPdOZ5m0rUBybCzCMu5XVA4fBMvUc6+XkQV3w++x9sUxGiAkW0UfEFqu3jA6DQtXP27kxI+Iyln0VfwW0WLQq3gYknAFJj4oPSsj2xD6L6OY4gXuKgI8iohmG0vVOFttmsBhFxtlcKAcHlKIpMRBYNp2Qdlo7MjVnDeeG66lO5+s/A6HWXe55czokmYX+Eq/ebtcQmC0kfdNHCD1vAGD4QnCzkUfG851sU392mec2WXgJQ1AQ4KNSmzGINK8lPS46rdf1zoChPUHqTMrTCosjHTw4HTkYyqQH/emasytVR0GM2E40qqlJ6a6FWY7bcpiG6J3QfqXWa/2GAVxxUy0ihAjaykP4d2mwG1lXaYwiMgLVfvvXLNdqroqbakXEBz8+Kzu1mdixYO16LxJfOSlbJYKtQVXaC3T9qSYMgomdpUMA8HWckg+ykzJkkFl38NdQgef8S7WGdkW0YTnCqQOB7eOdEaG8btbb2TBf2KMByMaz2C8N7HNVbNhdlAQfEdlniba10Eu1hVPKgzGCVBYUEzlhnD9w0t9vosivfoDZHeln84lxHPKTK57TlVogdtWJUlw2ppgFtHrZoqHt3fQO8nv6umrFLeU1UXWWVokSO9GTfcPo8dP8StJ7KQa/a+nJwq5mnE2XMk93zLdBdtkeMN3Z+Sp7t6Os3huXcdCPQPjE7jWKZ3ojo/qPyRXePj3HQtx47Zs XAFgk580 GmRRmFVIeqcZ4ybTP61MuOHUw/Sxjy98EK8FfOyi6kCnMQL9ExG+8CX6F7SRiaaPXxC9OmmITcfeBKeBorUp3+nsgVtDnqAjmPbRfCECXdLNRIFtJaBVqLvmADMJ93UcQwYKniOwuGe7zXLjvW4VdhFN9UsepstBVlt1zj9Hys86pmTlqVQES4PvY/ybAxD2C4ygMPHeQnW++w6RN1yEOISa5KU3BWAZ0Cu1fBeabHft+dFRHK9EIo6/sBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000409, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 10, 2024 at 3:36=E2=80=AFAM Vlastimil Babka wr= ote: > > On 12/6/24 23:52, Suren Baghdasaryan wrote: > > Current implementation does not set detached flag when a VMA is first > > allocated. This does not represent the real state of the VMA, which is > > detached until it is added into mm's VMA tree. Fix this by marking new > > VMAs as detached and resetting detached flag only after VMA is added > > into a tree. > > Introduce vma_mark_attached() to make the API more readable and to > > simplify possible future cleanup when vma->vm_mm might be used to > > indicate detached vma and vma_mark_attached() will need an additional > > mm parameter. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Shakeel Butt > > Reviewed-by: Lorenzo Stoakes > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 21660a9ad97a..71990f46aa4e 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -465,6 +465,10 @@ struct vm_area_struct *vm_area_dup(struct vm_area_= struct *orig) > > data_race(memcpy(new, orig, sizeof(*new))); > > vma_lock_init(new); > > INIT_LIST_HEAD(&new->anon_vma_chain); > > +#ifdef CONFIG_PER_VMA_LOCK > > + /* vma is not locked, can't use vma_mark_detached() */ > > + new->detached =3D true; > > +#endif > > It occured me we could probably move the detached setting to vma_lock_ini= t() > to avoid the #ifdef (also in the ctor in next patch)? Yes but setting vma->detached inside vma_lock_init() does not seem logical. I went back and forth on this and in the end decided to keep it this way. If the #ifdef-ery is too ugly I can introduce vma_init_detached() or something like that. > > > vma_numab_state_init(new); > > dup_anon_vma_name(orig, new); > >