From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A85C77B7C for ; Mon, 1 May 2023 18:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25454900004; Mon, 1 May 2023 14:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20451900002; Mon, 1 May 2023 14:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CCAF900004; Mon, 1 May 2023 14:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF4A6900002 for ; Mon, 1 May 2023 14:08:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 699FA1C7313 for ; Mon, 1 May 2023 18:08:24 +0000 (UTC) X-FDA: 80742470928.13.F73768D Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 7D48C4001A for ; Mon, 1 May 2023 18:08:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=InnNvCby; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682964502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+2lYHhqlJD16G2HYpsFMb3ZFL7Kq76WjunB2OGwz3cs=; b=6IkC7LCcpohTTKhPm5Z/DItTx3rdWJmk6gPkCcm9mg8BoRnhxmVRS0VApbFddp8f3eaKRB CRNBcH4AC38bwQ8hZoWTlUhDYDlNHBP86sxyXoFsuenTFiIAYfF+q2wPnjFJsnEHa3OYBd rZ069QKLerw4hFvBxLXOCBCVIrOGRnU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=InnNvCby; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682964502; a=rsa-sha256; cv=none; b=jlvFS2EgNJjAojYHUhR3emxqkkDhCMy1XD0h2jNGWAPgPt8srf5JANH+WG16pU3NE86ypr IILezrenhtYP24jfK3Qno8t3xaUZgUI+6rTAS3JHUCyVFmoE/oEaOyQurJuPgE49scSf9f +54uZFA0hoozbInWQV9UmwToWOeLcR8= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-2f3fe12de15so1577613f8f.3 for ; Mon, 01 May 2023 11:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682964501; x=1685556501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+2lYHhqlJD16G2HYpsFMb3ZFL7Kq76WjunB2OGwz3cs=; b=InnNvCbyWRIxKxFGHEw18GDFvAR07SJg7UsaQSzayd856NvZvHy/7D82OiVunxTwOQ iI4bPEnaVC8DKfBD9q2mpFU/D2+4QZOsePkMvk/nKecGEkR7ieMp18RUohlow/ONsuPb fRpdmKiy/hCz/JHzVWz2n5Mg5OcWXlB55bYJJxXjQz7D5uG5SID6uaCO/Kks5xdfPjJJ it9fnMSSuNm2JWdg5Tcm2D1rTGbvS4aDpWOvTKMsD+KeIoUScC3se5ywU/XKx17SosJd CH4HSE+fdc45RYf+DKFB/2hLNASZoyYfq4ehjOUiQfqHoIRcizKtgl3mADdezSKqh+u9 RU9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682964501; x=1685556501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+2lYHhqlJD16G2HYpsFMb3ZFL7Kq76WjunB2OGwz3cs=; b=Z9VIbkEevn5jXu+S0quJitWGqmlPLoHtB7nMzc5kVozOXrVcWQX5zoHvy3OI+o7Ovl jtUUacwBBzGB3bGe5O4RsULsAwRpiS9wDn/qwxMGDxIHNC+be33DP9k2Y1QBHdlgUg0u Qc7BwuZJXraGppf6YRnsmZRrmf76vIKASXkOfHFGUAELbx0M1/hXzxlnUee37Bh3AzJA sh87jlM9++JnyhL6fTxT25x00m2752/Q7vQ++TlKCyXx8V6VPmnivL6gaeRK652y6w2s rcmqns0FXmO8phIdSe34eq2Oe0kmWphK6NNa/aw0HyhxDIV1e6sN7fKao5RSx+gHYerb neYA== X-Gm-Message-State: AC+VfDzi5Y6hPpFnx+rS1rt49UCdPMwce+r3y7oQogB46BFUrvCqfprF 3NyW+RXJmPIjXs9gycKM5ZGJn9NqEOCXtbOLpUOuZQ== X-Google-Smtp-Source: ACHHUZ5amJjA/6tq+0x964OebbbLQ/pHCZFbXYS1+6FrTMuusEGNpiFnDiBKAeRF77HbwZnod13qqDRv0TRCNeDlvRc= X-Received: by 2002:a5d:6351:0:b0:306:2b9e:2a8c with SMTP id b17-20020a5d6351000000b003062b9e2a8cmr3336094wrw.11.1682964500617; Mon, 01 May 2023 11:08:20 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 1 May 2023 11:08:05 -0700 Message-ID: Subject: Re: [PATCH 00/40] Memory allocation profiling To: Roman Gushchin Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7D48C4001A X-Stat-Signature: 4u9hg3xnhrjs5mzpny5nrmux7s94mayn X-HE-Tag: 1682964502-623245 X-HE-Meta: U2FsdGVkX188L2k0hs1133cdS+CIrNN4pu1d4HKVhIHw74SLjb739HKFuT5xiDBUAYW7+hzZ8wPeSIryGvv/F26Hh1Zw0TnMzBT1kuX/dt+Jb74RDl+B/hMWlWW5ytxKF24BXtR6CglnO8Ki2zmz/mWVzEOpaDd++8tYw80d+3FrplRsp++jv6Ii0vXZoBd3IBQxk4b0qOFjcmCHlf1/vHwwIjHjQZAUimvOXNop1uqP8aY4JqqydjAYS09rDKplsB409OrM0ny0jfA56U49jEUTQwTewcjqKB4wqTis/9JRaQoXzIRzYnVphLFDrw6ExRUOYg278JtLSvuwu0YWSp+h/sedkeuDSliDDaJjF49OKoczz86zqb/LwvPwtqf3xoE0HydeLuX4ApD/jASeWAQgSkr7cgnd/SjWded+Kxmp/zI9U6YEI3UAcWsScQIrriGLhj7L+39+iTH+J6t3FTQyoG6m/f+xUqm42LZ/PQ9dhZGJQvymsP7NY6a3DypZmnM6paHPlpiLEyHcHQFilfZKOdWpQRf/1AyrhxgG0anbyRJTrfXGgqzxEt9VTjHoKvoBNVVob2TegJlKT5xFYU90KKTigr3CoOLdiL4DfkKHxQ0D3QUkbIbXdZlTk3hosMFlTnRXWJgFcbRNZZvAjmwef1JT4bJXH1LGreSJxDaoMaEAML++XPcu0K1Zk/tf1FNbsdiWn8jvY7Rk1GYuDvfkv5qYPua7uPrKK876pJ40k60p0z2cyNLUnXymOjg1ovxcsOnRGniHPfTqeH2A09RJx/FUCV4yoCDZLWDFq7A3/uBnbSdgJTFRdzOjc6qB2qJovXudyIvSbsE3fZaTwzflQd2CXsLqM0JaIUAgO8nUZen6CIMx3KNDIUGOp0Vte+e8ZZSJkrgjjTH+pDSSxvAe6EmTnvNAIumlqDYXLEulzKrq864M9KsJGA4H7sAithlVEjqcHf8CZ6UCVF4 ktoatu6i ApvssE6gGE+qkmIEKHpi1r6td8nd1YRUzakB8U6uyJBZ4FTMMjhWcC99n5/HJnarnEWWZeK2+9C0AA+uJAnuzR/jViGIrmscWM5gctWwBQr1Gq37Sb3RNK6nvAk8BQxaopBHrjMBKRS0jUsGoNyY+r//kRcFSTrgd8oogH+Rj2h6mvKcsWac67ANr9Vd35Y4EvLYSj14BLKdZ7PMfz4FtNAr8QiYmXFg15sSDPpQ49OQpN5IBnYGBZPCxxW57TVjyBZjULXTdWnOuKdpeK7fOFfK2EWgXjdulwxS39U1UgpPtNmk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 1, 2023 at 10:47=E2=80=AFAM Roman Gushchin wrote: > > On Mon, May 01, 2023 at 09:54:10AM -0700, Suren Baghdasaryan wrote: > > Performance overhead: > > To evaluate performance we implemented an in-kernel test executing > > multiple get_free_page/free_page and kmalloc/kfree calls with allocatio= n > > sizes growing from 8 to 240 bytes with CPU frequency set to max and CPU > > affinity set to a specific CPU to minimize the noise. Below is performa= nce > > comparison between the baseline kernel, profiling when enabled, profili= ng > > when disabled (nomem_profiling=3Dy) and (for comparison purposes) basel= ine > > with CONFIG_MEMCG_KMEM enabled and allocations using __GFP_ACCOUNT: > > > > kmalloc pgalloc > > Baseline (6.3-rc7) 9.200s 31.050s > > profiling disabled 9.800 (+6.52%) 32.600 (+4.99%) > > profiling enabled 12.500 (+35.87%) 39.010 (+25.60%) > > memcg_kmem enabled 41.400 (+350.00%) 70.600 (+127.38%) > > Hm, this makes me think we have a regression with memcg_kmem in one of > the recent releases. When I measured it a couple of years ago, the overhe= ad > was definitely within 100%. > > Do you understand what makes the your profiling drastically faster than k= mem? I haven't profiled or looked into kmem overhead closely but I can do that. I just wanted to see how the overhead compares with the existing accounting mechanisms. For kmalloc, the overhead is low because after we create the vector of slab_ext objects (which is the same as what memcg_kmem does), memory profiling just increments a lazy counter (which in many cases would be a per-cpu counter). memcg_kmem operates on cgroup hierarchy with additional overhead associated with that. I'm guessing that's the reason for the big difference between these mechanisms but, I didn't look into the details to understand memcg_kmem performance. > > Thanks!