From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D76AC54E76 for ; Tue, 17 Jan 2023 19:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30CB6B0072; Tue, 17 Jan 2023 14:01:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C07E66B0073; Tue, 17 Jan 2023 14:01:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF6476B0074; Tue, 17 Jan 2023 14:01:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A0ACA6B0072 for ; Tue, 17 Jan 2023 14:01:21 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5B6AA1C4656 for ; Tue, 17 Jan 2023 19:01:21 +0000 (UTC) X-FDA: 80365209162.17.690BF94 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf28.hostedemail.com (Postfix) with ESMTP id 97C2BC000F for ; Tue, 17 Jan 2023 19:01:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CjLP+GN4; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673982079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIZZvFyQtXHixD5sWfvEaQUvi24ljYnGZNh2fBEIyp4=; b=JS0o8r1cVDcTlu45uooTtkSfEz8NpEUHz8HfumpgsLQtEsFzdzr9IjzdrdCceCYUC41gH4 82vKA2NbmjELCutwpRhaz9eItswwfwhlJLxQP7iL0iTaMfREeA2Mk/VseTXRta/aE/urdr wD5Q2mTRiFiktp1vhpxCG5YBs02KY5M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CjLP+GN4; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673982079; a=rsa-sha256; cv=none; b=6kxH3J4Lwoc+AD2p4U7xm3HifphvHlxs74JV0b8P44A4C33YZnuji077TU6YKRxZDKQxHf hBV9nzIySzqY2qmyulyHylDfJSuCWhRzwATtRBNWtJ1jYnhIz2oa/s/s7qxjfKXL9klgLk 0G/BTy+sfyQUkVBDEEpycpxjvWAWh7M= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-4b718cab0e4so436203237b3.9 for ; Tue, 17 Jan 2023 11:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LIZZvFyQtXHixD5sWfvEaQUvi24ljYnGZNh2fBEIyp4=; b=CjLP+GN4eJ8YGFZvjoqXnYn0mL/Nm9o57f+7WOJDJDHEjmOn/4ZZF6+enYJUFh56p6 ZjMUPNGSRgQRosE3EMtoX1RXdV9HlQD3govS4EbUA9vX5E0lvyII7jNgKbkxa9q55Ofi 5fHxRCrBasHddp+A5FhlnIGxMd1HsMsFjjUSptfu2Xn/GYum5SsgoXsfxk+bQ6S1eMxn TjquS1QRX6eEGqUoWMTLZ0Uen7LLC6vfFjMFZvmVjQlE+SMKypaTTEwOKRHnLLugiZMU Ca7UGjlXIklsuObkggD1KlRzV4LfytQE7UWnMkJIywJkawE+81OksYcPHkL0icjcL46L ZAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LIZZvFyQtXHixD5sWfvEaQUvi24ljYnGZNh2fBEIyp4=; b=uo5hNLXlKsFwj2MWMdOkR9x0T4pERhDf2oR9AXJczrZpz6dGEspLelJ8LUymqz7k9A v2yBrkBmtaDYK0WDgrTFH4fSaMkV9kH9xA83hk6Nf07XTLizN7USXSZyht2KbRVUOYrc tL7BYS2B9UeNo0icw8kWspZzOi94rrdpfS4KoYNKmi+CZKqYvTKCQXXJm1Kn+ruhhgtg sG0WfwyIysZG1g5lK/7uDpnZM2FGS7A6HYDsLfyyhx+pLMcLrVji6oAD8uQ5/c8Hn8p2 cf3NxEcYJObBUunx2Q4e07qb+plFrbRyydgAvA7yJ6PiNsmEUnVvXzQ+CYn7Qvizipor zhvQ== X-Gm-Message-State: AFqh2kowKDdlqsdfDSQ/EDTnqY1v6AwXDYNfhQTrfwK1uh3JdDlutW/T BAQx65hG/XLfCzSI6NkVAxdglIEHnHSOQaNAwI7+6w== X-Google-Smtp-Source: AMrXdXuXSHUCPjq8vGtgRecAo+K4qxgIc9+GydwwGOLIiPEqHLP5AyNSTg15twzR8exVpLWal97Wzf6SyesXXn7pY10= X-Received: by 2002:a81:9105:0:b0:3dc:fd91:ef89 with SMTP id i5-20020a819105000000b003dcfd91ef89mr459982ywg.347.1673982078402; Tue, 17 Jan 2023 11:01:18 -0800 (PST) MIME-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-41-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 17 Jan 2023 11:01:07 -0800 Message-ID: Subject: Re: [PATCH 40/41] mm: separate vma->lock from vm_area_struct To: Jann Horn Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: fk1hpgbtd8xmcck3d84eibc1bed96qik X-Rspam-User: X-Rspamd-Queue-Id: 97C2BC000F X-Rspamd-Server: rspam06 X-HE-Tag: 1673982079-440904 X-HE-Meta: U2FsdGVkX19qGGa5EvzzRyCS5vRb/Rx2C1pv5elwW1we1xpbe0ojdLOlYkSbsQmmAs1V9x3jAK3dSBx05djsOK29nJAG5S0vEhFzjq8hmeKhQzDyW/cBkq2OiYwL0HlQqVP6EB9rBBt8neMN5E8+8ULjqGziRRKWpVv1CFiyzujyC6C0aSygTUZ6SVJbV03ksum7nibYOjbL7L+WCwhVtmrJfpKi6LR4lQA8n80r8unNwFRF27F9HS1ZpFlQlXzhEdi/y8xqMk0T0jb2Fr2ThipsGt/2zVnvMhGCPe76yJBmpEc0nnB3N2hDfUnERu5ryTyd7x+tjVGIrp6dl+mg2fy4TArMGUDL3VEHEPEZl1keWqD0MIo6jhDDqhYigiFIloq7nwlNwqvgksFvkDvsS3hqnju73iSGIvYVM6u2YpzSQjKyCfaPeU6HF9iDBgNtlLgWw5USuJ2lUI1+uaEjvXtEL6rpZJpfybxU7tvUitBeIl1P86HmML4+gXW6m/icNUSUXBGyrpNK58ihK3yyPu4ddPUSEAurtY4pDa22cXGAVqJ0NgRR33j13dZhvVYM7gIw4/Aw9Zg1aDYT6Hm9C6IDznuoLADjN45NgTG7iZpHBdTDFUfle4gSJ5GuVM9eD68SkGZfaBX+wbmcrnqs38qJuIQxl8t3qADfcUavyhSKYR0l76/RyQ70oilhAXTwmd/OvguM7nM4GE7gff7gAmeIPyd6GPl9y7osBWK4e6G4PIcRQJjSwluYlbQZS5msc1xtymQbZpkSyS6bwieXZtJdLLpHZs9w5aIE6Yf/IEJE/adaeAjRmAXUBIrPWs2dUh/kC9vCjV7K/fDAUTe4X2T2x4zR/JL2k0Bvfd4yPGiFL5/6sButqkiEmhhruQJWAvNko518GsdzsBE6HVYUZ958Uw8Wqx9GY5FeTUzBHm0f0+xPjvx8YdmxabMsxfAPDPihC1uAfSEj1Tre0V5 qqjCFYsj RMoJQtLIjqFeRgc76sbC/TSo5cOrNoho2ozdzAqX6jZ21TtNnWJjNMgi8Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 10:34 AM Jann Horn wrote: > > On Mon, Jan 9, 2023 at 9:55 PM Suren Baghdasaryan wrote: > > vma->lock being part of the vm_area_struct causes performance regression > > during page faults because during contention its count and owner fields > > are constantly updated and having other parts of vm_area_struct used > > during page fault handling next to them causes constant cache line > > bouncing. Fix that by moving the lock outside of the vm_area_struct. > > All attempts to keep vma->lock inside vm_area_struct in a separate > > cache line still produce performance regression especially on NUMA > > machines. Smallest regression was achieved when lock is placed in the > > fourth cache line but that bloats vm_area_struct to 256 bytes. > > Just checking: When you tested putting the lock in different cache > lines, did you force the slab allocator to actually store the > vm_area_struct with cacheline alignment (by setting SLAB_HWCACHE_ALIGN > on the slab or with a ____cacheline_aligned_in_smp on the struct > definition)? Yep, I tried all these combinations and still saw noticeable regression.