From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F43C48BC3 for ; Mon, 19 Feb 2024 16:55:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6D626B0071; Mon, 19 Feb 2024 11:55:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6576B0075; Mon, 19 Feb 2024 11:55:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6FAB6B0078; Mon, 19 Feb 2024 11:55:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A03036B0071 for ; Mon, 19 Feb 2024 11:55:39 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6452A1404F9 for ; Mon, 19 Feb 2024 16:55:39 +0000 (UTC) X-FDA: 81809154798.16.C5C9AAB Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf28.hostedemail.com (Postfix) with ESMTP id A2EF1C000C for ; Mon, 19 Feb 2024 16:55:36 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0S7hMqL6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708361736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MC1JxayV7V5FEwBjiEEHat04AtMi8UdAlknxmmQHPbY=; b=Ssy9znZXnBFvPYrB0KJoFkpfFw7iRCE00k+kkD1M1PI8gBaiB7u9mwfgjNsd1XP/HRulno oZZnwzdhtyFxpLQcTcPswRzZEVXqUJl/AtpZK6+RlJiZ478ocVBLqx0m11V9X15+lNNW0I HCGZHcTEvd1gey6pjl+VO7xc7jq3R5I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0S7hMqL6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708361736; a=rsa-sha256; cv=none; b=b7ChH50fAjm797MhK9jEZECUNByAjgmY4Qxt3hYXBMxKXQ52VMyKSd6zCREj7CpT6cHZCO oMnHp60eGT8TmjxePOO+KaifoXD+nEu02MlrwSM7zTZ9a565o/BX4M+UqykDSVeTghIoaB gKMmNl4SGo9tRE1bMPQZfDqkBgItvA8= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-db3a09e96daso3724348276.3 for ; Mon, 19 Feb 2024 08:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708361736; x=1708966536; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MC1JxayV7V5FEwBjiEEHat04AtMi8UdAlknxmmQHPbY=; b=0S7hMqL6IvhuvZ0USRX9GHB/0BVDNRg/3PmOQdxNNsx9OjrAwRI1F7IrqYfr/1RJXQ up/irwLcsuhlbUeoi69S2WCGIH0/lD929f4Uk+eSqfeJcW1n/pEMFSSFdQzmMK86uHwn G0e6dM05mw1YiBkhp4RvtLvLUjnqLJzCboxMKqvF29p20BYwvWaq3ZQfYVPivEYlBO/s K3QQcmlGl5EsNGdqbahbQCDuqX9LsrDgJ3EJodjEfHd4Bgpa3WmFgB9JE80r0YTKwf6k yvo8huPgx6o+bjm3XtMSzoiagqc3QPgmGByXlpg4vKNcY+KpAm3q0zTGbp28BZVXPL0P /4tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708361736; x=1708966536; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MC1JxayV7V5FEwBjiEEHat04AtMi8UdAlknxmmQHPbY=; b=nlawQGgNnzwjZIEG9XWXfJkOrL2+QAWKfkujIRjs+0HTtRW+VO0PMd0HREOktx9EZ7 /dQtJkRzRgaZyH/o+/hy2nJwVHDYIjOlmJoGJvQ5oMbL431/nJmCp6FieJbrKgQ0tcDJ h7LBCwiC2/48jst5ufx75cBMiSpGlfy3vpse9i85n1Y91TbRkzOqXVo+0h1GIMYE5WEN JaggTL9pMP9gfA2wtNgOPVcB1Uf46Q5hLG+Y4Dn6MafqvegM2kPPr38AG14Dpifm69qF 9Pf4vk6m4iZ86UnKVLozCc7nj7lGObOrQn2RdjbDy9bNmo0d7j2Lcm7hbvK9HA8tC3Wq Nr9g== X-Forwarded-Encrypted: i=1; AJvYcCVjA/QEkPcV6qBJEvb1cIEmP3mj3nma1O5AJjQ9rcZMou0ox/luweYgmrXnt6lQotGSF1WtuboKGQENnU0wLk7xXQ4= X-Gm-Message-State: AOJu0Yw8Any+c5wMijxbVixsW1TwGyZZl4rjsa+qfB7j9bLsS9zJGbbO YkxVwLlwgEfTpUaJe6TxnPiRhJI5gsjT7LPy6m5y20aFlt+lqjyt5DdwmtmdnOs9HOgr3P9nTL/ KXf8K2g0Kp2SoSfnS/SwUuLWrQtZrL7ZZbme+ X-Google-Smtp-Source: AGHT+IE9e4H9CxOF/Wkt1BmMwgF6wG5QNpfKFX5SyoOVKH5zyjhHqyJSbZUQlTjCIfZiNsAQiQ1++39gCNndnejh6es= X-Received: by 2002:a25:d68b:0:b0:dc6:aed5:718a with SMTP id n133-20020a25d68b000000b00dc6aed5718amr10952783ybg.26.1708361735183; Mon, 19 Feb 2024 08:55:35 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-33-surenb@google.com> <5bd3761f-217d-45bb-bcd2-797f82c8a44f@suse.cz> In-Reply-To: <5bd3761f-217d-45bb-bcd2-797f82c8a44f@suse.cz> From: Suren Baghdasaryan Date: Mon, 19 Feb 2024 08:55:22 -0800 Message-ID: Subject: Re: [PATCH v3 32/35] codetag: debug: skip objext checking when it's for objext itself To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A2EF1C000C X-Stat-Signature: 8erwyt8tkystqu79jjjx7xsbxkn6pik7 X-Rspam-User: X-HE-Tag: 1708361736-312930 X-HE-Meta: U2FsdGVkX1/8RiESmmxPquN+yZC/vmgZHPTqpzfVKlWtY4o9HbBZ86sfYSozWkwv5cWuB+VIrpn8bSc0TZPCbJOAM5LukM3vtyaK1PcgFZHM76LYoUoaTOCMhKPotEjPlN8lJUa8OrfhediWJKDUR59Szwp3/RGI02/ZYtwXXjvzIW2IAeW08PfWHXwFalwxgh/hdpiXgXpaH9RYUH3bTsF0VEh/85UBw4YOyTk1fciw2XpRoVCa6dydMlsVvNr6y7/YCJP6jMj6C91DL5O6EsAUQ8/3lDzr6uNpU81QB5PGzsJg48EJycwOD53a6taOaABdHksK/LXrUGXJUVYePbuPJvqGFfGsHyaYe6f1FTV2Ug4T5QUxXKmSGaaRe2A+OhM1L+vy19vMPFywgePzEdPkTV48WnePM+iSehJFHuyJA8Ly8S7H/Tz5t6na74iJiTITXaWtoOUVnUbgmYYYADcWZpOk3uw5S6N6LBRTVDDd2Kzt51/C5mSVxn3e/TxLm5PujHCVdskJDkxLS/alsM2LE8pi15wlPzGk2VgidlbWWxo2ly4nk5FjuYw2CA3wTaA2gYfJ5RJYYy7Z/I7O02U037k4NIwxhYUx9K2UNlW7289BVooKkeudmXjthUJ6vGqoMZpVzA/573ZHqoS47li22wEIsmDF45ehqyHpPli3txPc1vCCI6BAKYEl0/XXtaV1YNsn/J2cGBM5q8b/U7qxqAEewU0L04EwuzzeTW+s9Cykips2di9ZpwoQ7lyTjU3FxQfjCANx3Hv7lq1r9OFYb8uoFf+1xEAM7MXoRt6y8i6xR69Y/8Z42qpcw8pqs5gz/pmaoFeEp50aHfOg/tnG81tJVC0ZMDs/BrlhveQ3X8tfXE0RkFG4Y7jK/hbC/XR74XYWdDj6O9aoFXlnbA8vC3mV3P2NAO7UjcoU0eAeRdZL95bmKwdAuxV6LJFJTt9tnfozfhOo7Zv0yaT tqL5qVK+ vZjz6qAZr7DkPev3YqelxierZMnMFWTmEr9RV0epfIiRGVNjicceKy4i+ezlfHJ1+NrqVlh9ban/1j9cJTfhXOkhuO5MKv6rrxOGYjPokp2N5rrCuqxzNz8suJWoeWTC3eoecmPSMs8RYHk+zCDTRgOUdVd739jEDNbsJg1zL4CW7LApv+t1e0tUVgNI/84mP9qkWWouixgfnhb80eSlga5Zx2ouwLAgArDbtyxS5aDMMyTs30Q1q/QBVbmN+19LUrQbXvrSQ6wop8Aw6LWUFsxhd7F9qB7WswWq2DNj91dNN5clzFFgBhVK1KzSVqibmAx4e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 1:17=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/19/24 02:04, Suren Baghdasaryan wrote: > > On Fri, Feb 16, 2024 at 6:39=E2=80=AFPM Vlastimil Babka wrote: > >> > >> On 2/12/24 22:39, Suren Baghdasaryan wrote: > >> > objext objects are created with __GFP_NO_OBJ_EXT flag and therefore = have > >> > no corresponding objext themselves (otherwise we would get an infini= te > >> > recursion). When freeing these objects their codetag will be empty a= nd > >> > when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled this will lead to f= alse > >> > warnings. Introduce CODETAG_EMPTY special codetag value to mark > >> > allocations which intentionally lack codetag to avoid these warnings= . > >> > Set objext codetags to CODETAG_EMPTY before freeing to indicate that > >> > the codetag is expected to be empty. > >> > > >> > Signed-off-by: Suren Baghdasaryan > >> > --- > >> > include/linux/alloc_tag.h | 26 ++++++++++++++++++++++++++ > >> > mm/slab.h | 25 +++++++++++++++++++++++++ > >> > mm/slab_common.c | 1 + > >> > mm/slub.c | 8 ++++++++ > >> > 4 files changed, 60 insertions(+) > >> > > >> > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h > >> > index 0a5973c4ad77..1f3207097b03 100644 > >> > >> ... > >> > >> > index c4bd0d5348cb..cf332a839bf4 100644 > >> > --- a/mm/slab.h > >> > +++ b/mm/slab.h > >> > @@ -567,6 +567,31 @@ static inline struct slabobj_ext *slab_obj_exts= (struct slab *slab) > >> > int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > >> > gfp_t gfp, bool new_slab); > >> > > >> > + > >> > +#ifdef CONFIG_MEM_ALLOC_PROFILING_DEBUG > >> > + > >> > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) > >> > +{ > >> > + struct slabobj_ext *slab_exts; > >> > + struct slab *obj_exts_slab; > >> > + > >> > + obj_exts_slab =3D virt_to_slab(obj_exts); > >> > + slab_exts =3D slab_obj_exts(obj_exts_slab); > >> > + if (slab_exts) { > >> > + unsigned int offs =3D obj_to_index(obj_exts_slab->slab= _cache, > >> > + obj_exts_slab, obj_ex= ts); > >> > + /* codetag should be NULL */ > >> > + WARN_ON(slab_exts[offs].ref.ct); > >> > + set_codetag_empty(&slab_exts[offs].ref); > >> > + } > >> > +} > >> > + > >> > +#else /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ > >> > + > >> > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts)= {} > >> > + > >> > +#endif /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ > >> > + > >> > >> I assume with alloc_slab_obj_exts() moved to slub.c, mark_objexts_empt= y() > >> could move there too. > > > > No, I think mark_objexts_empty() belongs here. This patch introduced > > the function and uses it. Makes sense to me to keep it all together. > > Hi, > > here I didn't mean moving between patches, but files. alloc_slab_obj_exts= () > in slub.c means all callers of mark_objexts_empty() are in slub.c so it > doesn't need to be in slab.h Ah, I see. I misunderstood your comment. Yes, after slab/slob cleanup this makes sense. > > Also same thing with mark_failed_objexts_alloc() and > handle_failed_objexts_alloc() in patch 34/35. Ack. Thanks! >