From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3FBCE7B11 for ; Fri, 6 Sep 2024 20:10:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 960BD6B007B; Fri, 6 Sep 2024 16:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EA3B6B0083; Fri, 6 Sep 2024 16:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78B076B0085; Fri, 6 Sep 2024 16:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5CEC76B007B for ; Fri, 6 Sep 2024 16:10:26 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DEF2EA0CC7 for ; Fri, 6 Sep 2024 20:10:25 +0000 (UTC) X-FDA: 82535405610.20.8E8876E Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 2FFAB14000D for ; Fri, 6 Sep 2024 20:10:23 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uSkyO5Kp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725653350; a=rsa-sha256; cv=none; b=VWjyunHJ9Vw4EE4kRydDLbC8Y4TQ2f5dHwjFkZ2OiAaiwHz7p1MdMjE9KjqyZ7+s39uXsK z3TqvircvyztBuKSXi4jJHJYb5XOhWGInN+LbFmFjPJI7TLjO2fbnT+mPjcuj2Fymv6VhB 63uJUljSGxwPMcK85QlzRlyCFxSjjFY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uSkyO5Kp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725653350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pEVr4TQkWM51xSQ1EU645Vg/YgcR1Wzb2pslXzJntnI=; b=UAN61lealIl8R2s6L0+0BWF2c/ySg8QozPOCUGFk60MOlXuO00rE9k6YxBo0DkJstl3k2H fZ+Gu/3QflMOOyImbEBmThEUNVEaklm2umxRD7Tm7ROnRPmA6Pey8bxZy18wAFK6lT3ibT m6VojqzIt8234pZhp9Xz9Xf3JttEWrQ= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4567deb9f9dso18221cf.1 for ; Fri, 06 Sep 2024 13:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725653422; x=1726258222; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pEVr4TQkWM51xSQ1EU645Vg/YgcR1Wzb2pslXzJntnI=; b=uSkyO5KpeqnqL1VTJ4cXdCz8DteGWhdezUrBaI6Ht7cQI8yegyAbubbYnCV6cYL9xo OuJHYrFeEZtDs4j/+o6nh01YQH6M5klXPMnGVbQaibCsw0EbvxZ92nPLI0zcuZ3gUrZy 2KAjhru2d62iVmEx6/dNmAyiALvvuj7XHPQAHsBx8lmR93MkbQwwVpQ7VtkOlhXz4vZQ nKsmyPpprI3CpQ1S+k3x6mUGVXb5j+hTyYGhXIyL1H617TqhvAt5BFCSXt7Dbc5SRUN7 5ToRrGn54Zo4q8ZsCW4U2j+vORxq9Tgohbpx/g0C9tieUr05x/pLizFEUlr47U6ETl7R Uhwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725653422; x=1726258222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pEVr4TQkWM51xSQ1EU645Vg/YgcR1Wzb2pslXzJntnI=; b=E+yPO6hr5f6WTZrXhlm4mRDVBR5aWo8aPF19CoRstSQN4D+tjdPK0+4zJvWYZ+ggsW bPxE5NcH7nk0H/PtHluyxTwQkFf8m4D7JyYj77BRzQ05w66ukbh0i1xDAU4vcTdmYGpI r2kNoO2FYDNDWCFs9CaOLmeEPghisyIRhiV2x3NopzMxBsiUdyvZumHx2k0ATZk9lqsU 05OXF8uZsH+857mL7ugRWCA4LF4/uXWo6qvaMfQFaNM50SL0hecRbtikeshYt/+bJKNQ gibqyCKMzGvfarku8ytcuurhkouVHBjZ/1gLzdQvLt0UAjTWdDR6KgtAaoWVBmf17NdH VrQA== X-Forwarded-Encrypted: i=1; AJvYcCXH4XpY64yCLTS3oGbadXPTtBIsQaLykSXuCrajnv05fSjNKMb0PEhWyboQGvRWx7VcYwtHCtMO7Q==@kvack.org X-Gm-Message-State: AOJu0Yx3eX22uIbYw1Yh/f9RV2cgvc7HNHQ5iRiRoJMs4rDs6PeI9fW3 srHEoKJYVnXUysC2CYv7Ewgl+PcOwZFDFLAQCAabSA99AsgZEY+GeKtMgPMKpCs7ObsuWY8Ccev Y+U88kAg/8ozUg7/6bM4+YtoQxB4hlyTt3Nrk X-Google-Smtp-Source: AGHT+IEo+r/We55eTGzcfC1iyZnRWX+TItqds5VrqS5smVNhWNm7RrYLphczY6W0yAOsJe3xgdzYYWoda4BvzISrzBg= X-Received: by 2002:ac8:7f91:0:b0:451:caa6:bcd8 with SMTP id d75a77b69052e-4581fa8f3f1mr579461cf.21.1725653421753; Fri, 06 Sep 2024 13:10:21 -0700 (PDT) MIME-Version: 1.0 References: <20240906005337.1220091-1-kent.overstreet@linux.dev> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 6 Sep 2024 13:10:07 -0700 Message-ID: Subject: Re: [PATCH] mm/show_mem.c: report alloc tags in human readable units To: Kent Overstreet Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2FFAB14000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jeh1uxnep9d9c1jhq5b88jp494bq4swg X-HE-Tag: 1725653423-283074 X-HE-Meta: U2FsdGVkX1+wcROZInV/rD0Y5qeQPLPB24tC9kzcf3jm69wLo50P2Vnn8GWRFpH1l/Wbzue9o52cEd+rBNb2srMrah1lgSTjU8Lpg3Dmh9inFaNJ7p2vVt3R9zi2ecvLEZXM6Fs8+m6N4++HHAwtr3kRBSGOo+42XDDX7y/muukXc45JwNkjB1Wb4Xegx7l9RtOEp/fwnIPRys71srf75X8r4RGHqGeZLfTzEl2qCWgh1YW5Ad1pdrRa+/GE+Knch3uleariZ3w8WelgYwXqPmwp+UigkbQywGm6vk+eJRTQAWDnjEKLFlwObQm01Nmk/ol8YaH6UvTzuuue4Wc2lZL4xo2t+rp2W3ZEaguzUWCjE43bUMfo51znownt8j3qTpKEq6N1LhY6dU3/Lf4LRsDLnQAClLoZEXAi1MsFQHwVxTL53VnJW5iRmPbuCbthChFHJlu05k5CrNFJe/Ec4FFlFApdw5s5Lf9AxMUSIhY7icUXT7JRLBPezN9sov12jeU5MS3PfsfPwhmNyMKjmH9POAoIxykFrpFt71AT8kTW5aSzjnCYGZFEv+ffQs4qp39sPHBxZWY6wi6vP/sepYFi1E8ZCGW89b8VYqJriP8OAlM2Bk6pU7GajPa8+4qe2mMW7/auis4Qj2tcNsSeDq5oUaJzQJR1BVMFMgVSToPvegXv2AnHHNJli9nv0cjmAZATVKcFJ4F3Wd6xF8GTpuch1mUND2yEdlqZGEik+4hOso6F+NrXEzYeiDoNcCIy0MiiuhkSUwoHO7zFLPTTqke8+qXsDvkeu0phXx/tw0Lj/01J0ndCL2qHyhkAinAuGFP7If7/6BXxyf06A+xz8ULzGXOnRZzZKh6/nBVVKZOCnUQARatHuZio8S00rLrF7JSm7X4JDfFVt6bdowsx2klYhvhX9oAOR3uqMsVf77oE53LPDV1uC1YToLy59Oc3RiqfLAO099VF4/LuJVn 2nVqeC5p o6tpHhT/4SppvX6g70x5nn7iCYtVgSWxZ1bpZl2m5FC9+EWJvmIQFGlqYPDHjd6wkRyMPVU9HHt9YZisjCV1wD5+7vY3G0Gw6wxdGo/GTeFXGQ2+nOk/BKMUCZkb10dxiraS2cn/InaT105WdzQl8g2WndZjMI8SaqVGJ4+mwqe8nq8qKkLMRj92mGjlVAxVaWD7Y4KycmptUDybeVomE5o8Ti16uauOsiw8+AqDo4AexMzzDA7G2h4tknhPl3ex3defGBuzK1KB2wMybwuDiO87+rgFCr2JWhMdeSTVhxaBh096R2mxe6/YyxA5pKO/6RGmK X-Bogosity: Ham, tests=bogofilter, spamicity=0.193472, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 8:52=E2=80=AFPM Kent Overstreet wrote: > > On Thu, Sep 05, 2024 at 08:32:24PM GMT, Suren Baghdasaryan wrote: > > On Thu, Sep 5, 2024 at 5:53=E2=80=AFPM Kent Overstreet > > wrote: > > > > > > We already do this when reporting slab info - more consistent and mor= e > > > readable. > > > > Hi Kent, > > I remember we discussed this before and agreed upon Pasha's suggestion > > that if needed one could do: > > > > # sort -g /proc/allocinfo|tail|numfmt --to=3Diec > > 2.8M 22648 fs/kernfs/dir.c:615 func:__kernfs_new_node > > 3.8M 953 mm/memory.c:4214 func:alloc_anon_folio > > 4.0M 1010 drivers/staging/ctagmod/ctagmod.c:20 [ctagmod] > > func:ctagmod_start > > 4.1M 4 net/netfilter/nf_conntrack_core.c:2567 > > func:nf_ct_alloc_hashtable > > 6.0M 1532 mm/filemap.c:1919 func:__filemap_get_folio > > 8.8M 2785 kernel/fork.c:307 func:alloc_thread_stack_node > > 13M 234 block/blk-mq.c:3421 func:blk_mq_alloc_rqs > > 14M 3520 mm/mm_init.c:2530 func:alloc_large_system_hash > > 15M 3656 mm/readahead.c:247 func:page_cache_ra_unbounded > > 55M 4887 mm/slub.c:2259 func:alloc_slab_page > > 122M 31168 mm/page_ext.c:270 func:alloc_page_ext > > > > That's even documented here: > > https://elixir.bootlin.com/linux/v6.10.8/source/Documentation/mm/alloca= tion-profiling.rst#L36 > > Did something change? > > That's for /proc/allocinfo, which this patch doesn't change - this is > the oom report. Ah, got it! Looks reasonable to me. Reviewed-by: Suren Baghdasaryan