From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FC0E77188 for ; Fri, 10 Jan 2025 21:32:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B1A98D0005; Fri, 10 Jan 2025 16:32:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 260B68D0002; Fri, 10 Jan 2025 16:32:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 128678D0005; Fri, 10 Jan 2025 16:32:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E841F8D0002 for ; Fri, 10 Jan 2025 16:32:51 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9632012093D for ; Fri, 10 Jan 2025 21:32:51 +0000 (UTC) X-FDA: 82992842142.01.38A612D Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf04.hostedemail.com (Postfix) with ESMTP id B758340010 for ; Fri, 10 Jan 2025 21:32:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=w7SmVIm+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736544769; a=rsa-sha256; cv=none; b=AJkim/VQPqgabUpYYsy8RiwmY8o3uklHER1oZQzuWR91Jpz5lecLrZsFtlsGunxiDon5TL r4MFf0DjwI3mXZy39OcJJala8fGPqRZ3l1xLjL7Pn08+HwN99pgWMu+RFW6XpIBMjIa4Ej 9v48S5keZ85UWWQmnMM5gFaViNoyFjc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=w7SmVIm+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736544769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iO9s+szakul4E/2WEnhG2G7HJAsnQJyy47iQBn9j1jA=; b=rDuzAiyMoaDZIg91bWSZZCIQKTmxkNrCZbtC04Y1MfAFpjjwz6xDVvyEPWYHyg/BLMMDaQ dYRHDpXKBQZc53w3z3I4Dl4IYNIiDsnbIRDAlUKKt4ktIrsBKqAZdyUWpGOLWoJbGyg3LN NJiHJgvXaCXdQ471pPRSsM/TDrsvBNs= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467896541e1so58681cf.0 for ; Fri, 10 Jan 2025 13:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736544769; x=1737149569; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iO9s+szakul4E/2WEnhG2G7HJAsnQJyy47iQBn9j1jA=; b=w7SmVIm+Hg6eU4T/tSA/Z1etSHKaQ/BaT7jx/1QwQHWfKbSmoXesedDPvdaKF4K582 VjyCMBvb+3tVskpTpN5+eMZOUoxGYr75pwFMnBR2aA83vKPbbam70i7i+GTyVmrPvoTj tJPiMjUf7AZVhRna/5tpiUVSbNGO49Ur+x1RySj8ZoHZSsYwGjPtmphvfrKa2hlhXz0f +p5tXUcVjEsEcwZi5mjraRuVjddwaR9wCDIkAo9z42CJyTbkq9fz37lUGIJMEJDGi/3J WpC7dUhehpPy3IrfHe22WOBxi8KUvFiR8VG6Nkou6L0QLorhbbMAulLXpj3Fj0SHtMtn 3mzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736544769; x=1737149569; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iO9s+szakul4E/2WEnhG2G7HJAsnQJyy47iQBn9j1jA=; b=QkQ8ga9lsEzNBnJoETITLLL8O3txHmggo/x2WXGjNsEH56hmJPFK//opWS1KAHH/22 YfQRFnjADEj+0d0LdiblCkG9DqW7oPbAKb8R3A9bYcXGlnFed0ND4ypkSyVB5crlUOwn KfAl05pUE0etlRPWrXBoN+xZdrFGCHSgjdRHnlPUKkPJMsiVwfwVifEz6KVwcOH2k9hd qnRUishbDWU4CWIua6SAhM+2mhUa/R435aGPQkdfmawotxEETYYkUSXcE+ZypWN1GXWj cYKYLtDm02xoo8BIlvwy2KFcEyMd/0DvBPgCyo6TeHdsv2xC/FDtsDGwE1oOD/0TpJf/ Y3fg== X-Forwarded-Encrypted: i=1; AJvYcCXqhqEwto2GtFDn7HROkY80lOksnD5Ik3OH+cnhatGGG49KU4WqhNo4gOHqtsTKD9AWCoorKx4NVQ==@kvack.org X-Gm-Message-State: AOJu0YzMRfKLKbcGIQaXiRKSIyz1wuZ06r2oHtzvcudrYcnagpOJAIrU JsxxXV+JeNezi8qv2Tx0x6+O/7XROnHKlxhAHgr0AWVNlyDkRAVuaMtMsrFWpVYY5VgRfwqGK3Y AMV3yte252tljBIIH5QX6em8UKL/84nt9fOa1 X-Gm-Gg: ASbGncvm3/URBkcVlUEny7Vc1aP5zC3y+xXuFSmsEwx4Um+zMGh3wwAflOR6UOaL0ee Q531NCz8niY06Ut+s5XLThdqoAfpibfkBpO47QQ== X-Google-Smtp-Source: AGHT+IHtGoQwIvfoO01ptUkX9xO/qyf82fQhrhbq0qizCwkIbrpabwwtDN5/iK0ebbxvD+uq7grPmjKaGj5DMuTsXS4= X-Received: by 2002:ac8:5d07:0:b0:465:c590:ed18 with SMTP id d75a77b69052e-46c89dab6e2mr4099961cf.9.1736544768681; Fri, 10 Jan 2025 13:32:48 -0800 (PST) MIME-Version: 1.0 References: <20250109023025.2242447-1-surenb@google.com> <20250109023025.2242447-16-surenb@google.com> <5p3y2umz7yk3ymedybd3vaxz2f6rz52dzcjiihlyvx7aptxri7@yq2scgci3lyc> In-Reply-To: <5p3y2umz7yk3ymedybd3vaxz2f6rz52dzcjiihlyvx7aptxri7@yq2scgci3lyc> From: Suren Baghdasaryan Date: Fri, 10 Jan 2025 13:32:37 -0800 X-Gm-Features: AbW1kvZBb0W1ELVnGRwLtSKVI6boy0MRWCdZWqBm-an7v7W8QZuZTwPYx7uLPpo Message-ID: Subject: Re: [PATCH v8 15/16] mm: make vma cache SLAB_TYPESAFE_BY_RCU To: "Liam R. Howlett" , Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: e5jbqeaeyzzcsd6puitp5itt5gm1m81w X-Rspam-User: X-Rspamd-Queue-Id: B758340010 X-Rspamd-Server: rspam08 X-HE-Tag: 1736544769-596234 X-HE-Meta: U2FsdGVkX19s42Jrf5322vMk9BK55NiLXDGU1hCmS5O3GU1fLjO6LooFMyzj4zWS7Yh+cyHGE6Jqn4aw6PRvd3uvRJjfuqe5UlcmN7Xi5qK7agVDSLerex8nlAJlaLKX0z56DfZynNWz+zAAcg6vr5Zsogs4d8yfr2rXG5WV3X4jEwpJSDxMxy7MCNPtqqnctSoz25EuC/2Kvz3M4ktWp6HhvE5meRGZAY44mBlWFYcLH/WboOprRvIBKxcEEhdtmCNkvnZmeAtSnyTWjgPzpJq6/Q8NPMKNCii4GyPtH4ClDSne9uP/F+yn6tWTL5Eu1Vtvcy/ZJrAr++tJJtidQyMTNtjQ7Clq9Zg++ARnE+S+DiQbVJ+H9zEKlhel3cG/idW2uZDUPdUZQDPmPgD3g3p2bNegOZBs/rmRhiRq2ybTpfZIO0gVeRY1Dhhqi/evUeRkiBq3XOyPBL2MXFcDR39J/zC/oTCCwUbf0QJowrnbq9jo9gW/qyRcMKpim6jetYuie4h5+H8q4OGeX+soBQU0++PN+X16kQPwLFbkE3ETfDw/XrTwEIt3GgIiP1Hq7P8OdFjyXaIvrMxCvuAYJIEVz5SaTNUY/cuvZzUuGt1dlIELgDFwPnpfA6DoYRcll+zxZd32I8u5urvigIYR353k6UgwppoYLAA6z/PZcttbBWnLW4rqE9tWmcnZKtdWL8CWTIbY7J/WvShOji+8+Uy1XooMPVElasV8hhS4hfgzmlC4qDrPfBmbWbOKqm+aJSSO0f5Yrank8ZmjmPn899qONwn+MrKVgjuzwd2ibW1/RHQzXr168Ue/6RsGuet88CR7vpyceXOYc0V5vQmicok/b1N/0Wo55gJntTdHfMQR/3lJfSJmYAYIUzmruAkzW+PTDon+cECdBexc8ExxNd8A2rZ6Zs+JYHoxVbSbEeg1XSWojeq1p9UuyHlvDvOTaWOWmPxhQukYSrAw/7x zLMiVy4B MKWdToZ+GZVphLTqq06Z7OGoMc+8TOuKX52R3Y+KfTNWlIiiAiQ+yAT0XTjPnoDclqExDPIoSgc7iubh5CxzygmQww/9jdMadBytQKOzv4NlhDgOwHzhBA/JupziyEPOkLn3q1HZwuM9dIVvvI2952lnJIJA6wl080jyZdw4ngrsrLfNODveCwpms/O72NaaZw+46G06gpCkXmbwISAxkGW4tCfCA98j7erlSIuNZWSWWh/ufg3P+Z3n0+G7HKj6aAXbSXOqvHWgu+AzttxC6c3Kd4T7/px7HqETSJ3trO6XnMsvAs+BTqio3zYzkZe3i95R4RcTJl5tCf8NcGRph+0NWJ6JADW9jIBj0p3IrBB+MBMSv4vvk2Z24h6tu2zWkmj9m X-Bogosity: Ham, tests=bogofilter, spamicity=0.051828, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 12:47=E2=80=AFPM 'Liam R. Howlett' via kernel-team wrote: > > * Suren Baghdasaryan [250110 15:35]: > > On Fri, Jan 10, 2025 at 11:46=E2=80=AFAM 'Liam R. Howlett' via kernel-t= eam > > > > > > > > rwsem_acquire_read(old lock) > > > __refcount_inc_not_zero_limited() fails > > > > Are we looking at the same code > > (https://lore.kernel.org/all/20250109023025.2242447-12-surenb@google.co= m/)? > > The sequence should be reversed here like this: > > > > if (!__refcount_inc_not_zero_limited()) > > return false; > > rwsem_acquire_read(old lock) > > > > and because __refcount_inc_not_zero_limited() fails, > > rwsem_acquire_read(old lock) should never be called. > > > > We are not, I had an older version of the patch from the 7th. > > Sorry for the confusion. No worries. Thanks for taking a look! > > Thanks, > Liam > > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >