From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D32FE7717F for ; Thu, 12 Dec 2024 07:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BCE36B007B; Thu, 12 Dec 2024 02:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16C9A6B0082; Thu, 12 Dec 2024 02:16:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0334E6B0083; Thu, 12 Dec 2024 02:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D85FC6B007B for ; Thu, 12 Dec 2024 02:16:39 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FDC81C8986 for ; Thu, 12 Dec 2024 07:16:39 +0000 (UTC) X-FDA: 82885449024.28.5EBD41C Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 5BB28140006 for ; Thu, 12 Dec 2024 07:16:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fHukksPO; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733987774; a=rsa-sha256; cv=none; b=4XtQrVJHhbnygwmaj8WrSWP/y2/xDwVDjwqiFD+AN5kHrVeFu2XircIjdVLysXCDcBL4SP kd79jSIoCQQaETa3gEHx0myQrJr5Mv1ah7gFqPoQ45i4B0Yu31fxWchmMwLfhjWYR/n5K5 mSS8HsS0MymAgApDWndqp2qkNUYFu/8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fHukksPO; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733987774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fAqzJau5MNI7uhPzwJwwA8EW7jYEvVF2H0CgK8xErAM=; b=mnQ3Gj8fCsSG1L9g8Ni571fAEhu1zha/ZwEa3bxsiI5Vxo036CI7Vm5Ylr0mlJfuWumSAL 2Y1ZMC+PFwZrrXmKzpAArGYJs7y1Reci+7GQuPz7S1kRj4EQjgjwh9wgiWGx1Y5KGVn9Wp 5yLZ71PcKV289OKYuN1XXKdRzgAztmE= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4679b5c66d0so60661cf.1 for ; Wed, 11 Dec 2024 23:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733987796; x=1734592596; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fAqzJau5MNI7uhPzwJwwA8EW7jYEvVF2H0CgK8xErAM=; b=fHukksPO362hNvPf8FImWPP1gr63DgMyYmdZUUEel8anEYTRz2kkJm8zBV7GacrXDf 0cSDwZh0/0WqFad9/99/ftcL5c3TWG96/il+oszK1N7wc0LZ6n4Sdab7nj3xbKI177W6 W+iB8D6Q9GypeOUaEvB8maq6OADhq+FPl1pMTLU3Uf7buutQstLKaotYtQDz0UkSMtkM 0G0vJihln0qROwXm3LC2GuQz0ImKuJjR/fHGmnVFaOq53cX6NPbRQwDzGnXq1F6Tsoro jLDivfCc5agw3r9IcB8ihI9sh+h3zIQ/DmL8HWuLlYFqQv4+IgSg0uchdpANQrqNvo0u YRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733987796; x=1734592596; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fAqzJau5MNI7uhPzwJwwA8EW7jYEvVF2H0CgK8xErAM=; b=i58Npaz2shYItnVO+ZrMDzm6h9Zd++Aal1b90p7JbxAwsrHzj5x5gvcHe+31Qh4Gdc uPfrM3OwIAKP9aUfg7NNmtti5XNr2OsanQhifhiUP3W8C+OXCs3KFto4XUJFxVKEF4ZL JDut3eP517pYYK+YS+glP7QkdzSvT939X531v2d3h2AJFjK7mEm6v+xX+Wt3zUdW+7wz njeh4BZqI5fYsZOd9JEinedz0RaVGJHRPWUS22DEqgthSelFC989t7A9sm/NfLiXX85B ucpxqdCWVBs0G8fG4B5IPLY0egwQp6OvOHFPhPmBIQh9+PAPXo2VSbKd3cbCFxYbU0FO uEiA== X-Forwarded-Encrypted: i=1; AJvYcCUYZvArb56eBaGGM3sC3Rnb6NsLwgh/w8bLdmLzUCJzoSnWTSs1ktw0izsGsNYu683Ojx7yCeNFVg==@kvack.org X-Gm-Message-State: AOJu0YxqRax9hHRd6EymlO5hLfuy+qvH59zxiJferxaKaqPwIR4S/YE2 AuuSvs6HHbnwW/Kb0OsPKfFt9o3900HnA0fSvGAeNdz+6aMVAkMJkDza4AGcmMrStCu1f5Dndcp 6po8B5xWYfff3IcKAxVyMjQ9I+lJLBJ0yByld X-Gm-Gg: ASbGncuXA1F94Vjhgt4iVIjzis0M8Hpfk+m3P6WE2NqRrVzAe0drnQkzkCgPmOebM/g DwfRGpA6npQV/Gwe+jmAkn2bhAe5g7Ocw40TthOUGRhiPwYJnTdRgVnD+zARQD12pH/Pk X-Google-Smtp-Source: AGHT+IGgAPHIygAP8O+rI1KHXuuM3G5cHRMeOHQ7eC5ChWIlENkidXiO0dR8zJiRe2OJ2witO/aX1uih99/P6Sng88s= X-Received: by 2002:a05:622a:1cc6:b0:466:8646:c72 with SMTP id d75a77b69052e-46798246560mr1625341cf.25.1733987796309; Wed, 11 Dec 2024 23:16:36 -0800 (PST) MIME-Version: 1.0 References: <20241211085616.2471901-1-quic_zhenhuah@quicinc.com> In-Reply-To: <20241211085616.2471901-1-quic_zhenhuah@quicinc.com> From: Suren Baghdasaryan Date: Wed, 11 Dec 2024 23:16:25 -0800 Message-ID: Subject: Re: [PATCH] mm/code_tag: Skip displaying the code_tag if it is not called To: Zhenhua Huang Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5BB28140006 X-Stat-Signature: g59kthbph9df1ckuukxhe9ek8o7tryap X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733987781-649110 X-HE-Meta: U2FsdGVkX1/z9lsGKl1au3kCpos2tvgFaKpqnsj/+Oe+o4aYWN/qTy774U9OERRzkxuwMfCM8aIG8JJ9hLAn62U1XVdtcbkohrCk0H5CFiXTNlqjtwdTmqxY8Clfv/v3VSbe9Qx1ifow6Iew4m+FM/jv4oHEcHuTK6HRpqWmajNcnIrYnvpsV0PxCp+Z4lByY1+F9n0LMnD2/2zgQSW9i8fSsGhRBHx1DobCuCrWb+QzPf+LSCBc9NlPK7CYujUpNdj1QSFLR6lIXURsKnEe+r2GhkQ+jwWrA8PeRi5MHljcciDqenrnG7XPSYIlRF2FQZWfLs5Q3SJGS/U83Wi69DG/2pHMBdkXh2NOMMYGVUrvReJ0XN1KVJ4WTA8l0hjZ9CPqyUkYKDoNEhh2ZqtRYV4Wi3EKwsqoL1TEjiCJcB4OEn66oHGElRTJV2A+mqvxTXOVE0OqmToHCFChgGaJwpwOSpEEPEaR1ZTk7Qqxgen5BB2dfdDaIAkl3tblWoQit2Qi90uTyo1jj6S7bawVJyhIVi+VBtzZzU92+PX7ijQ4Kuurw851pUPMS0YZvNPzaDa0DHqNpyt9S52SliyLokASFzLLdOIoQwtxTme0MUokNL4Q9bJrL9ETh4X8UbC2FUZjN02lFnoU3NRbLVm9n5Eog6wCioSKUIqhkuDJVaP5vh5duLy1Y0KcHzYcN6mP/FrwipmstVt0hknaou+8aP5WXInFixM6Tvz1uFJr+86HrvDZ0GsdZR9DFOlQQwcBybBAd6H5q0aGNo3opZyqhKOUVQTm+eNmeg0oczTLzOFX9UUWdbiunpwxN/hgXJAc2iAHXLCssh4G/0QFMU75UxIT/KoJUMk77Tv3Dtb/qL5QptNwzjM9CAgZaTjRqhgv1xFf9l2MHfNWfvxdTku0LSG63cYbPCd77XCfJ9QWv3ZwonopTtKfQaddmT3ST5KLehijb8kwA5IaQ8mdxgF hJQ24Iiv KQWyqC9FHEoOe3lO9au7oDs6B7E2zJuITg4+BNcv06DbkH1+mvnwLeF8StzFjToihpr8fU/8PgkNOtESBFNlXom+Koyx+lT/9woX6Kz7g191cRV9vjLg/+LaRaxOcrwSgkdCnGng2/H9XW7LymJrurMJlBW6/zaIodKt3rNADd0Or5CSMNmh0PDNOH679pn758EQaoZC2HV11NxNGJPgMATGD4N4VZQd7GFRg/ON0kHlz7M6V0o7IFl73yntUiX1ZtrhYRHA7hhNIXYZbSJNmp75VPP0Vk/j2Qx+dhijy3L/fLl4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.332319, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 12:56=E2=80=AFAM Zhenhua Huang wrote: > > /proc/allocinfo is full of callsites which are not called at all. > Let's only output if the callsite actually been invoked. No, I disagree. Allocation that was never invoked is not the same as no allocation at all. How would we know the difference if we filter out the empty ones? If you don't want to see all the unused sites, you can filter them in the userspace. I also suspect that for practical purposes you would want to filter small ones (below some threshold) as well. > > Signed-off-by: Zhenhua Huang > --- > lib/alloc_tag.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 35f7560a309a..06fb7eb5c0bc 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -95,10 +95,12 @@ static void alloc_tag_to_text(struct seq_buf *out, st= ruct codetag *ct) > struct alloc_tag_counters counter =3D alloc_tag_read(tag); > s64 bytes =3D counter.bytes; > > - seq_buf_printf(out, "%12lli %8llu ", bytes, counter.calls); > - codetag_to_text(out, ct); > - seq_buf_putc(out, ' '); > - seq_buf_putc(out, '\n'); > + if (bytes || counter.calls) { > + seq_buf_printf(out, "%12lli %8llu ", bytes, counter.calls= ); > + codetag_to_text(out, ct); > + seq_buf_putc(out, ' '); > + seq_buf_putc(out, '\n'); > + } > } > > static int allocinfo_show(struct seq_file *m, void *arg) > -- > 2.25.1 >