From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E9CCD37B5 for ; Wed, 4 Sep 2024 01:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7018E8D0206; Tue, 3 Sep 2024 21:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1868D01E4; Tue, 3 Sep 2024 21:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5556D8D0206; Tue, 3 Sep 2024 21:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 381E58D01E4 for ; Tue, 3 Sep 2024 21:07:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB2AE80C0D for ; Wed, 4 Sep 2024 01:07:45 +0000 (UTC) X-FDA: 82525268490.22.947F26D Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf18.hostedemail.com (Postfix) with ESMTP id CD0511C0012 for ; Wed, 4 Sep 2024 01:07:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=J8HuOWyg; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725411988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aiMCdeWSF+tl7YGOAELZGKbNlcDS1t44j3ggjkwtiLI=; b=4gRG4z8XnUKO/xW1twxyL9w270AlkljSjEElygfBVBxeBxqpWIlORwdSC8SlFfhBnDyqE5 G0WdnbECgIlXD5PK9O4Dg8i1hUDjMadTmX/cq7GtU9yXRRsk4/3Ya2k4yeZZLTQi3ikdas bX3ek4W8rW7MuUouEqLsLqjHXj+RU1k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=J8HuOWyg; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725411988; a=rsa-sha256; cv=none; b=7rDncV7pu7UsGbe0HA0odcQYBZpcXxvX1hicMKJJoYbvn2Fj8IyzeoDwW0U07vFjD2Sd+n /CpxhbroCvmJE6auO/dJ2Li4LLXeZFwfie5l37L4SvtozR38eS2Uba/MU97EgRYhSsFapn IIKZ3zp91aF+yuiLOKuRs2/1wQwH+yE= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20546b8e754so58435ad.1 for ; Tue, 03 Sep 2024 18:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725412062; x=1726016862; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aiMCdeWSF+tl7YGOAELZGKbNlcDS1t44j3ggjkwtiLI=; b=J8HuOWygzuIbgbfeOIuxUb21lw4duOYwdRoeOjw5o9LnPnqizJh8OIXNKxAFwpWJpL wT09Z9YRV5NZ7Hm0PJvANxMYZQ10E8jTb6Kem2EQM50rHv02EQNN46maYkt1ZgchrVSE eMFvilEsIVxstnANyYDt3AymnF809k6gbG3PkreDLlDK75AILLPpYVxH/3Tf25Yub8qX zB4wMupPc9DYWQbT/hd5BD960r0nOH4Oj26zgJfBdnTf5E1FAiypVJlVnFln/oFljLdD 4akWcPnb80ktfMb342me/w4VWYlT5olMZZ3TjsdeLzOsv4Xw6c9Qf3Vg9dJozbyJS6+z 88+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725412062; x=1726016862; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aiMCdeWSF+tl7YGOAELZGKbNlcDS1t44j3ggjkwtiLI=; b=S0AoansPCmi3AsEEqDQBTn0bvVerQGmNjG7yylJ3eV+DFzCyQu8Aj+og3FTbocj1Gi Sm/2xZPCmc+Gykgx0PcdFhL0ujEerqm6digr6sY7lRBOxpBWDnr3QDaPp/IQkSVvWRjC i5H57SfnjOAX5LpOJoUSIfSq8/LRR0jV1bDsf/fPcfp2E3t9hmY4HzZMcikYyaUT8zho 098ju3qkwfaBH/sCmmbhf5T07OJyQzjZuANoLQXi5Z1tgikaNPlfCOlOtbp1e7eqmL/l kfyqHcyjGDvIjW729HQX2p++qDhdOmPXBoMwIwxefv/CKruTfUez5oQIJh5MKSkOrER3 esHA== X-Forwarded-Encrypted: i=1; AJvYcCXIQkouGsVV0ZZVz6Eu8g+WGsFdsLsqfvhctq5T3k0777Z+MlMb72z7OP5ikRY3dPszVd+vW1/ZqA==@kvack.org X-Gm-Message-State: AOJu0Yw++HwDCQSFWOG03yEzZwX1wZlo1XB1X/EdGfAYPX4x6n0HoUgA g+azpbf14wx2btELjCFki5LBqf+3y9fOiAaYwqNAkxoA7j/oOyRxoGaqotr4jEbgTdmDWLhZY7v IqVw0XDLTJo1ExlRAJOsVup/+Zqg3BD+BrvIc X-Google-Smtp-Source: AGHT+IHMZ7W6FQKnT8cNzSPAoQtVn4rXVv70QDuyzkhCB6YXblkNORpk0oIaHX18vr/BWumo0bGcKw60Ta+8WLK79nY= X-Received: by 2002:a17:902:c412:b0:206:9e8f:7cb with SMTP id d9443c01a7336-206b070e38cmr1640645ad.2.1725412061797; Tue, 03 Sep 2024 18:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20240902044128.664075-1-surenb@google.com> <20240902044128.664075-6-surenb@google.com> <20240901220931.53d3ad335ae9ac3fe7ef3928@linux-foundation.org> In-Reply-To: <20240901220931.53d3ad335ae9ac3fe7ef3928@linux-foundation.org> From: Suren Baghdasaryan Date: Tue, 3 Sep 2024 18:07:28 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] alloc_tag: make page allocation tag reference size configurable To: Andrew Morton Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: t47qicti6n6dypkorwkxssgr5mu7nnyf X-Rspam-User: X-Rspamd-Queue-Id: CD0511C0012 X-Rspamd-Server: rspam02 X-HE-Tag: 1725412063-123448 X-HE-Meta: U2FsdGVkX1/vRKHByWFq+rKSabzblGkmdTLUfFMnbUtGssDRlhUwOPWNxctNOq9+R4JS/lEL0r7dKP+XzdoCw3tb4J6E1tPc/85z54HzzKCmIyj2btzVc0mOHF00anJ2RvOxPKVwBzNDH6s+W9xI/DPNGFnCrKw5s+OSwVIDk4BVpXgimk2WXmXEKAiK3Io156RcctBLfV8BC7Q/o1gsDPaa6fQbyuXm944/bUDUIe81ZqnsgXQ8bu8B6a8GxP8OdoEanncgqGbkvc4Vof/QB9qjDItSEpJrYoJuHcwIwZg/Ei86m4ece5+8E9yJwy5qhFO0C8ns0kbUWsoJQ9yfMb9TAcm8DVcKBrTbRNrNc8a9dC87BSvHSn5/vSD8nIKe3bgzT5P5VLn4eRLd6brDmznx2DzcEo0L+JirnnWEYandKBoU4QCs823w5Wgyw8ZwXhmoNJjJg6qoMGNMPhShnlu9daLXynkMAebDiOQZ9N/1NB38fZbfR7I06qdNvW1+W48p12tVhRwdTBl5kNXeM9Ml68Hb2WwJFv8CNkGLnVz05UOpsIDeoJMT1DNILEaxdUgeBnwR9z61w8iR5db1yd1B/l36CBySoFPXCW3SRBA3AfgxGpQh4YVQRNrXI2+jfKXzx45usfIbrBSXfsQkQcPymLcBEAVuUeaUy+0c41gY8k+dpJdUbUGHnDhkH3xobHDv/0RuEaVQMbI91D9y9gByRpPNQqomEAYG8J2HsBNuUt9XO4Jo0wrgWUi8i4WFlrWgSOwAo8frmYxdHqPSe6AnezIwQhydpYausO0ZLgHVP74XPvMd5r4a5Uv72XgX1B2gy6QKYCDEFfOVhllLNQt8kzfkc4Ry91+oXMHie0KLneutOsPZFzMgv/CW+wxpAr7RHsLTxr6TBRytAs9QP2cLDwiTojzqHAJX0UgL0PX92K4GwVEkl7Z2qCeYG+JdicqtRHC3jxyHmAigMKU 7xdM7V3I 42RcCOPSlWsUCEI1UFiozwppVzv1ovR/lztAXcLxaEoLGc0BN33DmxVXnyqTu4PTccTdfmphQPwqPJ0K8oK7de5u04OOGYvE+Txpj6M9KYwfnw+Ji625mnahIxWMwsDrjUcflEw+87Jnklfhqv5T4sfiBCdQaRAoMDgsi0KRdj3tOPeqzGdE5rF7C7dTDrodbRE85VvHbbkojc2kegIkzol+5b0e6k9V2OvSajF7kd4uM5vWUummCHJterrSY6NhRiILZjVpPbhR9/xXMAqy+IFGdpVx2XFiS8oZkWs9mOnj1jEouW0+/WMXA7mKcHlcGrKILZtmDESthv9K9MyyKVnkEt/bkfW668Z452WRByd6S83TDPeGh2Wcd0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 1, 2024 at 10:09=E2=80=AFPM Andrew Morton wrote: > > On Sun, 1 Sep 2024 21:41:27 -0700 Suren Baghdasaryan = wrote: > > > Introduce CONFIG_PGALLOC_TAG_REF_BITS to control the size of the > > page allocation tag references. When the size is configured to be > > less than a direct pointer, the tags are searched using an index > > stored as the tag reference. > > > > ... > > > > +config PGALLOC_TAG_REF_BITS > > + int "Number of bits for page allocation tag reference (10-64)" > > + range 10 64 > > + default "64" > > + depends on MEM_ALLOC_PROFILING > > + help > > + Number of bits used to encode a page allocation tag reference. > > + > > + Smaller number results in less memory overhead but limits the n= umber of > > + allocations which can be tagged (including allocations from mod= ules). > > + > > In other words, "we have no idea what's best for you, you're on your > own". > > I pity our poor users. > > Can we at least tell them what they should look at to determine whether > whatever random number they chose was helpful or harmful? At the end of my reply in https://lore.kernel.org/all/CAJuCfpGNYgx0GW4suHRzmxVH28RGRnFBvFC6WO+F8BD4HD= qxXA@mail.gmail.com/#t I suggested using all unused page flags. That would simplify things for the user at the expense of potentially using more memory than we need. In practice 13 bits should be more than enough to cover all kernel page allocations with enough headroom for page allocations coming from loadable modules. I guess using 13 as the default would cover most cases. In the unlikely case a specific system needs more tags, the user can increase this value. It can also be set to 64 to force direct references instead of indexing for better performance. Would that approach be acceptable? >