From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BA4E77183 for ; Fri, 13 Dec 2024 17:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691636B0095; Fri, 13 Dec 2024 12:45:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 619FE6B0096; Fri, 13 Dec 2024 12:45:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B9846B0098; Fri, 13 Dec 2024 12:45:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A4676B0095 for ; Fri, 13 Dec 2024 12:45:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45595AFBBC for ; Fri, 13 Dec 2024 17:45:47 +0000 (UTC) X-FDA: 82890662778.12.84339BD Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf28.hostedemail.com (Postfix) with ESMTP id 18E46C001D for ; Fri, 13 Dec 2024 17:45:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4DbxDps1; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734111933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlVKHYsrjLmvj5laSk3FKQQhA8RJ98WLsv9xIi7uKWE=; b=GL3llQTS0CUs4RDQnvsj4Ryr0di/8MEZUKLPP4oZu7AAIyN8RlARZqqkKeFKuFlHMMuLh0 SITK6iExLyOOFsB/8ZHeIXcY7bqLcXZViFPtYDVgfRylDdLcNGIJ+KWnkpT0lA+OtlbEeN QzD8Sa65U39B6fuoJx5RThdhH2vMZUc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4DbxDps1; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734111933; a=rsa-sha256; cv=none; b=5r5EhnYSg3hL8FDHA7jNHk1UsV5Lhp2DAvfg19LYspk3tKAHMXN9Vq7yWQDYdxvk4fb2EC kxXpoxPcarkDAyLVbSTVaZnotwRCeuIiwZZjIVBVcBzjTrG/ayRFY7iOm3zBjXojCIrrgp LuGL4MKYZEn3xaYFjhooMcks9pRM4GI= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4678c9310afso701cf.1 for ; Fri, 13 Dec 2024 09:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734111944; x=1734716744; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HlVKHYsrjLmvj5laSk3FKQQhA8RJ98WLsv9xIi7uKWE=; b=4DbxDps1m5J6EtMS1QwlXr4CdtM3AtDOfW/o+44D420ma8TdOnxsLRqZyjt15PVOml t/EnDHyALscapaoxHQ+jqJ1mCuiVQHayJvltP/dOqjcvzalujAAuIHJ2nXxmktACuwz6 T4snctHCvfU+pceeFuaS4l4ecSRxtgHFguR6jcK1bY9rF/lDOMjsFtHSnsVXex9R427D C8IYzF0N/E4NEI/owCbeh2ICT1s5T0qzkTXgPRBLLAMvDzVakLmMUIKwXSYT71TJ1+gr Oj4P15uwe1V8/b01HwwqaqDJfsHhzFt6GjrjppLQLsUmoIePbGGJqenwL1lY1PHsFDqA IPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734111944; x=1734716744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HlVKHYsrjLmvj5laSk3FKQQhA8RJ98WLsv9xIi7uKWE=; b=wJhJ+QwdcPsfk3Oq77E+HVo1P26bcO5gQyATP99RbjIeQa25c1r2YrN/KCOgcZ+mqm cR/4piP/SW356+odadzN6XcOU3wqvvFOsPMhF1YviaRCwxTd7AKXcpiYLxFfSPCzZ65k m6zFMQkSgSyFEHGK/MIHT4XXMezXuKQWJutV6mve6scQnF1XApabtdKeE9Q1DBLID/+e oOXnGwHWTviys39m4JMxQDeqBqIjYACyJq46iTrZqyvLnm3iUzcZx6uYR/gwX29zIzVL JxCRWFuk15DoFtJ+f/bSscQUO9YWd2NF4zCvbPydNnWz+Jx5o4WIKz5jeR6XrNLy8tFF nWUw== X-Forwarded-Encrypted: i=1; AJvYcCXG4Vl19bR/Wy/3y+qjtNW64RanLCPDc0gnK6I9rVYFt6Wl6nMYxxdXWow44yB539Ha0Rs+yEmR4w==@kvack.org X-Gm-Message-State: AOJu0YwkATqg55T8ns857fnliAgD5Q6fqGWOaS7IaKLzjIXRHCbFe7NA ZMAukR2um7sKORSCSpL2R7tbh0h4pc66JDNujdq0rBWRSG/wciLvCcb/Hg7NCuhsSOQruRKWP7O 69yC2SXBKJAX+/Ev3OLUzhywHqmYWrt0AbAEK X-Gm-Gg: ASbGncu1ynvyC6l+h2hm8a0+FGrwkj5H/9dMCA1+cdYsEYNsQVLo+1yLK9l9TWuvj9T XHKyBWGs5ngYMbHbUyONz4N1UCF8ZQo2m1PtFlA== X-Google-Smtp-Source: AGHT+IGplKxIBGZDhO3HALFCCrn/tSzaesddHD11PZyBQJ1Q/vgoLq/oS7ohQIcKhbW+fc2DmazVW8pCuKCd/dnml4A= X-Received: by 2002:a05:622a:4207:b0:462:b2f5:b24c with SMTP id d75a77b69052e-467a59d66f3mr3648901cf.29.1734111944106; Fri, 13 Dec 2024 09:45:44 -0800 (PST) MIME-Version: 1.0 References: <20241210223850.GA2484@noisy.programming.kicks-ass.net> <20241211082541.GQ21636@noisy.programming.kicks-ass.net> <20241212091659.GU21636@noisy.programming.kicks-ass.net> <20241213095729.GC2484@noisy.programming.kicks-ass.net> In-Reply-To: <20241213095729.GC2484@noisy.programming.kicks-ass.net> From: Suren Baghdasaryan Date: Fri, 13 Dec 2024 09:45:33 -0800 Message-ID: Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock To: Peter Zijlstra Cc: Matthew Wilcox , akpm@linux-foundation.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 18E46C001D X-Stat-Signature: z3gnaofy5f63aeefots8pgk3skfy531g X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734111915-29296 X-HE-Meta: U2FsdGVkX1+nJCTkvgdOPViGj+36sgtwdu5EmrDUtL8QEZlF2xx5cTcSqFk85VNw3jb8hth3HFIJg9Ohiwho/kXXn10I8a0Klw7ZvjYN2lz9BJXDyB1qcEGDIlg4Mz30kR3RqBvQbzjet1DVF4sPXc7LWp+YXck5ENc8Hp04qTjX+GYeOFpbX7Da2AX6gcg7ngJ5rNyon0VxsW3HR6dQ9Q12I+fZ9IJONwSPyrwu/Al2qAbH3Qk7Ds9BjoOz6dOWeL8BMDnXxExBt0sXzDXxi3UaovEDs+lOWRknpQCpWBKpjnR828M5/byuUYhZ7vZSQIEKErmvEBV5xtKyqA0SyyHWH5O/oTu/RZ7FXrLAfpNbOd/Np2wmOUaOgFgq4BV+eWgkCV7aBIlOY4KwUvwISKSjzb93nSKA7sXpA1lmIWPpFaWh6LYDlTX0286vnjbL5eSnFG5lU1brNP8lFtJfkp+knW2ay8u4Z/UD7GxLR1RsRE9fF6E8mVF2zyy0OTNSRR7mmBrnhY13KAJrQzuVR05DUZBsIyrc4UIYiMNf+0Ye2UGNHw9UBSmSikAq3/Gy3tZXujqW+H6h9+D+4121MyNny6M/dfmGH+LQeSCM+v2TPZwN4OZbRnbsHy7doq/BHogmJuGnNWsYhYk6TMo+xv1ETeWufaV1vVUwW8JodwaG4Y/yZ3Z7xO1izVXcXb6P6rodiGS++x4Mn7fWJJL2rfHEBdYuSWKzDCodwQ+jsO+N8MXY+TDCbKR7oRgCYK3/Gsd5IySs8v0B3caKskoDZOEVrdeiLUPRQ/BxAcbfsC7nonaC7FecSDlxH7crNeqFq71QuV+csWB7/zshiZ0X/MoD1BAX6Sf0w8P6arpekQ1x+f06LrkLvln0AVsXDHV/eu3T1CiLSsKYfcFycK9fU1PVoq4ASQOShvc3HTeKvOfxwJTX7TAfGWdKJFZk9lZjFzeXPPBGelsIG0ShGh5 TsRyNUQb WJhKvzXU5BnpsWogqFF4SP5kBP5+haReH6eCjEA5J4gYW/hIVTwjOJyZvyzDnnxpeLYgGtitCs0b35mzjWCp/eahONZNhfhdf/ACkqiCenYxWb8SGJreqjFDGoTifudsCxUcZ2XAf1nQJDODS8HXs7BlHbeCKOraLfS6xc69rv6Q0Tswpfq3AJU2IPc5AMfS+4d4jjjZRsv9i8MXW8NZlxX5Q9ezmzBazzRBbKrTq0fbayTZuP6Clf8p55FzQ9cEfBCdqdY0PuzoXVQFcHOERo1KSwxnyY/uK5YB2g3iYustQ3Xq9zmIK0UcFZ4Ea52JZu6YahtJtUhE37UM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.404315, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 1:57=E2=80=AFAM Peter Zijlstra wrote: > > On Thu, Dec 12, 2024 at 08:48:52PM -0800, Suren Baghdasaryan wrote: > > > I'm not sure if this is the best way to deal with this circular > > dependency. Any other ideas? > > Move the waiting into an out-of-line slow-path? > > if (atomic_read(&vma->refcnt) !=3D 2) > __vma_write_start_wait(mm, vma); The problem is not a function but the addition of struct rcuwait into struct mm_struct. The type should be known and I don't want to add it via a pointer to avoid extra dereferences. After thinking it over, I think the simplest way would be to move the definition of struct rcuwait into a separate header and include that header in mm_types.h. That, with some uninlining like you suggested, should do the trick. > > or somesuch..