From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F65CD4857 for ; Wed, 4 Sep 2024 16:18:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E78566B0326; Wed, 4 Sep 2024 12:18:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E27506B0327; Wed, 4 Sep 2024 12:18:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA25B6B0328; Wed, 4 Sep 2024 12:18:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AAE396B0326 for ; Wed, 4 Sep 2024 12:18:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5824641871 for ; Wed, 4 Sep 2024 16:18:16 +0000 (UTC) X-FDA: 82527562992.16.61DF61A Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 909BD80023 for ; Wed, 4 Sep 2024 16:18:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Hh4kZL0Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725466670; a=rsa-sha256; cv=none; b=VEJyoLkcIfAPNhoYYD0i1qIoongasxivjs4yAYfgqm0wk/q8crfvqH0sH/2j8vXP/LVLuY hH5eN6jgo3JVLKKKELIcvQ1U/3pJiiSDtkQKuNyeZ6KdP9LQBXrJlVWdslBbNtcHYqnqJj Uhql2UdAH9eHxPmtePZHUz2TsqTxzsM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Hh4kZL0Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725466670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WeGJH80bEcJ0365jFT2qsdMy+ow6oBRUAZDQ7XPYag=; b=siGVLl+Rj1Gdq4yNc0HYBfcSBXbp2XVDopf9xUGCiP2iyoAqBMUPxjyDkiEolBRDILZGBa rdQ2u/A7WdgTd5xRfHd1AkIuKOhj35uhVmRU0uokQ+lcGnByyFUbheMFo/EMQfrM3SQGCQ yf4RQiIRLJKjveOPSb9AygNc5Dyta0g= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-457c6389a3aso293411cf.1 for ; Wed, 04 Sep 2024 09:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725466693; x=1726071493; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7WeGJH80bEcJ0365jFT2qsdMy+ow6oBRUAZDQ7XPYag=; b=Hh4kZL0QeMcShPQIVER0QQr5A6+fJzNFqPtvMcXyuSMU/X33RWBQUnt4GltWK5VifH LL10c18aGHlbCYWnYmArU6JaGiehHofqlaFLRKpnXLAcFP8vKhC4dzSmZef84nw7Sfe7 GVYOnGlPNduB9GLQwJDq9GvJy22kRoHJR+KA8SxRKHy2RaMMqeFdSrSSu1orsVizT9m7 Arx2+l9i4Zia7oiO8Azq1zYKXLEudTtuuQ5aln7IUkWMfYZ1oz/cHD6OdRVp4tl+dR2U H8be5zMhNAljouE4dUkMau55oU1C+qZkWu9QVghdMgnJakDcQxbHumzCbEfDf9CmTJPe zcYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725466693; x=1726071493; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7WeGJH80bEcJ0365jFT2qsdMy+ow6oBRUAZDQ7XPYag=; b=UsE1SCxoEAy+FeBE7x/qXuaUgDxH333mHppvrzNGEYPWrGwUOOLLTiMvEcicqfn11J 6FqzAwZelaje9aRf3W1525GQonyFOEGa2tO275ArQK87YKh6FmmjKi0wXm9L1OiDBOhi yKYGkrubTS0As9nmrBw37BhaCbuPzeuuSWL7LXIQlT0veqc2QHmBtYSuUSxHNCXP7x5v GQm3lL5b7WBBgwiuFeT8JXfMIRALC1kunjqqUsJh0G6+9m5pbNneaqtihWSFwAjf450m L/rE/nsW/oqERMqEHFiQtnJN2BwCgNm5/ui3Ew+J35rSqGnvYlLM339kAi1UnbaCAlTv A4zQ== X-Forwarded-Encrypted: i=1; AJvYcCXhPlBxbSh0tf1qzhzK2zXqEIuVMGOPwKYe9cez4A1s7CvpSwqQ3G88zWNYPY2ruvJSO6DQtwt2Ng==@kvack.org X-Gm-Message-State: AOJu0YxxBvmlxbKIoRIahBKf/FJUEp7zXOWquJkqm55K0jILLvjgWTFO gU+ouJW28dfEXP7DwmFLXkTCD3h5vGi2hd1oryMLytM1CPbGFXiDGaL4VCzAD+B6ieM4XYH8ONv gBxQVO30KynP0Ure/+2FkBYKX16XOEcnc1g6e X-Google-Smtp-Source: AGHT+IEykJoO0CUB9s8s6fVSGbKiIoASEttssn/0WTzizKwfBV/HeZPmuqrT5IbD+slBtZTDHwI1j3Scv6KP974j2CE= X-Received: by 2002:a05:622a:15c9:b0:456:9498:6b53 with SMTP id d75a77b69052e-457f623ac57mr4374521cf.16.1725466693017; Wed, 04 Sep 2024 09:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20240902044128.664075-1-surenb@google.com> <20240902044128.664075-7-surenb@google.com> <20240901221636.5b0af3694510482e9d9e67df@linux-foundation.org> <47c4ef47-3948-4e46-8ea5-6af747293b18@nvidia.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 4 Sep 2024 09:18:01 -0700 Message-ID: Subject: Re: [PATCH v2 6/6] alloc_tag: config to store page allocation tag refs in page flags To: Matthew Wilcox Cc: John Hubbard , Andrew Morton , kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 909BD80023 X-Rspamd-Server: rspam01 X-Stat-Signature: d8nc7a5cb3c6re1jp44pd9qs53dt3ty6 X-HE-Tag: 1725466694-350572 X-HE-Meta: U2FsdGVkX18bEAqzuIW5/srqDAZOBFOrzlG/mxsxpUkbcawOdjo2uKIEch6KsZc3kilyaQQzI5GtDe1tx/7xqwg3Q19K9L5kCJg1JZb5u23TP+jKZsofYR+jENV2aXv/m/7OrcHTuNfO0tZqLM+W7rHkr8LNmJQZWZJzzCWRChxjYfXbHaqKwTPJDIGaEt20HErzgv+SglTRi+n9bA81t1KQdntDJ0CG/Zr0ifuvZBaoZed+6Dh8oOblFmZ15deL5tm3WrX4No1sEd5Q9zXIZ4gf+QM7rh6XLhmyyQwM7uHueEfBL2YbPaoNzwMaRv3TFFlTVIZAqkLRHQN5gspGCL0zv0joFH2xzR9Yu+YMKBryVaiNAj5TrF1REuf4VSV/x3OJAAKeY6inettgtMITPAOG4+zSUh1z4+tWrGTdYTfLLR5xUzEuZM2o8s2dcKcg74NHb5Do4kSdSYJflJRyVN8+CAlfoF04iJ5B1AcnKS0SJfXMVSKS6rMRHfM1A+KNR1qBnEAp0XGGa5YJwbD2KC6VMkfC6LG18EvlACl7eUukgdw4KxrhQTr0Rw2bDXR3ZjwtmByWdSBzo9orOIdjrPmpcBsoYs1boSnSgCHPEVxBnx3CHTvvr39CNpZcpiDzQPH/QSpsTa8pfN+4xuo1AmHTWJLKo2AHRONcvVQ0CwFnTDwAFuqDXwOp6cO6b1FYCsqH5H3PTbRnWkQEHx6U2HBSGVzblxfNDxdAQcMIdDFXEGm2ZSZD2ORuvV+LBOCPxi66IU0BTyKUSpSYOPj7lCQRbnyTgyoSIz0OARRi3913bDcXbe5uxI/KOvLGgLUHTJKar7pPfOz6ijeZnOdOeyYZeh6LQLv9/bTDTtTl7AtVa+AGMTmHVj4Ubysw0DVDWWG+om08GpcIkFI7sxZHUAna3Swlb4dOgIaYFJidiKlvVD7tmBJBw+x6URFvvCL7ukUlsRqBUerqLFA0Ain OHh5NOR0 z0YCZrfb2J515NTRlClH5iMwTsCnS47F6LQnWu5PI8fadCBEQF7sOjcpgxAuZnsGzw0ijtApFyEGpaPvHpFrNZJkYe0kf8G8X1p42P5yo3/xQnwkDxtH48QGdd/7a5u4k6EsvHtVxZoKBgY2UVEXKMvWkijlkWhg8jBptIM7R1Zu9v7/j/I93V26l35/se1g+RQb6yWlQaA04SZZ6NM7GI7qyxkpv0s1RHcleSUHEfQlFsqQcVrKDQE8tkypiq8DBi61zxGUNKYs10ul0hDVEUdec8aALaXPRGV+ytH5ePyEcgnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 3, 2024 at 7:19=E2=80=AFPM Matthew Wilcox = wrote: > > On Tue, Sep 03, 2024 at 06:25:52PM -0700, John Hubbard wrote: > > The more I read this story, the clearer it becomes that this should be > > entirely done by the build system: set it, or don't set it, automatical= ly. > > > > And if you can make it not even a kconfig item at all, that's probably = even > > better. > > > > And if there is no way to set it automatically, then that probably mean= s > > that the feature is still too raw to unleash upon the world. > > I'd suggest that this implementation is just too whack. > > What if you use a maple tree for this? For each allocation range, you > can store a pointer to a tag instead of storing an index in each folio. I'm not sure I understand your suggestion, Matthew. We allocate a folio and need to store a reference to the tag associated with the code that allocated that folio. We are not operating with ranges here. Are you suggesting to use a maple tree instead of page_ext to store this reference?