From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF7FC41513 for ; Wed, 2 Aug 2023 20:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5F92801E2; Wed, 2 Aug 2023 16:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 656D22801AA; Wed, 2 Aug 2023 16:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51E892801E2; Wed, 2 Aug 2023 16:21:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 445762801AA for ; Wed, 2 Aug 2023 16:21:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 13A3A1CA080 for ; Wed, 2 Aug 2023 20:21:47 +0000 (UTC) X-FDA: 81080285454.09.A8C7E85 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 3A83A40012 for ; Wed, 2 Aug 2023 20:21:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=064itWtp; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691007705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ua/z6hJjJwaKpWnVce2LKpeE5PhDq5AwoL0z00SOjR4=; b=40WTVuCNbGUEveIRZ7Gx6jnHyrnLOH/osDpprrYxlDJIanKFja4yeC209c6Gr0rUOS2MNF wPloxYo/BV4GHjtFIKr450otSQsyd54bu+6ldgeQlZpwMhfB/FGAdjGNV/ZYIBQilJ1gYK ntsyzPgl+vqwag10G3e6917pjpe6BkA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691007705; a=rsa-sha256; cv=none; b=Al9kmMYhzV9z48SiTrqKUZWaNkgZfFK0eYwjzDJ+776WwnU1jIicNv9TjDiyi9t7A0pAUr IZyaM3qqmNCoYDl+9x/blchKInFBWasCB6rWztYmMf+rUxQapUIF2IS9hfWaiDoOa1bJeQ s99qlzrm1VLk94cs17UmsGFW0j5+F/M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=064itWtp; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d16639e16e6so184478276.3 for ; Wed, 02 Aug 2023 13:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691007704; x=1691612504; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ua/z6hJjJwaKpWnVce2LKpeE5PhDq5AwoL0z00SOjR4=; b=064itWtp3kWfEW186lgdqtOYBw/O5OZE00SLFKDPchRuS5vHGdVAh7rm94pcPhRxvC e7Pl2vnoPsz8euehcSnFMXZndkStl2qAUnXOISSVhtP9jgtOx+WtBuUZMQgSKkNVxixo hjxRWZNoKBi1HgWiArxXBB2w7dpI/rQnwSCrrtvkkqfTs/5bX9Y91cdRsRPmRQT8P7vn LJnF7oklLQQi2Rjs3irE7YFZTi9LSXhV+n+yWc7LvBuhm0EdywbRD6y0yKPyPiO9DsZk Pmi2tBPJlcAWyKWDAtijPct3C28V3IYhrOljME2Oaom/rK27cB1Tq0crG9liRCUd/srK o7ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691007704; x=1691612504; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ua/z6hJjJwaKpWnVce2LKpeE5PhDq5AwoL0z00SOjR4=; b=kl+UVkJRZQeACDH5lZ7kd1WKUVefeKQg5TMRmCRNTcn1IhepfhLJlI1hnQSiWNex+f MHFjCBrRuB1gkm4FHfzgoUEjaFJdvce9wDdSkakuvOY63gNDpY/GDCIP1uaTSYtSWi+M 5adKS6IVAiHebx6hhPH2BT1AAR+M9O1cS0qFrkQxc9GLlkkqccRvW3+oXZekQ+tm9WPC a/Ty2+9jXnVebA/EF1MExdkvex2k45y73pSuVm4krRYyT77Dlk+f0H46KSJ2mUZMkv2c hJ4sdPQ7etPFiHsK6XHTdH7IslkzbgpPzjfFlBuJOo0h+pQQraYmrXvtTd6wD8ana0Vu hDVQ== X-Gm-Message-State: ABy/qLbMYoDMWxp9koG+FHDBztwO4P30+jgKeUnjrVKUtd/GNW84Ydli 0SYPHXL69YFcirsMwa3SBtqz3Sh8SsTrz6E8zvJJQA== X-Google-Smtp-Source: APBJJlEewzNilSK9EhWoCm+pHDq+zrz9nrcvOAL6kD//nIyxF94LiWj7YSvP5Zmqsl4NTrqRtDoNukIk3awhpvJrb5s= X-Received: by 2002:a25:86ca:0:b0:d06:d1ae:dcf2 with SMTP id y10-20020a2586ca000000b00d06d1aedcf2mr12816778ybm.13.1691007704032; Wed, 02 Aug 2023 13:21:44 -0700 (PDT) MIME-Version: 1.0 References: <20230801220733.1987762-1-surenb@google.com> <20230801220733.1987762-5-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 2 Aug 2023 13:21:31 -0700 Message-ID: Subject: Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once To: Linus Torvalds Cc: akpm@linux-foundation.org, jannh@google.com, willy@infradead.org, liam.howlett@oracle.com, david@redhat.com, peterx@redhat.com, ldufour@linux.ibm.com, vbabka@suse.cz, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, hannes@cmpxchg.org, dave@stgolabs.net, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xxuah8zefc9ryxbd4agg95aazwf1fqhh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3A83A40012 X-Rspam-User: X-HE-Tag: 1691007704-450693 X-HE-Meta: U2FsdGVkX180PJqsT1+KF9j+NoaWp7YVjWKWfaPGN5dQttg9IbvN8iU6H8p1ATsqyLbVi2sP/pzD5WCZclhfy5k0mPkwxcoARk1jtsoQanUBNA0f3Oxrll/jv6/7jkqvxbRK5wYP43JxF9jFlW7uMm89CMVP4w+t2I0OrhoHYd1QwQV2MNO656iAggorPJoF62FzBrgr+05MWM72LQ71jwvWDfMHSdajd1waMLRV8d/ELtGWLKQHxs62aE1XyIocbqvR7AcjkpQie99Wp2RnrMUJwAIG1S6pku/3ouI1+1+HlmXg0cEwYLACKKaiAgkurnT+jV1ADh6jqLJN9ah6mWifaazQqy3NGZyJ1GPutJcALa8p0Insmj6UWVBFMWbsGDuQJeeTYhteSLIkIYIQAbU8pIncgwI5aw0fA/adJmZUwV34zNRvHAKbtNCwpZZeCgsfTDKbQgk9v8BYcHA7b0fuXb0iNfoNvbrBjXpDgsqe2Ma8fS2UNzVyeTelths4XNHP69Q71019NYE8yEum7EgF5mKxtEbDVIhsTTIdzvQFBolwYLTbxImOQ2d7BwhpjL7WMrBr1txhLeABRKWZ5kCcoBsoeOojXx4HL50myq8uWcig679ebm7KBB1ski0u4X7iuNiaW3zVlO1166YnC/glif2ihfsQ5nmDcAizctj/f4jtpDxq/cUNzPZLDiSuKYG7mFlhG0V9TBQo43L8756FwOrabR0+bqDbRRCJwLMpXz4MigJ6AKjn5DewdSmS++N0aOa6TGk7LPBcQXPESS1aTkS1IoPGjZp46bLL3QcHLxPcd+MNvPD8oQjy4MBqAfDC2B9rtoHMejRrsExSCdf2hp1otgAg4QkKbviuXWeCCsE83QBgiZtAqUP6xIpBDQkywEKOR5p/Ap9t6Ugcf6Hb4UEufpPS9/2CIWJGdyFSX1VtUPWbGi4lOy/M4Z5zusiz9+mVOKcfjcNyAS0 KARd4Gqk CBeZtFagN6LVi2ax5G+7dRrgStEGS4p7BVOCiZFkxhVhPz6RHIM1kItSVSoCsv4bCSWaCOjft/acnqZ06dWdFDMc89UAvo3rPQBLNucQt3rW/9038+XaRbvrqEddiLUe4XFbtbiqkxKK5w6tl5F6ZDQPy5UcWytHScrIdbjFfJ+ZEOyzUrrm29dvXbG+xuXBr3JTSwr8IKO0UfhskTH1RMJE+vhK94xRV/2UjgBPsdJrzeo/t/h1ih4Hq0HXgjwdAZ9rXeDyCKM8k3l+zuehZywHmfE/PgHyMmHnmx/D5UQXZ7XBnl2ClfGmqP3+ji6b7fM6L6j/3rti58XgHWsxRWgAbNfvzk+2hJ+/gB2SOCW0CfbBEf3/2pnXfmXoaI+eGsVqbyJn8m0NwUeD4D9oG27zA9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002332, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 2, 2023 at 11:54=E2=80=AFAM Linus Torvalds wrote: > > On Wed, 2 Aug 2023 at 11:09, Suren Baghdasaryan wrote= : > > > > Ok, IOW the vma would be already locked before mmap() is called... > > Yup. > > > Just to confirm, you are suggesting to remove vma_start_write() call > > from hfi1_file_mmap() and let vm_flags_reset() generate an assertion > > if it's ever called with an unlocked vma, correct? > > Correct. Got it. Will update in the next version. Thanks! > > Linus >