From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E9AC47DA2 for ; Wed, 17 Jan 2024 22:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1B206B0083; Wed, 17 Jan 2024 17:46:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CB9A6B0089; Wed, 17 Jan 2024 17:46:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892DD6B008A; Wed, 17 Jan 2024 17:46:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7A4046B0083 for ; Wed, 17 Jan 2024 17:46:36 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4A10FA1F04 for ; Wed, 17 Jan 2024 22:46:36 +0000 (UTC) X-FDA: 81690288792.26.FC3C39E Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf14.hostedemail.com (Postfix) with ESMTP id 8BD64100011 for ; Wed, 17 Jan 2024 22:46:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f0aj8wYZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705531594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZEtfKHM4jQzQLGyBhBaXBaAlBL+U+MX7o4RckoJKRd4=; b=zB8dvU63wKLNqBnV3mvLNRA7QDoffPSW46nuWn9OslKFtw8wWleaT+1v0k3g7B5wVmrkaS 9GgOsuIZ+NRSLz6NhXaUXOf35dL69UhAKUaGHGT3fezOI/u+ZnDDx/PGSQ5/czwIi7i7dO A95Sf3/IaTPxk2x+hgtlbOf3pwZYEes= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f0aj8wYZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705531594; a=rsa-sha256; cv=none; b=AMsaM2masQz9Zf1w+kM2pF96n2s+mHgqw6AViFNnPcn12rDgENjeY/frondaG2AHglDBzO kR+1WuGB75xed3Zh3Js+pwwsmGnijD2luT/ROnMzOg732pRO3QCso808jXjFSjLJ2AwenG 2CoWKHy+7ARpP5MPspQmECQGm5SZaNw= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5ff484f2ae7so32084767b3.2 for ; Wed, 17 Jan 2024 14:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705531593; x=1706136393; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZEtfKHM4jQzQLGyBhBaXBaAlBL+U+MX7o4RckoJKRd4=; b=f0aj8wYZq4HluDbFB1YvpSGpKsnvQ5et9C7upiOXV9ixB50XAC/5cHPqfctCE4dnsr YLJQz9l1yxfP4uy7sQsyKw/9bmMX9h3AEJFTgxmsKmGt5hrdOecmBQiA2xfxltXsk3MP tSiLCb/mw+RaJvTO9x3xkI5vHjny77ezZkWpAG/hBo9jhIHa3skzyaVjgW2v6vBIuqtS n1hmIlspVz3NadyY033DtIK46STBQFXjGWuTq8VH16etVo75nqG8X0wAPU8JvSuTxkCw vCgRFO7ueCsG8mM/6UupHHqzuf801W7usWZ22+F6NF8VYJE/Vc0adpEeOh83tLVqvIH2 V4kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705531593; x=1706136393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZEtfKHM4jQzQLGyBhBaXBaAlBL+U+MX7o4RckoJKRd4=; b=ROvxgEVcLNOSzw4Ibj55RNVRbPE5wB80kBu2nKRN0SPqcwLP9zNsBrL5EJCT0zeN3V AxlVGU+pFGxM/2HYYZMyUM79d7Lci50G5z1u8aoxVs2uzR7D2NzJP+BFmbH4SnT1MCbp OlPhaLU6uGeuPp6Qci48orbRLUlQwp2zkAJ1jYSDETd26AktoNLtLyloA79oQEFz+UZe uspq+GCqn8mTcjBe/eIT+KCVL5ZpQCxoLVZ7Jc19q+fJfQ5Qe6GuNuIO0nbqoFCDBmab DeC0aXZCdI4/csLV3b4tbDrK/RoVaZQCkUVv3v4zDy9Na3FQvAs7TxZTuxIuaO4X4byg mQig== X-Gm-Message-State: AOJu0YyNQ05HjXvPYzTl+pc93zCBgCfztBW7cUEfTR87AmJaFh4i+3nU 22GPcBsxMWTsFcwCiLMTMl9Le8OVLdCc6hzfxWZ+iEnL8Yxl X-Google-Smtp-Source: AGHT+IFcNPtuzXeyNaWzcBsBS0yPnJacNDAP6RyfSMO6gLFv7R5OR5rMNmfvyQmUVgCL03Ny0eXHwuHfVLL4PqulmvY= X-Received: by 2002:a81:ed02:0:b0:5f3:dd8d:4646 with SMTP id k2-20020a81ed02000000b005f3dd8d4646mr7819257ywm.81.1705531593500; Wed, 17 Jan 2024 14:46:33 -0800 (PST) MIME-Version: 1.0 References: <20240117223922.1445327-1-lokeshgidra@google.com> In-Reply-To: <20240117223922.1445327-1-lokeshgidra@google.com> From: Suren Baghdasaryan Date: Wed, 17 Jan 2024 14:46:22 -0800 Message-ID: Subject: Re: [PATCH] userfaultfd: fix return error if mmap_changing is non-zero in MOVE ioctl To: Lokesh Gidra Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, david@redhat.com, axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org, jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8BD64100011 X-Stat-Signature: 8u854ih5yo5q1nsyykcrci1o4be7o8h5 X-HE-Tag: 1705531594-3478 X-HE-Meta: U2FsdGVkX19+Cqbwpy6RqH1kJilAeFfZVVAlmFYcopSo0grkkEs+sK6p87+sl4M330dn9ckAtQJu8OX1w7qV7XZ9z25PeipUd9l1RZ2GlIgUUP5CwGnQSc4K7siEw3mJkixyRN9mmcyUm9kjM1Z+CzRHVu0dmfuR40bElymhwPoNaupacUv4OcUzOkstML8HUUD5vujKWYBpS/Cq5tk0F1Tlc8E26s8PZgCyVNcsqp6ieKtMzA8tBzN8Ujoktxf7HxoipwYj3W9tIsFRZkmb0Wk/I8zGfRceQE6MuXSNSvAYcyEcaJDbq2J2gl+JyqxccR8LYapsBjqjQNitkgln6OCkIMXnDpYEwytuRFwJKBTYI/M9PTyc6MoqKe4lXtRX58FHJ3Hj/qF6bQgdCoov+t454Tz+aCnXfUT4AQM50EsIN0o8KBL4ZRW1P+q4D0HSuDMlVafeL35UHFY3NUmnQSjFuVYXJyWfSai+UuMJhrP4ZJyhHlzkEd3aycTe2nZoF0E+LndjtgNHi9vKqDsLgFt3NhClduxDqW03Ct5Wbqr82kzJi2aQzLtLqcSaa6CZqrJ6JCPDdmLjxqsbaw+G+60BsEjh2Ztn+19084gLYUE/7Xq648RKq7HH2UYtWKtgmuTJhMrdxg/IA1v59af9Z0Ov0P97i1hRKhVAmDyxhj6zVWePKaPjP71G4f/c+HSgV2pdjBN89CZ4o9iXV9R+aN9TpCCG+S1wBrFffkNIKU7Spx5wn7oN3gFYJhsb7UdQbnB1+o8FA8bbwjHfe9KRqYb7XWhkjkJDsq2KOpWr/r0bp9aAHcaEB9g48I7BAfdHFMEzUfeCHkBD06oRy0YupU9DSEbjY61r8G8dsmrQ/v7hjY/5grxCIMwFFfD0ytqwTrn8rGkivKMmWAYQenukjhFx390RI6wBMHJiynupOzngToRdLfdeS1GrxayF5WbgmyMTPixZWqzuy4Kz0nA qXpM+KQf laNx3p2fGP0NO/C4s14bHM6i0zSpmCBfpLgpMUqmnMjJLVqh63aXrrdMr3hCwN14GEbnf91UahIL7HmnQgOv5j6aFinQ5kHWEzy+1dKUcbV1B9HtEI6lP73r/VXvrLXWU45AnREdatO7e557pjPvr3tjBS/BU429aUyhwmRUrZ4bSCdJgJvnlZFLN0nVx6+YxqxH/DUApPT0YsLK3UsTt69Try9RATg+93+qZIdKsG4v6IoYIO+q5ygLD3k3gHw8ka2/LJThf/CG2EnDxvDnXB55y7GqTb0dtlMFdg5KVjTSIt50= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 2:39=E2=80=AFPM Lokesh Gidra wrote: > > To be consistent with other uffd ioctl's returning EAGAIN when > mmap_changing is detected, we should change UFFDIO_MOVE to do the same. > > Signed-off-by: Lokesh Gidra Looks correct. Thanks for catching it! Acked-by: Suren Baghdasaryan > --- > fs/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c > index 959551ff9a95..05c8e8a05427 100644 > --- a/fs/userfaultfd.c > +++ b/fs/userfaultfd.c > @@ -2047,7 +2047,7 @@ static int userfaultfd_move(struct userfaultfd_ctx = *ctx, > ret =3D move_pages(ctx, mm, uffdio_move.dst, uffd= io_move.src, > uffdio_move.len, uffdio_move.mod= e); > else > - ret =3D -EINVAL; > + ret =3D -EAGAIN; > > mmap_read_unlock(mm); > mmput(mm); > -- > 2.43.0.429.g432eaa2c6b-goog >