From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DED9C3DA4B for ; Thu, 11 Jul 2024 18:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C490E6B0092; Thu, 11 Jul 2024 14:33:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF9C56B0095; Thu, 11 Jul 2024 14:33:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC1AC6B0098; Thu, 11 Jul 2024 14:33:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D64B6B0092 for ; Thu, 11 Jul 2024 14:33:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45BCA1207A8 for ; Thu, 11 Jul 2024 18:33:26 +0000 (UTC) X-FDA: 82328319612.10.E8DF577 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf22.hostedemail.com (Postfix) with ESMTP id 69F62C002A for ; Thu, 11 Jul 2024 18:33:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JtVl0UaB; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720722778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKrM1O47jB37W8cJpeR6qNjULwDGt/SAvrPqtbchHV0=; b=oqaLj9r9Gh85LQqOn8I1zl/IqUFKFi84Z0BFGYWB1vMfrgDBBURINJechwOr3Gd2nOXtj3 ufJS/AHBWGalvdB4h4RsCEykn7N+EQm9Pveaq0GCApNd6+6oxg3DTjrwnnu07ZCDVwljWe YsmhhwNMRbvUb7XE6lnm+Si48pyY3Mk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JtVl0UaB; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720722778; a=rsa-sha256; cv=none; b=aW7Tqui+2QHY4E+66KEsRZEltPsyq8mcvZgqB1skxIMpSoFp8GNaf+UENJkmTrel2oMO5Q 32xih3rcNhxErAfSKnJn6SEVWfv1ifVxXPBYk/jN9xHXv5sd6OWNyWOFOiQQJPtJR88MDN Y/GD7qYhoO+U996P75yZSpLA5EEYr3M= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e057c4885b3so1125147276.3 for ; Thu, 11 Jul 2024 11:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720722803; x=1721327603; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NKrM1O47jB37W8cJpeR6qNjULwDGt/SAvrPqtbchHV0=; b=JtVl0UaBnsB7Zz9oKZD0S4J6QIy0YzN2fOw5X/mICIi6vpp9w0xF+awDiXwizDzUIr 0nRaY0J2ZFIaznmqYBjKkuO0fRwYUkr6FeOLiHlUpyYu2e8hABCwUGJQmoM3Afx5Yh5G rPCQH2RNDQirUNk4Rxm8ZzF44bHndRsA3THFGFz+NLMGfuHiqVTRAQu/+dD3a2SWJ/x2 XfGUo0CDdHTmX//ubMm5E7xY2bFpoO+lkj949BHogNmGyIT1eWlBiSs7e9fWjScatTau +lRG/wSopmqMNBLMVeZBmGL72/x7j1/exohJDJ8pDCSd4AV7Z6rV4cd9LgXycBEPObO2 /Rtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720722803; x=1721327603; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NKrM1O47jB37W8cJpeR6qNjULwDGt/SAvrPqtbchHV0=; b=iB8gzW3gQf0KHEFsnkcZqry3I4s4lJWadetF9mj1denSQdIsetwJtLsrUTVlGdUTZQ dp5xDfOZxi05qZGJxuN01v+ixIm+r9/xtn5o22kkEMek3yq2DYKk+16KEZFGIwBtvIuU HeD+GNPisgc/c53n2r3tFoO57PVoNMK7VZ5ku7lJt1vADWaotwBzD2MCHLRQThcM9Mrg 9OCr1ZlnJKS2BEhPLnJUd9mX0lgR6ZQokR2ZCdOChhrrHXtytplkhH2ZlUdaehB526FY CzjgZ9xdw6nU2WcIW2aAT0itRJc6uj7wVFqywy0awRluQoFrjbHuWBwOTZIKejA6FoWA rwnA== X-Forwarded-Encrypted: i=1; AJvYcCVWnE8zcoQYYHDorU7toEbz/hkLMdZKDjSj2NFlbA8/Bc8asR+1ufwUDGfLJndMkDQbCTSPiwCnySxgBFb5NnpH+xE= X-Gm-Message-State: AOJu0YwYigrw0F+xGgVV/isIHu7y7r74wl9zqXsHYFZnYEhXvOEyyZP6 C3B1ifGDN4pnLsp+cqn1KupgAoQT91+4i+XsMGou23xxjWb1pwBeDKl+O0Smk5x1Yn9mpH7zy0T Aelmg4ItP48CCY1K/bWE+tRaU0WPvpyCRVG/v X-Google-Smtp-Source: AGHT+IFPnn8XTeseBm+nEoyL6DeSqAdfs1Hn6MN0AuuqFPv4o2UKdw+cc2xNnipURs1wj40Drk/KcRvTHQS0KSqvXHI= X-Received: by 2002:a25:ce02:0:b0:e02:bf09:18ae with SMTP id 3f1490d57ef6-e041b03d2f6mr10503579276.6.1720722803036; Thu, 11 Jul 2024 11:33:23 -0700 (PDT) MIME-Version: 1.0 References: <20240711170216.1149695-1-surenb@google.com> <30aa2414-3d73-4be5-adb3-10b1fc64f2a0@suse.cz> In-Reply-To: <30aa2414-3d73-4be5-adb3-10b1fc64f2a0@suse.cz> From: Suren Baghdasaryan Date: Thu, 11 Jul 2024 11:33:04 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm, slab: move prepare_slab_obj_exts_hook under CONFIG_MEM_ALLOC_PROFILING To: Vlastimil Babka Cc: akpm@linux-foundation.org, sxwjean@me.com, xiongwei.song@linux.dev, willy@infradead.org, nathan@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 19ut1mis1e799ojdakcp85a1krr5mrb5 X-Rspam-User: X-Rspamd-Queue-Id: 69F62C002A X-Rspamd-Server: rspam02 X-HE-Tag: 1720722804-490503 X-HE-Meta: U2FsdGVkX18qIYGArv+KBa5t7a4bU3fAdK6HR0Z6YOFHdFAqek6358JcZuA7beUziN8SpQZUuletyJhVq1zJyADuTzL1Lm/7D28IbB4sj3yg9kUcrOQahVH0GDK+4cnSG9R2EBvjAk2/Tqf6gjoF5OVvm9b3dbVkGtBpLhCp8LPoZiEqctf2qOyremrOJ+Ah/ohgAppkPH67PPh5YWXLr+7BL/qAKic8QV6TD5T3jaSPImVbQDoBy2mz3N+AEqfxn23uCQkwDmq82WVJMikQhQQVxVo8I/C+orThUZGShA4SJ/RWAe7DWKv7FqqTO739sZ6OaDw3kDammNnXV3bjoQtJBCnHG0EuvzM/lSTEZ7Aw3APnnk1RDddmqu8+hK2FJnOdlNixLtd7ITUv0U2IaxuhAJKOlpH0DtLPCXwV1ukekR+ZQ91Cy1JPVz536Zx2vJu53CPSqLwTP7KPdvT7XruON/IDCba4VVoKjfWm/blHSweNXgvKatHPcMZWF4gUxsVhLM8CEGHmP/rdD9f/Q4yJYfFvZenbVPY6kO5pYtXe6BN08SI5o6moOeU1kT4NENDRYCY9fqPS92SA6GNIthnB2TFMwSSivnrvDy4LHm/OBSjiKRFKcHZTotn/v27iZdGV9uynn8WXjfMccZXOXuzkvFk5Z7J1Zhu1rIx/5ayFAc/96LrE2ogCdPda3rQYRRXKm1PwpnEhLCqvj9UdkxOQv9QESvrHi4Oz26ziEjzCpnjHSAUXYmQ/0Zy5Y2NcayFc7zI4xXwlid6JGS1qEch4iUOoB8GQyvy5uM8biLpvA9nh6IG9cw5vIcr7Ro+Zm2o1ahc0motuOZe4Y2IWjrpNDWwxk7c1x0KA4GBf1s+88tANP2af804WPRVHxy0YLmyLX2lWpOZBXv/xRV+o6QZVSCv8J1e838TN5+uvmHhWQfU43UvzOJ8pMy5VZvNiZWFvIpaRHRDGn6TwnKZ mHBZLST/ /seN2wdpcPvM4Vkrd03psswUp83JVGxEroXKBQ55zd0AOb0nGZLAWm26ndds9Kqi9+YcduPUpaEu/T3nzMtXPJIeHM9l04ac64nQrothUz8KwuqcD+IVFc/yBf/aTr8dn5XWzLq8/Q5DOonuWxovufvMyAoQFf5H4YgZ8MNmq2qYeAXAVIaoGIN6D5Y+5iqgKAIUmJAE1n+4FdebBDTHNp76kUHrTkNvVFpFHLm4Z7mDwCIDQeZwnoIsdLOoCqCoPhNmIiKYxjLVfY3SmKCRGM7NWXARqHcQzP0E/Q/9YvnvqIRGuIwIehfki8YTJWM/gJVhdszrMMUZmoqu/YC5SBsMJ0KNYvzNZFccsR4S1BpP7DF5kSvfa6JkaKIj/1DVZRTncfwq6VOVJ6F0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 10:21=E2=80=AFAM Vlastimil Babka w= rote: > > On 7/11/24 7:02 PM, Suren Baghdasaryan wrote: > > The only place prepare_slab_obj_exts_hook() is currently being used is > > from alloc_tagging_slab_alloc_hook() when CONFIG_MEM_ALLOC_PROFILING=3D= y. > > Move its definition under CONFIG_MEM_ALLOC_PROFILING to prevent unused > > function warning for CONFIG_SLAB_OBJ_EXT=3Dn case. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202407050845.zNONqauD-lkp= @intel.com/ > > Hm so that's a mainline report, but being a clang-only W=3D1 warning I th= ink > it can just wait for the merge window and no need for last-minute 6.10 fi= x. Correct. I was wrong thinking that [1] caused this. The warning was there even before but adding this into slab/for-next simply avoids merge conflicts. > > > Signed-off-by: Suren Baghdasaryan > > Cc: Vlastimil Babka > > --- > > Applied over slab/for-next because of the refactoring [1] in that branc= h. > > And thus took it there. thanks. Thanks! > > > > > [1] 302a3ea38aec ("mm, slab: move allocation tagging code in the alloc = path into a hook") > > > > mm/slub.c | 48 +++++++++++++++++++++--------------------------- > > 1 file changed, 21 insertions(+), 27 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index ce39544acf7c..829a1f08e8a2 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -2027,6 +2027,27 @@ static inline bool need_slab_obj_ext(void) > > return false; > > } > > > > +#else /* CONFIG_SLAB_OBJ_EXT */ > > + > > +static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s= , > > + gfp_t gfp, bool new_slab) > > +{ > > + return 0; > > +} > > + > > +static inline void free_slab_obj_exts(struct slab *slab) > > +{ > > +} > > + > > +static inline bool need_slab_obj_ext(void) > > +{ > > + return false; > > +} > > + > > +#endif /* CONFIG_SLAB_OBJ_EXT */ > > + > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + > > static inline struct slabobj_ext * > > prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > > { > > @@ -2051,33 +2072,6 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s,= gfp_t flags, void *p) > > return slab_obj_exts(slab) + obj_to_index(s, slab, p); > > } > > > > -#else /* CONFIG_SLAB_OBJ_EXT */ > > - > > -static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s= , > > - gfp_t gfp, bool new_slab) > > -{ > > - return 0; > > -} > > - > > -static inline void free_slab_obj_exts(struct slab *slab) > > -{ > > -} > > - > > -static inline bool need_slab_obj_ext(void) > > -{ > > - return false; > > -} > > - > > -static inline struct slabobj_ext * > > -prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > > -{ > > - return NULL; > > -} > > - > > -#endif /* CONFIG_SLAB_OBJ_EXT */ > > - > > -#ifdef CONFIG_MEM_ALLOC_PROFILING > > - > > static inline void > > alloc_tagging_slab_alloc_hook(struct kmem_cache *s, void *object, gfp_= t flags) > > { > > > > base-commit: fe4e761669ab4d8b388fdb6e9dbe9a110eed8009 >