From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E9AC6FD1D for ; Fri, 7 Apr 2023 18:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31225900002; Fri, 7 Apr 2023 14:21:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29B7C6B0074; Fri, 7 Apr 2023 14:21:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13C41900002; Fri, 7 Apr 2023 14:21:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ED3116B0072 for ; Fri, 7 Apr 2023 14:21:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C450AA01AF for ; Fri, 7 Apr 2023 18:21:04 +0000 (UTC) X-FDA: 80655411648.18.98C9431 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 0C6AE40011 for ; Fri, 7 Apr 2023 18:21:02 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="NQ/Tb0DG"; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680891663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6n9BCzd/cUBPMGsdmITGqlzt5wria1X+QmbZC4aBSvM=; b=GYBvIylBO3BpgY3rAXB8lCWbpoicG58rZhGEBJGF2Wwp+jM+x68PrkIQ7In/smCodjjiCB Ar6JAQAX1S1UmE+Cxc68Fs4UcbjG9JzLi2OWTqAB1Wc7v5+jRXiuieKTiVFUt23Lq5KB5U iDealBQWcTM+zxL1m08cODrk5VXv+k8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="NQ/Tb0DG"; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680891663; a=rsa-sha256; cv=none; b=FGi+OHofxEGnShy0TYvIToinYiOcj8QSPXHEsjsv65gtX/mw/lsvXhOuGVJ3U654kLcuV6 KzYV2/X5cQHehAFzpSJ3vJfkgyiDio5RvMRYdl0+jt1XrLK66E1Th2VfIoiMjWKcbUZo4U 3OQg6mch3w6p4iTsjJUATXoqSpxiFH4= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-54c0dd7e2f3so102869607b3.8 for ; Fri, 07 Apr 2023 11:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680891662; x=1683483662; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6n9BCzd/cUBPMGsdmITGqlzt5wria1X+QmbZC4aBSvM=; b=NQ/Tb0DGafwLdqhgNp4K59kPcZ9/NRulY1cuqPgX3MVfr6KZ2HLzJyfgRGuh2m3MkU jA0YX1fC3BqUfCGCteuxT+hUR95Wa/hMay1OWFL92fIPHwP9IPyqEDIxN24fPY/2P6Hx u1EcdZCYNP4a+TO771XFd8MqbV+hxheDQau3ksrjRoFsAGn5hLYr982UPN03mVQkTqXL 3otmuRM+T/KML8tOpcIfVpKJ+plwao/Lx72+ZyJNuIFgPMlQHrJRzjEMuNiP//Fwq4cG DKTmY6m9omYA9BnEboKtDaQewu5hhmUkqEGKLGkViGk4DSdMc8z0U3DSkfhvDW6jEScV zkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680891662; x=1683483662; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6n9BCzd/cUBPMGsdmITGqlzt5wria1X+QmbZC4aBSvM=; b=rO3pCNxTCTZ1vHKHdBeXBm2fBDXS+ZZ3LafLwSx7TMst74IY2Y12Vga5HvRQXdjYCS AAsoIPRpT7BStHNFupcU2WvlKNrgwav8JAVYGnKKRID6QJ8jQsjs6R44wU8p1yBODr9s ymf0RuphNwO8ZFgnhngsgpfvuT9A0Q41+78CRKVrNngKQC2+p2p9z7I6ivkTO4YRxhVB Ki5/JjeO8L+Lw+i7GsAWW37HHjVHsiArktwMQArqm4rlZWicSw8NpYghbS8JBYs7n8/L BdfMk9zyJ724S4ZkqWI2shCfhmxhzTtDHxY3cCnHlWhZMgrbEBbULFJ5oUaTPlFNAWvW I8qA== X-Gm-Message-State: AAQBX9eVHHJsUc5fqzal1MTtIWv3aYPH+hW4moSysmy6/c9q9ZZJgbEo 8zvToPqZs4N+GFKN2QROkgpOp8g6RnbGGaLI44SdiQ== X-Google-Smtp-Source: AKy350ZE8FrJxkUosn8R5uDKTKFqIuRyq3AFkT6sOWk5d5hsdOI6ajPdqGF2MxJSVLoE3YnUi8Mz0LcJ3AEfMVc2GSk= X-Received: by 2002:a81:b620:0:b0:54c:88d:4052 with SMTP id u32-20020a81b620000000b0054c088d4052mr1531059ywh.1.1680891661895; Fri, 07 Apr 2023 11:21:01 -0700 (PDT) MIME-Version: 1.0 References: <20230404135850.3673404-1-willy@infradead.org> <20230404135850.3673404-7-willy@infradead.org> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 7 Apr 2023 11:20:51 -0700 Message-ID: Subject: Re: [PATCH 6/6] mm: Run the fault-around code under the VMA lock To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Punit Agrawal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5wm8qj7xdsihkjxd9od8p74iigum6dqr X-Rspamd-Queue-Id: 0C6AE40011 X-HE-Tag: 1680891662-54791 X-HE-Meta: U2FsdGVkX1+qo0tFUpbbiXLltFsBymXI6FzLw/HAoQWBGoEiNUYlgooUwiapa9MG37fCJxD90Oh46mxMC6TQgNd4bqKOZWyFWYCfoSb3HX8tq4vZVNIUm1w2G3EbkR/Fqk1ew0d8JOiafdIV5yPqZIdnRKVSdg8Wofu+CWhoq8o6iAjQ6X2rbCvP4wr8BZGlleT/cNNs6oLy3TLewSyI3yZf2jkxJ+KgkcsbtDLVQc3sBG15A8/Ft/9Ot/nRaafRy91f0rxGkMwtdNia3+bGw+lKrzVRcp3vc/YNV6Kh4HsL9O7/EORD+kDFKNqRd4XR+UNpGNKtvOYiWRp7oamZ6SOs0+EhpWgep2D3vt4p2T8DBPAnmkO91G9yOyfrrpwsb4BNgOu+0Xqf2Io/4lgKfQuqf0robm9gMMbBuD/XujhujKRAvF9Zig16YAc1RWGvijkHAaXHrzW0bKsHTX4Av/Tb5if+vcN/Fa4LSxQuNxEW2KoLrHYp+0RHVoNqLnJdeDSY8BseZfrKdRmvSxEhz0m3fLK+ReQBMEvXaUJtsHtPZ7OT3qCp3Lb0II/DWrcpWouVh6BPpM1GM786JATj9RUx1kv6WC6AX75gHuYxjzftYBJRtuC5gG3l6sp6um+5QvKy0g23OAZAptefisifrQH3US6zJX81WcMPmHoO6du5RkUkQhRN5p2pE4aNfvdc/1VJbphmQoTEL4z3LnhvHOHvjSwt6eRhYGNVXtvZCRHr7LqlIRTI5fzZcJqgUl2F3PYvboQ7NqVRndxJ4UPhpIgmc1BvTpjm6vw/QkRCB1GAnCexJHmAhWfEC4ZKa0tT9RQeR5pvk16uOxHtpkv9ZMwvZ71Xw5IkDZlPUUHP8QRShcETbvlwfBv7qv27d/yEY3nkNENR0Ld0g4LyoMMuSa2XSc3UdtdoWVqFoF7dGW6rfOSYEy53Py5nPE8FvDFpW1oJ4JSGZtcFf7SEepV PygHg88G p27rPC9ShjfMp8gVvrCXBAdUxHYCM1Ejw7cbJNE+JliwJKqOSfR7HkuLr9UE1qoTb47A9I+kghgxngT/8IbNE3ZgPm6Gm2hPDFATReh/vLbFhe+HNYfr9DXhcIEz6tkvZOUWkYk3bqlchSWKoPePjhKfp74uR+UhM7j4+J4Qu2iy5jjKF3OtV9wQtUd0pb8AOcCIxiC+SsdEINytKFbdOlwak5pFGjRf23kBiUl3ucG2lVcglWIb9IMkHrrcaf+FwXmF8nevUsQg+LUsKXF61Hq8dZsMxVyBw90VNS0U2+54gzzMEt0XFdtx1D+mx0n4yX4L2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 4, 2023 at 8:23=E2=80=AFAM Matthew Wilcox = wrote: > > On Tue, Apr 04, 2023 at 02:58:50PM +0100, Matthew Wilcox (Oracle) wrote: > > The map_pages fs method should be safe to run under the VMA lock instea= d > > of the mmap lock. This should have a measurable reduction in contentio= n > > on the mmap lock. > > https://github.com/antonblanchard/will-it-scale/pull/37/files should > be a good microbenchmark to report numbers from. Obviously real-world > benchmarks will be more compelling. The series looks sane to me. I'll run some tests on a NUMA machine to see if anything breaks. Thanks!