From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6C92C54798 for ; Sat, 24 Feb 2024 02:02:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26BE66B0082; Fri, 23 Feb 2024 21:02:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21B876B0083; Fri, 23 Feb 2024 21:02:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BD6C6B0085; Fri, 23 Feb 2024 21:02:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED8976B0082 for ; Fri, 23 Feb 2024 21:02:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 89818A151E for ; Sat, 24 Feb 2024 02:02:38 +0000 (UTC) X-FDA: 81825048396.23.621202A Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf05.hostedemail.com (Postfix) with ESMTP id EE657100008 for ; Sat, 24 Feb 2024 02:02:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gYzuVY4p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708740157; a=rsa-sha256; cv=none; b=MKpUPVb0LUYPOJnhs78hZ0DRVrFFzC2bswkl3ADbnUl/3sf7xq3d2DbqM0pspou4wMohTo hdR+MSRhGem8mBJuY9736dEPdLQjmGu3srq+icPnLhVDjoKZRufFahlgzqCtlARtqkDcbe ZuaS5F/SnB6lsHj0PEJZxAIsO8QdXuA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gYzuVY4p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708740157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9PYgxetUjHOrEBE3OyfXnw/V4oH+FzaVrAptzS8yqHg=; b=HU1xCx1Rn+zFfjKUz2+KlC3qo/PHdAEbvWAKH8at2Sq0npX0To5ywjSB7dS/74UaB9L1mH 76l0kNESauZAqhsHHGtvULXesuTKVBkXjPl5tafc3r3iDBrarHmU5htoobcX9aurKWSXz2 iPwUFkVMeq1SESQwPju6cQVMoQql7P8= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dcc73148611so1567542276.3 for ; Fri, 23 Feb 2024 18:02:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708740156; x=1709344956; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9PYgxetUjHOrEBE3OyfXnw/V4oH+FzaVrAptzS8yqHg=; b=gYzuVY4p2wFXZnZSsYIrd7ciJsH+sOjjOX2rfgVPKTbmfc58vC3FCDbzGN+Og2u5Tp C2bG93W7jKqCcknw0F3QOpACG3G+Z+vx8FhIoc3VilwaNA368m7c/ha+YNPUY40HE3HI hIJzav5MpZWcVlhciymG5aQLjZxey7Yxe5sTU9eMyAOFB7+CyGR9q8RPSHRC5ADM/aai 6JYc0CCiPuI/lgXya1xo9RI7RBHfvXb7vCeOmMMrcUy2MZLfiNKaiybPrne1t4ggzYly CqtIwHBs+MM7ICq81pmUrZnpL0rEFuiJdBG5FbLfOZM23d92C2JcA/IIs/EQlT6o4aoA tuCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708740156; x=1709344956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PYgxetUjHOrEBE3OyfXnw/V4oH+FzaVrAptzS8yqHg=; b=OR5FwRrSmLCgtlZeB3FbtDIkszjQqgM+6QyienyAj36Ldj/g7GWfzwXRVDxrBKG18B MIOR+4TWhOBijxA7AGNJzZNsWulWldLbem+XEXuV8MjAZ32yOa4lSawks4ikMdd2Yzer 1WzQTrrJZx7Qz8odUqPiqE3UO1CuRkcfq+91/x0tg24E72ViVJG7j/+O13LYtfJgukCP EmGDp+NOk76UbeT8uPGAT/kh/0qZZHq2Vk/YSMcfmzskiy1mXQ8eXnZ2uRfxFIvnT2aC /uAylaFWXxGlnY+7WXEeCBgYAQq1wZ9OpbdvvlOZlaJeP62hEuATG3F6wjdf0FjShwoq Hbhg== X-Forwarded-Encrypted: i=1; AJvYcCWbDSvrkbvSUj6Y4gXoacA6g25Gkc1XlFzgrg3HkxjKe4xNEDgXEMWCY3QE694tWx7dTlAD67C7SMKTyhCJUJUaauE= X-Gm-Message-State: AOJu0Ywt0bq7dNZ+ntGwX+e24RMJquQC8k6Z53s50c4If6a6VIc3i9cg rMDM1CaSCs0qIwxVEr0JmHzlwkDs8jc1hzcB3Xvh1yaA1VPdvkQywikdHg8NKsjr/DVXP6acnnK TQp5rJUIlLgyHpXR6VcRnj/aiLDvZprx9sAZY X-Google-Smtp-Source: AGHT+IHeD7s1jl7nDLOSZG0y9kCuKTd3u0TtUWQK/hX08wsrnwTSQEZdy4JG7wuGlK1ABvMhJVtPl8BOIpukOXAnbmk= X-Received: by 2002:a25:9986:0:b0:dc7:4758:7802 with SMTP id p6-20020a259986000000b00dc747587802mr1258940ybo.48.1708740155772; Fri, 23 Feb 2024 18:02:35 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-4-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 23 Feb 2024 18:02:24 -0800 Message-ID: Subject: Re: [PATCH v4 03/36] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Pasha Tatashin Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE657100008 X-Stat-Signature: masktbw89zf6jirm148w87qgxbcq1wpa X-HE-Tag: 1708740156-732876 X-HE-Meta: U2FsdGVkX184bkbdBgcIcTGUwcptVsVEC4+Rotl9jNWqYuQi/yzrqKEMjin2fUinInqLko/MZTg+OrtKjSAplOnXI24SdokLEmsHs8J7v0bdCiNEEdNtWSfzdVdPj5ZVb7WPGrCAG4DaAGUXzY+lTZX/H1l/Z+j6k7uEa6chuPUVcJ/9hx6CBZQsST7h+I0+/cQ4XnTYqbAx0hWegrtQL0PFqzkiVLn+oqQmJm26MmtZXdqhfAzwYHTTgklX3qoG+joRwcyCkasevTELcHc9WcZNdZy+DRsXSA3ThH/ionVUn+rc8Fvbc7Q6xVhrtBDCMo5XjQc7fXw4T0oLtbTNXezK9DfL8QPuQftABBvoqeQoR38pkNNg125r9NT2iwoYlcCMszpAeMTa4twZL8LDB9rRa/JT6T9wkXI1yqgW/UW+CpB61DxQaYGIo6NAJqihE+aXlDQTp0Hk+Xu3n0CMU66nHzpStyQISPgY99M/2VKMZOMHSbO0QxzsgddynY86LSns6N3H7EFpgMDHNs6A60r/QhVYzXd2rID83NHs4sGRcGlz12UyHNkgadUv63mFtZJIav36ZWgZ/MSDc+hQTnRE6n4W9bCP82x2WFQeeLA7lyTwDd/lUGG9TRJ735L21pumFmwLM2AE6LVpleShAA/bXtACoivaMNztGNy3mslPh52Owf28s5bdICeTmFkqVnZw29PjaAEU6QL8/1Y0El/BjGgNLNMu2mkZTrkyL/avf74avfxdHbiQ/Uv1Yj/qNJ/JalmRuZXXQn1MZ0IVnxSJWrVsJMxP2Fl6/EJYj+k0Jv1AzS3HnR50ap//SIxo1M+Npn6NsGec2Jjmdlcz0+ntBWcZxJdUnqAFAU5uXbSlWCLXQwuERUqvA3KyRadNto4KS/ajF2sJYCE03dFv0uqwfMRDEqE+ADgNv7IWUIE7nIZjdRqSNT20mLBu7XAbbq8gVp0U29PBWCfsH35 kegEj60j U1fXM19ChNzmhklDIQhGI9V/pq3RFAU85BlxlMQCExc53PCog/UEtqlh3xanWCaaQ2jBf8MnEeXQcBOiSPvquRfxqHLQExlVzEJlMICAnlmnnV5Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 1:16=E2=80=AFPM Pasha Tatashin wrote: > > On Wed, Feb 21, 2024 at 2:41=E2=80=AFPM Suren Baghdasaryan wrote: > > > > From: Kent Overstreet > > > > It seems we need to be more forceful with the compiler on this one. > > This is done for performance reasons only. > > > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Kees Cook > > --- > > mm/slub.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index 2ef88bbf56a3..d31b03a8d9d5 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *s, void *x= , bool init) > > return !kasan_slab_free(s, x, init); > > } > > > > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, > > +static __always_inline bool slab_free_freelist_hook(struct kmem_cache = *s, > > __fastpath_inline seems to me more appropriate here. It prioritizes > memory vs performance. Hmm. AFAIKT this function is used only in one place and we do not add any additional users, so I don't think changing to __fastpath_inline here would gain us anything. > > > void **head, void **tail, > > int *cnt) > > { > > -- > > 2.44.0.rc0.258.g7320e95886-goog > >