From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E741C54798 for ; Fri, 23 Feb 2024 22:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C275B6B0071; Fri, 23 Feb 2024 17:18:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0BC6B0075; Fri, 23 Feb 2024 17:18:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2A526B0078; Fri, 23 Feb 2024 17:18:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 923156B0071 for ; Fri, 23 Feb 2024 17:18:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D0A3A17F5 for ; Fri, 23 Feb 2024 22:18:01 +0000 (UTC) X-FDA: 81824482362.25.6AC268F Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 5CDD6A0002 for ; Fri, 23 Feb 2024 22:17:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kW6MIZHf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708726678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mr+d1THQdIOXLBHXtZjKUSDXbb7TH7vTqrSqao2j71w=; b=wsTHHwWHVEnoAOUAybQCYHjygSKquzNg5hH/CUWLRmoh05/b7If8366aQDhKsLyk1SJ5Xh offRqjWs+p4R/MB2ZXMrXV8vkUayAEqi3KhdrDLHilaRO+U5h7K866o8mIPFhd2RenphU4 4CnOYfh9gEqhUzTWQgE1rMKvoi8SK2U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kW6MIZHf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708726678; a=rsa-sha256; cv=none; b=elSrLMTIZXi8vvcvc1nGP1ThDlqEow6IqDuZTo/ggf+qRioay2qE4jbGVT9+d+hFNF6a4S KHS9SOolJIzAa9gR4AJ0KoF5ah+ukAgkJ04ylO646/htjHR7xzAHdgAV2M7DirVYqz3STE NGzNQ5RRwGTMGytSoUE52Z4hp9uENJY= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso1373678276.0 for ; Fri, 23 Feb 2024 14:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708726677; x=1709331477; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mr+d1THQdIOXLBHXtZjKUSDXbb7TH7vTqrSqao2j71w=; b=kW6MIZHfWhgsmOiNRSDxm4A5xFak2G1oDRQEFJQo52zkuSE+lhfc3Gn5iskIxB2era CU3NNvh8Z1RxnRR+6beNbVhafppkXWk63Ui3G/Y3CwQ02SkXrAH9RWoPjoityoD5xXR2 vBk9a3WBVtA6EiNjV4VoXrSSeWsdOblnCrcYR2ER1BipTbKHmn5GmfH12p27DDLa6Lof g1GDQFiEI93Kt+BY13y9RYyYnLa0/DAB9ZsE9OFxnWOfV05vrG+KbgXDeNHOkwYh5k7d uiS2ntIIBSdUONZKpCCXgthWLJnSmWKOay5C+V49XEXwidZwFMh9O1k0vRiaz4b5/Im9 hOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708726677; x=1709331477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mr+d1THQdIOXLBHXtZjKUSDXbb7TH7vTqrSqao2j71w=; b=hqCYHhlN8+WOl6gdO/yDzoD9RQEadfEVwdA3RH82NpLI2S2UiBZ8gHHDI11u+GNh4a oij73pHZJ4aDOQr7ZgqplOJ5DSwsx5gq3FezaQ60mKWLBnrfnMtShrU/ZbDJzC+NGj2K ZkovRhAisQCdT5xKiPSGX0GAL1/H9QJ821yonzNxwpIgR5UPgFXwlPSgPJ9GZ/CXB8Wr d/nwDST/Hq6jYlTgOdSPcS1xuak1cnCH9YHvHsVbk3H8KGK/H57Jez9c5dK/LW6fKzmn 67VPAlrlzz31QawbRCaKLbMTxFiURQQHzLYgLVcnjV5AtlFRb/wZW/MgKlE03Xo1k+Om gx4A== X-Forwarded-Encrypted: i=1; AJvYcCVqF8tOheX00WKaJFLfChrxAFWw/2QJ63LU7TmRHDBWXkFOIpUIdXOPV7rjGgvfr2JD1rAiPBTN4oJT/X+9yx9pnCk= X-Gm-Message-State: AOJu0YxfQqdUKTYn7CXirEMLjFIEmnwzDtyFEndpj/srmVplMhrvZ/u7 fcEq5fslOpUGZ+rfuwKllHwMbZ44X47p+eYh+0sJlmBGgaF+dpdNBzSRXr3IC5knT3vdbojRCr1 FP5h8XSq42O3PkWo0qju06fBP+BiNtByNLt9o X-Google-Smtp-Source: AGHT+IFvVslf3S11aDqNfvq204R/MIDJZtFxjw2mS4TXD0XUNA43SeY457VF5UW1NHR7Lcxr2CpVLic3B31+1rRIW2U= X-Received: by 2002:a25:a427:0:b0:dc7:47b7:9053 with SMTP id f36-20020a25a427000000b00dc747b79053mr1214318ybi.15.1708726677063; Fri, 23 Feb 2024 14:17:57 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-25-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 23 Feb 2024 14:17:44 -0800 Message-ID: Subject: Re: [PATCH v4 24/36] rust: Add a rust helper for krealloc() To: Alice Ryhl Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5CDD6A0002 X-Stat-Signature: pua4a3u59smu5n6nsdq3ii78fzziwdsm X-Rspam-User: X-HE-Tag: 1708726678-17056 X-HE-Meta: U2FsdGVkX18gp9dLMCNG0qHC3RnWGq94GMrSrzuR/fquc/mWrPfY7kbS0PKnV05m2S0dliSA8edDNd4bdlq4enpzWYN1qppXkMGtBzFg7/gCX7ofxJmmsUHowy42GppaoGGw9cfmGpC0gDIcDbo8IhyL2mkcAgwFYjK7nAbjZ2KUwmSojNhE3nKaJOwfvyolrFHXPZxJSZgnF1rC6BbBMdzvXOIMJXs7LUy6zEbcksYYi6U7TQrYgj7OQOTiFUbAxbqhk1tJ3D0oMoaFOdaafwg1/eTZiA4OCTPDzmJfgTdgY/4ZOWhy4iF5B67zvVOpwYVGEk7Zh1F9bVWHySy3n+QZxIZjfPvebrj4TJ4phakpZbIv/A0m1FhUcOBxPflod3RgrBCRevG1ZZcZnPAZkXeTfyqOGmzBT6Dbof1GUnVNAJrFgK7eSSOvL2IsMHL1iRu9kDqrGwylWnS1d+9D4srV2NdCsMkJuUJRgcrBUHfZICmasdldSzuzYobQ737gTSws2dB3oiz4mA/zD1Es5ZwNKovxZbr2LlGcEbzcXQtsLxrlrgE+lPDhhlxL9LtGiPiYyVFuSG4Tb/e3zI6Mvgva4B/vsEaIunvXsXW9qGb/4jtObc+a9Qv6RXzDeLE0bK67l77z2HbLzRmfMQDeTaLu5zoeZr/Fv5IjAnlFOGmgHF7FbWh7SmF8N0lgO+zxpPRvD4a/k+jZ3p4rplz7/PJCTVtWtVSOE/prQr6OpaUrf0KUR/A2SpfwpOc81lZ+DWfbSFEmIwwmZfuVFDHU6QpVBXHr66s8Z8zJdLseRG5PEqD1CptqsmlhZkCMs9qnK1uIvuaobZ9ymTtB5Qxg5ewG67HND4zfaXsmWO8kRgwmr5qXpFcDk9uUaEn2q7xCVOECV0YZnxDZgT/l3btWmUsfuHRAZR2ueTkDMjIHk7Azw5JN6svy2PCI8lN/0ddNYYMzD2up66TZiy/otHx YQ5vJJub YznpQC4VTSDHjEqcWW1Le7YfKC4UGD0kMelfuJM4oC6jU2fGQIWloH8DOxEcKRo55tO6eHGzaIl1AMB2Nz2eygJK54ys1YU8Vl5R+kUXjnOZuEXeqHsG3fTj671zcJzwlEGZw50BYnpguZOA4X9jcMQ3afYPynJgn5T5aeBo3BX21y+/9L7YhLujsdEJnR6ki3qafTvbP+UYQSJp6k0eyo/r8yWnmpT7Y9KDJq+R2Ow/UJWI0IPwwsL/EvLfx2zNX1ujy35RUDL1T6tjEH4ZAocni1XIHRh4sTmD8KtwO87m5wxHQDUEIPSIISyB3n03uPGI6vkURSLfxb4bdla1ZHJY4oSBOhdUbCYQBbo7LSjj4XLvMYHM4aJPXD6oT00KvoSCtYRGn/RROnQSJprFy1/W+ZyojA2wC8WpGIZ50BwY9a9cupT7j+6QlvSSPEdiBpRYFrXS2oPvYi74FAw2trN+CEBqEpPdA+L4oSq/yBqLnx/yYPfP2BvTx1CxNl6P6WrETf8Kob/xelcnnq0+FeY3u7SIlvS44K1wW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 2:00=E2=80=AFAM Alice Ryhl w= rote: > > On Wed, Feb 21, 2024 at 8:41=E2=80=AFPM Suren Baghdasaryan wrote: > > > > From: Kent Overstreet > > > > Memory allocation profiling is turning krealloc() into a nontrivial > > macro - so for now, we need a helper for it. > > > > Until we have proper support on the rust side for memory allocation > > profiling this does mean that all Rust allocations will be accounted to > > the helper. > > > > Signed-off-by: Kent Overstreet > > Cc: Miguel Ojeda > > Cc: Alex Gaynor > > Cc: Wedson Almeida Filho > > Cc: Boqun Feng > > Cc: Gary Guo > > Cc: "Bj=C3=B6rn Roy Baron" > > Cc: Benno Lossin > > Cc: Andreas Hindborg > > Cc: Alice Ryhl > > Cc: rust-for-linux@vger.kernel.org > > Signed-off-by: Suren Baghdasaryan > > Currently, the Rust build doesn't work throughout the entire series > since there are some commits where krealloc is missing before you > introduce the helper. If you introduce the helper first before > krealloc stops being an exported function, then the Rust build should > work throughout the entire series. (Having both the helper and the > exported function at the same time is not a problem.) Ack. I'll move it up in the series. > > With the patch reordered: > > Reviewed-by: Alice Ryhl Thanks Alice! > > Alice