From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC50C25B77 for ; Sun, 19 May 2024 21:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00F566B007B; Sun, 19 May 2024 17:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F01EE6B0083; Sun, 19 May 2024 17:16:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC9A86B0085; Sun, 19 May 2024 17:16:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAF3F6B007B for ; Sun, 19 May 2024 17:16:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3BE4EA19DB for ; Sun, 19 May 2024 21:16:35 +0000 (UTC) X-FDA: 82136404350.01.9E37747 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf02.hostedemail.com (Postfix) with ESMTP id 7F9F680004 for ; Sun, 19 May 2024 21:16:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X623lwZQ; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716153393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aepYcjZoe1VltFPIAkhmsPx3W+z0i3qcRSlTsZdDdn8=; b=kKMH5vbvCv971vIfIfogPP+23tZE7zbWdbBLHxxvDXj8zFose74hzzLilxbYNE1KMBgkJD gBdvV4gVv0wnpocbArqQV8w62LG/YMBqNJ5ySgTX4QrEBtb9a/5P3Rdy2rfGQsTTYRJyWL zF4wc/BcNN9zYc2Ody99rdHWjZW42+w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716153393; a=rsa-sha256; cv=none; b=waD/3eaaycIzAog+vBukfEPpj6847VODmOJ0yzgsSyoeVQufxBrC3fPz+QQRbSDWltJu5i wrlhveMxFZYUiL1rV8EGJKM88uK9BuC1P0nA2p/6uR3+8iLSu4BTkf/LIItYeVaLQf/2cy fy/piZpwoLHx4rmYn5SAdZwqn2wQzJs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X623lwZQ; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-de8b683f76cso1247647276.1 for ; Sun, 19 May 2024 14:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716153392; x=1716758192; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aepYcjZoe1VltFPIAkhmsPx3W+z0i3qcRSlTsZdDdn8=; b=X623lwZQ57RkO7g03uA5yaY3zAyCIH8Os8WH6kMBmHjRqP1NZPkCwOds2dS+E33rBG pG3pc4DNp+Aumh4kxMVdfVxiEYCuRWddtodUAdJj3Zx0gdvcImSEeCexgfKX8NVNjMXg 1Z+nYiV50I3fTlAmNZDpbswo5xXSCnjXLClnc6RKSqni5aas/lLlGp+A+8SWnoIS9bIn 9xKGfho3oYRJpzjzPyrymt2r6U3ExZSAE5/wQKURRzLg5XJ9wB5S6WK/FqteZq8XghtO E8msf6w04/P92wHAVbNn/JBmjl0kZfYHrjJ7N1DAASn74ntOikum4tyYbMnyxWrtEDK0 RzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716153392; x=1716758192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aepYcjZoe1VltFPIAkhmsPx3W+z0i3qcRSlTsZdDdn8=; b=J3BtbPRjIn2LQhgix12+ZkJppvHmB8BLsx2wV9KhyW701oIV7tE/A6bS01ZkE8KUcn bCwpZVKwLHd684h7hdMdS1wBT4WJAuN1AWItk1kDLnsxLJCpeUSSJRA14YpT9GTlZysA FTRN/S+rD/FDyYSbwN2VjnUI9lvcGAFDjzVikPx6YMsoALjQ2EixrfdIJd/rZRRsvfZT 3KJHl9zdQzfeyZuuq/2fAHbovGwOOo/ilwxzeUr37or2UADzETXEkq1/jOgytbl7TpWJ cguW/YpfRRRAlE5YE1cShseEYWoBQ3uIvy2rOvk+XXoI9Q7pSTWfm88jq1g5k6UUcGmZ c9mg== X-Forwarded-Encrypted: i=1; AJvYcCX5p4ZRZD7ZX+ZNMsguIxRYaIyM2mPWkpfh0LoPE+q5lFcJCZxSPy0E2fomHq7/SczeYpa7UZdBBJ/9NAeP3uaotwA= X-Gm-Message-State: AOJu0YxWge9wt+sRIyaotWz9xPvSC2WVx/1oJYHGxCIRiZHWESkGZEyM fVtluFsvYEkXku63zkwl3cmNLgJK4thJezcvI6eHka1hMyoCizhBeq7S017lLHVsdDkI19vRq+2 LIERWQrapOBCLz/vpnN+/hw1jQi+ZtEtmQWaX X-Google-Smtp-Source: AGHT+IE69gHLeUIav2qwSBHMXCXDWEAkZ0MCjYZT0jU6CvB7u6z5f78gziAFXfnbpZDqnwxL4OABn3LeV4aQD7rNGBg= X-Received: by 2002:a25:5103:0:b0:dd1:6cad:8fd3 with SMTP id 3f1490d57ef6-df49062935bmr3300167276.27.1716153392254; Sun, 19 May 2024 14:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20240517192239.9285edd85f8ef893bb508a61@linux-foundation.org> <5qcafqbnrox7r5m4kghgykahtp2pusmhwfxqzrmhgvavxxsdux@ao2tce7nppey> In-Reply-To: <5qcafqbnrox7r5m4kghgykahtp2pusmhwfxqzrmhgvavxxsdux@ao2tce7nppey> From: Suren Baghdasaryan Date: Sun, 19 May 2024 14:16:21 -0700 Message-ID: Subject: Re: [GIT PULL] MM updates for 6.10-rc1 To: Kent Overstreet Cc: Linus Torvalds , Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: o3bf5n4p58mnesju76n7qbfc5ookoj47 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7F9F680004 X-HE-Tag: 1716153393-644761 X-HE-Meta: U2FsdGVkX1+LXnBStRdRr3b18nG932x2606z/LAnB7NSOi6ySaySl+afnEL8jF8b1b8CTALyV9GPsqtOoaclp5FnJPtktpu3Y7cFpGr0T/VfPisx1SVOQlc4MbGjN4miNsa3MeAhtQbss/h0AQnFRlQoqDiDu09JaA5Y4QYvczrHDSqBJf4TbFA7ank13S2EA43WAq2ooy4+sf2tmLmpFkjDEjMiFSpx8wsliu+sRb1gqXrR/Dvnd88JB6D5XaQeHbxa81t9bMAmUBbLTGxdqoSjPbvz569mEoasMMGMJEHlwGRZmwMqdVpw1fjdc+B4bzhPgpSI4gBXki+pZqL2pPzNiFODWj1QQXSnpMgXyEs3wAqBUUVYOyPZ9YRWyrG9Xfrm4eaQSwXBIqRm/ALlSHg9PHYOTXDVtZ5siegwSEX12ocXzgOMuCy6PUljpzIjbONCj9GvMom6PejWp5BT2gC1Pr6qlIDaJoSjq3COCDE2zAy8q1xjpcm0yIG63n+bRXm82GR8RXK2GAkgfrbfzSSY2Zg2okAtDqrM0KujDRNFGie9fgKdXXur+JYNXKjj4SpwZaxqJQw74j3kXuxe18o8H8r2VSwLx6UUMKKdZAiY2Hwlu4Zxc39lKHoy+Wn2M6Y6CmpELZi1nte/4NayJHBK4V930VDKmdIMb5hoUZCe0jw4CniPFvE6K4+GeIimzqe16IzMOBrGgx2PDgWavXrHDQiA9QQthUZDNUHuT6AraR1SgeDemhoYlHlEdeE9QABnJivGUndfmSQ+jUr99y5zpGv0JVJ6IeoKkPI+f5wC2BMP+VejeeOakxB/FI1vLt27DXXSZzwvJ9yI8NZqrssrNK95nJO9DhudVlrfD6NZUTBFWvpZi0u4dY/MZW+SKt1gPh8BCPNHpT6Q3yHtQ6apKCgyJzH0Vw2tSFtL+9BsTRMm9Daqjpa7T+04uMZN3Gz+B0EaCbtWCHeDuL+ B8yU3NzD xAT35nLas4IhjuzWR2NL2pbQkoGJW7YWVwHVgUfqxuBtT+o/VwR0GJ1lmXMwjh8SffZ863b1yD6UlO6DgNDYNdwkUKHXPIHj7mCcGnoCQgiEKpkytcl9g5kq2ONdaxbbyyaBXCnF+fPRcrNnx1XFQYIZhbEdgy0MXSO+DSUeXfxZvuzMuFyAVCxslDjImVSE5y1D1bOH+NQwbFtN+PUfVNtSNOF25DF9EWOXtd+UtcK5pRecr61RhPldcoizb7bhTS28M8KwklzGKF8BEPM5nZTGyJc0HGs0NwJmH X-Bogosity: Ham, tests=bogofilter, spamicity=0.003926, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 19, 2024 at 11:02=E2=80=AFAM Kent Overstreet wrote: > > On Sun, May 19, 2024 at 09:48:49AM -0700, Linus Torvalds wrote: > > On Sun, 19 May 2024 at 08:32, Linus Torvalds > > wrote: > > > > > > I'm going to take this pull and fix up the cases I find, but I'm not > > > happy with this kind of trivial C preprocessor misuse. > > > > I did some other maco handling cleanup too and tried to regularize > > some of this all, and it seems to work for me. But somebody should > > double-check, and it's possible these patterns should all be > > regularized further with a few helper macros for the whole "add > > __GFP_ZERO to argument list" or similar. > > I just double checked slab.h, gfp.h and percpu.h, and scanned through > the diff vs. 6.9 for include/linux/ - looks like you got everything. Sorry about that. Yeah, I could not find any other place that was not fixed. Thanks for noticing and fixing them! > > I think we can slim down the API surface of slab.h some more too, we're > now exposing three different ways of saying "trace/track this allocation > here": _trace, _track_caller and _noprof vs. normal; I think after a > cycle we can see if the old variants are still needed or can be > consolidated somehow. >