From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAA3C4829E for ; Thu, 15 Feb 2024 22:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64DCD8D0010; Thu, 15 Feb 2024 17:10:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5DE8D000E; Thu, 15 Feb 2024 17:10:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44FA78D0010; Thu, 15 Feb 2024 17:10:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C8918D000E for ; Thu, 15 Feb 2024 17:10:26 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B1D3B803F2 for ; Thu, 15 Feb 2024 22:10:24 +0000 (UTC) X-FDA: 81795432768.04.EE24FB4 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf14.hostedemail.com (Postfix) with ESMTP id 1571E100013 for ; Thu, 15 Feb 2024 22:10:22 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="M/2H7aZX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708035023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DLHIWZhrv84d6KmPP8BZW5HG3tmTNG2nCmARo35gkoM=; b=WjJ9syLyLuxldXttQrMJNGSP6fFb/dHo1ExMqF7rctGHLDMbWPQZK0AkXU/cN7OMpJzlIo OLClOg9gEH9RvPX8gxBnwyPkoMqAN8ZDCloBSXrI4qaWS/k6DpB8+iNZ03TAxQGksgHWD4 vjRaowHTdkLD3cKQqUIX766zS9nires= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="M/2H7aZX"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708035023; a=rsa-sha256; cv=none; b=AAzkYwwbM2t5bPIo8iYmA1kVk5J0LfevRG6qLqnYJr/vdyMcbCSvfbzr7fLu3ngktFUZP+ BHUggXA35LhMfeN+IqX1zaua9zDNHFkqZLGc5yoQCna8Ja5V7KGYGZYMY3u744p5YDM8NK q6cVPOyCkDDIoI4DjBk2zatDqn5KUbM= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-607d590aeb5so10042647b3.0 for ; Thu, 15 Feb 2024 14:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708035022; x=1708639822; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DLHIWZhrv84d6KmPP8BZW5HG3tmTNG2nCmARo35gkoM=; b=M/2H7aZXFhffHkENuNMxC3ezfM4aueLR/UVSnqYla+jfJ0dmKHDQmqVy8BifIogUGU ahPvKGTVaxNHtWLZVCZFON07fwrUNkBQgQ83xPLz74ivUR+V2fVWaFgxKwZ1GieH/7oU BL9rkeXhKjx+udeMaoguczzm12hUVAyTmynyAB1OKnNVq5UqBfYQAYEFt4pD9YYFRoNH cf4EbrfHpf/SWyP+/QS7SltrXCdHyRL8u1X8ncVpTHrwoe/+MQ8X+hrbe/o9+JsJgmtN 84kevLYHAUZMynBqAOXY1w9cwFOF6IgnFT7PlV9+4Dj9JipRepMYCoczZHC/D8TBOT1X l4eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708035022; x=1708639822; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DLHIWZhrv84d6KmPP8BZW5HG3tmTNG2nCmARo35gkoM=; b=duY6NQifHiu6uy01ZWeux5Ys8CO9fQepFFvuXyWRyMQATz8588vpCHkIKlMYpKKiC8 7X1WhcNPBJauk6nUR0LQEwmhX6qBp0ZqUbhbMOq+cXBZw9JBjdRa4BwJ1iK7B2qovaR0 Mh4qFZ+eHDFxtvRHhY77bsOOPIpUE0Y5iMgwPx84Ee/3Wg40TnWINLWCWveq2eFEBOvm GF9xbwS7PCPzxOA4Ok8GfTwvrRf/HPF0gIsJ3YHIrw/uKuhyJ12vte6M4Hes3BdrlWy0 UfOEM7AYUSbIotVHR/zqfMsMxyB4MhrLkvLZeTIgy6OELEZwdbxz3B5tnyPh3N2+OO4V 43+w== X-Forwarded-Encrypted: i=1; AJvYcCVret6N+xGKcrTS9KZm9V9OcrwW81xQqiAII89Zhauj4yOhCCobcyjEcHjKfP0x/JCTtpzSMLpLaoCcS4vsHs4yQv4= X-Gm-Message-State: AOJu0YzWrBNuyqDoPlTazpUdK9Juqv6q3Ebd8i8p3hHFhxb5ANuZPqqW MDZVzrPLuMk9NaPdL/ZoqAVpsCyKeSpfrZO1ZKcdKsZPnnEW+7bUJAQ5M2g5YQWXCI2r9Qymm/t fPcukkICbxZEGL1iQs4uERWfssvYKPHzsiFOi X-Google-Smtp-Source: AGHT+IFPqVFbWR3loG0cymbC1adYDa/mthQjD5ce08MYwc/pTnwtNoukSoOp+DLhCLmSTzEm3k2gZM9hlQK2lswT1QI= X-Received: by 2002:a0d:cc81:0:b0:5ff:956a:1a05 with SMTP id o123-20020a0dcc81000000b005ff956a1a05mr3845012ywd.14.1708035021851; Thu, 15 Feb 2024 14:10:21 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-8-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 15 Feb 2024 14:10:09 -0800 Message-ID: Subject: Re: [PATCH v3 07/35] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation To: Vlastimil Babka Cc: Kent Overstreet , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1571E100013 X-Stat-Signature: 87joh3jdwg9mb8expkud4fou3xgna8yg X-Rspam-User: X-HE-Tag: 1708035022-985109 X-HE-Meta: U2FsdGVkX1+GITxRgj7cyeExekldYDUVk+hMksGtxbGsjAo1zPxAP6rE9Z94Nq1QyAsB6ninLZxfBjM3CjyOsuw5WDt+FHr451xqk0EjRNI+DRbWVspCYzEQrNrrV+uGuLkgHsFGaY8UZYQ81ZsDRfBSlUSszU6zG9WrogKUbrj44Wx2YDERizM6Lczlk8ycoDLwHAf3AWVWjCED8G7FnXdB8XSBWtYS9j46+p09Gc7SLJduQk/0YhEIm8HHqJKZD00g4QtKFc/Ddj71V1VZpUVj5RMZe+G99P0aTFtaLa4WYP6+ekr3FrcifkjPj0YMF9nmL0QV2/rgyPw7FbEgsl/S1zEhyg5hIu0rlNnvvbO4ts+3G3Ibhyr7H8YTIwEjhaaR5JFd1lc6dvtS0hzz1XuZ0G16FmgkmXjPzL+AOy7YqfTWg8wqHbOGIEvJDqdcXxlk76hEEsva8STyCSZmHv9f60C4c0aR1nlZ0dstV2lmr/is8LP9AjfmVwqnFtZOt/SZnnuHi/SVpHRgiz3ZAHiJLQonFZeMBqj5Zo6wDQTRAzCJb9k71/dFqF5BDF4ZeHGY4MYvfHFYy55upKXk18DsIB/xJh+BznHGszoaI9dqMZ6H+YOcURqneHKGltyOuqdFt36W53/t6G9nJeAF7LlwdnZJ0vbIElW2FjHTfKbOqiIRs7Bl3oQKC+V8BKaWWuXDw/TPXsyvcB4IKwKPaY/BnPLibs29w06uJUEwit0GDzs8fBIJwBdfiFfYgvLJflCCgT59BRA3uCbJPSjOcQvltIFrOpti8OH3IpZZb6WhEJPRyvelEdRX+Vv1+PXO7kBRHV7JzZLnuHLMFsFM0EAf77xT/aTdhH5qetNp0bpfLqGgBZxN3ZnPWKmMWHhB7G7/hL2CDjs734wJgGdqHcIkbHtvb2cGmVik4V5B1pqVt8yUE8PGhH8gh7lzdU7wnuAjQ+f7PHKE9aNIcGU 3R89RUdY 3pqEUiHJIgbcBHSPwvwJfz+0hkef2eNzj1Nx7r0MpxvRPtdv2njGNlVlmWgZDSjbEuviVarmAVVOK0X+TyzutzsD4o90aPnEBRQqUuxKkXfQuEJF9jvYHeFqmPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 1:50=E2=80=AFPM Vlastimil Babka wr= ote: > > On 2/15/24 22:37, Kent Overstreet wrote: > > On Thu, Feb 15, 2024 at 10:31:06PM +0100, Vlastimil Babka wrote: > >> On 2/12/24 22:38, Suren Baghdasaryan wrote: > >> > Slab extension objects can't be allocated before slab infrastructure= is > >> > initialized. Some caches, like kmem_cache and kmem_cache_node, are c= reated > >> > before slab infrastructure is initialized. Objects from these caches= can't > >> > have extension objects. Introduce SLAB_NO_OBJ_EXT slab flag to mark = these > >> > caches and avoid creating extensions for objects allocated from thes= e > >> > slabs. > >> > > >> > Signed-off-by: Suren Baghdasaryan > >> > --- > >> > include/linux/slab.h | 7 +++++++ > >> > mm/slub.c | 5 +++-- > >> > 2 files changed, 10 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h > >> > index b5f5ee8308d0..3ac2fc830f0f 100644 > >> > --- a/include/linux/slab.h > >> > +++ b/include/linux/slab.h > >> > @@ -164,6 +164,13 @@ > >> > #endif > >> > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Object= s are short-lived */ > >> > > >> > +#ifdef CONFIG_SLAB_OBJ_EXT > >> > +/* Slab created using create_boot_cache */ > >> > +#define SLAB_NO_OBJ_EXT ((slab_flags_t __force)0x20000000U) > >> > >> There's > >> #define SLAB_SKIP_KFENCE ((slab_flags_t __force)0x20000000U) > >> already, so need some other one? Indeed. I somehow missed it. Thanks for noticing, will fix this in the next version. > > > > What's up with the order of flags in that file? They don't seem to > > follow any particular ordering. > > Seems mostly in increasing order, except commit 4fd0b46e89879 broke it fo= r > SLAB_RECLAIM_ACCOUNT? > > > Seems like some cleanup is in order, but any history/context we should > > know first? > > Yeah noted, but no need to sidetrack you.