From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B0DC7EE2D for ; Fri, 3 Mar 2023 16:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7B36B0072; Fri, 3 Mar 2023 11:14:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9985C6B0073; Fri, 3 Mar 2023 11:14:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839276B0074; Fri, 3 Mar 2023 11:14:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 72D756B0072 for ; Fri, 3 Mar 2023 11:14:51 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4291CA0540 for ; Fri, 3 Mar 2023 16:14:51 +0000 (UTC) X-FDA: 80528085582.18.333DFBC Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf07.hostedemail.com (Postfix) with ESMTP id 835974000C for ; Fri, 3 Mar 2023 16:14:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DBUjHTuC; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677860089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+HigpCH+Z2DmMB8BhdGZnkGJxtK6UAghULTuYAvBYII=; b=RSsSTsWADP8j3+Zwo5yTHfNo4zyRd96LB8nw+YSDZ3+cS+uZUTFCfdNuTBT/ansi8KaT5E YZeFryB/s8O76yLVKT8jON2Y6ce/wNQSx1KwN29gcPDJZcFZMZcF9+gKMpg0jmOqhwcuh2 yNvJYQ6DO9OuWugN1Th+9uYGciqmJRM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DBUjHTuC; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677860089; a=rsa-sha256; cv=none; b=KqldN6TtgzumJkQmUn88srJSgV4R4VeWofvdB5d5JP8JcIf4nsLczs5E5uJzdE4TfhSS53 RnXz3NIY5rG9ZgZ5Auln8FQIhgTZnIbqKbhecEs256WmAcDCGq0nPUNQFg3J9p5GXvP59t JjlmznXV5v0aAz67P7ikcAxhpiTuYDc= Received: by mail-yb1-f177.google.com with SMTP id n18so2416058ybm.10 for ; Fri, 03 Mar 2023 08:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677860088; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+HigpCH+Z2DmMB8BhdGZnkGJxtK6UAghULTuYAvBYII=; b=DBUjHTuC6OLAOEFQL/9SnCUwEjvU7+kYaOKx7lUZ2rsDkdc7y/weciI+YncXMe6yPq 6v7NyE0keu/sVTwXjsJ4KB5s6vKWaOGP/EGn2Ts18q4AM6xKHTTAs+FzN7P89jEGoSXx Rn4xQV9h2vkZ7UOsVGBeGNj5DXmqTpDFn5+Gz2eRhQI6AJYkNZmXOzKQfRNBCpuBXRbB POdcu+EOJT60kluX5CyxfEYIr7GmvmSf36YIDXysgZHS203zORKBRmpggPYflvsN1n8+ 9lgiQHv8LJxYXWINdHGrRhDw3uhYq9n1+bTj6MIZ0yhPAuvCWKEBstJYeMFnHvnJVk+B rlcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677860088; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+HigpCH+Z2DmMB8BhdGZnkGJxtK6UAghULTuYAvBYII=; b=4UCdw/MSPMvgLbvtMu94PgMdjV8c8LiMCORkNFWD2Va7f59s//Uyl+K6hIfaz8Vqm/ lzId4J3Jwz2M/bnfm5IXwdMjBHLzSqp3su1ONKMat8qXFR7SqALAmZaseCAgddpNxVjP vcXHI4IgmZjbWqPawrGYKgPrt7T7vHduRxpB32vLlwZnq8+mAdOBygihNLTssRgEEnj0 w+Hj87ejRAA7pzz6QIVi0yFhRstPzewwG9BT2KOkMmOGeKNwPKhDWubbQwgXOUv0F5j4 x3qh65ELUHWfYdVrGey/RmDkoVxK1B5SQqP6t+JgcFGO3yl3FUm2vZiZlePK9lf3KtRw rwWA== X-Gm-Message-State: AO0yUKWngEj1D5wPXAYwBL1uP68h2UPvcnOLn8ZE+8jJ6h4w/BCgIezS f+0LPh738L/9Bg+8B0Chgr88xOZ/WHuvYarfjXYQ6g== X-Google-Smtp-Source: AK7set8tjuuaCGJxS2xjbV3oET8sl7sgczITsPDeROrOkb0RgwsUNDHjDBMroxTBST8vYw0SK0MsoSZi2W21t2t+4Gw= X-Received: by 2002:a05:6902:524:b0:ab8:1ed9:cfc5 with SMTP id y4-20020a056902052400b00ab81ed9cfc5mr1287342ybs.6.1677860088329; Fri, 03 Mar 2023 08:14:48 -0800 (PST) MIME-Version: 1.0 References: <20230301190457.1498985-1-surenb@google.com> <31a88065-063a-727e-52fd-9fbc7d17fb5c@redhat.com> <787e7d9a-fcf4-ad5f-97f1-c0e1c1553c2d@redhat.com> In-Reply-To: <787e7d9a-fcf4-ad5f-97f1-c0e1c1553c2d@redhat.com> From: Suren Baghdasaryan Date: Fri, 3 Mar 2023 08:14:37 -0800 Message-ID: Subject: Re: [PATCH 1/1] mm/nommu: remove unnecessary VMA locking To: David Hildenbrand Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 835974000C X-Stat-Signature: qzmsedg71zza639ng5tjrer4e7qqtkm3 X-HE-Tag: 1677860089-64225 X-HE-Meta: U2FsdGVkX1/LcPZcBblKdqVwef/13OXbEomuzA7WlQTWKfcgTZxcSqRJpbddTS7O/LvzWRXjlRQ40TebDBBRZ5yekA3CrfGI2V1Mqr7f55lYfrOMOxtmf6xzuSb5NkVOdrszMCOlgjpxCII6rs9aHd9aMzaPbVymAf4ox6wWZBJ7Vs0/1a5ivKkQ925HYqYoNA7T9MQmartYbBCW64pgorNZ9NnqSyvYN9sVmbwWLyzrZVy9bv3nPHi4Jvxo+oLXMZXQkQCXleHdKQugQAxZhl0jfbQvLWzjrmxgx94CpPXuMqGN66/OrCSOd5PuiOw2jDufO/W2PLflCzwLoyErFUtT+avesvNnDQzK04Vt0sFmQ7JemAw3HhdAPhFz80jdk/KjmncppYJabhaoobEOMmH8fQMdtlBfXBKoqMBkLVlWpZPxWyjoG8oAuX6nB/hwhrSTaOow3v0J2qs2bKy/VbmnHBkNRskSU25FVL28UGEygIYohZpmwiLjD676BUSqMyPW6YXvxhEd4gBNN9+R1v4alheoTE2jTwa/9ocA2c2PqPZdvm1jFZEJBqZSNITTeUDrehpb4qUnVuZXj1mU3bhl0ph6kXYcG2VX7CDBVLa+NXmlN2Y0ogi15lvCLXSlmsKzMlD9hvifVm6ZDEI0OOPQQxvUpkPjWBPNgM3dRCEY6dkW7Up1ogWPqDz3EYMgOjfoKsZPopLGrqyXof6zvZzj29Ym4oA6W74WyBNrQe6ZLdw8MxPaEWVbKT0nNG0HAJ2xW/fR9fikLgoEiZPTzQN8Tz01/6lz+HK9f/HwGqQcrH/VZl5WpJ4IE6+G2RYBRUnTqCFKR20WjD8dUfelFLRACae1Tikjxx2UxAxXk9UvvuV+PS5ASdR0oRdKdS2Hxsb0iDUtk6AWG7bstqioW6fIhpPo0xVcRyclZ89uSbovK+FOaO64WO2doqtFrdyPl5lMJGCsyI6suPIa2+U p9MTl07B Tc1S6G7Wu1J9RNSLbSQWRdHLFYZhdVxWJoYN/nKfIoFTEyqSUP2cX+YslKukz4KaBzqbOAeF9i5nbB/CY4969+75kFyx7Y4qmt/L/TwjCf01RFGywgnZKaKoWSTiY9pjVnHCZ+5Tpl+CVwugbn4QAPMvkYz16nS6MArF1AXXb36ADkAn8d6AdGEWSEgPxmBp5cguW6el9H6MAzmXg0+B2scviAR0jc7NAHE+EWRiXKJX0J8V4i/jX0wDeoGKdwlh+RbNDpVkFVHTZKaBtxKSy/ornQK2x/ZqHrYzc93wR1OjloarzDimm7LyLvwFRUPg/X0tQVQyuP2n9Z93PzPKCsKEh2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 3, 2023 at 1:05 AM David Hildenbrand wrote: > > >> > >> Just a general comment: usually, if review of the original series is > >> still going on, it makes a lot more sense to raise such things in the > >> original series so the author can fixup while things are still in > >> mm-unstable. Once the series is in mm-stable, it's a different story. In > >> that case, it is usually good to have the mail subjects be something > >> like "[PATCH mm-stable 1/1] ...". > > > > Ok... For my education, do you mean the title of this patch should > > somehow reflect that it should be folded into the original patch? Just > > trying to understand the actionable item here. How would you change > > this patch when posting for mm-unstable and for mm-stable? > > For patches that fixup something in mm-stable (stable commit ID but not > yet master -> we cannot squash anymore so we need separate commits), > it's good to include "mm-stable". The main difference to patches that > target master is that by indicating "mm-stable", everyone knows that > this is not broken in some upstream/production kernel. > > > For patches that fixup something that is in mm-unstable (no stable > commit ID -> still under review and fixup easily possible), IMHO we > distinguish between two cases: > > (1) You fixup your own patches: simply send the fixup as reply to the > original patch. Andrew will pick it up and squash it before including it > in mm-stable. Sometimes a complete resend of a series makes sense instead. > > (2) You fixup patches from someone else: simply raise it as a review > comment in reply to the original patch. It might make sense to send a > patch, but usually you just raise the issue to the patch author as a > review comment and the author will address that. Again, Andrew will pick > it up and squash it before moving it to mm-stable. > > > That way, it's clearer when stumbling over patches on the mailing list > if they fix a real issue in upstream, fix a issue in > soon-to-be-upstream, or are simply part of a WIP series that is still > under review. Thanks for the detailed explanation, David. I'll post fixups to mm-unstable patches by replying to the original ones from now on. Interestingly enough, I have another fix today (internal syzcaller found a potential deadlock) which might be interesting enough to be in a separate patch. So, I'll post it as a separate patch and we can discuss whether it should be squashed or kept apart. Thanks, Suren. > > -- > Thanks, > > David / dhildenb >