From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DB2E77197 for ; Tue, 7 Jan 2025 17:45:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E486B00B0; Tue, 7 Jan 2025 12:45:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADD386B00B3; Tue, 7 Jan 2025 12:45:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E526B00B4; Tue, 7 Jan 2025 12:45:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 741EC6B00B0 for ; Tue, 7 Jan 2025 12:45:17 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1EE0B160AF1 for ; Tue, 7 Jan 2025 17:45:17 +0000 (UTC) X-FDA: 82981382274.11.FB34BD1 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 3C08A18000F for ; Tue, 7 Jan 2025 17:45:15 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uAjFyqy2; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736271915; a=rsa-sha256; cv=none; b=Ucix3yv9nVmyrIj21CwVvAdmpjJF+ZVfgoJNS/g8VPGRXtN2qVRm7ax3/0JbvmgWZVmwnK Gc93AGo/8wmjKmz0lT4lb3zOKtAHMdWis6mqf+G5K5zjBw9C0pQ5EOXq6l7Tz3vdiNIgB0 wFGVd73Io9KY0LAkv69iRN5WaQ3OxEg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uAjFyqy2; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736271915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZV93VUPech+aDp5P+R82vpWYr/ENu1LDnDURQ32K4jA=; b=BGGPqSEt/Wei1nNlxkOw7g7Cx95mB86vGp7fWxZDUoXXIfqWqK/6ZzoJHqO7i4WU+1pRTF sojSu3iQsok2NVKw7sQVgDkf2/RWC4GsJpH9ykYDXuj7wARgv+kOrrvkxKjxar4v8Cmbab a8MIS0G7eqJA4LV3HYgJ5l1Ls4yWISo= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4679b5c66d0so421cf.1 for ; Tue, 07 Jan 2025 09:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736271914; x=1736876714; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZV93VUPech+aDp5P+R82vpWYr/ENu1LDnDURQ32K4jA=; b=uAjFyqy2c+SsoZm672QzChSZcSMr0y6WNAY+673Som736FjRd0xVKZAOetJnSZmlQg 0BidiJ+r5Z1mmLTbrqRZIsMxAI9QMCjO6oaEJtOiA2fMQYFsxRUiNJZ2O3yv872eP6XM 8naKq8SCZdBYQbyfrvysp9VEQ4Z7vvtzIC5ks79B8zcVMktClLTt/Fxn5c5ihnVEYz1I V4eoBmpwwA2PxYOtqWCpdVAqM9VI1lmiGZs/Q+wWrbnarAZvN4a/5G8tOP1lGllI7PoE cdxetds6YgmEi2SzFENK5m22me5M4UqNWgNgs6d8V71PArGRm/7cUbNBD2GplCrlEcII O+IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736271914; x=1736876714; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZV93VUPech+aDp5P+R82vpWYr/ENu1LDnDURQ32K4jA=; b=Zz5gEc49hnIpvM4bS7oqdTYQ1kzSXYaX+8C+mOGAPPSl8mSAl1UP77ZG+7Yp9QU5P6 3dzkN/u2vpHkoEveUyPxyPVA6dnc3WNcJupYsO3Yt4CxKMa7C76OYH5ypIgbZu3kAhSx ySQ5Z3tSBfm25Ge9f6ZdqRP0HPdcyMalC5ga/36ciwab4WJxNm+JMp5fEckafpJVq+FX 7bgjt6Rz2lohbztkGIfxsftCDHKCrfEJrxAYKCBGwG0dNai9c6XRyRrio2IMmzgIEy3D AVF988gMO1gDXCl697NnSTjn55/NQtr2aFkZ2EnABxHgYMUhQkjbXSchsebtgNf3hITo lXOA== X-Forwarded-Encrypted: i=1; AJvYcCXHjTNX0JTcXtKj4Q/7guElBY9aDa8/9nwbdUxjOQk3uBatMpnDJFLiB5baehrzslFBni0bnDW+1A==@kvack.org X-Gm-Message-State: AOJu0Yz3KJNajTz7/A2J5EvN2LF6dY1oOP4oOYOB1zWU7R8Fz/53Bbc8 d+eexrP0NsMwiKqCNBSLOq0Frpe+zvZjwIAcD+7K8Ei7gDk0nRWKtiKb05xxrNNBXX9HEsiOMWI lQBSWK4pAs9kpnWD2P6BnyRmbJjleCF8Q5TjO X-Gm-Gg: ASbGnctLVBlL+tJxqF051ykq1dirVutV2xVgKP4dHLemvGYZ3x1kV9br0PX2HVc7xHm hQLvKUybgoxCJi2FklT8P1frMGdHpaa4SSRBbLZxgJOKhBUbJMaVI3O3fsY9O0Mh+8Byg X-Google-Smtp-Source: AGHT+IHZ0PRyj47AFsXc/kz4t2BngIa9FU0t+YkwrwaQn5xBWFIIbMvTtR0HUFbSrOy1CDU0Zieeox9P6tZ4O6GwIcU= X-Received: by 2002:a05:622a:608:b0:466:8c23:823a with SMTP id d75a77b69052e-46b3c814b88mr3906951cf.17.1736271913933; Tue, 07 Jan 2025 09:45:13 -0800 (PST) MIME-Version: 1.0 References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-11-surenb@google.com> <0d36fd53-b817-4bbd-ae38-af094bd301df@suse.cz> In-Reply-To: <0d36fd53-b817-4bbd-ae38-af094bd301df@suse.cz> From: Suren Baghdasaryan Date: Tue, 7 Jan 2025 09:45:03 -0800 X-Gm-Features: AbW1kvbQ5eB81Czg-BskCYXstYQRXiuXVcnQhjZ4clU2cXzdV3Y2_y24itu1HbI Message-ID: Subject: Re: [PATCH v7 10/17] mm: uninline the main body of vma_start_write() To: Vlastimil Babka Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3C08A18000F X-Stat-Signature: ejzyi6usgtjymihqzdwpaa8qexk9ujwc X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736271915-498372 X-HE-Meta: U2FsdGVkX18PXIEpKromthICRX01IB+uD7PZA9hTTpU+mnEo+Nav/IPJWgkE8b5+DqVtcMXBxe7AmyAqbkvZ0h0tesMKZYSBQV3GSc9AVIa9YLH+vsLmoVgRvACdx6oZ2Xdl42XbnHTwfmokBDCfPkW+k8uK/m6wLPwMgNiqgjVrsrueUwCzZz0HB7prqlwiLoTVAK8MO4/jJ1St4m2ph4aFEdioB7flfW0jUnP9QEH5q6LFequ8GoBchFT2ZzVBQudadL8IGpq7fZhTF1y5g+bJm6npAiS6iE9AFlireCGzRGObRL+psyCpZ7a19gIBHi3wIDC7Vl8entmmkMCy8cxocTJteeqIy8QGiDUKc4hPH+ix4s+WSD6scz5lE71pN1OPIdC+Y8hve7yo5650XLm/Qb3vKQKgNgy96PbhMpj1+rN1vU9t0YJW4Zqf9hsPdBMrQDGfVjalSiMHiFAhkBLRod1NNecHxkvonM55PvtaKWrVSMXaAr6jeykLSVrq+vVn9SDoxrXRQwZg91TzT4hOZpmrlDwsPZhfd27ipq7cF7otAfEA6JAvSgdlkcKuDvsIS61WWi08raLaVaJaNKyQw6g1QEmajBNeH7+WxhjDMVIehtjuViuNrbH+hdghAT+6hI91LdQWEa3ejvi3uZC7zDoqG9PoC1mvBaCudkdrjOL6ipgsoUSCyKrEX2nKArAa5ALsol+mdHS/pa7KzrMIpcLovI/9D4JC/SSWUvwWzgWxNFInp9GRpf+i+w5TAUfFiRq/1fKmTtqEbdR+1btrJlAxutaUZZexvOUfMTAtROZ1EJUIoLLgp7EKptkv6lN4DRRgpTMGiuxDPgTRsfH33PzQZyhZCt0TYERxmY5cKtUSB9tjzZWo9+ixFlNDPBzo6eF+3LG653y6C+vyQw+9IhhcFB+3UrceayKVArk0YMV0QT86i6/3ZCMVvnuIs6uxTmkn6SPVJ5irqJP BI0/Fp1D 3sESCGq4BCRL3I81Xn+XRTi202Sbr9w67XLm17V8yPMx9TOQt66rqubZDMdp22Sl4H7VMelWy5iDORsotYok/Xis6JA4OqNpCr79QB03YbgQOCyxmlb3QWcEZuXDbQLwvpQ7i+BfX28TeASVib/MxvbHUVhJSZBSokQKTnohhO4BDIY2f6j9kHkW8kWrOwZRa1Z+9Q1yw05q4I+jC7rA0rT/CoK+4UGhgF75bMxlPFvLmNXGlFCGydiTntAU033N5bXB+zYoCoQe3hIU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 9:35=E2=80=AFAM Vlastimil Babka wro= te: > > On 12/26/24 18:07, Suren Baghdasaryan wrote: > > vma_start_write() is used in many places and will grow in size very soo= n. > > It is not used in performance critical paths and uninlining it should > > limit the future code size growth. > > No functional changes. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Vlastimil Babka > > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -6328,6 +6328,20 @@ struct vm_area_struct *lock_mm_and_find_vma(stru= ct mm_struct *mm, > > #endif > > > > #ifdef CONFIG_PER_VMA_LOCK > > +void __vma_start_write(struct vm_area_struct *vma, unsigned int mm_loc= k_seq) > > +{ > > + down_write(&vma->vm_lock.lock); > > + /* > > + * We should use WRITE_ONCE() here because we can have concurrent= reads > > + * from the early lockless pessimistic check in vma_start_read(). > > + * We don't really care about the correctness of that early check= , but > > + * we should use WRITE_ONCE() for cleanliness and to keep KCSAN h= appy. > > + */ > > + WRITE_ONCE(vma->vm_lock_seq, mm_lock_seq); > > + up_write(&vma->vm_lock.lock); > > +} > > +EXPORT_SYMBOL_GPL(__vma_start_write); > > Do any modules need it? If not we shouldn't export. I'm pretty sure I added it because of the allmodconfig build failure but let me rerun it and see which module was using it. > > > /* > > * Lookup and lock a VMA under RCU protection. Returned VMA is guarant= eed to be > > * stable and not isolated. If the VMA is not found or is being modifi= ed the >