From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0678C4345F for ; Wed, 17 Apr 2024 00:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570B06B0093; Tue, 16 Apr 2024 20:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 521826B0095; Tue, 16 Apr 2024 20:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E8E16B0098; Tue, 16 Apr 2024 20:36:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E5506B0093 for ; Tue, 16 Apr 2024 20:36:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A8FEB1A0563 for ; Wed, 17 Apr 2024 00:36:27 +0000 (UTC) X-FDA: 82017157614.03.BDC1F4A Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf17.hostedemail.com (Postfix) with ESMTP id E63134001A for ; Wed, 17 Apr 2024 00:36:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2TtLHPFg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713314185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rzuAMB5kZ9cysqwT31amJunolyCfXrs4TaDWxUZblGY=; b=P/pDPCpjGDczekZm6sRUANTsr5z/q3FlraRhPDbpUQhSAI6JC0xpLtKZnqvDdjJpuz/82o FPuy7OIEW0uwfOHcbml+IULEgXiM8cde1eitPczdlTyhxFVHfkdW0pk/94hgMtuw12CY5a RX9kQ8h0XTa77jwu3CyiXighj0np+rY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2TtLHPFg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713314185; a=rsa-sha256; cv=none; b=Kq5+kXzgqrtY2ohhYcA5NPVdU+aWnI70HN6pVkwdsA7lyCIL1xy6xiTt4PFh8bD21OYjTZ Y3DKbCMH1K6XC9grq/GqEzHA7m4ubn5YJNhuLfNOcelXu3Kr+aGfTsOhjA8Xaz2WEpS3jE Xq8xhwznVxLjfQY02nVWReHOWt2X0Cg= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-617e6c873f3so56089477b3.2 for ; Tue, 16 Apr 2024 17:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713314185; x=1713918985; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rzuAMB5kZ9cysqwT31amJunolyCfXrs4TaDWxUZblGY=; b=2TtLHPFgPQPsfOGmdSvjzBq07jGlSMB93MMVsWzrfex37OLyLKHYoNFvkFTWRaVBbE oPJzyr55c6IhOsTDbSe2dEoPX1lIaMDFDfaJoasGlXAnVYfmjk+F7b9O9PJoymPPJJ65 7QU76q7sZPzcLYqp6wMKn7T+uafSIYx3WFsBqNl6V9hcRk2jnHdFIhkcXxtS89yBr13f xMlmub1QDJaCk9hIlX/aykf9bbem/F4OtLlGIUjsrpCE+lT38fT881sFMP8Zl8ihIbmw NaPfBU5zgsgek5/84Kezg6n8UI6kCaqhLAq1P8YIZYSxQK7KByBQxuHNbb9udDQmG79P o0zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713314185; x=1713918985; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rzuAMB5kZ9cysqwT31amJunolyCfXrs4TaDWxUZblGY=; b=eLlwveIbsbkh0AR3l4c0xnI3X4U7TkcqBXPWEHvPxx8KPSo27wiEi10fDIszPU0cHq hxjbBErzaQtqrdeeJBdFE2HpQHs7BJgLb9D6VXQ0o6nc9yMLFFPF9/tx4XpB/egJg8UY 2qoEUWa8QrdfV7G0/E40DcQpAoCUElKP3CfritJfkKEBoj0JKdBfb0nTsTGaGw22yy8q 9hmjZzw56ObhTaQWPxFgTDqhWMvG9awNoaZbBftAnFpJ/JiIrcYf8yK9YiFxZrwtH2Mx 0a0gF+6krhCQLxl4NjeHuaoP3SRYQp0TF5jaLehSg40QYetXFb2cF8hYfjgDk7TnAHBq /YUw== X-Forwarded-Encrypted: i=1; AJvYcCXOpXwhgtxkpCZl739+e2ji+BUrG6PLj5H1buy5+9J0PRSb+/b2T4EIZeN2btTz3ZeTxaXc5HIa3HCXAiEmUDPbkFE= X-Gm-Message-State: AOJu0Ywe/67uMf3Fpr0wjdBxfVDLmUSSBeGk4CROFLS1xcDi86MEEpFf BpeLfu5n/eoHqEsVdKROjRGvIFHXLl/jrVA90+sej624aakviIhW8e7ANN7UnMuVVBCivEgCyNo EwR/l5WYH0DABYipR4qgWUPlbCmaV7rz6wmXw X-Google-Smtp-Source: AGHT+IHgn07Z06Nwink4x6GpgSvdH2TFVsTS0zKEIHaEjvyb68QnH4/vtJXPZ+SZXScI7OmGqUJnNFUrvaYTXdZz0w0= X-Received: by 2002:a25:be8f:0:b0:dc6:23ac:9ef2 with SMTP id i15-20020a25be8f000000b00dc623ac9ef2mr13818240ybk.19.1713314184854; Tue, 16 Apr 2024 17:36:24 -0700 (PDT) MIME-Version: 1.0 References: <6b5281d8-2998-4e66-b65e-45a0e68e5780@moroto.mountain> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 16 Apr 2024 17:36:13 -0700 Message-ID: Subject: Re: [linux-next:master 2720/3921] lib/alloc_tag.c:142 alloc_tag_init() warn: passing zero to 'PTR_ERR' To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton , Kent Overstreet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E63134001A X-Stat-Signature: qtsheg5j7snahtzinzgu7tcga9ooukeu X-HE-Tag: 1713314185-962347 X-HE-Meta: U2FsdGVkX19D41z4fZbhiQBmKvQ6CjmTqiAuGzGNod0s4hKfiLrihQv8cYXSVnIyCyFGr1+vJtmgbwn25lQNB0a0U0SS/dw0Ci0T/g9i3PuzA/W1aBQJQ/4+w3puGsxsFVyEOFxjFILRTXXKVkFdw89D3/Wy8Ukcx5oUQW2oRuFPeUgo/yqZAr3d5nDRk7xlN/ppU5MuztMEU3FJi0tsGJcn2K0cxwkBZKyqlgTfxYxTMg+K1Sb4IzpGnKdXp+sKLzcAJpotvUzcBelWPOKb3n7IVT81yuxQzRDX0LYUsFuTeN5j9iwYt8UaOPmzF5e3L7A+X2LTO27alfMy+FKVR2mu9C1MIPgAnZfKmAnEXIqCMIyGRuqrJcHvgZ5W4gs1SsNp7hC0W+NvVKrE7qrNUzkHO1bw8UDAi4LaGP1SoOAOC0f2PHnJ+mfYVzqvQ2V+TzAve8hsYKKT8Ff7nsdnkXCJJPNmK2X2WKFuXgoH3QYqFOtsV7lME7272GwrN/dp4nen3mKVoI5+PRTAtfXUvMXc4ruFG1eaGJ2IOppQLhOWL1Dzb4p6Unmthe8pPL2Oo9peGs4ryQ9qjPXosKl1qdfx7Tuec6DkqlktLrkC+HWFoCH65MTHQtLvBB3hlIqEKGuFKVC0HR9zCUITKhKYl0ObQj6C20gZAAK0fP1PWgD939gNz5Nu2wOu9s110cQ1KFN4ForeKbi7b3AHkA7HlSqupx0cMWaUzevmKV3tcNoPKpknIpSTgQjppW75T3ER0u8o8F47cbq283cVbApPkaV7adb1K3Cf10wMDE/39dFbc7me9qODivdkF3vI4FingMRUfLDugPwoiaCS802mp9wldWIDd89JArmKCB+o42xXZ/Uxc5GYtZj+rTlPjgce4HxFLWoUZwMEq1nsDqEEsAKh9CgrWj/LOoKOb64uc2V87rnq9qrudIq6srNx2A/XwCOr6qGYswfxoEiiPv4 bO9ajOsZ lNBoRPF8IMKKCnd68UStn5eu0lbmKWstYP7EXdITy147oVe8XTQIWuhNsgtkJGeU7kdZcqSlFAFCdphk8qM8SehB20lF9VpzhLUkk6DOen3ExECYPzi/ioas/iB5S2k+Ihs7uyhDwy9SnCUWCWCTElahmthmsuya0KBOhuGOz879dtdth+ItSEeUhVn5bsMlKkqFdQi1oXHwmcAFsOiV+jlBRL1cpYuIsyg4PeMrdDrSFS2ZewwdLDlHlje8YUvSLlZy8ZyNzIGchD9ErQbnzvoLB7/3eiUfbf4uLJeM0ZxcyidQZVc+ERy9miAYaGdazFham1TX/xhVZPvtPMrKgmR4nfkj+vuvGfVF+0VDRp566OM2k75p4h8Vhlxx47GjyTVoUjw50XYzqP1ln6fdTVjIuPAt6ggp5ejGFARDv2qu7xJp7mmiSv2NfXOA1regCcb2NhvzWMI21/J8kUDDQl1vzY6VRQHYJcYGYTVArObFgxUiS2vWntuAFsbeB26qkorY7UHfMr2aOTPw8/kwZgUhTTwKNI+3ITbIpfCQQde63fkAa4x29CwY0n5BRBK2iNPV29D087YPt6Hw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 4:57=E2=80=AFPM Suren Baghdasaryan wrote: > > On Fri, Apr 5, 2024 at 6:51=E2=80=AFAM Dan Carpenter wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc > > commit: 9e2dcefa791e9d14006b360fba3455510fd3325d [2720/3921] lib: add a= llocation tagging support for memory allocation profiling > > config: microblaze-randconfig-r081-20240405 (https://download.01.org/0d= ay-ci/archive/20240405/202404051340.7Wo7oiJ5-lkp@intel.com/config) > > compiler: microblaze-linux-gcc (GCC) 13.2.0 > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202404051340.7Wo7oiJ5-lkp@intel.com= / > > > > smatch warnings: > > lib/alloc_tag.c:142 alloc_tag_init() warn: passing zero to 'PTR_ERR' > > > > vim +/PTR_ERR +142 lib/alloc_tag.c > > > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 132 static int __init al= loc_tag_init(void) > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 133 { > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 134 const struct co= detag_type_desc desc =3D { > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 135 .sectio= n =3D "alloc_tags", > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 136 .tag_si= ze =3D sizeof(struct alloc_tag), > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 137 .module= _unload =3D alloc_tag_module_unload, > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 138 }; > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 139 > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 140 alloc_tag_cttyp= e =3D codetag_register_type(&desc); > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 141 if (IS_ERR_OR_N= ULL(alloc_tag_cttype)) > > ^^^^^^^^^^^= ^^^^^^^^^^^^^^^^^^^^^ > > This should just be IS_ERR(). I have written a blog that has more > > details: > > > > https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-a= nd-null/ > > Sorry for the delay, I somehow missed this report. You are absolutely > right about the fix. codetag_register_type() never returns NULL, so > IS_ERR() should be used here. I'll post a fix shortly. Here: https://lore.kernel.org/all/20240417003349.2520094-1-surenb@google.co= m/ > Thanks, > Suren. > > > > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 @142 return = PTR_ERR(alloc_tag_cttype); > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > >