From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A99FE77197 for ; Tue, 7 Jan 2025 18:51:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 198F26B0098; Tue, 7 Jan 2025 13:51:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14AB56B009C; Tue, 7 Jan 2025 13:51:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2B7B6B009D; Tue, 7 Jan 2025 13:51:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D17A46B0098 for ; Tue, 7 Jan 2025 13:51:28 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8D1D5A0BE7 for ; Tue, 7 Jan 2025 18:51:28 +0000 (UTC) X-FDA: 82981549056.28.BA53E43 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf12.hostedemail.com (Postfix) with ESMTP id B0EFE4000A for ; Tue, 7 Jan 2025 18:51:26 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Vcec6Ar4; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736275886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPh2gKS/v4VjzRQCsLemWsvX/hSIorRAHAy4XmYPBPU=; b=UYVoOK8FYpikb0wPWDAUmERnXzPwQe03G2J3jah8RvL3gyVEReqlkJ1RjLB6Pwhs3+s7mO uypDROUC/d4q2Q1Ap1yrsAu4+1IUAS/xA4NaG/zvLq4iNwqkyD3J6L5/h5w/UiyKhpjjw0 vPbNdhf0fSNBhryIZrqsj4UmVtkByTg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Vcec6Ar4; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736275886; a=rsa-sha256; cv=none; b=d0Hgw+piukjt8fmcIROvdDMiaJmaE7f/nznHlnhwsaZKJoTEJFqK1CrclCuzJamitTEzEQ 6wqDfr5goWrzhjrZcczcuwbXcE0Cq5fOQAODN1Wl7e7ivwaw8MbKOhzZHcTh+ynvsDRuhD ZRufM5j7iHAEZSvVi+PFMHASpSybmQ4= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4679b5c66d0so19171cf.1 for ; Tue, 07 Jan 2025 10:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736275886; x=1736880686; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tPh2gKS/v4VjzRQCsLemWsvX/hSIorRAHAy4XmYPBPU=; b=Vcec6Ar4ypSDxsieM23v4i6h2OJpZaekWQajwNwJFWBkscVBUVvqirBV/fHsfb5iam NrGGZPGBSb2IXpDoBIURQB4sc5HnLN2eUIwaqZdzPxw6EWdfP0nimXc6tERPOg2xmM/r sQepieRaHb4xQjepuJ4UqwKRGn600M4IknUdewz53pDVhUlzshZdYg6z8quBoFCYOM/h zfV5Inm4SkALW2ygz2QexMuphCMvyeEw791DA+HvIKsWYNhs1C7qb6xXSJUT7kzkr+YK wQtZcq1JIIaKkvKOCHDQrmRx1rxjjqaVLHs7AGU9EKqHkgrflBmaWdx7SOCnfYQ5uwCl fQaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736275886; x=1736880686; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tPh2gKS/v4VjzRQCsLemWsvX/hSIorRAHAy4XmYPBPU=; b=WEbIwEHtMuCW72v0kRQziNAgCY5eSczH7HxQgnGQSxGbgcCRrlD1S4Bhsq2ANWJ4dD xbdNkCnZq/FmCzpFdwT8me/GZEbmTU4DvKYh19xVJSPefkNvFldtJtiAgglzcZKZ+O+4 LuAk1lsMtE4vAe152nR8+tX8UAFJ5w18QnJM6zVG2116xPz133cxA0H7y1hGZj/Pm6F/ hv+pC5uxB+eHlpqe8CFLg0GNWwkqcWnYWbSpSsIrvGxnw3W5575/r/wectq+VZMNlQjl aV/LuMMreDZx+or/cWQcuIOmxy5pIoPvBvuakMP5xKwWP4DKdgo4PVbtr0PhWsMXC3lJ nYLw== X-Forwarded-Encrypted: i=1; AJvYcCWMkKUW0qznVnCdIJmC5Ka9TuSlPowIkv8niqIXJiiBKjLRrFhQ3Xv4dT/45GPRiBY+vKafFjp/lA==@kvack.org X-Gm-Message-State: AOJu0Yy8c+v+Md+CHSyhCAqKpW3WG5pWnz6OvUddKb08u1GxZuNvc7GD XfyITBiMieKHZuB62LD60qgX2wTMQDPyUNar1YEcn1b+wXNyk7CqqtmfwmTiXYPWicz9cvy7VV9 P5QJoZ7lCWS8K9mAzTz6rONwu1j2OLdU8AlAe X-Gm-Gg: ASbGncs30ZvHEMEShdshO90Oilyyhcu9gesDH1nybSSmwk3LA4MGBIEB8bIWmEHw+pf M47bijMeMK0IgLuzNw/bA7upyqXM7qFypWR/vB076DHUaLp/p00CA57e1m3oTiY6wmjnY X-Google-Smtp-Source: AGHT+IGvMHw6R55/7RPunW0bn5d1AcmQMp94GlSumE0j3nd2FkOFABupMFvz0IO2VbC/lpg+oAQLe5CNCvnHOkf1vRA= X-Received: by 2002:a05:622a:ca:b0:466:a3ed:bde7 with SMTP id d75a77b69052e-46c70bd562bmr18791cf.6.1736275885451; Tue, 07 Jan 2025 10:51:25 -0800 (PST) MIME-Version: 1.0 References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-11-surenb@google.com> <0d36fd53-b817-4bbd-ae38-af094bd301df@suse.cz> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 7 Jan 2025 10:51:14 -0800 X-Gm-Features: AbW1kvZ3qxEhcdILrDHwREO3rKuUtsZyNZvMA-zGpm4yXwrVECVYk0kyTIRjG2Y Message-ID: Subject: Re: [PATCH v7 10/17] mm: uninline the main body of vma_start_write() To: Vlastimil Babka Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B0EFE4000A X-Stat-Signature: fmhjct8xhpge5yaa6gbph9b9q88izedn X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736275886-962782 X-HE-Meta: U2FsdGVkX19fNz3WT68I1DZbYZ23jQN5AMV4/oM64/5aFjZn9Nf938Zkc1bojgD1k6cnlF5LlWp+CHP1C7Xphl6fQf/x9GOtrLV3C9Dfwz4hr1XO/lFnMBlqNtfkjm2im5UVIGeviCJj3zIxmtXgzUWBQ1Ew/M9xGr+RYKgpb6ljDDfaric/eV7EP5HlWswKm11S5UrVh8J7D/6rbMSOJgdvfiL4kBKJK0KubfvafyW2LUHS0x686QyR+XlqL0TQShx9WDorXaQeqFPQAafYwATD20RRNGEDAqNfH0npnovG42KBPg2n64IJvxpEa4uGasmbijo2PzX1F7j4teVVGV9/LqfMoRPU+7N9S4qeNYIKYtz7upFg8x5KtS81SbmUE/B6/RtFiOV63cmy2WHvpcaILvPBbldIhyWByhkfkJ/u+SKN60/aJ9+6YsTBRq5vl8xgN3hwQCe9rne+GyWa0MCQZ6kCWys4yrWGYNCDv/7t5YIVFL+NTJ3CjH+2YyyFTBXEvvI9dy+/M/k/WBwPDfB1FTldnT0Y/fff7gpc3njIeKha0EeQgZJaHQ22jzmWWQD+nC+4LmvgFHi6sUmibdgUlpKeYsd4c6HrIWJhLi0ibfPs/ZUf5jAi4/vmZbLWbzVbKA3YoN705ksoC1mgzhOHeq39p9LKicoa95zUY3WAup/iOLq0Xs5xMnTapCDze8Sw1fainMrqkPjyRBxLB4zhmNA7l82M1bnafnayam6kPBWmDwjjaQW378pm6OqaVHQCXn1tHEKJRxPPrOjYEtX11ZmvZ/corbEM1jRNZQOEK9m6CEj6aK2HmWn5jBfiuEZjx1bq28LOfmqeczaiDiQdTmODawlKf9ltOiQeMw6O4LbGjnlKDp33gjOKTUGeegnmfMlbOcKyeiFsZOwfvir6/gEGGoYksyKQuKAnMMZzspAtv6PZYoLRP231ADNp1Q/nyJGDk/NVQBzWHb/ 15m4oK/f f+gqP3tmYMPHRVHEt33XAMzxNOAz6VFSlFeeZQrFMsKv2feZIUmQBPGz5YRubLcWT1D5nIAC9Cbx5A68vvTcIuL2O/ckkB2OZxDMNjA7G5Rm1SWDT5GESX4q0QLpkmcdFRMg5iyYzZS+nzWCmX22xfBSNz6J+ntBhgl3k5VyCryezS/V499Qw7j20tCyDiPGyGdW8WLvDBgRCf1YKtqFJdZDWH85PALjUH0aF0cyZu/gO/fOU91BhTO79DlJKqjws7YKTuNGE2I5QVYI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 9:45=E2=80=AFAM Suren Baghdasaryan wrote: > > On Tue, Jan 7, 2025 at 9:35=E2=80=AFAM Vlastimil Babka w= rote: > > > > On 12/26/24 18:07, Suren Baghdasaryan wrote: > > > vma_start_write() is used in many places and will grow in size very s= oon. > > > It is not used in performance critical paths and uninlining it should > > > limit the future code size growth. > > > No functional changes. > > > > > > Signed-off-by: Suren Baghdasaryan > > > > Reviewed-by: Vlastimil Babka > > > > > --- a/mm/memory.c > > > +++ b/mm/memory.c > > > @@ -6328,6 +6328,20 @@ struct vm_area_struct *lock_mm_and_find_vma(st= ruct mm_struct *mm, > > > #endif > > > > > > #ifdef CONFIG_PER_VMA_LOCK > > > +void __vma_start_write(struct vm_area_struct *vma, unsigned int mm_l= ock_seq) > > > +{ > > > + down_write(&vma->vm_lock.lock); > > > + /* > > > + * We should use WRITE_ONCE() here because we can have concurre= nt reads > > > + * from the early lockless pessimistic check in vma_start_read(= ). > > > + * We don't really care about the correctness of that early che= ck, but > > > + * we should use WRITE_ONCE() for cleanliness and to keep KCSAN= happy. > > > + */ > > > + WRITE_ONCE(vma->vm_lock_seq, mm_lock_seq); > > > + up_write(&vma->vm_lock.lock); > > > +} > > > +EXPORT_SYMBOL_GPL(__vma_start_write); > > > > Do any modules need it? If not we shouldn't export. > > I'm pretty sure I added it because of the allmodconfig build failure > but let me rerun it and see which module was using it. Yeah, when building allmodconfig without this export I get: ERROR: modpost: "__vma_start_write" [fs/ext4/ext4.ko] undefined! ERROR: modpost: "__vma_start_write" [fs/cramfs/cramfs.ko] undefined! ERROR: modpost: "__vma_start_write" [fs/fuse/fuse.ko] undefined! ERROR: modpost: "__vma_start_write" [fs/orangefs/orangefs.ko] undefined! ERROR: modpost: "__vma_start_write" [fs/xfs/xfs.ko] undefined! ERROR: modpost: "__vma_start_write" [fs/erofs/erofs.ko] undefined! ERROR: modpost: "__vma_start_write" [drivers/video/fbdev/core/fb.ko] undefi= ned! ERROR: modpost: "__vma_start_write" [drivers/acpi/pfr_telemetry.ko] undefin= ed! ERROR: modpost: "__vma_start_write" [drivers/dma/idxd/idxd.ko] undefined! ERROR: modpost: "__vma_start_write" [drivers/xen/xen-gntdev.ko] undefined! > > > > > > /* > > > * Lookup and lock a VMA under RCU protection. Returned VMA is guara= nteed to be > > > * stable and not isolated. If the VMA is not found or is being modi= fied the > >