From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93418C3DA4A for ; Mon, 19 Aug 2024 20:39:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04FB46B0082; Mon, 19 Aug 2024 16:39:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1A906B0085; Mon, 19 Aug 2024 16:39:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D94726B0088; Mon, 19 Aug 2024 16:39:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B87AC6B0082 for ; Mon, 19 Aug 2024 16:39:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 674FF1C53CF for ; Mon, 19 Aug 2024 20:39:33 +0000 (UTC) X-FDA: 82470160626.09.C0B1242 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 83622C0019 for ; Mon, 19 Aug 2024 20:39:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dM5daJqJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724099884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5uFM/7CjPk8scoS/LKz8NVm9q32EXxQmB7Ug1L0dZjQ=; b=L6bjeOLhPx+hJABEfvtqbS7M29EBpc8gNu0hZoDf0kRzjOJcmwV0NeFLXSbgOGbxQn2KJ1 Q1l386OOHiL6tn4iXhPon7indPiV32cJ7eZ9O5wIzRc2WAz/B/z1Gfrds2DRxrcdK0FWd7 kF6EkVvYniZZ5MVSTO0x1kFIO02feYU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724099884; a=rsa-sha256; cv=none; b=stc/lUMmT/jCVNpf+Lx5MgYVrslN5AZvdbvMlHalVDMqhpi5WT/CPKhf4N87TE/5NZE+4F ep0yjcwclSXkfGQAVICn1TaexPtrTY0zpMjPOJv4pdIHizHtcNNXUe5vvVKE8dnDHFx0TS yc6TBf3xEheaBYlt3Ud3/22OJk2kPMo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dM5daJqJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-690af536546so47229657b3.3 for ; Mon, 19 Aug 2024 13:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724099970; x=1724704770; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5uFM/7CjPk8scoS/LKz8NVm9q32EXxQmB7Ug1L0dZjQ=; b=dM5daJqJvLnkubbE3AYEbQkuM31MnBvrMU6a0L5WFDYEM5UCd4O53yisBV3+kxWmbU VQzln+4sMC1gTtVMCGhL+JJ7hnweimLh1itT8L8/4mvQuutgiBMkaL0g5q7rydVGArTJ vKjYh+5kcW8eHwKkjPKSXqkyfCd+U3p4waI5hgMjbSFkyYXT1LhmIEF5lRR58QfI5yYu 8YTG28mW61OIrQj+UwczAt6Tc395TcBwDXh7A5dMzuEa+MMiNWVG+s4X9TYh27aFdXXp mWLX1inEXvxpW/UoYc+D/8X6xrI+H2lMsJcDm4Yit+u2TJ9AlmE5HKBZUKov66FdBBY5 YrqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724099970; x=1724704770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5uFM/7CjPk8scoS/LKz8NVm9q32EXxQmB7Ug1L0dZjQ=; b=XnOu/l7ZE/alnj+nn8LWh/ozOlCKhVg/oTE0NNTCCY1vm6+5urF5qHPCU/XX4nxOej AWeWifKU0QZohw12qyY/vvNFxDi+pzEnZEFlJaB4dpewj896nW1pE3pAafbDREycOurx VgMkYYmdPTPzh/YqhbFIQ+r2VJxI42tejhYzIczXDYYqR61mtIr3H5nDrqeLzh79CTHE IACaOqkkelQtebnkwJz/8pNzAcWpq6ef/nwetmgOVbWNjySPRRa041xNMGdy/Ld1wQml qULN5oDXI44lp/Harec+DFt6A4H2ENQByi0SuM/piyy9XEB0PMVpvYfmH+Sr77BycQBD OdVg== X-Forwarded-Encrypted: i=1; AJvYcCV9mf+qXeNu4cXfIrLzWC7UFld+HA9HnuxmA/SZE6zr40pNBFe5Wm2FfWjjAgeCExm9lejqphtuuY6Q7dA6hXsI0gQ= X-Gm-Message-State: AOJu0Yz+bBGNv2DWdUpPmuIAFpBRAWwfNsg/7q0cb0EVOkhXs0bZCkxr iKhH2EudEvvmJvEL5n33wC1nTy8Klin1Z07Zs9fjHpCZl1cNEpj5CgB3kkZZRrtD9FtW9ZTkf0R ljsVX/PPDjuP4JPnAYHyTxZ2zGP/2dxFJLIMz X-Google-Smtp-Source: AGHT+IElAuirGCjfeSZJPYUAW0ei9jJHOeGrwyuGYXkqFM/e262PAdLed4KeFggiWi4ZXjelTO/ciQYl3Ojs6C8UDM4= X-Received: by 2002:a05:690c:4dc2:b0:6b1:9815:b526 with SMTP id 00721157ae682-6be2f5ec85bmr2324487b3.42.1724099970130; Mon, 19 Aug 2024 13:39:30 -0700 (PDT) MIME-Version: 1.0 References: <20240819151512.2363698-1-surenb@google.com> <20240819151512.2363698-6-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 19 Aug 2024 13:39:16 -0700 Message-ID: Subject: Re: [PATCH 5/5] alloc_tag: config to store page allocation tag refs in page flags To: Matthew Wilcox Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 83622C0019 X-Stat-Signature: 65697ba7wg6epus1z34ghfdio3ep1d7o X-Rspam-User: X-HE-Tag: 1724099971-229009 X-HE-Meta: U2FsdGVkX19s21XObzKebdQt/zszFwHgn+HA2lThuE28ojn67tnX6sQCYU7dB7GaHSHk31h3960MEZpZnF/uqsvUvs/KgOtg1xATI7MYWgbstyIiQ1s5pt8utNhgvTKWkpyRXq6+dvOd4U+FU87YU3BlSGSfWGqzZ+oHiG9i/e1FBs8oZOfpANA3/ljLcsdMYs+LMI7Qfug7j9MyRmLQgRWPcA6QM2y1Lf5csBgwBGjWDyWaN2Y90c3jkgU0qhivsZLXGJ/vtMSx5p4+3XNVkNEUD1pFvS1wKivrHc/Zr8oVBtnGRa0NIceUCYl6EIsWpZVJaW9lfcshXfoigPVgtyiE+J1O00gGcUSD0rgjwoV1eMsSsfg8YVglJNeqKPbU38wd19ZH8LF9K/+pWGO/44iOUr1lm1R7ravH2rY8syye0iW054fTSkQEykv2Y8T2UftVKvuf+iugmyhDDS6e1j54v2vdwJV7SbsWZ7wqitvowAkJMoivjydfUCEGwppDsUJ9lhk1NV4XqySpCqyFfWoSO6u7XoTA7YomhZMvHs+zh0Be4py6faF39BiN2KLTg93m7wb5h6kafJqUSaKZvbtqrN8x/Zf2uyvvSiCra8bT3BqSwPm1xR8LtdyQGpwGiEAYC7s6ssZjFhICVsmzzuUqnxFbOfPGy/UFpInGP/NtD7j/UJZuKnd67NW0iV/3vBVUQkIAXd1wHzbfAxL4sGQIL0aexgHy/v1JoftpmzfaHzz8sa6PGEVxkWkU473oaiKYK1M2sqiWKjRSBJsEYJlckc+ScOAhalSm8CNu932W0vNzaTzTPSrgdWGTSDI9TsvXfmLWsURnopDzlQfjIdNY0XlORm1TrPjCYOlZ8ZuNygoVzAYLgOIUDG4jC8aAs9bXeJHukH9QkH6zlfHmC5Htds5wLENQFT/PSihv6ccwCtsJBliruB38xvL/XgA/CdZiFTXXqRNBVK1gFXB VmTAg0ap Tj3aG2zjqqfAy/c/WLOXbdeN8RJo5Iqdeu0JfGJyvJ11xI5WNVOz2/tqRk6wHlM9GcR2qPC6FHE/SKmTfPj02GcYVdaZyoULkZ83leGYEk9jdQEaguDVjfDsy0VUffR2WuWzV3Nd7fLA7++OuIdb8wha27t3ACiD8bE78nEVbYWW3q2Q77jzX1odpnbzRxRHrfas6Ajv9vheyyMP8x2LkfdPaOrM2Sor5sd17nQ3rA95YNUvqpnytFeLlGNHAnNqGea3zdYLxWJRrctMGEHpyvfzbFGXrEobterbsv4sx1xtIcpzCMT1SCYthkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.125362, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 12:34=E2=80=AFPM Matthew Wilcox wrote: > > On Mon, Aug 19, 2024 at 08:15:11AM -0700, Suren Baghdasaryan wrote: > > @@ -91,7 +97,7 @@ > > #endif > > > > #if ZONES_WIDTH + LRU_GEN_WIDTH + SECTIONS_WIDTH + NODES_WIDTH + \ > > - KASAN_TAG_WIDTH + LAST_CPUPID_SHIFT <=3D BITS_PER_LONG - NR_PAGEF= LAGS > > + KASAN_TAG_WIDTH + ALLOC_TAG_REF_WIDTH + LAST_CPUPID_SHIFT <=3D BI= TS_PER_LONG - NR_PAGEFLAGS > > #define LAST_CPUPID_WIDTH LAST_CPUPID_SHIFT > > #else > > #define LAST_CPUPID_WIDTH 0 > > So if ALLOC_TAG_REF_WIDTH is big enough, it's going to force last_cpupid > into struct page. Thanks for taking a look! Yes, but how is this field different from say KASAN_TAG_WIDTH which can also force last_cpupid out of page flags? > That will misalign struct page and disable HVO -- with no warning! mminit_verify_pageflags_layout already has a mminit_dprintk() to indicate this condition. Is that not enough? >