From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2470C43140 for ; Thu, 5 Sep 2019 17:39:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC687214DB for ; Thu, 5 Sep 2019 17:39:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HIC37gy1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC687214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53C456B0275; Thu, 5 Sep 2019 13:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EC506B0276; Thu, 5 Sep 2019 13:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DB4C6B0277; Thu, 5 Sep 2019 13:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 1B66F6B0275 for ; Thu, 5 Sep 2019 13:39:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id AEEA2180AD7C3 for ; Thu, 5 Sep 2019 17:39:53 +0000 (UTC) X-FDA: 75901579866.15.hair77_1c1b20380a809 X-HE-Tag: hair77_1c1b20380a809 X-Filterd-Recvd-Size: 6241 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Sep 2019 17:39:52 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id r17so5525273wme.0 for ; Thu, 05 Sep 2019 10:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oHaIgZ+QyOTSQuPWv07Wdi8uuPiW8MfzbAABFbSnd3w=; b=HIC37gy16K0TPOUajtDzmEc5zZSn8ifcV0CdwZEt2UG2lAt1BDvAx2vslZsVJVs9ch YE3q79onfyftOBvNiJ9wSZLbRYg01lgsdj6JvQGP/bxsVqTC9DgPtE1RXmYViynnQBPd 9xjzb5Z/rxvZdep6cgKBDS3876jQQz6xqTsOe7jbcPYdBcM9AIJJlAYnZHBGUw4MuX5K XwgHXQORth3+vMh0B5gQC5bopaOCzM/zRdRHfwLv2eGgYxixfNVWXCpgjyBBFaWA3OO2 r0eSUbfDeZ6k8biG/IbGzkfPisoVtsFqk0+RazXoRzClIidmdbfFzSMZe5joiGjIa9KV x2ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oHaIgZ+QyOTSQuPWv07Wdi8uuPiW8MfzbAABFbSnd3w=; b=AsOwniKHRnWH2FxMebVhkdro80SUPiFJND+7H/vivkpmejz7Uh9fXaYL9dL2OINaPx 42gQLTdIGc+fCZPXkJD7ZMkYDjWRN+6dLAkfpGgwDxbQeXMn+4SI2zjiYwWvsiMHVHPd 6dwc4CgNeoMnTbXhs/pk5qnrfgtddk0KdRpzNYaNNZCHCE1OZ96dr5iN5vlxUQd/rYLZ 7R9rhCI7C8fmrFirNtkvxuhEbo2Ntjd7KH8tWb9ZvHCcRH+vxxyj6bxz7TNfWigVVsiR MunpqnQlWNo/FJyOQermL9ZXwNFi0qF0wuYguJrgKrpiJui6dhrLMvxFPrtwYVMmwCAQ PfJQ== X-Gm-Message-State: APjAAAXxzFbHNuLzheZ6rzGxRwjeFqR+yEZYhwIKEJ2u0s0TIc4CIr9x 0y+YH4CaAdv24bfQ5fchNWKbPv4zOohBfRoYNP28BQ== X-Google-Smtp-Source: APXvYqwnk9SZLeXmt0DPPOvUyd0JD3bs5o/I4Q4Vf+1BPtPTSwu/Y4O3dmRg/1fFeKJx7zcWFuuR/SIyEVpqKh7SHf8= X-Received: by 2002:a1c:f417:: with SMTP id z23mr1878827wma.77.1567705191475; Thu, 05 Sep 2019 10:39:51 -0700 (PDT) MIME-Version: 1.0 References: <20190903200905.198642-1-joel@joelfernandes.org> <20190904084508.GL3838@dhcp22.suse.cz> <20190904153258.GH240514@google.com> <20190904153759.GC3838@dhcp22.suse.cz> <20190904162808.GO240514@google.com> <20190905144310.GA14491@dhcp22.suse.cz> <20190905133507.783c6c61@oasis.local.home> In-Reply-To: <20190905133507.783c6c61@oasis.local.home> From: Suren Baghdasaryan Date: Thu, 5 Sep 2019 10:39:40 -0700 Message-ID: Subject: Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold To: Steven Rostedt Cc: Michal Hocko , Joel Fernandes , LKML , Tim Murray , Carmen Jackson , Mayank Gupta , Daniel Colascione , Minchan Kim , Andrew Morton , kernel-team , "Aneesh Kumar K.V" , Dan Williams , Jerome Glisse , linux-mm , Matthew Wilcox , Ralph Campbell , Vlastimil Babka , Tom Zanussi Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 5, 2019 at 10:35 AM Steven Rostedt wrote: > > > > [ Added Tom ] > > On Thu, 5 Sep 2019 09:03:01 -0700 > Suren Baghdasaryan wrote: > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > > > [Add Steven] > > > > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > > [...] > > > > > > but also for reducing > > > > > > tracing noise. Flooding the traces makes it less useful for long traces and > > > > > > post-processing of traces. IOW, the overhead reduction is a bonus. > > > > > > > > > > This is not really anything special for this tracepoint though. > > > > > Basically any tracepoint in a hot path is in the same situation and I do > > > > > not see a point why each of them should really invent its own way to > > > > > throttle. Maybe there is some way to do that in the tracing subsystem > > > > > directly. > > > > > > > > I am not sure if there is a way to do this easily. Add to that, the fact that > > > > you still have to call into trace events. Why call into it at all, if you can > > > > filter in advance and have a sane filtering default? > > > > > > > > The bigger improvement with the threshold is the number of trace records are > > > > almost halved by using a threshold. The number of records went from 4.6K to > > > > 2.6K. > > > > > > Steven, would it be feasible to add a generic tracepoint throttling? > > > > I might misunderstand this but is the issue here actually throttling > > of the sheer number of trace records or tracing large enough changes > > to RSS that user might care about? Small changes happen all the time > > but we are likely not interested in those. Surely we could postprocess > > the traces to extract changes large enough to be interesting but why > > capture uninteresting information in the first place? IOW the > > throttling here should be based not on the time between traces but on > > the amount of change of the traced signal. Maybe a generic facility > > like that would be a good idea? > > You mean like add a trigger (or filter) that only traces if a field has > changed since the last time the trace was hit? Almost... I mean emit a trace if a field has changed by more than X amount since the last time the trace was hit. > Hmm, I think we could > possibly do that. Perhaps even now with histogram triggers? > > -- Steve > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >